Commit Graph
13292 Commits
Author SHA1 Message Date
Sébastien Han 386ec12032 ceph: fix error message
Re-phrase error message and use %q to put the var into quotes.

Signed-off-by: Sébastien Han <seb@redhat.com>
2019-11-08 15:59:08 +01:00
egafford bb7aac4b62 ceph: Standardize association of keyrings with deployments
This change standardizes the ownerRefs of Ceph keyrings to
k8s Deployment resources across all daemons and refactors a
bit of duplicate code on keyring association for ease of
maintenance.

Fixes: #4089

Signed-off-by: egafford <egafford@redhat.com>
2019-11-08 09:50:37 -05:00
Santosh Pillai 26360689f5 ceph: skip osd prepare job creation if osd daemon exists for the pvc
When an orchestration is restarted or retriggered and starts new osd prepare pods, they are unable to start because the device is already in use by the osd daemon pods.
This fix simple skips the osd prepare pod creation if the daemon is already running.

Signed-off-by: Santosh Pillai <sapillai@redhat.com>
2019-11-08 20:11:49 +05:30
Sébastien Han 4ac8e5417b Merge pull request #4276 from leseb/external-cluster-csi-keys
ceph: create csi keys and secrets for external cluster
2019-11-08 13:21:08 +01:00
Travis Nielsen a625a43854 Merge pull request #4076 from beautytiger/dev-190910-clean
cleanup code in pkg/util
2019-11-07 17:46:43 -06:00
Travis Nielsen 30f3535116 Merge pull request #4149 from umangachapagain/objectuser-retry
adds retry to ObjectUser creation
2019-11-07 17:45:26 -06:00
Sébastien Han 80c8846a19 Merge pull request #4150 from rajatsingh25aug/simplify_addOrRemove
ceph: Simplification of addOrRemoveMonitor()
2019-11-07 14:02:38 +01:00
Guangming Wang 950af10e62 cleanup: cleanup codebase
device.go: replace string func Index with Contains.

Signed-off-by: Guangming Wang <guangming.wang@daocloud.io>
2019-11-07 19:45:43 +08:00
Guangming Wang a9063c27e9 cleanup: cleanup codebase
monitoredproc_test.go: remove redundant break.

Signed-off-by: Guangming Wang <guangming.wang@daocloud.io>
2019-11-07 19:45:39 +08:00
Guangming Wang e5e0369e37 cleanup: cleanup codebase
exec.go: use String method of bytes itself.

Signed-off-by: Guangming Wang <guangming.wang@daocloud.io>
2019-11-07 19:45:32 +08:00
RAJAT SINGH 65fb5684f2 Ceph: Simplification of addOrRemoveMonitor()
Signed-off-by: RAJAT SINGH <rajasing@redhat.com>
2019-11-07 15:26:47 +05:30
Sébastien Han 10c57f834d ceph: create csi keys and secrets for external cluster
Once the cluster is connected, we need to create the CSI keys so that we
can provide persistent storage to containers, via ceph csi.

Signed-off-by: Sébastien Han <seb@redhat.com>
2019-11-07 10:56:06 +01:00
Sébastien Han 5c010a7cea Merge pull request #4257 from leseb/relax-blockpool
ceph: relax cr block requirements
2019-11-07 08:08:02 +01:00
Sébastien Han 4c3dc2828d Merge pull request #4053 from jmolmo/issue_2606
Get <ceph-volume inventory> data in dev. configmaps
2019-11-06 16:40:43 +01:00
Sébastien Han f78ed36539 Merge pull request #4131 from leseb/osd-fs-flag
ceph: remove topologyAware CRD option
2019-11-06 15:08:21 +01:00
Juan Miguel Olmo Martínez 7c942604f6 ceph: Get <ceph-volume inventory> data in dev. configmaps
**Description of your changes:**
This modification adds the information extracted from 'ceph-volume inventory':
command to the device configmaps generated by the discovery daemon when
"rook discover" starts with the new boolean "--use-ceph-volume" parameter.

Resolves #
https://github.com/rook/rook/issues/2606

Now the <cephVolumeData> field contains all the information returned
from <ceph-volume inventory> command.

Signed-off-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
2019-11-06 10:22:56 +01:00
Sébastien Han 546271c179 Merge pull request #4172 from Madhu-1/csi-driver-object
CSI: Add support for CSIDriver object creation
2019-11-06 09:40:21 +01:00
Umanga Chapagain 69c1c4c8ff Ceph: Create ObjectStore before ObjectStoreUser
Signed-off-by: Umanga Chapagain <chapagainumanga@gmail.com>
2019-11-06 14:04:52 +05:30
Madhu Rajanna 9b368ef15c CSI: Create CSIDriver Object
This will be helpful to list the CSI drivers
deployed in the kubernetes cluster. if we have
N number of CSI drivers deployed in the cluster,
the user can query kubectl get csidriver and get
the list of registered CSI drivers and it requires
kube 1.14+

This removes the deployment of Attacher sidecar container,
as we are setting the attacher required to false during
the CSIDriver object creation.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2019-11-06 11:18:03 +05:30
Blaine Gardner b7b3880b08 Merge pull request #3882 from thotz/master
Add object bucket claim details to admin guide
2019-11-05 15:41:17 -07:00
Travis Nielsen 85c413b212 Merge pull request #4231 from egafford/generate-keyrings-before-MDS-deployment
ceph: Generate MDS keyrings before creating dependent deployments
2019-11-05 15:26:37 -07:00
Travis Nielsen 220033ee60 Merge pull request #4235 from egafford/generate-keyrings-before-RGW-deployment
ceph: Generate RGW keyrings before creating dependent deployments
2019-11-05 15:26:28 -07:00
egafford ecd9ff1672 ceph: Generate MDS keyrings before creating dependent deployments
Failure to create a keyring prior to creating a deployment
dependent on that keyring created a race conditition resulting
in an intermittent and unnecessary pod failure. This change
creates a keyring prior to deployment creation for MDS
daemons.

Partially fixes: rook#4089

Signed-off-by: egafford <egafford@redhat.com>
2019-11-05 15:02:15 -05:00
egafford 8ec1256af8 ceph: Generate RGW keyrings before creating dependent deployments
Failure to create a keyring prior to creating a deployment
dependent on that keyring created a race conditition resulting
in an intermittent and unnecessary pod failure. This change
creates a keyring prior to any RGW deployment.

Partially fixes: #4089
Signed-off-by: egafford <egafford@redhat.com>
2019-11-05 14:58:46 -05:00
Sébastien Han 1916cee895 ceph: relax cr block requirements
The only things that should be required are the name of the pool and the
namespace. We don't need to enforce the replication type as a
requirement.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1767249
Signed-off-by: Sébastien Han <seb@redhat.com>
2019-11-05 18:11:31 +01:00
Blaine Gardner 97e07069dc Merge pull request #4195 from d-luu/fix_missing_ceph_mgr_annotation
ceph: fix set mgr annotations
2019-11-05 09:25:39 -07:00
Sébastien Han fab0646209 Merge pull request #4252 from nizamial09/difforchestration
ceph: added a check for triggering the orchestration
2019-11-05 12:37:26 +01:00
Nizamudeen 1aaad8f3be ceph: added a check for triggering the orchestration
Fix for automatic orchestration triggering even if the cluster CRD is unchanged.

Signed-off-by: Nizamudeen <nia@redhat.com>
2019-11-05 15:25:29 +05:30
Umanga Chapagain c90c5f8711 ceph: fixes mon failover test
Real mons and canary both have the same rook-ceph-mon label.
It creates a confusion while retrieving list of mon deploymets
using label selector. This commit adds a check to remove canary
deployments from the deployment list.

Signed-off-by: Umanga Chapagain <chapagainumanga@gmail.com>
2019-11-05 12:47:56 +05:30
Umanga Chapagain 6dd474d6f4 ceph: adds retry to ObjectUser creation
retry ObjectUser creation as long as valid input is provided
or it times out. Retry every 15sec for 5min.

integration test creates ObjectUser before ObjectStore to
ensure that ObjectUser waits for ObjectStore to be created
and available

Closes: https://github.com/rook/rook/issues/3937
Signed-off-by: Umanga Chapagain <chapagainumanga@gmail.com>
2019-11-05 12:45:45 +05:30
Travis Nielsen 47764715fe ceph: remove the location from the cluster CR
The topology of the cluster should be based on the node labels rather
than a setting in the cluster CR. This allows a much richer and more
dynamic topology to be configured. The location will now be ignored
if specified in the cluster CR.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2019-11-04 23:07:13 -07:00
Travis Nielsen 3767d6e14b tests: initialize the cluster-specific rbac properly
The integration tests were creating several namespace-specific resources
in the system namespace instead of the namespace with the cluster. This
was only affecting the rook-ceph-osd and rook-ceph-mgr service accounts,
which hadn't been exercised until the nodes were queried by osds for
topology awareness.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2019-11-04 23:07:13 -07:00
Travis Nielsen 51cc8a752f ceph: restructure the object store guide for OBCs
The guide for configuring object stores has a new flow for creating
buckets in the object store. This requires a new approach instead of
asking the user to create user creds and a bucket with other commands
such as s3cmd.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2019-11-05 10:04:03 +05:30
d-luu 014431ee0d ceph: fix set mgr annotations
Mgr annotation was previously not being set.

Signed-off-by: d-luu <david@davidluu.info>
2019-11-04 15:22:24 -06:00
Jiffin Tony Thottan 5a72f9a299 doc: Add OBC details to admin guide
This patch adds required documentation to consume OBC for a user

Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
2019-11-04 23:14:07 +05:30
Sébastien Han ef6815ebfa ceph: remove topologyAware CRD option
We removed the topologyAware CRD option since it was redundant with the
use of an OSD being backed by a PVC.
So now, if an OSD is backed by a PVC we assume the topology aware
decision and will discover zone and region labels on that host.

Signed-off-by: Sébastien Han <seb@redhat.com>
2019-11-04 09:53:14 -07:00
Sébastien Han 1f788cf637 Merge pull request #4202 from galexrt/fix_helm_chart_csi_port
ceph: helm: fix operator chart rbdGrpcMetricsPort
2019-11-04 09:16:34 +01:00
Alexander Trost 020626a432 docs: added missing Rook Ceph operator helm values
Added missing csi values of the Rook Ceph operator helm chart to the
documentation.

Signed-off-by: Alexander Trost <galexrt@googlemail.com>
2019-11-03 13:06:38 +01:00
Alexander Trost 9fe5e2ad3e ceph: helm: fix operator chart rbdGrpcMetricsPort
This fixes the conditional for the `rbdGrpcMetricsPort` option.
Previously the `rbdGrpcMetricsPort` was useless as it was not used,
instead the Helm chart looked for `cephfsrbdGrpcMetricsPort` option.

Signed-off-by: Alexander Trost <galexrt@googlemail.com>
2019-11-03 13:06:38 +01:00
Travis Nielsen 77a583dac9 Merge pull request #4240 from travisn/yq-install
Build Fix: Update the path to pull the yq tool
2019-11-03 01:42:38 -06:00
Travis Nielsen d79c8a61a3 build: update the path to pull the yq tool
The yq tool changed and requires a new path from which to build.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2019-11-03 01:16:20 -06:00
Alexander Trost 77814b022d docs: rework and improve documentation (#4166)
docs: rework and improve documentation
2019-11-01 18:15:41 +01:00
Alexander Trost c7afa0eb43 misc: docs: unified formatting and style
This is the first phase  miscellaneous part of three phases to improve and
rework the Rook documentation for better user accessibility to the Rook
projects and  with that the storage providers.
Phase two is about automatic generation of CRD documentation and phase
three is about reworking the docs themselves and, e.g., examples for
CRDs and certain use cases.

Signed-off-by: Alexander Trost <galexrt@googlemail.com>
2019-11-01 18:13:27 +01:00
Alexander Trost eb74512021 yugabyte: docs: unified formatting and style
This is the first phase YugabyteDB part of three phases to improve and
rework the Rook documentation for better user accessibility to the Rook
projects and  with that the storage providers.
Phase two is about automatic generation of CRD documentation and phase
three is about reworking the docs themselves and, e.g., examples for
CRDs and certain use cases.

Signed-off-by: Alexander Trost <galexrt@googlemail.com>
2019-11-01 18:11:19 +01:00
Alexander Trost a91d83d833 edgefs: docs: unified formatting and style
This is the first phase EdgeFS part of three phases to improve and
rework the Rook documentation for better user accessibility to the Rook
projects and  with that the storage providers.
Phase two is about automatic generation of CRD documentation and phase
three is about reworking the docs themselves and, e.g., examples for
CRDs and certain use cases.

Signed-off-by: Alexander Trost <galexrt@googlemail.com>
2019-11-01 18:11:00 +01:00
Alexander Trost eb0d8699d1 cockroachdb: docs: unified formatting and style
This is the first phase CockroachDB part of three phases to improve and
rework the Rook documentation for better user accessibility to the Rook
projects and  with that the storage providers.
Phase two is about automatic generation of CRD documentation and phase
three is about reworking the docs themselves and, e.g., examples for
CRDs and certain use cases.

Signed-off-by: Alexander Trost <galexrt@googlemail.com>
2019-11-01 18:10:51 +01:00
Alexander Trost 64afb24596 cassandra: docs: unified formatting and style
This is the first phase Ceph part of three phases to improve and rework
the Rook documentation for better user accessibility to the Rook
projects and  with that the storage providers.
Phase two is about automatic generation of CRD documentation and phase
three is about reworking the docs themselves and, e.g., examples for
CRDs and certain use cases.

Signed-off-by: Alexander Trost <galexrt@googlemail.com>
2019-11-01 18:10:36 +01:00
Alexander Trost 98217272be ceph: docs: unified formatting and style
This is the first phase Ceph part of three phases to improve and rework
the Rook documentation for better user accessibility to the Rook
projects and  with that the storage providers.
Phase two is about automatic generation of CRD documentation and phase
three is about reworking the docs themselves and, e.g., examples for
CRDs and certain use cases.

Signed-off-by: Alexander Trost <galexrt@googlemail.com>
2019-11-01 18:10:32 +01:00
Travis Nielsen 038667cfb7 Merge pull request #4236 from travisn/topology-aware-rack
Support all layers of CRUSH map with node labels
2019-10-31 14:49:27 -06:00
Travis Nielsen 831c15086a ceph: support all layers of CRUSH map with node labels
The node labels were already supported for zones and regions to add to
the CRUSH map. Now all layers of the CRUSH map will be supported
with the new labels such as topology.rook.io/rack.
The labels will be detected at the osd startup time
similar to the zone and region labels already being detected.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2019-10-31 14:47:18 -06:00