Commit Graph
13292 Commits
Author SHA1 Message Date
subhamkrai d429ed8be4 build: update controller runtime to v0.18.4
this commit update cntrl runtime to v0.18.4 and other related deps/

Signed-off-by: subhamkrai <srai@redhat.com>
2024-07-05 09:05:12 +05:30
Travis Nielsen 0837c15b86 Merge pull request #14407 from parth-gr/external-seamless-upgrade3
external: add final args used to the upgrade configmap
2024-07-03 11:29:58 -06:00
Blaine Gardner f17d6a0d08 Merge pull request #14412 from subhamkrai/update-go-1.22
build: upgrade to go 1.22
2024-07-03 10:46:31 -06:00
parth-gr 26cecb568a external: add final args used to the upgrade configmap
Recently we have introuced external-cluster-user-command cm
Which help user to look at the previous command run,
So with this PR we will add another data field arg
on this confimap which will have the final processed flags
that are being used
So user can use them directly either in config.ini or cmd line args

Signed-off-by: parth-gr <partharora1010@gmail.com>
2024-07-03 21:50:29 +05:30
subhamkrai b4510fdace ci: fix govulcheck by updating to go 1.22.5
govulcheck requires go 1.22.5 and even if `check-latest` is `true`
with go `1.22` it is failing so setting specific version go `1.22.5`

Signed-off-by: subhamkrai <srai@redhat.com>
2024-07-03 17:15:18 +05:30
subhamkrai d116429f75 build: upgrade to go 1.22
this commit upgrade to go 1.22 in go mod file and ci related files.
Also remove go 1.21 support

Signed-off-by: subhamkrai <srai@redhat.com>
2024-07-03 17:01:33 +05:30
Travis Nielsen 80272b6043 Merge pull request #14408 from Madhu-1/fix-14394
csi: update csi-addons repo link
2024-07-02 10:34:15 -06:00
Madhu Rajanna 266fd49c02 csi: update csi-addons repo link
updating csi-addons repo link
to pull the yamls for installation

closes: #14394

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2024-07-02 17:36:24 +02:00
Travis Nielsen 8e25300ad5 Merge pull request #14199 from Nordix/update-cephfs-clusterroles
csi: add cephfs encryption support
2024-07-01 15:27:38 -06:00
Blaine Gardner e51b9e0abf Merge pull request #14391 from subhamkrai/update-go-dep
build: update go-retryablehttp from 0.7.6 to 0.7.7
2024-06-27 15:03:31 -06:00
Blaine Gardner d7eddfe98d Merge pull request #14305 from parth-gr/csi-logrotate
csi: add log rotation for csi rbd pod containers
2024-06-27 14:37:38 -06:00
subhamkrai 9fbf3d3aac build: update go-retryablehttp from 0.7.6 to 0.7.7
this commit updates go-retryablehttp from 0.7.6 to 0.7.7
and without this govulcheck ci is failing.

Signed-off-by: subhamkrai <srai@redhat.com>
2024-06-27 14:44:59 +05:30
parth-gr d3742119b9 csi: add log rotation for csi rbd pod containers
1) Make the csi rbd container logs persisted in a file
   (csi plugin, csi provisioner, csi addons sidecar)

2) Use the cephcluster api specs to configure the log rotate

3) Add log rotation to rotate the log file and
   Add a sidecar log collector container

part-of: https://github.com/rook/rook/issues/12809

Signed-off-by: parth-gr <partharora1010@gmail.com>
2024-06-27 14:20:18 +05:30
Blaine Gardner 22125bad4c Merge pull request #14342 from dbrennand/docs-fix-missing-bold
docs(fix): missing ** in filesystem-storage.md
2024-06-26 14:04:05 -06:00
Blaine Gardner bd02cf1f6f Merge pull request #14353 from parth-gr/external-seamless-upgrade1
external: add support for config file in external mode
2024-06-26 09:48:56 -06:00
parth-gr 5387ef16fd external: add support for config file in external mode
Now user can pass the cli flags using config file and
also command line argument,
if mentioned at both the place priority is given to
command line argument

Signed-off-by: parth-gr <partharora1010@gmail.com>
2024-06-26 17:07:49 +05:30
Blaine Gardner 7a53913049 Merge pull request #14294 from subhamkrai/skip-fence-when-csi-disabled
csi: skip creating networkFence when csi disabled
2024-06-25 09:36:02 -06:00
Blaine Gardner c85ce7c4e6 Merge pull request #14354 from parth-gr/external-seamless-upgrade2
external: create a configmap for the command line args
2024-06-25 08:08:11 -06:00
Blaine Gardner a6fc34149d Merge pull request #14374 from BlaineEXE/fix-osd-block-device-name-change
osd: fix activate failure when block device moves
2024-06-25 08:07:20 -06:00
parth-gr 951c683786 external: create a configmap for the command line args
user can look back to there configurations by
looking at the configmap created with command
line arguments
This will be useful for them during upgrades when they
need to re run the python script with the same flags

Signed-off-by: parth-gr <partharora1010@gmail.com>
2024-06-25 16:50:48 +05:30
subham rai c096b8403d Merge pull request #14373 from rook/dependabot/go_modules/github-dependencies-9b2da29897
build(deps): bump github.com/aws/aws-sdk-go from 1.54.2 to 1.54.6 in the github-dependencies group
2024-06-25 11:29:55 +05:30
Blaine Gardner f2304bf8b8 osd: fix activate failure when block device moves
Block devices can move between reboots. In corner cases, an OSDs block
device might move to a lower-indexed device while the previous device
does not exist. For example, an OSD on /dev/sde might move to /dev/sdd
on reboot if the original /dev/sdd died. There would be no /dev/sde
after that.

Users report that NVMe drives commonly change names, even when there are
no disk failures.

For these cases, ensure the activate script properly handles cases where
the previous disk is not present on the node and where the OSD is still
available on a different disk.

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
2024-06-24 11:38:24 -06:00
dependabot[bot] 7c6d0b9e7b build(deps): bump github.com/aws/aws-sdk-go
Bumps the github-dependencies group with 1 update: [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go).


Updates `github.com/aws/aws-sdk-go` from 1.54.2 to 1.54.6
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Commits](https://github.com/aws/aws-sdk-go/compare/v1.54.2...v1.54.6)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-06-24 12:52:03 +00:00
subham rai 3a72a2a920 Merge pull request #14367 from black-dragon74/use-orig-enc-key
osd: Use old passphrase to kill the LUKS slot
2024-06-24 11:04:00 +05:30
Blaine Gardner d1e4f96dd7 Merge pull request #14362 from subhamkrai/revert-crd-limit-scds
core: revert increase storage deviceset name limit to 50
2024-06-21 09:53:56 -06:00
Niraj Yadav b8b7af3495 osd: use old passphrase to kill the luks slot
While adding a new encryption key to slot 1
if there exists a key in slot 1 which is not
equal to the one we want to update it with,
we kill the slot and then add the new key to it.

While killing the slot, the existing code uses
the new key, which is not valid in such cases.

This patch modifies the code to use the key in
slot 0 (the one that we know works) to kill the slot.

Signed-off-by: Niraj Yadav <niryadav@redhat.com>
2024-06-21 19:15:01 +05:30
subhamkrai e8aeb0d263 osd: revert limit storageClassDeviceSets to 63 chars
This reverts commit 6f5cc9b01d.

Signed-off-by: subhamkrai <srai@redhat.com>
2024-06-21 11:24:25 +05:30
subhamkrai c7d07562c4 core: revert increase storage deviceset name limit to 50
This reverts commit 1dcc99ec1d.

Signed-off-by: subhamkrai <srai@redhat.com>
2024-06-21 11:23:55 +05:30
Santosh Pillai 643986224e Merge pull request #14358 from subhamkrai/update-storagedevice-set-limit
core: increase storage deviceset name limit to 50
2024-06-20 12:17:11 +05:30
subhamkrai 1dcc99ec1d core: increase storage deviceset name limit to 50
initially, we have the limit of 40 char set on
storageclassdeviceset.Name but seems like that is not enough and
upgrade clusters can face issue with this. So, increasing the limit to
50.

Signed-off-by: subhamkrai <srai@redhat.com>
2024-06-20 10:51:14 +05:30
Blaine Gardner d74832d41c Merge pull request #14346 from matofeder/fix_CephPoolGrowthWarning_expr
monitoring: fix CephPoolGrowthWarning expression
2024-06-17 12:23:39 -06:00
Blaine Gardner 4b51c2c3bd Merge pull request #14322 from ideepika/wip-disablecrush-updates
enableCrushUpdates option: rook operator would not be able to update crush rules by default if not set
2024-06-17 12:20:26 -06:00
Blaine Gardner f47d2372ab Merge pull request #14347 from rook/dependabot/go_modules/github-dependencies-fd2d6e934b
build(deps): bump the github-dependencies group with 3 updates
2024-06-17 11:39:40 -06:00
dependabot[bot] 1d7034ce4d build(deps): bump the github-dependencies group with 3 updates
Bumps the github-dependencies group with 3 updates: [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go), [github.com/ceph/go-ceph](https://github.com/ceph/go-ceph) and [github.com/spf13/cobra](https://github.com/spf13/cobra).


Updates `github.com/aws/aws-sdk-go` from 1.53.19 to 1.54.2
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Commits](https://github.com/aws/aws-sdk-go/compare/v1.53.19...v1.54.2)

Updates `github.com/ceph/go-ceph` from 0.27.0 to 0.28.0
- [Release notes](https://github.com/ceph/go-ceph/releases)
- [Changelog](https://github.com/ceph/go-ceph/blob/master/docs/release-process.md)
- [Commits](https://github.com/ceph/go-ceph/compare/v0.27.0...v0.28.0)

Updates `github.com/spf13/cobra` from 1.8.0 to 1.8.1
- [Release notes](https://github.com/spf13/cobra/releases)
- [Commits](https://github.com/spf13/cobra/compare/v1.8.0...v1.8.1)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-dependencies
- dependency-name: github.com/ceph/go-ceph
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-dependencies
- dependency-name: github.com/spf13/cobra
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-06-17 12:16:16 +00:00
Matej Feder 6ba084f35a monitoring: fix CephPoolGrowthWarning expression
Prometheus found duplicate series for the match group `pool_id`
and `instance` when evaluating the CephPoolGrowthWarning alert
expression. This alert has an evaluation interval of 2 days and
did not consider the changing POD names during the Rook migration process.

This commit adds the `pod` label to the set of considered labels.

Signed-off-by: Matej Feder <matej.feder@dnation.cloud>
2024-06-17 09:18:07 +02:00
dbrennand e9ff24fec3 docs(fix): missing ** for bold text
In docs page Storage-Configuration/Shared-Filesystem-CephFS/filesystem-storage.md

Signed-off-by: dbrennand <52419383+dbrennand@users.noreply.github.com>
2024-06-15 23:14:23 +01:00
Blaine Gardner eff2e69847 Merge pull request #14339 from travisn/honor-labels
monitoring: Set honor labels on the service monitor
2024-06-14 17:51:37 -06:00
Travis Nielsen eed1033485 monitoring: set honor labels on the service monitor
The endpoint property honorLabels: true should be set so that
different rgw instances can show separate prometheus
values instead of being aggregated.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2024-06-14 15:38:34 -06:00
Blaine Gardner e84e782158 Merge pull request #14331 from travisn/azure-pkg-update
core: Update go modules for snyk security check
2024-06-13 10:03:14 -06:00
Travis Nielsen 4f75058c61 Merge pull request #13876 from parth-gr/external-nfs
doc: add recommendation for nfs in external cluster
2024-06-13 09:46:40 -06:00
parth-gr 9be33bca53 doc: add design to support nfs in external cluster
with recent discussion we come to conclusion
nfs can be suported easily in the external cluster
so adding the design that we discussed

closes: https://github.com/rook/rook/issues/13277

Signed-off-by: parth-gr <partharora1010@gmail.com>
2024-06-13 16:44:31 +05:30
Travis Nielsen c5fd5cd0b5 core: update go modules for snyk security check
The snyk security check started failing with a warning
about the package being outdated:
github.com/libopenstorage/secrets/azure which depends on
github.com/Azure/azure-sdk-for-go/sdk/azidentity.
These and related packages are now updated.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2024-06-12 16:45:07 -06:00
Travis Nielsen 720c23abcf Merge pull request #14325 from ideepika/wip-solve-device-class-bug
pool: get the exact deviceClass name instead of crushroot+deviceClass
2024-06-12 16:13:41 -06:00
Deepika Upadhyay 41116be919 pool: get the exact deviceClass name instead of crushroot+deviceClass
this lead to creation of 2 crush rules because of difference in
deviceClass names:
eg:
creating a new crush rule for changed deviceClass
("default~hdd"-->"hdd") on crush rule "test-crush-bug-az-ab-4"

Signed-off-by: Deepika Upadhyay <deepikaupadhyay01@gmail.com>
2024-06-13 01:03:20 +05:30
Deepika Upadhyay 8bb2c3b9f6 docs: add docs for enableCrushUpdates option
Signed-off-by: Deepika Upadhyay <deepikaupadhyay01@gmail.com>
2024-06-13 00:23:40 +05:30
Deepika Upadhyay d71f9c238f pool: add option to enableCrushUpdates to pool if required
this will be disabled by default but in scenarios where the user want to
update failureDomain, DeviceClass etc, this option can be enabled, to be
noted this can lead to lot of data rebalancing and remapping. Use with
caution

Signed-off-by: Deepika Upadhyay <deepika.upadhyay@clyso.com>
2024-06-12 22:48:25 +05:30
Travis Nielsen dafcb7644f Merge pull request #14323 from catdog2/add-annotations-labels-storageclass
helm: allow custom labels and annotations for storage classes
2024-06-12 07:33:45 -06:00
Peter Dahlberg de82481d80 helm: allow custom labels and annotations for storage classes
Storage classes were missing the possilbilty to attach custom labels and
annotations. This change brings it on par with VolumeSnapshotClass
objects.

Signed-off-by: Peter Dahlberg <catdog2@tuxzone.org>
2024-06-12 03:48:45 +02:00
Travis Nielsen 02a552ce00 Merge pull request #14312 from matofeder/update-prometheus-alerts
monitoring: update to the latest ceph prometheus rules
2024-06-10 15:17:25 -06:00
Blaine Gardner 63bbbe4de8 Merge pull request #14319 from rook/dependabot/go_modules/github-dependencies-977e0afb3f
build(deps): bump the github-dependencies group with 2 updates
2024-06-10 13:58:54 -06:00