Commit Graph
13292 Commits
Author SHA1 Message Date
Redouane Kachach 734d105790 test: applying adding rbac.yaml when enabling monitoring
applying adding rbac.yaml when enabling monitoring to avoid
permission issues when accessing servicemonitors

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
2023-11-23 16:38:12 +01:00
Redouane Kachach f60cdde460 test: increasing rook-ceph-tools deployment timeout to 90s
Signed-off-by: Redouane Kachach <rkachach@redhat.com>
2023-11-23 16:37:01 +01:00
Redouane Kachach f93532a8e4 test: adding support to specify the operator and cluster namepaces
adding support to specify operator and cluster namespaces through new
command-line arguments: -c for cluster and -o for operator. The script
will automatically update the namespace in the corresponding YAML files

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
2023-11-23 13:48:06 +01:00
Redouane Kachach afc485fa03 mgr: adding CEPH_ARGS to the mgr pod so radosgw-admin can use it
ceph dashboard uses radosgw-admin for certain tasks that
aren't accessible via the rgw REST API. Due to the absence of
a valid ceph.conf file at /etc/ceph/ceph.conf within the mgr pod,
radosgw-admin fails to operate, resulting in 500 errors across
various 'Object Gateway' views on the dashboard. This change
adds CEPH_ARGS environment variable to the mgr pod enabling
its propagation and utilization by the dashboard/radosgw-admin
for executing rgw commands.

closes: https://github.com/rook/rook/issues/13255

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
2023-11-23 10:48:55 +01:00
Ryotaro Banno 0ad88e9d68 core: add pgHealthyRegex to DisruptionManagementSpec
This patch adds `pgHealthyRegex` field to DisruptionManagementSpec.
`pgHealthyRegex` is a regular expression that is used to determine which
PG states should be considered healthy. The default value of
`pgHealthyRegex` is:

        ^(active\+clean|active\+clean\+scrubbing|active\+clean\+scrubbing\+deep)$

which is effectively the same as before.

Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
2023-11-22 00:19:04 +00:00
Travis Nielsen 510d2721b4 Merge pull request #13247 from riya-singhal31/master
csi: add csi-addons sidecar to cephfs deployment
2023-11-21 16:13:31 -07:00
Travis Nielsen da2513e484 Merge pull request #13248 from rkachach/fix_issue_exporter_interval
mgr: get servicemonitor exporter's interval from MonitoringSpec
2023-11-21 16:02:38 -07:00
Riya Singhal 401ce4697a csi: add csi-addons sidecar to cephfs deployment
this commit adds csi-addon sidecar to
cephfsplugin provisioner deployment

Signed-off-by: Riya Singhal <rsinghal@redhat.com>
2023-11-22 02:50:45 +05:30
Redouane Kachach 6b71325dbe mgr: get servicemonitor exporter's interval from MonitoringSpec
this change updates the serviceMonitor interval of the the rook-ceph-exporter
with the value from the MonitoringSpec.

closes: https://github.com/rook/rook/issues/13159

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
2023-11-21 21:47:28 +01:00
Travis Nielsen 38ceb90ab2 Merge pull request #13211 from subhamkrai/pr/gauravsitlani/12957
core: operator to skip reconcile of mgr, rgw, mds and rbd-mirror
2023-11-21 12:15:34 -07:00
Travis Nielsen 346746c43b Merge pull request #13244 from iPraveenParihar/upgrade-sidecar-versions
csi: update csi sidecars' image version
2023-11-21 12:10:49 -07:00
Travis Nielsen e3c9ed6768 Merge pull request #13239 from avanthakkar/run-exporter-with-specific-keyring
exporter: run exporter with specific keyring
2023-11-21 11:59:05 -07:00
avanthakkar 8fa561484a exporter: run exporter with specific keyring
Similar to the ceph crash collector daemon that generates a keyring with more
restrictive privileges, the exporter should also generate and use a more limited keyring.

Signed-off-by: avanthakkar <avanjohn@gmail.com>
2023-11-21 23:52:50 +05:30
Blaine Gardner e9410058fd Merge pull request #13249 from BlaineEXE/fix-rgw-period-errors
test: add tmate to daily/nightly jobs
2023-11-21 10:37:44 -06:00
Blaine Gardner cbd9c8fe74 test: add tmate to daily/nightly jobs
Add tmate debugging to daily/nightly jobs to help debugging.

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
2023-11-21 09:29:28 -07:00
Blaine Gardner 891edb1cbd Merge pull request #13230 from koor-tech/ceph_config_via_cluster_crd
build: use /usr/bin/env to look up script interpreters
2023-11-21 10:07:56 -06:00
gauravsitlani 3d0049c547 core: operator to skip reconcile of mgr, rgw, mds and rbd-mirror daemons in debug
During certain maintenance tasks the admin will own running
operations on the ceph mgr, rgw, mds and rbd-mirror daemons
and the operator should not interfere with those operations.

Co-authored-by: gauravsitlani <gaurav.sitlani@live.com>
Signed-off-by: subhamkrai <srai@redhat.com>
2023-11-21 20:14:16 +05:30
Alexander Trost fcf52207f8 build: use /usr/bin/env to look up script interpreters
Signed-off-by: Alexander Trost <galexrt@googlemail.com>
2023-11-21 14:38:22 +01:00
Praveen M ddf03bce6f csi: update csi sidecars' image version
csi-node-driver-registrar: v2.9.1
csi-resizer: v1.9.2
csi-provisioner: v3.6.2
csi-attacher: v4.4.2
csi-snapshotter: v6.3.2
Signed-off-by: Praveen M <m.praveen@ibm.com>
2023-11-21 14:41:57 +05:30
Blaine Gardner e54f112f04 Merge pull request #13237 from zer0def/issue-12833
rgw: correctly handle mgr-proxied rgw cli commands in multus scenarios
2023-11-20 18:18:15 -06:00
zer0def 9b69b5cb46 rgw: correctly handle mgr-proxied rgw cli commands in multus scenarios
Due to multi-site Ceph object resources (realms, zonegroups, zones)
reconciliation CLI commands being proxied through CephCluster's Mgr pods
in Multus-based scenarios, return codes were being additionally wrapped
by K8S' command streams and weren't adequately handled in-code, causing
reconciliation of CephObject(Realm|ZoneGroup|Zone) resources to fail, as
an exit code of 0, instead of the expected syscall.ENOENT (2) was returned.

Fixes #12833

Signed-off-by: zer0def <zv0uzqbqnncivw0afjsx79jmd19shpps3r5f2vjc6yv@definedaszero.xyz>
2023-11-20 23:42:17 +01:00
Travis Nielsen fc43f8fc69 Merge pull request #13233 from rook/dependabot/go_modules/k8s-dependencies-3e07744c0b
build(deps): bump the k8s-dependencies group with 4 updates
2023-11-20 14:49:09 -07:00
dependabot[bot] 8abc599c42 build(deps): bump the k8s-dependencies group with 4 updates
Bumps the k8s-dependencies group with 4 updates: [k8s.io/api](https://github.com/kubernetes/api), [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver), [k8s.io/cli-runtime](https://github.com/kubernetes/cli-runtime) and [k8s.io/cloud-provider](https://github.com/kubernetes/cloud-provider).

Updates `k8s.io/api` from 0.28.3 to 0.28.4
- [Commits](https://github.com/kubernetes/api/compare/v0.28.3...v0.28.4)

Updates `k8s.io/apiextensions-apiserver` from 0.28.3 to 0.28.4
- [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases)
- [Commits](https://github.com/kubernetes/apiextensions-apiserver/compare/v0.28.3...v0.28.4)

Updates `k8s.io/cli-runtime` from 0.28.3 to 0.28.4
- [Commits](https://github.com/kubernetes/cli-runtime/compare/v0.28.3...v0.28.4)

Updates `k8s.io/cloud-provider` from 0.28.3 to 0.28.4
- [Commits](https://github.com/kubernetes/cloud-provider/compare/v0.28.3...v0.28.4)

---
updated-dependencies:
- dependency-name: k8s.io/api
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/apiextensions-apiserver
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/cli-runtime
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/cloud-provider
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-11-20 14:21:16 -07:00
Travis Nielsen 86c227e64a Merge pull request #13234 from rook/dependabot/go_modules/github-dependencies-df6d6e1067
build(deps): bump the github-dependencies group with 1 update
2023-11-20 12:09:54 -07:00
Travis Nielsen 6b1f912958 Merge pull request #13236 from rkachach/fix_issue_monitoring_namespace
manifest: adding the namespace tag to the monitoring manifests
2023-11-20 11:43:05 -07:00
Redouane Kachach 147f6e2e78 manifest: adding the namespace tag to the monitoring manifests
including the namespace tag in the monitoring manifests to streamline
the automated process of modifying them through scripting

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
2023-11-20 17:19:37 +01:00
dependabot[bot] fb63aa5be6 build(deps): bump the github-dependencies group with 1 update
Bumps the github-dependencies group with 1 update: [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go).

- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Commits](https://github.com/aws/aws-sdk-go/compare/v1.47.9...v1.48.0)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-11-20 12:06:17 +00:00
Travis Nielsen 8f611cfdfc Merge pull request #13228 from Madhu-1/fix-csi-conf-link
doc: correct csi ceph.conf path
2023-11-17 09:48:58 -07:00
Travis Nielsen 250db2b888 Merge pull request #13218 from subhamkrai/min-k8s-1.23
ci: upgrade min k8s support to 1.23.17
2023-11-17 07:24:42 -07:00
Madhu Rajanna d1613af35d doc: correct csi ceph.conf path
correct the csi ceph.conf path
in the documentation.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2023-11-17 13:38:21 +01:00
subhamkrai 39e41ed8d7 ci: upgrade min k8s support to 1.23.17
Upgrade minimum kubernetes support to 1.23.17 from 1.22.17.
Also, upgrade kubernetes version latest minor release.

Signed-off-by: subhamkrai <srai@redhat.com>
2023-11-17 13:06:46 +05:30
Alexander Trost 931174d36a Merge pull request #13202 from koor-tech/design_osd_scrubbing_schedule 2023-11-17 00:53:27 +01:00
Travis Nielsen 297e8400e5 Merge pull request #12850 from parth-gr/node-telemetry
core: report node metrics using ceph telemetry
2023-11-16 14:55:44 -07:00
Alexander Trost d7311c8e87 docs: add design doc for setting ceph config via cluster crd
Signed-off-by: Alexander Trost <galexrt@googlemail.com>
2023-11-16 16:47:00 +01:00
parth-gr f007f2aca1 core: report node metrics using ceph telemetry
Add this reporting with the cephcluster reconcile,
Similar way we reported other telemetry's

Closes: https://github.com/rook/rook/issues/12344

Signed-off-by: parth-gr <paarora@redhat.com>
2023-11-16 19:13:22 +05:30
Travis Nielsen f86fca5e7a Merge pull request #13216 from travisn/upgrade-from-1.12
tests: Upgrade from 1.12 to master
2023-11-15 17:40:58 -07:00
travisn 6c16c0eb83 tests: upgrade from 1.12 to master
The upgrade test should always upgrade from the previous
minor release to the latest master. With 1.13 releasing
soon, now we uprade from 1.12 to master, to confirm
if there are any upgrade issues to 1.13.

Signed-off-by: travisn <tnielsen@redhat.com>
2023-11-15 16:11:14 -07:00
Travis Nielsen 7b57e0640f Merge pull request #13207 from travisn/remove-pacific
core: Remove support for ceph pacific
2023-11-15 10:24:43 -07:00
travisn 03d077aa6b core: remove support for ceph pacific
Pacific is end of life and no longer necessary to
support in Rook with v1.13.

Signed-off-by: travisn <tnielsen@redhat.com>
2023-11-14 17:07:03 -07:00
Blaine Gardner d01029a4b0 Merge pull request #13206 from BlaineEXE/multus-fix-network-canary-all-placement
multus: fix placement error for net addr detect job
2023-11-14 17:58:19 -06:00
Blaine Gardner 0a538bfc37 multus: fix placement error for net addr detect job
Fix an issue in the network address detection job where placement was
only retreived from osd and not merged with all.

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
2023-11-14 12:36:58 -07:00
Travis Nielsen 1f157df699 Merge pull request #12817 from parth-gr/objectstore-improvements
object: improve the error handling for multisite objs
2023-11-14 12:33:38 -07:00
parth-gr 46c241433d object: improve the error handling for multisite objs
here is the https://go.dev/play/p/SS9Q-dAiIx3 example which says the
error handling was wrongly implemented

Signed-off-by: parth-gr <paarora@redhat.com>
2023-11-14 15:12:15 +05:30
Blaine Gardner 5230fcd60d Merge pull request #12845 from synarete/nfs-liveness-probe
nfs: add livness-probe to nfs-ganesha container
2023-11-13 13:44:57 -06:00
Travis Nielsen 6f1a3eee01 Merge pull request #13182 from obnoxxx/fix-getopts-in-create-dev-cluster
unify treatment of invocation errors in the create-dev-cluster script
2023-11-13 11:29:40 -07:00
Michael Adam 82c329c6af tests: create-dev-cluster: unify handling of invocation errors
This change to the create-dev-cluster script is intended to make the
handling of invalid invocations more uniform
examples are unknown options and options requiring an argument specified
without one.

The unification is achieved by encapsulating the corresponding code in a
function.

Signed-off-by: Michael Adam <obnox@samba.org>
2023-11-13 19:19:52 +01:00
Travis Nielsen 3288e60cf5 Merge pull request #13069 from subhamkrai/update-device-class
pool: allow updating deviceClass on existing pool
2023-11-13 10:57:57 -07:00
subhamkrai 133154d192 pool: allow updating deviceClass on existing pool
This commits add check to update the deviceClass on
existing pool.

Signed-off-by: subhamkrai <srai@redhat.com>
2023-11-13 20:40:21 +05:30
Travis Nielsen 784325a5d9 Merge pull request #13194 from rook/dependabot/github_actions/dcarbone/install-jq-action-2.1.0
build(deps): bump dcarbone/install-jq-action from 2.0.2 to 2.1.0
2023-11-13 07:43:27 -07:00
Travis Nielsen da53fb8ad2 Merge pull request #13193 from rook/dependabot/go_modules/github-dependencies-0aba6ab15d
build(deps): bump the github-dependencies group with 4 updates
2023-11-13 07:42:29 -07:00