Commit Graph
13292 Commits
Author SHA1 Message Date
dependabot[bot] 98788f99a0 build(deps): bump github.com/aws/aws-sdk-go from 1.44.328 to 1.44.329
Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.328 to 1.44.329.
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Commits](https://github.com/aws/aws-sdk-go/compare/v1.44.328...v1.44.329)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-08-22 23:25:53 +00:00
Travis Nielsen 031f3c60e4 Merge pull request #12663 from BlaineEXE/update-go-mod
build: update go modules
2023-08-22 17:23:52 -06:00
Blaine Gardner 87fc55200f build: update go modules
Update go modules. The primary goal is to remove the goproxy import
which has security warnings. The library is not used directly or
indirectly by any called Rook code, only dependency modules. Therefore,
exclude it from the build.

At the same time, portworx deps are starting to complicate the module
update again. Rook also doesn't directly or indirectly use the portworx
code, so exclude it also.

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
2023-08-22 13:33:50 -06:00
Travis Nielsen d845107fda Merge pull request #12764 from travisn/pkg-go-sum
build: Remove go modules under apis directory
2023-08-22 11:16:31 -06:00
Travis Nielsen 9803bd5aa7 Merge pull request #12724 from Madhu-1/close-12645
csi: set ceph cluster as ControllerRef for holder ds
2023-08-22 07:41:30 -06:00
Madhu Rajanna d7a4f0038c csi: set ceph cluster as ControllerRef for holder
Setting ceph cluster as the ControllerRef
for the holder daemonset set so that when
a ceph cluster is deleted the holder daemoset
will also gets deleted.

fixes: #12645

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2023-08-22 10:41:17 +02:00
travisn 138624a3b0 build: update the go modules to the latest
Run make go.mod.update to update the go modules to
the latest references.

Signed-off-by: travisn <tnielsen@redhat.com>
2023-08-21 15:19:28 -06:00
travisn 1a4917de78 build: remove go modules under apis directory
The go package dependencies (go.mod and go.sum) were created
under the pkg/apis directory to simplify the dependencies for
other projects referencing the rook repo. The downside is that
the dependabot can no longer open a working and valid PR since
the bot is not aware of the go.mod and go.sum in the apis directory.

Since the reduction of dependencies for vault in #12455,
the list of extra dependencies is not quite so extensive.
We are putting effort into shrinking the dependency list instead
of using the modules files in the apis subdirectory.

Note that #12419 updated the dependencies for the latest controller
runtime which also increased the size of the modules
list in the pkgs subdirectory, which means the difference
in dependencies in the pkgs subdirectory is no longer
signficant anyway.

Signed-off-by: travisn <tnielsen@redhat.com>
2023-08-21 15:13:33 -06:00
Travis Nielsen 9a5ea4c92b Merge pull request #12734 from parth-gr/helm-improvements
helm: improvement in docs
2023-08-21 10:17:14 -06:00
parth-gr 67f294b623 helm: update the default version tag to master
updating this to ease the local testing
using helm for master branch repo

Signed-off-by: parth-gr <paarora@redhat.com>
2023-08-21 20:05:14 +05:30
parth-gr 41aa70aedf helm: improvement in docs
values.overide isn't used for cephcluster
we use values.yaml so updated the doc with the
change

Signed-off-by: parth-gr <paarora@redhat.com>
2023-08-21 19:50:29 +05:30
Travis Nielsen e2debde445 Merge pull request #12747 from rowanruseler/rr/charts-documentation-refs
helm: replaced broken documentation references
2023-08-18 08:12:52 -06:00
Rowan Ruseler 8f8f46dbd6 helm: replaced broken documentation references
Noticed that since the release of 1.9, the values.yaml file has some
old documentation references. Replaced them with the new locations.

Adjusted the link as requested by travisn
Placed extra line eof back as requested by path-gr

Signed-off-by: Rowan Ruseler <rowanruseler@gmail.com>
2023-08-18 10:21:37 +02:00
Travis Nielsen 430e8552a4 Merge pull request #12744 from Javlopez/feature/11574-move-how-to-run-tests-instructions-to-developer
docs: move how to run tests instructions to contributing
2023-08-17 12:51:49 -06:00
Travis Nielsen e84ba84af6 Merge pull request #12751 from travisn/crd-gen-update
build: Update crds gen for new descriptions
2023-08-17 12:45:04 -06:00
Travis Nielsen 0e3117bd6e Merge pull request #12507 from sp98/osd-migration
Replace OSD to use new backend store
2023-08-17 12:40:49 -06:00
travisn 438b61721f build: update crds gen for new descriptions
The CRDs were not generated for the latest since #12384
was merged without rebasing, and other updates with a newer
dependency required the newer descriptions.

Signed-off-by: travisn <tnielsen@redhat.com>
2023-08-17 12:03:33 -06:00
Travis Nielsen afaadd78c4 Merge pull request #12384 from ideepika/feature/ksd-174
mon: add mon storage class support
2023-08-17 11:52:20 -06:00
Javier b16f062af0 docs: move how to run tests instructions to contributing
rename and move tests/README.md to
Documentation/Contributing/rook-test-framework.md in order to make it
part of the contributing section

Signed-off-by: Javier <sjavierlopez@gmail.com>
2023-08-17 10:13:39 -06:00
sp98 886bb357ef osd: replace osd to use new backend store
If osd store is updated in the ceph cluster, then
delete OSDs one by one, cleanup disks and provision a new OSD on
the same disk

Signed-off-by: sp98 <sapillai@redhat.com>
2023-08-17 21:40:55 +05:30
Travis Nielsen 4655300a0a Merge pull request #12743 from travisn/earlier-toolbox
tests: Start toolbox earlier in tests
2023-08-17 08:37:35 -06:00
travisn 0bd7d4ac84 tests: use same ceph version for toolbox in multicluster
The multicluster test was using a different ceph image for the
toolbox than from the original cluster. For efficiency of
pulling images in the test, the toolbox of the external cluster
will now use the same ceph image as the internal cluster.

Signed-off-by: travisn <tnielsen@redhat.com>
2023-08-16 15:50:57 -06:00
travisn 90d06a862b tests: start toolbox earlier in tests
The toolbox sometimes times out when the tests are waiting
for it to start. Now we create the toolbox spec sooner in
the tests so we won't need to wait so long for it to start
or increase the wait timeout in the tests.

Signed-off-by: travisn <tnielsen@redhat.com>
2023-08-16 15:30:12 -06:00
Travis Nielsen f3764cc7ad Merge pull request #12731 from cjyar/alert-for
monitoring: add "for" to CephOSDDownHigh alert
2023-08-16 14:11:54 -06:00
Travis Nielsen 29f984da3a Merge pull request #12691 from subhamkrai/operator-placement
operator: move most of discover pod setting to cm
2023-08-16 13:54:23 -06:00
Travis Nielsen 9efe0b7db0 Merge pull request #12672 from subhamkrai/fix-update-vault
build: update vault and other indirect imports
2023-08-16 11:11:06 -06:00
Travis Nielsen bffd2e0af5 Merge pull request #12679 from subhamkrai/fix-nodeLoss-logging
operator: log op. config cm setting when changed
2023-08-16 11:09:27 -06:00
Travis Nielsen 0c3c8d1fdf Merge pull request #12675 from parth-gr/openshift-helm
helm: install rook in openshift cluster
2023-08-16 11:06:15 -06:00
subhamkrai fb39580067 operator: move most of discover pod setting to cm
It's better to move most of discover daemon setting
from env to configmap rook-ceph-operator-config.
Although, we are moving to configmap, we keep reading settings
from env but the priority will be configmap settings.

Signed-off-by: subhamkrai <srai@redhat.com>
2023-08-16 22:17:47 +05:30
Travis Nielsen 7bab21f9cb Merge pull request #12736 from subhamkrai/fix-raw-disk-ci
ci: create toolbox-operator early in ci
2023-08-16 10:42:10 -06:00
subhamkrai a25071ac29 ci: fix golangCI lint remove k8s.io/utils/pointer
golangci linter was throughing error `k8s.io/utils/pointer`
package is deprecated. So, I have removed that.

Signed-off-by: subhamkrai <srai@redhat.com>
2023-08-16 21:48:42 +05:30
subhamkrai bffa766b4f ci: create toolbox-operator early in ci
moving the toolbox-operator creation early in
ci, so that by the time we wait for others pods
to come up, toolbox-operator will be ready or
will wait for 180s.

Signed-off-by: subhamkrai <srai@redhat.com>
2023-08-16 20:44:46 +05:30
parth-gr 62e3ffb2ba helm: install rook in openshift cluster
The sccs were missing in the helm installation,
added it

Closes: https://github.com/rook/rook/issues/12280

Signed-off-by: parth-gr <paarora@redhat.com>
2023-08-16 14:43:36 +05:30
subhamkrai 733be02577 operator: log op. config cm setting when changed
earlier, we're always logging when `GetValue` method is
called to get operator config  values which somettime
spamming the logs for example `ROOK_WATCH_FOR_NODE_FAILURE`
keep logging every time 5 min.

Now, we'll store the settings in the map and log only when
map key value is changed.

Signed-off-by: subhamkrai <srai@redhat.com>
2023-08-16 13:56:38 +05:30
Chris Jones 9f1e5ec4ee monitoring: add "for" to CephOSDDownHigh alert
As part of a normal restart, an OSD can go down just as prometheus tries
to scrape it, causing this alert to fire. Alerts shouldn't fire as part
of normal operations. This change requires the OSD to be down for 5
consecutive minutes before the alert will fire.

Signed-off-by: Chris Jones <chris@cjones.org>
2023-08-15 19:37:46 -06:00
Travis Nielsen 561511e8d4 Merge pull request #12726 from obnoxxx/contrib-wording
docs: minor rewording in  Contributing guide.
2023-08-15 11:20:26 -06:00
Travis Nielsen be4e60bfe1 Merge pull request #12725 from Madhu-1/update-12673
file: ignore exit code 22 when addding datapool
2023-08-15 11:16:14 -06:00
Michael Adam 3022c0f8f2 docs: minor rewording in Contributing guide
This is just an innocuous little rewording of one part of the
contributing guide that occurred to me while reading the doc.

Signed-off-by: Michael Adam <obnox@samba.org>
2023-08-15 18:57:40 +02:00
Madhu Rajanna bd9b42d221 file: ignore exit code 22 when adding datapool
Ignore the exit code 22 when adding the
datapool to a filesystem.

updates: #12673

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2023-08-15 16:01:48 +02:00
Blaine Gardner d4b806d20c Merge pull request #12698 from nixpanic/nfs/dbus-uid
nfs: run dbus-daemon sidecar as dbus user instead of root
2023-08-11 13:42:21 -06:00
Blaine Gardner 853bab398a Merge pull request #12495 from Nikhil-Ladha/issue12172/multus-validation-job
multus: Add sample job manifest for multus config validation
2023-08-11 13:28:07 -06:00
Nikhil-Ladha 9fea9cd865 multus: add sample job manifest for multus config validation
added a sample job manifest named `multus-validation` that
validates the multus configuration in the cluster.

Signed-off-by: Nikhil-Ladha <nikhilladha1999@gmail.com>
2023-08-11 10:55:29 +05:30
Niels de Vos 320b112cc6 nfs: run dbus-daemon sidecar as dbus user instead of root
When the dbus-daemon in the sidecar is started as "root" user, it fails
with the following log entry:

Failed to start message bus: Failed to drop capabilities: Operation not permitted

By starting the sidecar as "dbus" user (uid=81), the executable does not
try to drop capabilities, and starts successfully.

Signed-off-by: Niels de Vos <ndevos@ibm.com>
2023-08-10 18:17:19 +02:00
Travis Nielsen 71f078c0fc Merge pull request #12694 from parth-gr/ci-objectsuite-time
ci: update the objectsuite test timeout to 40m
2023-08-09 11:45:05 -06:00
parth-gr 8617e2e924 ci: update the objectsuite test timeout to 40m
While running object test we need some more time
to run the cosi test completely so increasing the timeout

Also update timeout of ntegration-tests-on-release.yaml

Signed-off-by: parth-gr <paarora@redhat.com>
2023-08-09 22:47:06 +05:30
Deepika Upadhyay 427c53786b docs: amend for clarity on failureDomainLabel and VolumeClaimTemplate
Signed-off-by: Deepika Upadhyay <deepika@koor.tech>
2023-08-09 21:21:40 +05:30
Travis Nielsen e90cedce85 Merge pull request #12600 from parth-gr/ci-objectsuite
ci: fix testobjectsuite ci
2023-08-09 09:05:06 -06:00
Travis Nielsen 4bcda1a47e Merge pull request #12381 from sp98/osd-migration-design
doc: osd migration design
2023-08-09 08:35:28 -06:00
Travis Nielsen 3d2bbd9785 Merge pull request #12677 from parth-gr/canary-ci-improvement
ci: improve the canary toolbox operator pod check
2023-08-09 08:19:40 -06:00
sp98 3f79fe8548 docs: osd migration design
A design doc to migrate osd incase of change in the OSD backend

Signed-off-by: sp98 <sapillai@redhat.com>
2023-08-09 07:35:38 +05:30