Commit Graph
13292 Commits
Author SHA1 Message Date
Blaine Gardner b3438a8b60 docs: update upgrade docs to add ceph reef support
Ceph Reef v18 is supported by Rook v1.12 even though it is still in
pre-release. Add Reef support to docs, and note that Pacific support
will be dropped in the next Rook release.

Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
2023-07-17 10:52:01 -06:00
Travis Nielsen 7827ad6c0c Merge pull request #12523 from rook/dependabot/github_actions/helm/kind-action-1.8.0
build(deps): bump helm/kind-action from 1.7.0 to 1.8.0
2023-07-17 10:45:41 -06:00
Alexander Trost 86630709b7 Merge pull request #12505 from parth-gr/black-formatter 2023-07-17 15:18:12 +02:00
dependabot[bot] c5a70f5ee3 build(deps): bump helm/kind-action from 1.7.0 to 1.8.0
Bumps [helm/kind-action](https://github.com/helm/kind-action) from 1.7.0 to 1.8.0.
- [Release notes](https://github.com/helm/kind-action/releases)
- [Commits](https://github.com/helm/kind-action/compare/v1.7.0...v1.8.0)

---
updated-dependencies:
- dependency-name: helm/kind-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-07-17 12:32:29 +00:00
Lucas Henry 393d09347e rgw: add option to disable synchronization traffic
Some users want to deploy two CephObjectStores for a single Zone. The first
configures RGWs to process the synchronization of the data, while the second
CephObjectStore configures the client RGWs.

Currently, this can be implemented by setting the RGW option
'rgw_run_sync_thread' in the 'rook-config-override' ConfigMap, though it is not
really user friendly.

Ref: https://docs.ceph.com/en/latest/radosgw/config-ref/#confval-rgw_run_sync_thread

This commit adds a new option in the CephObjectStore CRD as defined in issue
https://github.com/rook/rook/issues/12272. The new option
'disableMultisiteSyncTraffic' determine whether the operator should disable the
multisite sync threads for the RGWs.

If the option is set to 'false', or if the option is not specified, the operator
does nothing. This ensures that the multisite sync threads will not be enabled
for users that disabled explicitely the multisite sync threads either manually
or with the 'rook-config-override' ConfigMap.

This commit also recommends to use two objectstore when scaling Ceph Objectstore
Multisite replication, with one objectstore configured with disabled replication
traffic.

Signed-off-by: Lucas Henry <polyedre@disroot.org>
2023-07-17 09:27:20 +02:00
Sachin Prabhu 0a151e913d nfs: mount krb5.conf and krb5.keytab in the sssd container
This will enable us to use GSSAPI in sssd for authentication when
connecting to the remote LDAP server.

Signed-off-by: Sachin Prabhu <sprabhu@redhat.com>
2023-07-15 18:55:09 +01:00
parth-gr d7e0ccdfcd external: make black as default python formatter
Closes: https://github.com/rook/rook/issues/11926

Signed-off-by: parth-gr <paarora@redhat.com>
2023-07-14 21:04:42 +05:30
Blaine Gardner 647a4e3534 Merge pull request #12477 from parth-gr/subvolume-pinning-external
external: pin the default csi subvolume
2023-07-13 09:40:22 -06:00
parth-gr 53413e5a24 external: pin the default csi subvolume
set the csi subvolume to pin type distributed and pin setting 1
So to statically balance the PVs across all MDS ranks

Signed-off-by: parth-gr <paarora@redhat.com>
2023-07-12 20:32:27 +05:30
Travis Nielsen 1913413ddf Merge pull request #12423 from Javlopez/feature/12367-add-support-ceph-reef
test: add support Ceph Reef v18 with updated integration tests
2023-07-10 18:05:06 -06:00
Javier 46cb9435a6 test: support Ceph Reef v18 with updated integration tests
update test files to support the next version of ceph, ceph reef v18

Signed-off-by: Javier <sjavierlopez@gmail.com>
2023-07-10 15:24:36 -06:00
Travis Nielsen a96f809f3b Merge pull request #12492 from Rakshith-R/rwx-watcher-check
core: add check for pv access modes' multinode support
2023-07-10 10:59:38 -06:00
Travis Nielsen ba7e68594a Merge pull request #12484 from subhamkrai/fix-tmate-ui-acces
ci: fix tmate access issue
2023-07-10 06:57:17 -06:00
Rakshith R 12e2cd550f core: add check for pv access modes' multinode support
During faster node loss recovery,
Rook needs to check and blocklist only rbd pvs
that do not support multinode access modes such as
ReadOnlyMany(ROX) and ReadWriteMany(RWX).
This commit adds check for the same.

Signed-off-by: Rakshith R <rar@redhat.com>
2023-07-10 16:12:13 +05:30
Travis Nielsen 8ee4ae2a19 Merge pull request #12489 from travisn/mergify-1.12
ci: Enable mergify for the 1.12 branch
2023-07-07 15:18:26 -06:00
travisn 57703deb6c ci: enable mergify for the 1.12 branch
For the new release-1.12 branch, mergify rules are added
for automatically opening PRs and merging backports
when approved.

Signed-off-by: travisn <tnielsen@redhat.com>
2023-07-07 12:30:39 -06:00
Travis Nielsen 65f413ce1f Merge pull request #12286 from subhamkrai/fix-node-loss-rbd
core: faster recovery from rbd rwo node loss
v1.12.0-alpha.0
2023-07-07 10:35:59 -06:00
subhamkrai ab297afa0e ci: fix tmate access issue
we need make `limit-access-to-actor: false` and also
in the right place where tmate `uses` is called for
composite yaml.

Signed-off-by: subhamkrai <srai@redhat.com>
2023-07-07 21:57:58 +05:30
subhamkrai 39b5c057ce core: faster recovery from rbd rwo node loss
in the existing node watcher, we'll check for node update
event and see if there are `out-of-service` taints are applied
and `ROOK_WATCH_FOR_NODE_FAILURE` is enabled in rook-ceph-operator-configmap,
if then we'll create the networkFence cr and delete the cr if nodes come back.
And, added the unit test too.

Signed-off-by: subhamkrai <srai@redhat.com>
2023-07-07 21:16:25 +05:30
Travis Nielsen 3ffec84100 Merge pull request #12462 from Madhu-1/fix-holderpod
csi: update csi holder daemonset template
2023-07-07 08:32:00 -06:00
Travis Nielsen 18e2502a69 Merge pull request #12295 from subhamkrai/remve-default-scc
security: remove default scc privileges
2023-07-07 08:24:37 -06:00
subhamkrai 48f84b37e8 security: drop all capabilities to the container
adding drop `ALL` capabilities in rook operator container
as this is not required and will remove warning in ocp cluster.

Signed-off-by: subhamkrai <srai@redhat.com>
2023-07-07 17:06:48 +05:30
Travis Nielsen 854bc7d980 Merge pull request #12143 from parth-gr/IPV6-external
external: add support for IPV6 ceph daemons
2023-07-06 15:39:05 -06:00
Travis Nielsen 46dd374e30 Merge pull request #12478 from Rakshith-R/csi/rm-checks
csi: drop checks for k8s version below the support minimum version
2023-07-06 11:53:47 -06:00
Travis Nielsen 11018f0d41 Merge pull request #12479 from Rakshith-R/csi/upgrade-sidecar-v
csi: update csi sidecars' image version
2023-07-06 10:29:47 -06:00
Travis Nielsen a58098daa0 Merge pull request #12448 from travisn/set-logger
core: Enable logging for the controller runtime
2023-07-06 10:18:41 -06:00
Rakshith R aa0aa34c23 csi: update csi sidecars' image version
Signed-off-by: Rakshith R <rar@redhat.com>
2023-07-06 16:18:35 +05:30
Rakshith R 76f4b1f586 csi: remove code related to betav1CsiDriver
This commit removes code related to betav1CsiDriver
since minimum k8s version support by rook is now
k8s v1.22 which does not support betav1 csi driver crd.

Signed-off-by: Rakshith R <rar@redhat.com>
2023-07-06 15:55:57 +05:30
Rakshith R d6b8a8f380 csi: remove k8s version check for oidc token
This commit removes k8s version check for oidc token
which required k8s v1.20 or above since minimum
k8s version that rook supports now is v1.22.

Signed-off-by: Rakshith R <rar@redhat.com>
2023-07-06 15:44:45 +05:30
travisn fd66825dad core: set logger for controller runtime
The controller runtime logger has not been set, which means we are missing
information that could be useful in troubleshooting the controllers.
Now the logger is enabled to report this logging in the operator
log.

Signed-off-by: travisn <tnielsen@redhat.com>
2023-07-05 12:20:43 -06:00
Travis Nielsen 29ae629c5f Merge pull request #12455 from travisn/reduce-vault-modules
core: Remove vault server module dependencies
2023-07-05 12:13:25 -06:00
travisn a74a945202 core: remove vault server module dependencies
The vault server dependencies were pulling a lot of indirect modules
that are not necessary for Rook. The modules were only used
for testing. The vault github explicitly indicates that:

"Some other projects have made a practice of doing so in order to
take advantage of testing tooling that was developed for testing Vault itself.
This is not, and has never been, a supported way to use the Vault project."

When attempting to update to vault v1.13.3, we are hitting
such an unsupported configuration with go modules
that are impossible to satisfy. By removing the tests
that were using the vault server project, we can remove
this large set of dependencies, enable updating to v1.13.3,
and also reduce the modules pulled in by vault.

Signed-off-by: travisn <tnielsen@redhat.com>
2023-07-05 11:33:03 -06:00
Travis Nielsen 33133cc2c2 Merge pull request #12457 from mysiki/mysiki-patch-import_ecternal_idempotence
external: Fix import script for idempotent
2023-07-05 11:29:10 -06:00
Travis Nielsen 063087d942 Merge pull request #12467 from subhamkrai/fix-kms-ci
ci: fix ci test encryption-pvc-kms-vault-token-auth
2023-07-05 07:29:03 -06:00
parth-gr de61187eb4 external: add support for IPV6 ceph daemons
updated some function which were strictly used for IPV4

Signed-off-by: parth-gr <paarora@redhat.com>
2023-07-05 17:13:06 +05:30
mysiki b5d0d80444 external: fix import-external-cluster.sh and documentation
fix import-external-cluster.sh in order to work with set -e bash directive, see issue https://github.com/rook/rook/issues/12412
fix documentation mispell in namespace word

Closes: https://github.com/rook/rook/issues/12412

Signed-off-by: mysiki <hoaxboy@wanadoo.fr>
2023-07-05 13:01:44 +02:00
subhamkrai 70f29be748 ci: fix ci test encryption-pvc-kms-vault-token-auth
we need to wait for the rgw pod to be delete and not
only the cephobjectsore, sometime the pod could be in
terminating state. Also, in some place it require proper
command to wait for pod to be ready/delete and get the
pod name only.

Signed-off-by: subhamkrai <srai@redhat.com>
2023-07-05 14:49:18 +05:30
Madhu Rajanna 1ba3aa4d19 csi: update csi holder daemonset template
Currently the holder daemonset is never updated
which will leaves the images the daemonset also
not updated. we should update the daemonset
template but not restart the csi holder pods
which causes the CSI volume access problem,
set the updateStrategy to OnDelete (already set in
yaml files) which allow us to update the holder
daemonset but not restart/update the pods, when a
pod is deleted or node is rebooted
the new changes will take effect.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2023-07-03 14:13:38 +02:00
Peter Goron 40eed236cf object: align spelling of user admin capabilities with ceph
users & buckets admin capabilities aren't spelled the same
way between rook crd (singular) and ceph (plural). It's a bit
misleading when comparing ceph admin cap and rook users.

Signed-off-by: Peter Goron <peter.goron@gmail.com>
2023-07-01 19:05:26 +02:00
Travis Nielsen aee57ea9ff Merge pull request #12449 from travisn/deprecated-bucket-checker
object: Remove obsolete bucket health checker removal
2023-06-29 11:39:39 -06:00
Blaine Gardner d6475408d9 Merge pull request #12437 from sudharsanomprakash/patch-1
Multus Validation : Added verbs "deletecollection"
2023-06-29 09:46:27 -06:00
Travis Nielsen 58994fe922 Merge pull request #12418 from Jeansen/update_docu
Remove deprecated annotation
2023-06-29 08:38:25 -06:00
travisn 4ff18dadf4 object: remove obsolete bucket health checker removal
The bucket health checker was removed in 1.10. Now in 1.12
we no longer need this removal of the bucket health
checker since it will no longer exist to remove.

Signed-off-by: travisn <tnielsen@redhat.com>
2023-06-28 16:07:51 -06:00
Sud 2547372527 multus: add deletecollection capability for validation tool
Without deletecollection capability the image pullers won't be deleted, causing multus validation to fail.
    Added deletecollection verbs to the daemonsets resource in role rook-ceph-system
    This is fix for Issue: https://github.com/rook/rook/issues/12435

    Signed-off-by: Sudharsan Omprakash <sudharsan.omprakash@yahoo.com>
2023-06-28 17:45:18 -04:00
Travis Nielsen c2517f47d0 Merge pull request #12417 from parth-gr/idempotent-external
external: make import script idempotent
2023-06-28 14:31:11 -06:00
Travis Nielsen 7f4dfb1ea8 Merge pull request #12440 from Rakshith-R/selinux-csi-driver
csi: update cephcsi to v3.9.0 and k8s-sidecar to v0.7.0
2023-06-28 10:31:05 -06:00
Rakshith R fa1be14bca csi: update csiaddons k8s-sidecar to v0.7.0
This commit updates k8s-sidecar to v0.7.0
and all links now point to v0.7.0 tag.

Signed-off-by: Rakshith R <rar@redhat.com>
2023-06-28 20:38:29 +05:30
Rakshith R 1af70aca60 csi: update cephcsi to v3.9.0
This commit updates cephcsi image to
v3.9.0 release and also removes support
for v3.7.x.

refer:
https://github.com/ceph/ceph-csi/releases/tag/v3.8.0

Signed-off-by: Rakshith R <rar@redhat.com>
2023-06-28 20:38:29 +05:30
Rakshith R c488693cb3 csi: add SeLinuxMount: true Option to csidriver obj
This feature is alpha and available from k8s 1.25.
This enabled faster mounting of volumes using
RWOP access pod.

refer:
https://kubernetes.io/blog/2023/04/18/kubernetes-1-27-\
efficient-selinux-relabeling-beta/

Signed-off-by: Rakshith R <rar@redhat.com>
2023-06-28 20:23:51 +05:30
Travis Nielsen 034304d8a1 Merge pull request #12430 from travisn/exporter-context
exporter: Ignore failed deletion of service monitor
2023-06-28 08:20:01 -06:00