feedc0de/my-rook-config
1
0
Fork 0
forked from rook/rook
Code Pull Requests Activity
13,292 Commits 38 Branches 289 Tags
c1a892396a94de281cddfa088945b91ae8a6f33a
Commit Graph
13292 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Satoru Takeuchi 99eda42156 Merge pull request #16710 from cybozu-go/update-pr-template 
docs: mark overwriting Ceph's configurations as breaking change
 2025-11-13 09:12:21 +09:00
Satoru Takeuchi b585c35743 docs: mark overwriting Ceph's configurations as breaking change 
Mark overwriting Ceph's configurations as breaking changes.
This is to avoid troubles caused by such changes on upgrade.

ref.
https://github.com/rook/rook/discussions/16652

Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
 2025-11-12 22:29:24 +00:00
Elias Carter 82a7edc268 osd: cleanup orphaned osd provision jobs 
In a running cluster, I noticed that a node which was provisioning was removed from k8s
and the following log was emitted by the rook operator:
```
op-osd: cleaning up dangling OSD prepare status configmap "rook-ceph-osd-xxx-status"
```

But the osd provisioning job was still trying to run on the removed node:
```
rook-ceph-osd-prepare-xxx         Running    0/1           4d22h      4d22h
```

This PR implements a mechanism to remove any osd provision jobs which are bound to a
node which no longer exists within kubernetes. I added a test for this cleanup as
there wasn't a pre-existing test.

Signed-off-by: Elias Carter <elias@dropbox.com>
 2025-11-12 12:35:49 -08:00
Travis Nielsen 23fd211544 Merge pull request #16675 from parth-gr/deviceclass-prepare 
osd: add device class label to the osd prepare pods
 2025-11-12 11:16:08 -07:00
Travis Nielsen d58bebd256 Merge pull request #16705 from parth-gr/fix-pool-panic1 
pool: retry if pool status is empty in rn controller
 2025-11-12 11:13:51 -07:00
subham rai ca440a6d1b Merge pull request #16679 from huyejia/master 
osd: replace Split in loops with more efficient SplitSeq
 2025-11-12 15:37:26 +05:30
huyejia a6239dedfe osd: replace Split in loops with more efficient SplitSeq 
Signed-off-by: huyejia <huyejia@outlook.jp>
 2025-11-12 16:52:12 +08:00
parth-gr fb7226698b subvolumegroup: retry if the filesystem status is empty in svg 
if the filesystem is just created and getting the status
updated svg controller can still go and proceed to
check the filesystem status
If the filesystem status is empty we should retry instead of
proceeding further

Signed-off-by: parth-gr <partharora1010@gmail.com>
 2025-11-12 11:58:53 +05:30
parth-gr 7ef4b4849c pool: retry if pool status is empty in rn controller 
if the pool is just created and getting the status
updated rn controller can still go and proceed to
check the pool status
If the pool status is empty we should retry instead of
proceeding further

Signed-off-by: parth-gr <partharora1010@gmail.com>
 2025-11-12 11:51:53 +05:30
subhamkrai c8ee7305d4 namespace: add retryOnConflict when updating status 
currently, in RNS crd while updating status we don't
have retryOnConflicts, similar to other CRD due to
this RNS status was not updated succesfully and to
fix this we have restart the rook operator pod.

Signed-off-by: subhamkrai <srai@redhat.com>
 2025-11-12 10:16:43 +05:30
subham rai 8424d09e44 Merge pull request #16700 from parth-gr/fix-pool-panic 
pool: fix pool status check in rn controller
 2025-11-12 10:13:48 +05:30
Travis Nielsen 02c197165c Merge pull request #16646 from GanghyeonSeo/master 
external: fix quote parsing and message in import-external-cluster.sh
 2025-11-11 13:01:56 -07:00
Travis Nielsen 3954f05009 Merge pull request #16698 from jhoblitt/maint/add-jhoblitt-to-reviewers 
doc: add Joshua Hoblitt (jhoblitt) to reviewers list
 2025-11-11 11:42:56 -07:00
GanghyeonSeo f9acdab146 external: fix quote parsing and message in import-external-cluster.sh 
Fixed a syntax error caused by incorrect quotation parsing in the importClusterID function of import-external-cluster.sh, and updated the output message shown while waiting for the SubVolumeGroup CR to be created.

Signed-off-by: GanghyeonSeo <sgh000109@gmail.com>
 2025-11-12 03:00:22 +09:00
parth-gr ec242d5ee7 pool: fix pool status check in rn controller 
if the pool is just created and getting the status updated
rn controller can still go and proceed to check the pool status
which result in panic
and later it stop re-trying because of panic get swallowed
https://github.com/rook/rook/commit/cf13deee6f0aaa1ff854d57493bf91df70f8f436

Signed-off-by: parth-gr <partharora1010@gmail.com>
 2025-11-11 18:39:01 +05:30
Joshua Hoblitt 3e0f4d2780 doc: add Joshua Hoblitt (jhoblitt) to reviewers list 
Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
 2025-11-10 14:21:16 -07:00
subham rai 532ea8d497 Merge pull request #16690 from rook/dependabot/go_modules/k8s-dependencies-46bc08174d 
build(deps): bump sigs.k8s.io/controller-runtime from 0.22.3 to 0.22.4 in the k8s-dependencies group
 2025-11-10 20:44:48 +05:30
subham rai c1ecd7b5ec Merge pull request #16692 from rook/dependabot/go_modules/golang.org/x/sync-0.18.0 
build(deps): bump golang.org/x/sync from 0.17.0 to 0.18.0
 2025-11-10 20:44:11 +05:30
subham rai b0958e1b18 Merge pull request #16691 from rook/dependabot/go_modules/github-dependencies-dd301547bd 
build(deps): bump the github-dependencies group with 6 updates
 2025-11-10 20:43:49 +05:30
subham rai 55496c48b0 Merge pull request #16694 from rook/dependabot/github_actions/helm/chart-testing-action-2.8.0 
build(deps): bump helm/chart-testing-action from 2.7.0 to 2.8.0
 2025-11-10 20:43:27 +05:30
subham rai d46885e456 Merge pull request #16695 from rook/dependabot/github_actions/psf/black-25.11.0 
build(deps): bump psf/black from 25.9.0 to 25.11.0
 2025-11-10 20:42:53 +05:30
subham rai 991765937d Merge pull request #16693 from rook/dependabot/github_actions/docker/setup-qemu-action-3.7.0 
build(deps): bump docker/setup-qemu-action from 3.6.0 to 3.7.0
 2025-11-10 20:42:07 +05:30
subham rai 003f1ffd0d Merge pull request #16697 from rook/dependabot/github_actions/codespell-project/actions-codespell-2.2 
build(deps): bump codespell-project/actions-codespell from 2.1 to 2.2
 2025-11-10 20:41:46 +05:30
subham rai 7325c9630c Merge pull request #16696 from rook/dependabot/github_actions/golangci/golangci-lint-action-9.0.0 
build(deps): bump golangci/golangci-lint-action from 8.0.0 to 9.0.0
 2025-11-10 20:41:23 +05:30
dependabot[bot] 48327a5fda build(deps): bump codespell-project/actions-codespell from 2.1 to 2.2 
Bumps [codespell-project/actions-codespell](https://github.com/codespell-project/actions-codespell) from 2.1 to 2.2.
- [Release notes](https://github.com/codespell-project/actions-codespell/releases)
- [Commits](https://github.com/codespell-project/actions-codespell/compare/406322ec52dd7b488e48c1c4b82e2a8b3a1bf630...8f01853be192eb0f849a5c7d721450e7a467c579)

---
updated-dependencies:
- dependency-name: codespell-project/actions-codespell
  dependency-version: '2.2'
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2025-11-10 13:11:57 +00:00
dependabot[bot] 005a5718dc build(deps): bump golangci/golangci-lint-action from 8.0.0 to 9.0.0 
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 8.0.0 to 9.0.0.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases)
- [Commits](https://github.com/golangci/golangci-lint-action/compare/4afd733a84b1f43292c63897423277bb7f4313a9...0a35821d5c230e903fcfe077583637dea1b27b47)

---
updated-dependencies:
- dependency-name: golangci/golangci-lint-action
  dependency-version: 9.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
 2025-11-10 13:11:52 +00:00
dependabot[bot] fec2ceb7cb build(deps): bump psf/black from 25.9.0 to 25.11.0 
Bumps [psf/black](https://github.com/psf/black) from 25.9.0 to 25.11.0.
- [Release notes](https://github.com/psf/black/releases)
- [Changelog](https://github.com/psf/black/blob/main/CHANGES.md)
- [Commits](https://github.com/psf/black/compare/af0ba72a73598c76189d6dd1b21d8532255d5942...05f0a8ce1f71fbb36e1e032d3b518c7b945089a2)

---
updated-dependencies:
- dependency-name: psf/black
  dependency-version: 25.11.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2025-11-10 13:11:48 +00:00
dependabot[bot] e427b5770e build(deps): bump helm/chart-testing-action from 2.7.0 to 2.8.0 
Bumps [helm/chart-testing-action](https://github.com/helm/chart-testing-action) from 2.7.0 to 2.8.0.
- [Release notes](https://github.com/helm/chart-testing-action/releases)
- [Commits](https://github.com/helm/chart-testing-action/compare/0d28d3144d3a25ea2cc349d6e59901c4ff469b3b...6ec842c01de15ebb84c8627d2744a0c2f2755c9f)

---
updated-dependencies:
- dependency-name: helm/chart-testing-action
  dependency-version: 2.8.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2025-11-10 13:11:44 +00:00
dependabot[bot] bea5f3821d build(deps): bump docker/setup-qemu-action from 3.6.0 to 3.7.0 
Bumps [docker/setup-qemu-action](https://github.com/docker/setup-qemu-action) from 3.6.0 to 3.7.0.
- [Release notes](https://github.com/docker/setup-qemu-action/releases)
- [Commits](https://github.com/docker/setup-qemu-action/compare/29109295f81e9208d7d86ff1c6c12d2833863392...c7c53464625b32c7a7e944ae62b3e17d2b600130)

---
updated-dependencies:
- dependency-name: docker/setup-qemu-action
  dependency-version: 3.7.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2025-11-10 13:11:41 +00:00
dependabot[bot] 4421b37507 build(deps): bump golang.org/x/sync from 0.17.0 to 0.18.0 
Bumps [golang.org/x/sync](https://github.com/golang/sync) from 0.17.0 to 0.18.0.
- [Commits](https://github.com/golang/sync/compare/v0.17.0...v0.18.0)

---
updated-dependencies:
- dependency-name: golang.org/x/sync
  dependency-version: 0.18.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2025-11-10 12:37:31 +00:00
dependabot[bot] b19514cb07 build(deps): bump the github-dependencies group with 6 updates 
Bumps the github-dependencies group with 6 updates:

| Package | From | To |
| --- | --- | --- |
| [github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2) | `1.31.16` | `1.31.17` |
| [github.com/aws/aws-sdk-go-v2/credentials](https://github.com/aws/aws-sdk-go-v2) | `1.18.20` | `1.18.21` |
| [github.com/aws/aws-sdk-go-v2/service/sns](https://github.com/aws/aws-sdk-go-v2) | `1.39.2` | `1.39.3` |
| [github.com/aws/smithy-go](https://github.com/aws/smithy-go) | `1.23.1` | `1.23.2` |
| [github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring](https://github.com/prometheus-operator/prometheus-operator) | `0.86.1` | `0.86.2` |
| [github.com/prometheus-operator/prometheus-operator/pkg/client](https://github.com/prometheus-operator/prometheus-operator) | `0.86.1` | `0.86.2` |


Updates `github.com/aws/aws-sdk-go-v2/config` from 1.31.16 to 1.31.17
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json)
- [Commits](https://github.com/aws/aws-sdk-go-v2/compare/config/v1.31.16...config/v1.31.17)

Updates `github.com/aws/aws-sdk-go-v2/credentials` from 1.18.20 to 1.18.21
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/config/v1.18.21/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-go-v2/compare/config/v1.18.20...config/v1.18.21)

Updates `github.com/aws/aws-sdk-go-v2/service/sns` from 1.39.2 to 1.39.3
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json)
- [Commits](https://github.com/aws/aws-sdk-go-v2/compare/v1.39.2...v1.39.3)

Updates `github.com/aws/smithy-go` from 1.23.1 to 1.23.2
- [Release notes](https://github.com/aws/smithy-go/releases)
- [Changelog](https://github.com/aws/smithy-go/blob/main/CHANGELOG.md)
- [Commits](https://github.com/aws/smithy-go/compare/v1.23.1...v1.23.2)

Updates `github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring` from 0.86.1 to 0.86.2
- [Release notes](https://github.com/prometheus-operator/prometheus-operator/releases)
- [Changelog](https://github.com/prometheus-operator/prometheus-operator/blob/main/CHANGELOG.md)
- [Commits](https://github.com/prometheus-operator/prometheus-operator/compare/v0.86.1...v0.86.2)

Updates `github.com/prometheus-operator/prometheus-operator/pkg/client` from 0.86.1 to 0.86.2
- [Release notes](https://github.com/prometheus-operator/prometheus-operator/releases)
- [Changelog](https://github.com/prometheus-operator/prometheus-operator/blob/main/CHANGELOG.md)
- [Commits](https://github.com/prometheus-operator/prometheus-operator/compare/v0.86.1...v0.86.2)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2/config
  dependency-version: 1.31.17
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-dependencies
- dependency-name: github.com/aws/aws-sdk-go-v2/credentials
  dependency-version: 1.18.21
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-dependencies
- dependency-name: github.com/aws/aws-sdk-go-v2/service/sns
  dependency-version: 1.39.3
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-dependencies
- dependency-name: github.com/aws/smithy-go
  dependency-version: 1.23.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-dependencies
- dependency-name: github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring
  dependency-version: 0.86.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-dependencies
- dependency-name: github.com/prometheus-operator/prometheus-operator/pkg/client
  dependency-version: 0.86.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
 2025-11-10 12:37:27 +00:00
dependabot[bot] a1bff5ca9c build(deps): bump sigs.k8s.io/controller-runtime 
Bumps the k8s-dependencies group with 1 update: [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime).


Updates `sigs.k8s.io/controller-runtime` from 0.22.3 to 0.22.4
- [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases)
- [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md)
- [Commits](https://github.com/kubernetes-sigs/controller-runtime/compare/v0.22.3...v0.22.4)

---
updated-dependencies:
- dependency-name: sigs.k8s.io/controller-runtime
  dependency-version: 0.22.4
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
 2025-11-10 12:33:41 +00:00
parth-gr 4fcdfaad1f osd: add device class label to the osd prepare pods 
currently the device class label was added to the osd pod,
we need the device class label on prepare pod,
so to spread across prpeare pods evenly among the faiure domains
per device class

Signed-off-by: parth-gr <partharora1010@gmail.com>
 2025-11-10 17:10:05 +05:30
Blaine Gardner c8c4f58adf Merge pull request #16672 from jhoblitt/maint/obc-bucketowner-user-quotas 
object: fix user quotas being overwritten when obc bucketOwner is set
 2025-11-07 11:46:19 -07:00
Joshua Hoblitt 61cbe4fc23 object: fix user quotas being overwritten when obc bucketOwner is set 
Resolves https://github.com/rook/rook/issues/16417

Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
 2025-11-06 16:31:12 -07:00
Travis Nielsen 7fe438b5cb Merge pull request #16659 from travisn/app-migration 
docs: Example of application migration between clusters
 2025-11-06 15:21:29 -07:00
Travis Nielsen 4cd6416dab docs: example of application migration with dynamic pv 
Document how to migrate an application with a dynamic
PV rather than a static PV, since static PVs have limitations
such as not supporting snapshots and clones.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
 2025-11-06 12:00:46 -07:00
Travis Nielsen 12a6278836 Merge pull request #16681 from richardbadman/fix-some-typos-and-yaml-formatting 
doc: Fix typos and yaml formatting
 2025-11-06 11:32:02 -07:00
Travis Nielsen d34eeee786 Merge pull request #16669 from YiteGu/use-sync-map-for-monitoringRoutines 
core: use sync.Map for cluster.monitoringRoutines
 2025-11-06 11:18:35 -07:00
Richard Goodman f833c549bb doc: fix typos and yaml formatting 
Noticed two small typos when reading the documentation on object stores.
I also noticed that the lack of a whitespace in the creating a user
example affects the syntax highlighting.

Signed-off-by: Richard Goodman <richardg@brandwatch.com>
 2025-11-06 17:13:23 +00:00
Travis Nielsen dba69aab0a docs: example of application migration between clusters 
Applications can be migrated between clusters that are
connecting to the same external Ceph cluster.
This is done with a static PV that can be mounted
by the application across the clusters.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
 2025-11-06 09:37:39 -07:00
Travis Nielsen a5180adb92 Merge pull request #16617 from Nordix/Sunnatillo/add-networkHost-field-cephMgr 
mgr: add hostNetwork field to Manager spec
 2025-11-06 09:28:19 -07:00
Yite Gu bf6c295d02 core: use sync.Map for cluster.monitoringRoutines 
`cluster.monitoringRoutines` stores three types of
daemon health: "mon", "osd", and "status". These are
used by three goroutines respectively, resulting in:
fatal error: concurrent map reads and map writes.

Signed-off-by: Yite Gu <guyite@bytedance.com>
 2025-11-06 19:36:40 +08:00
Sunnatillo b9a4685f65 mgr: add hostNetwork field to Manager spec 
Add optinal hostnetwork field for Ceph Mgr to control whether the
mgr pods to run in host network. If unset, this defaults to
cluster level Network.HostNetwork value. This particulary useful
when user wants to restrict ceph mgr pod from exposing metrics
port in all host interfaces.

Signed-off-by: Sunnatillo <sunnat.samadov@est.tech>
 2025-11-05 21:52:49 +02:00
Blaine Gardner 1ae3d04763 Merge pull request #16349 from obnoxxx/ci-add-upterm-debugging 
ci: add upterm debugging as an  alternative to tmate
 2025-11-05 09:38:06 -07:00
Parth Arora 1c1bd6957d Merge pull request #16673 from parth-gr/fix-external-csi-doc 
doc: add csi operator creation step for external mode
 2025-11-05 21:22:55 +05:30
Michael Adam 19b5efd542 ci: add upterm debugging as an alternative to tmate 
This enables interactive debugging of ci checks
with the upterm tool as an alternative to the tmate tool which does not
work entirely anymore.
see https://github.com/rook/rook/issues/16131

addition to tmate, upterm debugging is now enabled via the debug-ci label on
PRs

Signed-off-by: Michael Adam <obnox@samba.org>
 2025-11-05 14:57:34 +01:00
parth-gr 31d410822d doc: add csi operator creation step for external mode 
Rook has started using csi operator by default,
so with every new rook external mode install,
we need to use create the csi operator

closes: https://github.com/rook/rook/issues/16620

Signed-off-by: parth-gr <partharora1010@gmail.com>
 2025-11-05 17:25:17 +05:30
Travis Nielsen b89af41df4 Merge pull request #16655 from jhoblitt/feature/OSDMaxUpdatesInParallel 
osd: add CephCluster.spec.storage.OSDMaxUpdatesInParallel
 2025-11-04 10:36:05 -07:00
Travis Nielsen b79c38bf9b Merge pull request #16670 from AlienAscension/patch-1 
docs: fix typo in 'Advance Options' heading
 2025-11-04 10:32:47 -07:00