to run the integration test there needs
to be a few changes in manifests like using
`deviceFilter` and other related changes.
Signed-off-by: subhamkrai <srai@redhat.com>
as we are planning to move toward Github actions
for integration test. This commit runs ceph
suites using Github action.
Signed-off-by: subhamkrai <srai@redhat.com>
The CRDs need to be installed and updated separately from the
rest of the manifests. Helm charts also do not have a way to update
CRDs, therefore, any updates to the CRD schema must be done separately
from the helm chart. Now the CRDs are created in a new crd.yaml that must
be created along with common.yaml and before creating the operator.
The helm chart still contains the CRDs for initial creation, though
the helm chart will never update or remove them.
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
As a follow up to #6563 which fixed all the typos found in the
repository, to avoid adding more obvious typos.
Signed-off-by: Mateusz Gozdek <mgozdekof@gmail.com>
Found by running the following command:
codespell -S .git,*.png,*.jpg -L \
aks,keyserver,atleast,dne,ser,ist,files\',ba,dum,iam,te -f -H
Signed-off-by: Mateusz Gozdek <mgozdekof@gmail.com>
Add the following scenario:
* simple osd on pvc
* osd on pvc with db device
* osd on pvc with wal device
* encrypted simple osd on pvc
* encrypted osd on pvc with db device
* encrypted osd on pvc with wal device
Signed-off-by: Sébastien Han <seb@redhat.com>
When the Ceph cluster runs on PVC and the OSDs are encrypted we can
store LUKS's Key Encryption Key inside a Key Management System. Today,
Rook only supports HashiCorp Vault: https://www.vaultproject.io/
The CephCluster has now a new "security" field which will plug onto the
KMS. Here is an example:
security:
kms:
tokenSecretName: <name of the secret containing a Vault token, used
to authenticate>
connectionDetails: < a map of strings containing connection
information>
Refer to the ceph-cluster-crd documentation to lear more.
Closes: https://github.com/rook/rook/issues/6105
Signed-off-by: Sébastien Han <seb@redhat.com>
golangci-lint linter gosec showing more errors
than gosec gh. This commit resolve
new errors. And, removing
nosec comments from autogenerated files.
Signed-off-by: subhamkrai <srai@redhat.com>
The CI runs a github action that builds and deploys a Rook cluster and
then execute various tests on the create-external-cluster-resources.py
script.
Signed-off-by: Sébastien Han <seb@redhat.com>
adding linter staticcheck in golangci-lint.
staticcheck - Staticcheck is a go vet on steroids,
applying a ton of static analysis checks
Signed-off-by: subhamkrai <srai@redhat.com>
adding one more linter ineffassign in golangci-lint.
ineffassign - Detects when assignments to existing
variables are not used.
Signed-off-by: subhamkrai <subhamkumarrai03@gmail.com>
add one more linter rule in golangci-lint
and renaming this golangci-lint as we already have `lint`
name taken.
Signed-off-by: subhamkrai <subhamkumarrai03@gmail.com>
The stalebot has not been closing PRs that are stale.
Reducing the timeout from 6 months to 3 months.
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
The commitlint bot is rarely understood and flags to skip the CI are
rarely used by new contributors. This update to the PR template
aims to make these options more discoverable to newer members of
the community
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
Some issues should not be closed by the stale bot, whether because an
issue is taking a long time to design, implement, or if we need an
owner for the issue, but we know we need the feature or fix.
The keepalive label will cause the bot to skip closing stale issues.
This label should be used sparingly
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
The bot should not close issues that are related to reliability.
Rook's reliability is too critical to allow the bot to close
these issues.
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
Issues are already being closed if there is no activity for 90 days.
Pull requests have not been closed automatically. This change will cause
pull requests to be closed after six months of inactivity. If there is
no further activity, the PR will be closed after one more month.
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
This is not a recommended workflow but useful if people click on "Don’t
see your issue here? Open a regular issue."
Signed-off-by: Sébastien Han <seb@redhat.com>
The CI only needs to be run for PRs that have code changes.
PRs that are only documentation, yaml, or other files
that are not built should skip the long and tedious
CI process. This makes the [skip ci] flag more discoverable.
Signed-off-by: travisn <tnielsen@redhat.com>
* when submitting code people must be provide unit tests
* when submitting code for a new functionnality, integration tests must
be added so we can get coverage of that feature in the CI.
Signed-off-by: Sébastien Han <seb@redhat.com>
this commit updates dep to version 0.5, and adds a check during
CI runs that enforces that the vendor dependencies have not changed.
There is a now a makefile target `make vendor.check` that performs
this check. Also removed the requirement that PR run make vendor as
this will be done by CI.
Signed-off-by: Bassam Tabbara <bassam@upbound.io>
We want to have good code documentation in the future, and we would like
to slowly develop better documentation for existing code. As a checklist
item for PRs, add a requirement for godoc-style comments when (1) new
code items are added and (2) when existing items are sufficiently
modified.
Signed-off-by: Blaine Gardner <blaine.gardner@suse.com>
This makes use of GitHub's feature to give a selection on issue creation
this splits the issue types in bug report and feature request.
Signed-off-by: Alexander Trost <galexrt@googlemail.com>
Sébastien Han
subhamkrai
Travis Nielsen
Mateusz Gozdek
Arun Kumar Mohan
subhamkrai
Alan
Steven Rathbauer
Alexander Trost
Bassam Tabbara
Blaine Gardner