Commit Graph
45 Commits
Author SHA1 Message Date
Blaine Gardner e6c4b7e6c3 ci: update go version for govulncheck
Update the version of Go used for govulncheck to get the latest CVE fix
present in Go v1.22.3.

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
(cherry picked from commit f21f3f549c)
2024-05-08 16:25:21 +00:00
subhamkrai 411ebfbf77 ci: update go mod and go version in govulncheck
this commits updates the go version to 1.22.2 in govulncheck ci and
also updates golang.org/x/net to v0.23.0 to fix the ci

Signed-off-by: subhamkrai <srai@redhat.com>
(cherry picked from commit f063e8fe39)
2024-04-04 13:25:29 +00:00
NymanRobin fdacd1e587 ci: remove minor version from setup-go in govulncheck
The patch version was pinned which caused problems
with security patches. Unpin it and always check
for new patch version

Signed-off-by: NymanRobin <nyman.robin@gmail.com>
2024-03-07 12:51:53 +02:00
dependabot[bot] 2fffc69cfa build(deps): bump golangci/golangci-lint-action from 3 to 4
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 3 to 4.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases)
- [Commits](https://github.com/golangci/golangci-lint-action/compare/v3...v4)

---
updated-dependencies:
- dependency-name: golangci/golangci-lint-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-02-12 12:15:45 +00:00
Blaine Gardner c98ce0a56b ci: check for gofmt usage in golangci-lint
This is needed because not all contributors may be using gomft to format
source code, and this could result in inconsistent usage over time.

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
2024-02-01 10:26:46 -07:00
subhamkrai 0c115927e1 build: remove go1.20 support and default to go1.21
Signed-off-by: subhamkrai <srai@redhat.com>
2023-12-19 11:55:03 +05:30
dependabot[bot] a2c63650c5 build(deps): bump actions/setup-go from 4 to 5
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 4 to 5.
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](https://github.com/actions/setup-go/compare/v4...v5)

---
updated-dependencies:
- dependency-name: actions/setup-go
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-12-11 12:07:59 +00:00
subhamkrai ccaffd935f ci: update go version in govulncheck
updating go version from `1.21.4` to `1.21.5`.

Signed-off-by: subhamkrai <srai@redhat.com>
2023-12-08 09:07:22 +05:30
travisn 6f8e42422d core: fix golang linter issues with variables in loops
Loop variables cannot be reliably uses since they will
change with each iteration. Update these loop variable
uses to be safe by indexing the slice rather than
using the loop variable directly.

Also suppress the linter issues for passwords used
in tests.

Signed-off-by: travisn <tnielsen@redhat.com>
2023-12-05 14:14:58 -07:00
subhamkrai a878e52ba7 ci: add go 1.21.4 in govulncheck ci run
In, go 1.20 govulncheck ci is failing due to
some vulnerabilities which affects windows
machine and rook is not used in windows machine.
The solution is to update go version to 1.21.4

Signed-off-by: subhamkrai <srai@redhat.com>
2023-11-09 19:25:30 +05:30
Blaine Gardner f90e069ba9 test: add govulncheck to look for go vulnerabilities
govulncheck is a static code analyzer that scans more deeply than Snyk.
Additionally, because govulncheck checks the code itself, it can rule
out vulnerabilities that are present in dependencies but that are not
used in Rook's code path.

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
2023-10-24 11:47:10 -06:00
Blaine Gardner bf9e5dc1f5 ci: make use of caching in actions/setup-go
The GH action to set up Golang (actions/setup-go) has cache
functionality. For cache hits, this saves ~2 minutes for each run. In
order for the cache to hit, caching must not be disabled, and the code
must be checked out before setting up Golang.

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
2023-10-04 13:41:56 -06:00
dependabot[bot] 14f0a9e772 build(deps): bump actions/checkout from 3 to 4
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/v3...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-09-04 12:33:02 +00:00
subhamkrai e9cc7ed7b9 build: update go version to 1.21 from 1.20
Signed-off-by: subhamkrai <srai@redhat.com>
2023-08-25 12:23:21 +05:30
travisn ee80061c74 ci: update golangci linter to go 1.20
The linter requires updating wait.Poll methods to more recent
given the new dependencies for the controller runtime.

Signed-off-by: travisn <tnielsen@redhat.com>
2023-06-21 17:05:10 -06:00
dependabot[bot] 128e7d72df build(deps): bump actions/setup-go from 3 to 4
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 3 to 4.
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](https://github.com/actions/setup-go/compare/v3...v4)

---
updated-dependencies:
- dependency-name: actions/setup-go
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-03-20 13:02:05 +00:00
parth-gr 8e317ee074 ci: update golangci-lint version as it fails for some k8s version in 1.10
Closes: https://github.com/rook/rook/issues/11896

Signed-off-by: parth-gr <paarora@redhat.com>
2023-03-16 20:59:22 +05:30
parth-gr b81ee215a7 build: update golang version to v1.19
Updated the go mod and ci to use gov1.19 as
minimum and removed support for go1.18

Closes: https://github.com/rook/rook/issues/11681
Signed-off-by: parth-gr <paarora@redhat.com>
2023-02-17 18:39:05 +05:30
dependabot[bot] aa102da4c8 build(deps): bump actions/setup-go from 2 to 3
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 2 to 3.
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](https://github.com/actions/setup-go/compare/v2...v3)

---
updated-dependencies:
- dependency-name: actions/setup-go
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-10-31 12:27:55 +00:00
Travis Nielsen 306b2c3900 Merge pull request #11227 from rook/dependabot/github_actions/actions/checkout-3
build(deps): bump actions/checkout from 2 to 3
2022-10-27 12:58:29 -06:00
dependabot[bot] 482c6bc780 build(deps): bump golangci/golangci-lint-action from 2 to 3
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 2 to 3.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases)
- [Commits](https://github.com/golangci/golangci-lint-action/compare/v2...v3)

---
updated-dependencies:
- dependency-name: golangci/golangci-lint-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-10-27 13:55:05 +00:00
dependabot[bot] 53bbd631e1 build(deps): bump actions/checkout from 2 to 3
Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/v2...v3)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-10-27 13:55:01 +00:00
subhamkrai aec9ac3060 ci: ubuntu 18.04 is deprecated upgrade to ubuntu 22.04
Signed-off-by: subhamkrai <srai@redhat.com>
2022-08-26 15:19:26 +05:30
Travis Nielsen 49ca309622 build: only support go 1.18 with the latest modules
The modules are only compatible with go 1.18.
Remove support for go 1.17.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2022-08-11 12:31:50 -06:00
neilnaveen 2e2eca672a ci: set permissions for github actions
Restrict the GitHub token permissions only to the required ones;
this way, even if the attackers will succeed in compromising your workflow,
they won’t be able to do much.

Included permissions for the action.
https://github.com/ossf/scorecard/blob/main/docs/checks.md#token-permissions

https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#permissions

https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs

Signed-off-by: neilnaveen <42328488+neilnaveen@users.noreply.github.com>
2022-08-04 11:07:00 -06:00
Madhu Rajanna 4a26d389b7 ci: stop inprogress jobs when pr is updated
stop the in progress jobs when a PR is updated

Ref: https://docs.github.com/en/actions/using-workflows/ \
workflow-syntax-for-github-actions# \
example-using-concurrency-to-cancel-any-in-progress-job-or-run

example job is here
https://core.trac.wordpress.org/changeset/50930

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2022-05-30 12:11:48 +05:30
subhamkrai 6de3e3d48d build: update go-ceph version and remove ceph_preview
updating go ceph version to 0.15.0 will no longer require
`ceph_preview` during build. Also if added in VsCode workspace
we can remove that now.

Signed-off-by: subhamkrai <srai@redhat.com>
2022-04-21 11:38:11 +05:30
subhamkrai 81d696652d build: update golang version to v1.17
update golang version to v1.17

Signed-off-by: subhamkrai <srai@redhat.com>
2022-04-19 09:04:29 +05:30
subhamkrai 0cdb32a403 ci: update golangci linter version
update golangci linter version

Signed-off-by: subhamkrai <srai@redhat.com>
2022-04-04 19:37:20 +05:30
Sébastien Han f2cb792e9f rgw: add support for updating user caps
User's capabilities can now be updated from the admin ops API.

Closes: https://github.com/rook/rook/issues/8683
Signed-off-by: Sébastien Han <seb@redhat.com>
2021-10-28 14:17:13 +02:00
Travis Nielsen 87596c6f8e build: detect git version instead of setting to 0
The build version should be detected with the git describe
command, but if the VERSION var is already set, it will be
used instead of being detected from git. During the official
builds or even local builds, we just want to let the makefile
detect the git version.

The full git history is added to enable proper detection of the
version. Without the full history only a hash is returned for
the version, which then results in an invalid semantic version
error for the helm chart.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2021-07-28 07:25:10 -06:00
Andy Bursavich 11f0add706 build: update golangci-lint version and nolint comment format
Signed-off-by: Andy Bursavich <abursavich@gmail.com>
2021-06-21 08:50:04 -07:00
Sébastien Han 6a33395c4a ci: separate PR and release/master branch push into different files
We now have a single file with all the integration test that will run
when code is pushed to a release branch or merged in master.

Also, we have separate files with integration tests that run on pull
requests against master or a release branch.

Signed-off-by: Sébastien Han <seb@redhat.com>
2021-04-19 12:43:31 +02:00
Sébastien Han 89f4c4a81a ci: always run golangci-lint
This action wasn't not running on release branch. Now enabling it.

Signed-off-by: Sébastien Han <seb@redhat.com>
2021-04-12 17:37:59 +02:00
Satoru Takeuchi 4766954dfc ceph: suppress golanglint-ci complaints
Suppress the following complaints.

```
$ golangci-lint run -E gosec
pkg/operator/test/client.go:244:13: G404: Use of weak random number generator (math/rand instead of crypto/rand) (gosec)
        randIdx := rand.Intn(len(nodes.Items))
                   ^
tests/framework/installer/ceph_manifests_v1.5.go:44:19: G107: Potential HTTP request made with variable url (gosec)
        response, err := http.Get(url)
                         ^
pkg/daemon/ceph/client/pool.go:182:6: ineffectual assignment to stats (ineffassign)
        var stats = new(PoolStatistics)
            ^
pkg/operator/k8sutil/pod_test.go:34:2: ineffectual assignment to container (ineffassign)
        container, err := GetMatchingContainer([]v1.Container{}, expectedName)
        ^
```

Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
2021-03-12 15:34:27 +00:00
Sébastien Han 0adf7624d9 ceph: stick with ubuntu-18.04 on the CI
Github just switched to use Ubuntu 20.04 for the ubuntu-latest and it is
breaking some of our scenarios so far. Especially scenario creating
partitions.

Closes: https://github.com/rook/rook/issues/7327
Signed-off-by: Sébastien Han <seb@redhat.com>
2021-03-01 18:20:42 +01:00
Sébastien Han 2d1cf09d8d ci: only run the canary test on code changes
If no Go files changed we do not run the CI.

Signed-off-by: Sébastien Han <seb@redhat.com>
2020-11-16 18:05:07 +01:00
subhamkrai a3cb168020 ci: increase golangci linter timeout
golangci linter sometimes failing due to
the timeout. So, increasing it to 6m from 4m.

Signed-off-by: subhamkrai <srai@redhat.com>
2020-10-21 22:38:03 +05:30
subhamkrai cb0ca66a6b ci: enable gosec linter in golangci-lint
golangci-lint linter gosec showing more errors
than gosec gh. This commit resolve
new errors. And, removing
nosec comments from autogenerated files.

Signed-off-by: subhamkrai <srai@redhat.com>
2020-10-19 11:50:06 +05:30
subhamkrai 679230f285 ci: enable all golangci-lint linter
this commit enable defalut error check
for golangci-lint linter.

Signed-off-by: subhamkrai <srai@redhat.com>
2020-09-30 22:26:02 +05:30
subhamkrai ff0fb897ff ci: update golangci-lint with staticcheck
adding linter staticcheck in golangci-lint.
staticcheck - Staticcheck is a go vet on steroids,
applying a ton of static analysis checks

Signed-off-by: subhamkrai <srai@redhat.com>
2020-09-24 15:12:49 +05:30
subhamkrai af7ba588c6 ci: update golangci-lint with ineffassign linter
adding one more linter ineffassign in golangci-lint.
ineffassign - Detects when assignments to existing
variables are not used.

Signed-off-by: subhamkrai <subhamkumarrai03@gmail.com>
2020-09-21 14:35:00 +05:30
subhamkrai 54fe97c988 ci: add deadcode linter in golangci-lint
this commit will add one more linter deadcode
in golangci-lint tool.

Signed-off-by: subhamkrai <subhamkumarrai03@gmail.com>
2020-09-18 16:56:37 +05:30
subhamkrai 1c438021ce ci: update golangci-lint yaml
add one more linter rule in golangci-lint
and renaming this golangci-lint as we already have `lint`
name taken.

Signed-off-by: subhamkrai <subhamkumarrai03@gmail.com>
2020-09-17 23:00:08 +05:30
subhamkrai 7d03e84866 ci: adding golangci-lint tool in ci
this commit will add golangci-lint tool
in ci and currently, only gosimple linter
is enabled.

Signed-off-by: subhamkrai <subhamkumarrai03@gmail.com>
2020-09-17 15:20:49 +05:30