Commit Graph
11197 Commits
Author SHA1 Message Date
Alexander Trost be16bc455f docs: operator use rbac.authorization.k8s.io/v1
This replaces any uses of `rbac.authorization.k8s.io/v1beta1` with
`rbac.authorization.k8s.io/v1` affecting RBAC objects like ClusterRole
and ClusterRoleBindings, etc. to make it consistent.
This is done as some RBAC objects used the `v1beta1` and others already
using `v1`.

Signed-off-by: Alexander Trost <galexrt@googlemail.com>
2020-08-20 12:08:32 +02:00
Daniel Schneider d4d53b610e docs: fix RGW AWS credential export commands
Fix ceph rgw export commands to access values in object yaml definitions through jsonpath instead of grep. This solves issues that arise, should there be more than one lines with the grep value in the yaml file which would concatenate arbitrary values.

Closes: https://github.com/rook/rook/issues/6087
Signed-off-by: Daniel Schneider <daniel.schneider@eramux.com>
2020-08-20 11:15:23 +02:00
subhamkrai 9247b65f44 ceph: vulnerability in package golang.org/x/text
package golang.org/x/text v0.3.3 fixes the Vulnerability
in golang.org/x/text which could lead to infinite loop when
providing single byte to utf16 decoder.

Signed-off-by: subhamkrai <subhamkumarrai03@gmail.com>
2020-08-20 13:34:33 +05:30
Sébastien Han 9ed885c57f Merge pull request #6121 from thotz/podmandocumentation
docs: mention about podman in development workflow
2020-08-20 09:39:20 +02:00
Sébastien Han a1a1a989a5 Merge pull request #6122 from thotz/crcdoclink
docs: provide link for crc documentation
2020-08-20 09:38:38 +02:00
Sébastien Han bfacd2a1c9 Merge pull request #6119 from binoue/cleanup-smoke-test
ci: clean up after SmokeTest
2020-08-20 09:27:15 +02:00
binoue aa2af5a24b ci: clean up after SmokeTest
Currently, SmokeTest is not cleaned up after the test.
As this can affect other following tests, set rookCephCleanup as true.

Signed-off-by: binoue <banji-inoue@cybozu.co.jp>
Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
2020-08-20 03:53:03 +00:00
Sébastien Han ee893eda5e Merge pull request #6126 from leseb/encryption-expansion-pvc
ceph: add expansion support for encrypted osd on pvc
2020-08-19 21:40:46 +02:00
Travis Nielsen cc10653033 Merge pull request #6116 from travisn/minimum-resource-warn
ceph: Continue with memory limits below min settings
2020-08-19 11:56:07 -06:00
Jiffin Tony Thottan e17c1a6151 docs: mention about podman in development workflow
Rook supports building images with podman as well, mention that in documentation
Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
2020-08-19 22:51:56 +05:30
Jiffin Tony Thottan 0815899078 docs: provide link for crc documentation
CRC aka code ready containers provide openshift cluster 4.x in a single host machine
Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
2020-08-19 22:49:32 +05:30
Travis Nielsen ce92249725 ceph: continue with memory limits below min settings
The operator will now allow the resource limits to be applied below the
recommended minimums. In small clusters, even the recommended minimums
may not be necessary. A warning is still printed to the operator log,
but we allow the configuration to continue.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2020-08-19 11:07:16 -06:00
Sébastien Han 321e8e0b5a ceph: add more pvc dep unit tests
Added more unit tests scenario for osd on pvc such as:

* block/db/wal
* block encryption
* block/db encryption
* block/db/wal encryption

Signed-off-by: Sébastien Han <seb@redhat.com>
2020-08-19 18:45:31 +02:00
Travis Nielsen 0bcf040bd7 Merge pull request #6123 from subhamkrai/sync-manifests
ceph: applying latest changes to object-prefixed manifests
2020-08-19 10:11:41 -06:00
Sébastien Han aa5362d48d Merge pull request #6120 from leseb/fix-5996
ceph: do not use realPath for osd on pvc
2020-08-19 17:33:46 +02:00
Travis Nielsen 1111f7b3ca Merge pull request #6079 from cybozu-go/ceph-add-a-note-of-OSD-on-LV-backed-PVC
docs: add a note of OSD on LV-backed PVC's known problem
2020-08-19 09:14:34 -06:00
Sébastien Han 803462ceca ceph: add encrypted block status container
This init container displays the status of the encrypted pvc. This can
be really useful for debugging purpose.

Signed-off-by: Sébastien Han <seb@redhat.com>
2020-08-19 17:13:46 +02:00
Sébastien Han cb81ee7d1d ceph: add pvc expansion support for encrypted osds
We now support the expansion of encrypted osds. We added a new init
container to run "cryptsetup resize".

Signed-off-by: Sébastien Han <seb@redhat.com>
2020-08-19 17:13:46 +02:00
Sébastien Han 3f42db5ce0 ceph: support osd deployment update on encrypted pvc
If the deployment spec was updated or restarted, the "encryption-open"
init container would fail to open the device since it was already
opened on the node.
Because they are no reliable post stop hook on Kubernetes, the trick is
to use a small bash init container.

Signed-off-by: Sébastien Han <seb@redhat.com>
2020-08-19 17:13:25 +02:00
Sébastien Han d5b1e89ce2 Merge pull request #6118 from travisn/osd-prepare-resources
ceph: Set the OSD prepare resources
2020-08-19 15:38:06 +02:00
Sébastien Han 944d8cb209 ceph: do not use realPath for osd on pvc
It is fine to use /mnt/set1-data-0-k47mc, it looks like I thought there
was an issue with udev but there is none...

Closes: https://github.com/rook/rook/issues/5996
Signed-off-by: Sébastien Han <seb@redhat.com>
2020-08-19 14:39:55 +02:00
Sébastien Han 6d6449b5af Merge pull request #6103 from travisn/osd-prepare-placement
ceph: Separate placement for osd prepare jobs from osd daemons
2020-08-19 14:04:03 +02:00
subhamkrai 99cc3692fe ceph: applying latest changes to object-prefixed manifests
the commit apply latest changes or sync the
object-prefixed manifests with object.yaml
and keeping object-test.yaml simple and
without lastest change.

Signed-off-by: subhamkrai <subhamkumarrai03@gmail.com>
2020-08-19 15:04:32 +05:30
Travis Nielsen 18d39d909e ceph: set the osd prepare resources
The osd prepare resources were only being set on the main container
while the init containers either did not have resources set, or were
inheriting the resource settings from the device set resources for osds.
Now the osd prepare resources will be consistently set based on the
prepareosd resources in the main section of the cluster CR.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2020-08-18 22:58:26 -06:00
Travis Nielsen 26f59c0382 ceph: remove redundant check for encrypted osds
This is simply a code simplification to remove an extra check for
whether the OSDs are encrypted. There is no change in functionality.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2020-08-18 22:50:32 -06:00
Yuji Ito ce1951469d ceph: reflect review
Signed-off-by: Yuji Ito <llamerada.jp@gmail.com>
2020-08-19 02:55:37 +00:00
Travis Nielsen 0ffa0348b5 ceph: separate placement for osd prepare jobs from osd daemons
The osd prepare jobs and osd daemons may have different placement
requirements. In particular, the topology spread constraints
or pod anti-affinity should only work on either the prepare job or
osd daemon, but does not work effectively on both types at the same
time. Therefore, we split out the osd prepare placement to be separate
from the osd daemon placement. If the osd prepare placement is not set
the operator will fall back to the osd daemon placement for
backward compatibility.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2020-08-18 15:24:04 -06:00
Travis Nielsen cb3db54187 Merge pull request #6072 from alimaredia/object-multisite-testing
ceph: object realm controller unit tests
2020-08-18 14:58:38 -06:00
Ali Maredia 5b339cf791 ceph: object realm controller unit tests
Add unit tests for the ceph object realm
controller.

Signed-off-by: Ali Maredia <amaredia@redhat.com>
2020-08-18 15:15:14 -04:00
Travis Nielsen b4db31033b Merge pull request #6107 from leseb/fix-6078
ceph: check rootfs for lvm too
2020-08-18 11:52:36 -06:00
Sébastien Han fa69a4b150 Merge pull request #6104 from Madhu-1/fix-csi-resources
ceph: pass csi resources as string in helm
2020-08-18 17:20:00 +02:00
Sébastien Han 713d3ecace ceph: check rootfs for lvm too
On rancher OS, the lvm binary is in a different location and cannot be
accessed via the root namespace. So we now also check directly from
/rootfs. When using nsenter, itbreaks out of container's mount
namespace and executes an lvm command.

Closes: https://github.com/rook/rook/issues/6078
Signed-off-by: Sébastien Han <seb@redhat.com>
2020-08-18 17:04:56 +02:00
Sébastien Han 4fbe07d55f Merge pull request #6102 from binoue/fix-inconsistent-log-message
ci: fix inconsistent error log
2020-08-18 15:14:11 +02:00
Madhu Rajanna 244b94dbc6 ceph: pass csi resources as string in helm
Currently the CSI resources are getting passed as
the map instead of string, due to this the yaml
unmarshal is getting failed. This commit adds
the missing '|' to pass the resources as the
string instead of map

fixes: #5501

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-18 18:41:48 +05:30
Sébastien Han adab0e07e5 Merge pull request #6059 from leseb/lvm-list
ceph: improve callCephVolume() for list and prepare
2020-08-18 13:30:49 +02:00
binoue 5c897e4a21 ceph: fix error log
"Giving up waiting for Rook Toolbox to be ready" error always
logged even if Rook Toolbox is ready.
This commit fix the problem.

Signed-off-by: binoue <banji-inoue@cybozu.co.jp>
2020-08-18 08:04:17 +09:00
Alexander Trost f819404113 Merge pull request #6099 from cloudical-io/fix_13_upgrade_apply_file
ceph: fix v1.3 to v1.4 upgrade apply file syntax
2020-08-17 22:51:43 +02:00
Alexander Trost d16a778cc5 ceph: fix v1.3 to v1.4 upgrade apply file syntax
There is a missing YAML document / object separator in the apply file.
This PR adds it so it can be applied without errors.

Signed-off-by: Alexander Trost <galexrt@googlemail.com>
2020-08-17 22:46:05 +02:00
Alexander Trost 435b99f7ee Merge pull request #6086 from cloudical-io/fix_5491 2020-08-17 22:15:24 +02:00
Travis Nielsen 98db380237 Merge pull request #6062 from leseb/wal-encryption
ceph: add support for wal encrypted device on pvc
2020-08-17 14:07:40 -06:00
Alexander Trost 2288ec90ed docs: fix helm command usage
This fixes the helm commands to be compatible with Helm v3.x and adds an
example / notes for Helm v2.x users.

Resolves #5491

Signed-off-by: Alexander Trost <galexrt@googlemail.com>
2020-08-17 22:04:26 +02:00
Alexander Trost 788709f67a Merge pull request #6082 from cloudical-io/additional_user_labels
core: added labels to rook v1
2020-08-17 18:18:42 +02:00
Sébastien Han 45b8a0c88c Merge pull request #6035 from guni1192/ci-fix-remove-cluster-role-bindings
ci: skip the creation of already existing clusterrolebinding
2020-08-17 17:52:38 +02:00
Sébastien Han b4208f4a55 Merge pull request #6090 from leseb/fix-rgw-healthcheck
ceph: fix object store healthcheck yaml
2020-08-17 17:32:15 +02:00
Sébastien Han a5982b749f ceph: fix object store yaml example
The healthcheck for the bucket is called `bucket`.

Signed-off-by: Sébastien Han <seb@redhat.com>
2020-08-17 17:24:26 +02:00
Sébastien Han 80ff2bb0be Merge pull request #6048 from aruniiird/external-script-optional-json-output
Making RBD provisioner, Ceph provisioner and Ceph node optional
2020-08-17 17:19:11 +02:00
Arun Kumar Mohan a5b4020d80 ceph: making rbd / cephs provisioner and nodes optional
Some more optional items in json output.
RBD Provisioner, CSI CephFS node and provisioner are now optional and
will only be populated if they are available.

Signed-off-by: Arun Kumar Mohan <amohan@redhat.com>
2020-08-17 19:32:26 +05:30
Arun Kumar Mohan 940118af82 ceph: a minor refactoring of external cluster resources script
Signed-off-by: Arun Kumar Mohan <amohan@redhat.com>
2020-08-17 18:57:00 +05:30
Sébastien Han dbac1c11d0 ceph: improve callCephVolume() for list and prepare
callCephVolume() was using our exec interface with CombinedOutput which
means return both stdout and stderr. This is fine when preparing OSDs
since we read back the stdout and also want any errors if any (stderr).
However when listing OSD we only want the output since ceph-volume tends
to mix stdout and stderr in the output and does not always silence the
warning types/harmless errors. If the listing has a problem we report it
by printing the ceph-volume log file.

Signed-off-by: Sébastien Han <seb@redhat.com>
2020-08-17 12:43:43 +02:00
Sébastien Han f59aecb36b Merge pull request #6083 from cloudical-io/rbdmirror_doc
docs: added rbd mirror crd documentation
2020-08-17 12:12:38 +02:00