Commit Graph
11197 Commits
Author SHA1 Message Date
Sébastien Han af60060704 Merge pull request #3626 from jmolmo/issue-3603
Set "ssl_server_port" dashboard setting if it is present in ceph dashboard config
2019-09-12 09:52:44 +02:00
Deng Zhou e679b2742c replace hard code namespace with release namespace
Signed-off-by: Deng Zhou <deng.zhou@petuum.com>
2019-09-11 13:23:16 -07:00
Sébastien Han ff73043b75 Merge pull request #3790 from umangachapagain/nbd-filter
ignore updates on nbd device
2019-09-11 17:59:15 +02:00
Sébastien Han f6fb706018 Merge pull request #3815 from rohan47/osd_prepare_panic
Set the Command property for the OSD prepare init container blkdevmapper
2019-09-11 16:26:54 +02:00
Blaine Gardner 3397e64b20 Merge pull request #3825 from SUSE/ceph-upgrade-docs-custom-csi-image
ceph upgrade doc: document CSI image changes
2019-09-10 15:21:22 -06:00
Blaine Gardner 0be2e2c027 ceph upgrade doc: document CSI image changes
The configuration for using Rook with CSI images has changed somewhat
since v1.0, and users of Ceph's CSI drivers will need to consider some
additional update steps.

Signed-off-by: Blaine Gardner <blaine.gardner@suse.com>
2019-09-10 11:02:21 -06:00
rohan47 a4639ae541 Changed the OSD DOWN message to debug level
We want the OSD DOWN message to be shown when debug option is set to
true in the rook-ceph operator.

Signed-off-by: rohan47 <rohgupta@redhat.com>
2019-09-10 22:06:48 +05:30
rohan47 fcbce4898c Set the Command property for the OSD prepare init container blkdevmapper
If a Ceph container image is specified which has a entrypoint then the
Init container for osd prepare job blkdevmapper will fail. So set the
Command property.

Signed-off-by: rohan47 <rohgupta@redhat.com>
2019-09-10 22:05:50 +05:30
Kristoffer Grönlund c2b75db41c Doc (Yugabyte DB): Fix hostname in API connection (#3816)
Use the correct hostname when accessing the API.

Resolves: #3816

Signed-off-by: Kristoffer Grönlund <kgronlund@suse.com>
2019-09-10 13:19:58 +02:00
Ashish Ranjan 651efc26b1 Disruption: Wrapped the reconcile logic with a secondary reconcile func
This commit wraps the existing reconcile logic for mdb and machinelabel controller with a secondary reconcile func for better logging as rook's logging mechanism is not compatible with controller-runtime logging interface.

Signed-off-by: Ashish Ranjan <aranjan@redhat.com>
2019-09-10 13:28:55 +05:30
Travis Nielsen ba74cc9361 Merge pull request #3806 from travisn/helm-allow-settings-disable
Helm: Always apply boolean settings
2019-09-10 06:58:44 +03:00
travisn 86968c5064 ceph: boolean settings not applied if set to false and default
THe boolean helm settings were only being applied if their value was true.
If the desired value was false, the value would be skipped in the chart
instead of adding it with the value of false.

Signed-off-by: travisn <tnielsen@redhat.com>
2019-09-09 23:27:35 +03:00
Blaine Gardner c91db82cde Merge pull request #3811 from SUSE/fix-ceph-volume-outputs-to-stderr-now
Ceph: use combined output from ceph-volume
2019-09-09 14:09:20 -06:00
Travis Nielsen 3eb4586827 Merge pull request #3808 from Madhu-1/csi-timeout
Increase sidecar timeout from 60s to 150s
2019-09-09 23:06:46 +03:00
Travis Nielsen 6e4b40b842 Merge pull request #3786 from rohantmp/drainFix
Fix: only schedule node drain canaries on nodes with osds
2019-09-09 22:53:15 +03:00
Travis Nielsen 69c6c20494 Merge pull request #3805 from Madhu-1/fix-3777
Add leases rules to csi roles in helm chart
2019-09-09 20:57:38 +03:00
Blaine Gardner 704786f273 Ceph: use combined output from ceph-volume
ceph-volume now sends status and log output to stderr, which breaks
`ceph-volume lvm prepare` if not other things as well. Use the combined
stdout and stderr output from ceph-volume to fix this.

Signed-off-by: Blaine Gardner <blaine.gardner@suse.com>
2019-09-09 10:29:51 -06:00
Alexander Trost 5c04dc0c9a Merge pull request #3789 from umangachapagain/MonLeaderChangesAlert
Fixed HighMonLeaderChanges Alert
2019-09-09 17:55:18 +02:00
Juan Miguel Olmo Martínez 4700193b1f ceph: dashboard - get right ssl port from ceph settings
Starting with Nautilus 14.2.1 the dashboard SSL port is readed from <<mgr/dashboard/ssl_server_port>> ceph setting.
Previous versions use the port specified in <<mgr/dashboard/server_port>>

Addressed @travisn suggestion about use of <ssl> attribute in conditional.
This suggestion drove me to change the type of the SSl attribute (from *bool to bool) in the DashboardSpec Struct.
This makes code more clean/safe and make sure that the SSL atribute has always a meaningful value.

Now if you want to run the <secure dashboard> you need to set explicitly SSL to true, as is demonstrated in unit tests.

[x] Code generation (make codegen) has been run to update object specifications

Signed-off-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
2019-09-09 11:08:17 +02:00
Umanga Chapagain 332c9993b1 Fixed HighMonLeaderChanges Alert
rounded the value of MonLeaderChange Rate to 2 decimal points (e.g. 2.44)
previously, we had 16 decimal points (e.g. 2.4406779661016946).
This makes the alert notification more sensible and readable.

Signed-off-by: Umanga Chapagain <chapagainumanga@gmail.com>
2019-09-09 10:34:00 +05:30
Madhu Rajanna 1830c68947 Increase sidecar timeout from 60s to 150s
At present, the request timeout of sidecars
are at 60s and this is a request to increase
this time out value to 150s or higher. The
higher timeout value can help to reduce the
load of our backend ceph cluster and also can
avoid throttling issues at sidecars to an extend.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2019-09-09 08:37:14 +05:30
Madhu Rajanna dceaf29a00 Add leases rules to csi roles
update helm chats roles for leases roles

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2019-09-09 08:21:12 +05:30
Blaine Gardner 9bdc301f2b Merge pull request #3800 from SUSE/nfs-operator-line-endings
NFS: Fix operator.yaml line endings
2019-09-06 16:53:58 -06:00
Travis Nielsen 82a2d018a2 Merge pull request #3715 from ashishranjan738/rohan
Adds MDB controller and machineLabel controller required for fencing
2019-09-06 16:51:56 -06:00
Blaine Gardner 9f6cbd382e NFS: Fix operator.yaml line endings
NFS operator.yaml example file had Windows (CRLF) line endings instead
of the Unix (LF) line endings used elsewhere. Fix this.

Signed-off-by: Blaine Gardner <blaine.gardner@suse.com>
2019-09-06 16:43:02 -06:00
Dmitry Yusupov d804989511 Merge pull request #3799 from dyusupov/master
edgefs image version update in examples and docs
2019-09-06 15:38:02 -07:00
travisnandAshish Ranjan 638b591535 ceph: Adds support for MDB controller and machineLabel controller
Add support for MachineDisruptionBudget controller and MachineLabel controller required for fencing
in OpenShift. This will ensure that machines are only fenced and OSDs are only stopped
when Ceph is in a healthy state.

Co-authored-by: Ashish Ranjan <aranjan@redhat.com>
Signed-off-by: travisn <tnielsen@redhat.com>
2019-09-06 16:32:06 -06:00
Blaine Gardner 6eb2238bcb Merge pull request #3745 from SUSE/pg-num-enforce-minimum-default
ceph docs: identify required ceph configs
2019-09-06 15:56:59 -06:00
Dmitry Yusupov 5b1aa7fa21 edgefs image version update in examples and docs
Signed-off-by: Dmitry Yusupov <dmitry.yusupov@nexenta.com>
2019-09-06 14:52:59 -07:00
Blaine Gardner 138b30e5ff ceph upgrade doc: add note about required configs
Make users aware of the newly 'required' configs earlier in the upgrade
doc so they have more context when they arrive at the upgrade step to
consider changing these for their own clusters.

Signed-off-by: Blaine Gardner <blaine.gardner@suse.com>
2019-09-06 15:48:41 -06:00
Travis Nielsen 49c516916e Merge pull request #3781 from rohantmp/topology
Fix topologyAware on PVC-based OSDs
2019-09-06 13:59:22 -06:00
Travis Nielsen fe4874dc77 Merge pull request #3769 from leseb/mgr-modules
Ceph: Ability to enable pg_autoscaler mgr module via CRD
2019-09-06 13:34:05 -06:00
Travis Nielsen 18c6f8ae37 Merge pull request #3788 from umangachapagain/activeMDS
updating additionalPrinterColumns for CephFS
2019-09-06 13:00:18 -06:00
Travis Nielsen c2aec9ea41 Merge pull request #3780 from Madhu-1/csi-v1.2.0
Use v1.2.0 ceph-csi version
2019-09-06 12:58:27 -06:00
Rohan CJ f8b7537830 Fix topologyAware on PVC-based OSDs
Signed-off-by: Rohan CJ <rohantmp@gmail.com>
2019-09-06 23:17:01 +05:30
travisnandSébastien Han c30cc697c7 ceph: ability to enable mgr module via CRD
We can now enable via the cluster CR any manager module with a
setting under the new mgr element

mgr:
  modules:
  - name: pg_autoscaler
    enabled: true

Co-authored-by: Sébastien Han <seb@redhat.com>
Co-authored-by: travisn <tnielsen@redhat.com>
Signed-off-by: travisn <tnielsen@redhat.com>
2019-09-06 11:32:51 -06:00
Travis Nielsen 5bcfb7205f Merge pull request #3787 from Madhu-1/make-plugin-configurable
configure cephfs  and rbd servers
2019-09-06 11:05:10 -06:00
Blaine Gardner cb3107a303 Merge pull request #3775 from SUSE/lower-builtin-osd-mem-requests
Ceph osd: lower OSD pod minimum mem to 2Gb
2019-09-06 10:50:12 -06:00
Travis Nielsen 7781a443e3 Merge pull request #3797 from travisn/rename-build-fix
Fix build break from bad merge with method rename
2019-09-06 10:36:26 -06:00
travisn 8d89724e80 fix build break from bad merge with method rename
Signed-off-by: travisn <tnielsen@redhat.com>
2019-09-06 10:15:23 -06:00
Alexander Trost 10f17bc1e0 Merge pull request #3791 from ashishranjan738/osdpanic
fix(osd prepare): osd prepare job getting into panic state
2019-09-06 17:38:13 +02:00
Dmitry Yusupov 91ed971b58 Merge pull request #3785 from dyusupov/master
support for mdpsize
2019-09-06 08:33:12 -07:00
Travis Nielsen 585d7a963d Merge pull request #3759 from krig/typo-1
Tests: Fix typo, defintion -> definition
2019-09-06 08:43:38 -06:00
Blaine Gardner 3c637a8e60 Merge pull request #3784 from travisn/helm-bucket-rbac
Add the rbac to the helm chart for bucket provisioning
2019-09-06 08:29:56 -06:00
Travis Nielsen cb5143555d Merge pull request #3779 from sp98/fix-osd-failure-on-pvc
fix random OSD daemon pod failures when running OSD on PVC
2019-09-06 06:59:57 -06:00
Ashish Ranjan f16c8dc060 fix(osd prepare): osd prepare job getting into panic state
Osd pods getting into panic state due to index out of range error.

logs of osd prepare job:

```
[aranjan@localhost:~]$ oc logs -f rook-ceph-osd-prepare-set1-0-data-6f2nh-zh4zl
2019-09-06 07:48:11.448085 I | cephcmd: desired devices to configure osds: [{Name:/mnt/set1-0-data-6f2nh OSDsPerDevice:1 MetadataDevice: DatabaseSizeMB:0 DeviceClass: IsFilter:false}]
2019-09-06 07:48:11.449841 I | rookcmd: starting Rook v1.0.0-623.gc18d575c.dirty with arguments '/rook/rook ceph osd provision'
2019-09-06 07:48:11.449866 I | rookcmd: flag values: --cluster-id=308f232a-d07a-11e9-96ba-0adfe2bb9bfc, --data-device-filter=, --data-devices=/mnt/set1-0-data-6f2nh, --data-directories=, --encrypted-device=false, --force-format=false, --
help=false, --location=, --log-flush-frequency=5s, --log-level=INFO, --metadata-device=, --node-name=set1-0-data-6f2nh, --operator-image=, --osd-database-size=0, --osd-journal-size=5120, --osd-store=, --osd-wal-size=576, --osds-per-devic
e=1, --pvc-backed-osd=true, --service-account=
2019-09-06 07:48:11.449875 I | op-mon: parsing mon endpoints: a=172.30.150.154:6789
2019-09-06 07:48:11.470058 I | cephconfig: writing config file /var/lib/rook/rook-ceph/rook-ceph.config
2019-09-06 07:48:11.470797 I | cephconfig: generated admin config in /var/lib/rook/rook-ceph
2019-09-06 07:48:11.470989 I | cephosd: discovering hardware
2019-09-06 07:48:11.471030 I | exec: Running command: lsblk /mnt/set1-0-data-6f2nh --bytes --nodeps --pairs --output SIZE,ROTA,RO,TYPE,PKNAME
2019-09-06 07:48:11.473887 I | exec: Running command: sgdisk --print /mnt/set1-0-data-6f2nh
2019-09-06 07:48:11.476048 I | cephosd: creating and starting the osds
2019-09-06 07:48:11.476070 I | exec: Running command: lsblk /mnt/set1-0-data-6f2nh --bytes --pairs --output NAME,SIZE,TYPE,PKNAME
2019-09-06 07:48:11.478030 I | sys: Output: NAME="xvdbg" SIZE="10737418240" TYPE="disk" PKNAME=""
2019-09-06 07:48:11.478056 I | cephosd: /mnt/set1-0-data-6f2nh found in the desired devices
2019-09-06 07:48:11.488231 I | cephosd: configuring osd devices: {"Entries":{"/mnt/set1-0-data-6f2nh":{"Data":-1,"Metadata":null,"Config":{"Name":"/mnt/set1-0-data-6f2nh","OSDsPerDevice":1,"MetadataDevice":"","DatabaseSizeMB":0,"DeviceCl
ass":"","IsFilter":false},"LegacyPartitionsFound":false}}}
2019-09-06 07:48:11.492191 I | cephosd: device /mnt/set1-0-data-6f2nh to be configured by ceph-volume
2019-09-06 07:48:11.492213 I | cephosd: 0/0 pre-ceph-volume osd devices succeeded on this node
2019-09-06 07:48:11.492399 I | exec: Running command: ceph auth get-or-create-key client.bootstrap-osd mon allow profile bootstrap-osd --connect-timeout=15 --cluster=rook-ceph --conf=/var/lib/rook/rook-ceph/rook-ceph.config --keyring=/va
r/lib/rook/rook-ceph/client.admin.keyring --format json --out-file /tmp/973674470
2019-09-06 07:48:12.020858 I | cephosd: Successfully updated lvm config file
2019-09-06 07:48:12.020894 I | cephosd: configuring new device /mnt/set1-0-data-6f2nh
2019-09-06 07:48:12.020908 I | exec: Running command: stdbuf -oL ceph-volume lvm prepare --data /mnt/set1-0-data-6f2nh
2019-09-06 07:48:55.172366 I | cephosd:
panic: runtime error: index out of range

goroutine 1 [running]:
github.com/rook/rook/pkg/daemon/ceph/osd.getLVPath(0x0, 0x0, 0x1e3c60d, 0x2)
        /home/aranjan/Project/go/src/github.com/rook/rook/pkg/daemon/ceph/osd/volume.go:128 +0x2fd
github.com/rook/rook/pkg/daemon/ceph/osd.(*OsdAgent).initializeBlockPVC(0xc000829c30, 0xc00072e1e0, 0xc000736e70, 0x1e4927d, 0xd, 0x0, 0x0)
        /home/aranjan/Project/go/src/github.com/rook/rook/pkg/daemon/ceph/osd/volume.go:108 +0x50b
github.com/rook/rook/pkg/daemon/ceph/osd.(*OsdAgent).configureCVDevices(0xc000829c30, 0xc00072e1e0, 0xc000736e70, 0x38, 0xc000829310, 0x2, 0x2, 0x0)
        /home/aranjan/Project/go/src/github.com/rook/rook/pkg/daemon/ceph/osd/volume.go:70 +0x33a
github.com/rook/rook/pkg/daemon/ceph/osd.(*OsdAgent).configureDevices(0xc000829c30, 0xc00072e1e0, 0xc0000bc370, 0x1c, 0xc0008296e8, 0x1, 0x1, 0xd)
        /home/aranjan/Project/go/src/github.com/rook/rook/pkg/daemon/ceph/osd/agent.go:213 +0x97d
github.com/rook/rook/pkg/daemon/ceph/osd.Provision(0xc00072e1e0, 0xc000829c30, 0xc0000560d0, 0x24)
        /home/aranjan/Project/go/src/github.com/rook/rook/pkg/daemon/ceph/osd/daemon.go:166 +0xeb2
github.com/rook/rook/cmd/rook/ceph.prepareOSD(0x359be60, 0x35cd220, 0x0, 0x0, 0x0, 0x0)
        /home/aranjan/Project/go/src/github.com/rook/rook/cmd/rook/ceph/osd.go:252 +0x838
github.com/rook/rook/vendor/github.com/spf13/cobra.(*Command).execute(0x359be60, 0x35cd220, 0x0, 0x0, 0x359be60, 0x35cd220)
        /home/aranjan/Project/go/src/github.com/rook/rook/vendor/github.com/spf13/cobra/command.go:762 +0x465
github.com/rook/rook/vendor/github.com/spf13/cobra.(*Command).ExecuteC(0x359e200, 0xc0006eff30, 0xb, 0xb)
        /home/aranjan/Project/go/src/github.com/rook/rook/vendor/github.com/spf13/cobra/command.go:852 +0x2ec
github.com/rook/rook/vendor/github.com/spf13/cobra.(*Command).Execute(...)
        /home/aranjan/Project/go/src/github.com/rook/rook/vendor/github.com/spf13/cobra/command.go:800
main.main()
        /home/aranjan/Project/go/src/github.com/rook/rook/cmd/rook/main.go:35 +0x12e
```

Signed-off-by: Ashish Ranjan <aranjan@redhat.com>
2019-09-06 13:40:22 +05:30
Umanga Chapagain 3f2c9f4e79 ignore updates on nbd device
- adds regex to ignore updates on nbd device
  similar to 'rbd' and 'dm'

Signed-off-by: Umanga Chapagain <chapagainumanga@gmail.com>
2019-09-06 12:00:51 +05:30
Umanga Chapagain 0caedcf4d6 updating additionalPrinterColumns for CephFS
- Renamed MDSCOUNT to ActiveMDS & updated Description
  This was to remove the confusion about what the count
  is actually about (Active or Active+Standby).

Signed-off-by: Umanga Chapagain <chapagainumanga@gmail.com>
2019-09-06 11:38:33 +05:30
Madhu Rajanna f776671e3d configure cephfs and rbd servers
https://github.com/ceph/ceph-csi/pull/550 made
the servers configurable to avoid noise
on the GRPC metrics and also to avoid
unnecessary server starting

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2019-09-06 09:48:29 +05:30
Rohan CJ 7d3f313cab clusterdisruption: Bypass crush location cache if active failureDomain is not populated
Signed-off-by: Rohan CJ <rohantmp@gmail.com>
2019-09-06 09:43:48 +05:30