Commit Graph
11197 Commits
Author SHA1 Message Date
Mahesh Shetty 518537113b operator: add tolerations for rook-ceph operator deployment
This addresses #12660. As discussed in the issue when zone failure
happens and if the operator running in that zone, then it takes the
default toleration of 300 seconds. We want to override this default
toleration seconds to 5 seconds so that operator gets redeployed
immediately

Signed-off-by: Mahesh Shetty <mashetty@redhat.com>
2023-10-05 15:52:47 +05:30
Blaine Gardner 04c9f98954 Merge pull request #12968 from BlaineEXE/multus-validation-allow-node-types
multus: allow node profiles in validation test
2023-10-04 15:42:51 -06:00
Blaine Gardner 0c721e05d5 multus: allow node profiles in validation test
Add the ability to specify node profiles in the multus validation test.

This addresses a few points of early feedback on the validation tool.
Statements below critique the tool's behavior before this patch.
1. The tool assumes all daemons are on public and cluster network, which
   means users who have a significantly smaller cluster net (a
   design choice) cannot run a single test to determine if Rook is
   likely to install correctly.
2. The tool does not have placement options to select only a subset of
   Kubernetes nodes to run validation on.
3. Users of multus seem to have a dedicated pool of storage nodes more
   often than the average Rook install. This makes sense for security-
   and perforance-minded users. The tool cannot run a single test to
   verify storage-only and general-workload nodes at one time.

These points are addressed by allowing users to specify configurations
for different "NodeTypes."

Each NodeType config has options for selecting the number of OSDs as
well as the number of other (non-OSD) Ceph daemons. This limits the
unnecessary exhaustion of cluster network addresses from critique 1.

Each NodeType config has its own placement (critique 2).

Users can define as many NodeTypes as needed to test the network for
their planned CephCluster. Specifically, this allows the tool to test
storage-only nodes and generalized-workload nodes at the same time. An
arbitrary number of NodeTypes are allowed to support even more highly
specialized cluster setups, such as multiple tiers of storage nodes
where some storage-only nodes may run more OSDs than others.

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
2023-10-04 15:26:35 -06:00
Blaine Gardner 7d7d1ba509 Merge pull request #12997 from BlaineEXE/gh-action-golang-cache
ci: make use of caching in actions/setup-go
2023-10-04 15:25:33 -06:00
Blaine Gardner bf9e5dc1f5 ci: make use of caching in actions/setup-go
The GH action to set up Golang (actions/setup-go) has cache
functionality. For cache hits, this saves ~2 minutes for each run. In
order for the cache to hit, caching must not be disabled, and the code
must be checked out before setting up Golang.

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
2023-10-04 13:41:56 -06:00
parth-gr 2dd9b00ca3 mds: improve the mds liveness probe calls
Instead of checking the socket files for mds daemon,
check the mds daemon in fs maps

Closes: https://github.com/rook/rook/issues/12789

Signed-off-by: parth-gr <paarora@redhat.com>
2023-10-05 00:54:06 +05:30
travisn 29fb879675 exporter: change verbose info to debug logs
Several messages were showing up in the operator log
more often than necessary, so let's change them to
debug level.

Signed-off-by: travisn <tnielsen@redhat.com>
2023-10-04 12:45:39 -06:00
Travis Nielsen e21503e21c Merge pull request #12979 from rook/dependabot/go_modules/github-dependencies-d149345ed6
build(deps): bump the github-dependencies group with 1 update
2023-10-04 10:49:49 -06:00
Blaine Gardner e74333ddcd Merge pull request #12633 from thotz/cosi-user-creation
object: create cosi user for each object store
2023-10-04 10:05:36 -06:00
Travis Nielsen cdf0d65c4a Merge pull request #12986 from rkachach/fix_issue_12985
ci: fixing linter error (using variable 'urllib' before assignment)
2023-10-04 09:34:11 -06:00
Redouane Kachach 5f4fae4f3b docs: improving minikube setup documentation
Adding some detailed instructions on how to use the local
built Rook image on minikube cluster

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
2023-10-04 10:51:12 +02:00
Redouane Kachach aa59e3bb86 ci: fixing linter error
Fixing linter error (using variable 'urllib' before assignment)
Adding logic to properly import urlencode depending on python version

closes: https://github.com/rook/rook/issues/12985

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
2023-10-04 09:40:49 +02:00
Satoru Takeuchi eb71fb2b65 Merge pull request #12988 from rkachach/fix_issue_12987
docs: fixing some spelling issues
2023-10-03 21:40:06 +09:00
Redouane Kachach b3dd74ea20 docs: fixing some spelling issues
closes: https://github.com/rook/rook/issues/12987

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
2023-10-03 13:50:17 +02:00
Travis Nielsen 0e2359dc7b Merge pull request #12981 from travisn/filesystem-standby
file: Disable active standby when set to false
2023-10-02 10:10:43 -06:00
travisn f7094d1d13 file: disable active standby when set to false
The activeStandby property of the filesystem CR was not
taking effect when changed from true to false. The standby
was only being enabled when true, but never applied when
changed to false.

Signed-off-by: travisn <tnielsen@redhat.com>
2023-10-02 08:27:14 -06:00
Travis Nielsen 91c0df973c Merge pull request #12970 from travisn/crash-profile
core: use crash profile in crash daemon keyring
2023-10-02 07:25:56 -06:00
dependabot[bot] 8cc05f495e build(deps): bump the github-dependencies group with 1 update
Bumps the github-dependencies group with 1 update: [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go).

- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Commits](https://github.com/aws/aws-sdk-go/compare/v1.45.15...v1.45.19)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-10-02 12:21:17 +00:00
Travis Nielsen a6d82fcec6 Merge pull request #12971 from subhamkrai/revert-clean-disk-workaround
ci: remove workaround for clean disk action
2023-09-29 09:57:17 -06:00
subhamkrai e14f8c7710 ci: remove workaround for clean disk action
The issues are fixed from the clean disk action
repo and we shouldn't require any workaround. Also,
I'm not using git revert to revert the commit is earlier
clean disk action was mentioned in every CI which was
duplicate and now we have placed the action to composite yaml

Signed-off-by: subhamkrai <srai@redhat.com>
2023-09-29 19:17:01 +05:30
travisn fab23d3407 core: use crash profile in crash daemon keyring
The ceph documentation indicates to use the crash profile
instead of specifying rw for the mgr access.

Signed-off-by: travisn <tnielsen@redhat.com>
2023-09-28 11:43:01 -06:00
Travis Nielsen 03b5d49b09 Merge pull request #12959 from subhamkrai/fix-ci
ci: fix github action free disk space
2023-09-28 08:22:41 -06:00
subhamkrai 3267576307 ci: fix github action free disk space
Since `google-cloud-sdk` is renamed with `google-cloud-cli`,
the github action is failing to remove the older name and this
is causing ci issues. Applying changes suggested by community to
manually remove some packages to resolve the issue.

Signed-off-by: subhamkrai <srai@redhat.com>
2023-09-28 18:56:59 +05:30
Travis Nielsen b7eaba318c Merge pull request #12941 from subhamkrai/update-caps
external: update healthchecker caps for rbd command
2023-09-27 22:55:31 -06:00
subhamkrai c78bd1cbc6 external: update healthchecker caps for rbd command
when creating networkFence CR, it requires IP's to block
which we get from running `rbd status ...` command. But,
the client.healthchecker user didn't had the right caps
to run hence it was giving error. Now, adding the required
caps `profile rbd-read-only` to osd so that rbd command can
be executed.

Signed-off-by: subhamkrai <srai@redhat.com>
2023-09-28 08:21:21 +05:30
Travis Nielsen 4bf100b867 Merge pull request #12958 from subhamkrai/replace-krew-with-kubectl
docs: krew is wrong word use kubectl instead
2023-09-27 10:21:08 -06:00
subhamkrai 47c0038136 docs: krew is wrong word use kubectl instead
krew is itself a plugin and it is wrong wording
to use krew plugin intead it should be kubectl
pluging.

Signed-off-by: subhamkrai <srai@redhat.com>
2023-09-27 20:26:14 +05:30
Travis Nielsen 33fb7b801b Merge pull request #12926 from rkachach/fix_issue_12876
mgr: adding support for prometheus endpoint configuration
2023-09-27 08:09:13 -06:00
Travis Nielsen 9691afe8e6 Merge pull request #12956 from rook/snyk-suppress-mpl
ci: Suppress mpl-2.0 warnings in Snyk scan
2023-09-27 07:09:55 -06:00
Redouane Kachach c763935436 mgr: adding support for prometheus endpoint configuration
Using the new configuration parameters prometheusEndpoint and
prometheusEndpointSSLVerify users can configure dashboard to
point to their prometheus instance.

closes: #12876

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
2023-09-27 11:07:18 +02:00
travisn b718622919 ci: suppress mpl license from snyk
The Snyk scan was failing on a warning with the
MPL 2.0 license, which is compatible with Rook.
Now the warnings are suppressed.

Signed-off-by: travisn <tnielsen@redhat.com>
2023-09-26 15:32:36 -06:00
Travis Nielsen ef487ec1c2 Merge pull request #12948 from travisn/canary-kms-test-skip
ci: Skip encryption pvc kms test if needed
2023-09-26 09:58:34 -06:00
Travis Nielsen 33f797b0e3 Merge pull request #12954 from obnoxxx/fix-snyk-policy
ci: fix the  snyk policy to  correctly  ignore the  MPL  license issue.
2023-09-26 09:30:32 -06:00
Michael Adam 4a672c8c35 ci: fix the snyk policy to correctly ignore the MPL license issue
after  https://github.com/rook/rook/pull/12932 has been merged, we
continue to see MPL issues reported by the snyk CI runs:

https://github.com/rook/rook/actions/runs/6302663608/job/17110310884

This updates to the `.snyk` policy file to correctly ignore the MPL license issue
by using the  the proper snyk ID for this issue

According to the doc
https://docs.snyk.io/manage-risk/policies/the-.snyk-file,

the correct ID is `snyk:lic:npm:symbol:MPL-2.0`

The update to the file has been performed with the `snyk ignore`
command to ensure validity of the policy file.

Fixes: #12930

Signed-off-by: Michael Adam <obnox@samba.org>
2023-09-26 16:18:27 +02:00
travisn 0a4ce46727 ci: skip encryption pvc kms test if needed
The skip_ci label was not being respected by the
encryption-pvc-kms-ibm-kp canary test.

Signed-off-by: travisn <tnielsen@redhat.com>
2023-09-25 11:17:23 -06:00
Travis Nielsen 0e2dd1ee87 Merge pull request #12932 from obnoxxx/snyk-fix-12930
suppress snyk warnings for MPL license projects.
2023-09-25 11:16:59 -06:00
d3bc9aafee ci: suppress snyk MPL license warnings
Fixes: #12930

This patch introduces a  .snyk policy file that lets snyk suppress the warnings
 about  the MPL license in projects pulled in as dependencies.

Additinally, this  fixes a typo in the name of the snyk workflow
file

Signed-off-by: Michael Adam <obnox@samba.org>
Co-authored-by: Travis Nielsen <tnielsen@redhat.com>
Co-authored-by: Blaine Gardner <b.blaine.gardner@gmail.com>
2023-09-25 19:10:15 +02:00
Travis Nielsen 4e90214485 Merge pull request #12945 from rook/dependabot/go_modules/k8s-dependencies-5de3848a9f
build(deps): bump the k8s-dependencies group with 4 updates
2023-09-25 09:14:45 -06:00
Travis Nielsen a273312b4a Merge pull request #12946 from rook/dependabot/go_modules/github-dependencies-8ce166961d
build(deps): bump the github-dependencies group with 4 updates
2023-09-25 09:13:44 -06:00
dependabot[bot] 8ca8621ce1 build(deps): bump the github-dependencies group with 4 updates
Bumps the github-dependencies group with 4 updates: [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go), [github.com/gemalto/kmip-go](https://github.com/gemalto/kmip-go), [github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring](https://github.com/prometheus-operator/prometheus-operator) and [github.com/prometheus-operator/prometheus-operator/pkg/client](https://github.com/prometheus-operator/prometheus-operator).


Updates `github.com/aws/aws-sdk-go` from 1.45.5 to 1.45.15
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Commits](https://github.com/aws/aws-sdk-go/compare/v1.45.5...v1.45.15)

Updates `github.com/gemalto/kmip-go` from 0.0.9 to 0.0.10
- [Release notes](https://github.com/gemalto/kmip-go/releases)
- [Commits](https://github.com/gemalto/kmip-go/compare/v0.0.9...v0.0.10)

Updates `github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring` from 0.67.1 to 0.68.0
- [Release notes](https://github.com/prometheus-operator/prometheus-operator/releases)
- [Changelog](https://github.com/prometheus-operator/prometheus-operator/blob/main/CHANGELOG.md)
- [Commits](https://github.com/prometheus-operator/prometheus-operator/compare/v0.67.1...v0.68.0)

Updates `github.com/prometheus-operator/prometheus-operator/pkg/client` from 0.67.1 to 0.68.0
- [Release notes](https://github.com/prometheus-operator/prometheus-operator/releases)
- [Changelog](https://github.com/prometheus-operator/prometheus-operator/blob/main/CHANGELOG.md)
- [Commits](https://github.com/prometheus-operator/prometheus-operator/compare/v0.67.1...v0.68.0)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-dependencies
- dependency-name: github.com/gemalto/kmip-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-dependencies
- dependency-name: github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-dependencies
- dependency-name: github.com/prometheus-operator/prometheus-operator/pkg/client
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-09-25 12:32:32 +00:00
dependabot[bot] 57752949c7 build(deps): bump the k8s-dependencies group with 4 updates
Bumps the k8s-dependencies group with 4 updates: [k8s.io/api](https://github.com/kubernetes/api), [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver), [k8s.io/cli-runtime](https://github.com/kubernetes/cli-runtime) and [k8s.io/cloud-provider](https://github.com/kubernetes/cloud-provider).


Updates `k8s.io/api` from 0.28.1 to 0.28.2
- [Commits](https://github.com/kubernetes/api/compare/v0.28.1...v0.28.2)

Updates `k8s.io/apiextensions-apiserver` from 0.28.1 to 0.28.2
- [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases)
- [Commits](https://github.com/kubernetes/apiextensions-apiserver/compare/v0.28.1...v0.28.2)

Updates `k8s.io/cli-runtime` from 0.28.1 to 0.28.2
- [Commits](https://github.com/kubernetes/cli-runtime/compare/v0.28.1...v0.28.2)

Updates `k8s.io/cloud-provider` from 0.28.1 to 0.28.2
- [Commits](https://github.com/kubernetes/cloud-provider/compare/v0.28.1...v0.28.2)

---
updated-dependencies:
- dependency-name: k8s.io/api
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/apiextensions-apiserver
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/cli-runtime
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/cloud-provider
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-09-25 12:31:44 +00:00
Blaine Gardner f70b687a60 Merge pull request #12921 from travisn/cleanup-guide
docs: Review the teardown guide for updated guidelines
2023-09-22 10:08:53 -06:00
Travis Nielsen cb9ffacce5 Merge pull request #12909 from testwill/pkg-import
core: import packages only once
2023-09-21 15:30:04 -06:00
Satoru Takeuchi a21a859a95 Merge pull request #12924 from cybozu-go/osd-support-encrypted-osd-on-part
osd: support encrypted OSD on partiton
2023-09-21 07:31:37 +09:00
Travis Nielsen b00831c9c5 Merge pull request #12781 from subhamkrai/update-controller-runtime-0.16
build: upgrade controller runtime to 0.16
2023-09-20 13:19:48 -06:00
subhamkrai 2a5ba8e998 build: upgrade controller runtime to 0.16
This commits upgrade the controller runtime version
from v0.15.1 to v0.16.0 and also adding the changes force by
new version.

Signed-off-by: subhamkrai <srai@redhat.com>
2023-09-20 13:02:38 +05:30
Travis Nielsen 0db7108d4f Merge pull request #12329 from jouve/aggrole
helm: clusterrole to add objectbucketclaims to user facing roles
2023-09-19 12:12:28 -06:00
Blaine Gardner 750ae02265 Merge pull request #12922 from BlaineEXE/update-multus-canary-test
test: update multus canary test
2023-09-19 11:28:13 -06:00
Satoru Takeuchi 093125904b osd: support encrypted OSD on partiton
Let's use raw mode for encrypted OSD. This mode supports encrypted
OSD on partition.

Closes: https://github.com/rook/rook/issues/10984

Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
2023-09-19 13:10:18 +00:00
Jiffin Tony Thottan a941b3c33f object: create cosi user for each object store
Create each cosi user for each object store and secret which holds
credentials.

Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
2023-09-19 13:48:58 +05:30