Commit Graph
291 Commits
Author SHA1 Message Date
subhamkrai 6c3f3438a2 ci: add new cni flag in minikube start
adding cni flag in minikube start command
since it is required for multus ci.

Signed-off-by: subhamkrai <srai@redhat.com>
2022-06-03 10:48:19 +05:30
Travis Nielsen 7a938090a1 build: flannel flag to minikube is causing test failures
The minikube node is staying in NotReady state and preventing
the operator from even starting in the canary and other suites
that use the setup-cluster-resources action.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2022-06-02 15:33:57 -06:00
Travis Nielsen f7930455c4 Merge pull request #10343 from Madhu-1/stop-action-when-pr-updated
ci: stop inprogress jobs when pr is updated
2022-05-31 09:16:10 -06:00
subhamkrai f05b6dc307 ci: update doc link in ci
Signed-off-by: subhamkrai <srai@redhat.com>
2022-05-31 16:50:03 +05:30
Madhu Rajanna 4a26d389b7 ci: stop inprogress jobs when pr is updated
stop the in progress jobs when a PR is updated

Ref: https://docs.github.com/en/actions/using-workflows/ \
workflow-syntax-for-github-actions# \
example-using-concurrency-to-cancel-any-in-progress-job-or-run

example job is here
https://core.trac.wordpress.org/changeset/50930

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2022-05-30 12:11:48 +05:30
Satoru Takeuchi 5b3633bfd6 test: add canary integration test for osd with metadata device
"metadataDevice" field in host based cluster is not tested yet.

Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
2022-05-25 01:36:33 +00:00
Alexander Trost c149d871c8 build: install python3 version of pygit2 package for docs publish
Signed-off-by: Alexander Trost <galexrt@googlemail.com>
2022-05-24 19:04:54 +02:00
Alexander Trost 548f723f1b docs: use apt-get to install docs deps and configure git user
Signed-off-by: Alexander Trost <galexrt@googlemail.com>
2022-05-24 18:27:30 +02:00
Travis Nielsen 2404fe1274 build: add setup tools package for docs publish
The setup tools package and libgit2 are required on
ubuntu 18.04 in order to install the mkdocs framework
and publish the docs. After we move to ubuntu 20.04
this should no longer be necessary.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2022-05-23 16:07:55 -06:00
Travis Nielsen 5793582a78 build: correct architecture for the release build
The push image build CI action is mistakenly running on
arm64 instead of amd64, which is failing the build since
it only expects amd64.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2022-05-23 14:08:17 -06:00
Travis Nielsen 03a091e741 ci: fix the doc build generation script
The doc build generation script is failing to install
the needed dependencies for mkddocs.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2022-05-19 14:05:18 -06:00
Alexander Trost f7da56a743 Merge pull request #10265 from koor-tech/docs_restructure_mkdocs 2022-05-18 18:57:38 +02:00
Alexander Trost 74431443e3 docs: use mkdocs and restructure docs
Signed-off-by: Alexander Trost <galexrt@googlemail.com>
2022-05-18 16:06:22 +02:00
Sébastien Han 9b6143baa7 Merge pull request #10006 from parth-gr/rgw-external
rgw: validate rgw endpoint ip
2022-05-13 14:28:10 +02:00
parth-gr 09d52511ad rgw: validate rgw endpoint ip
The ceph-external-cluster-details-exporter.py
generates the json output even with
rgw-endpoint IP from different cluster
Added a check validate_rgw_endpoint which will validate
the above rgw_endpoint Ip by matching the cluster fsid

Signed-off-by: parth-gr <paarora@redhat.com>
2022-05-11 19:52:30 +05:30
parth-gr 17918c0b9e namespace: adding radosnamespace in canary CI
THe radosnamespace CRD is already added by
https://github.com/rook/rook/pull/9733,
Checking the external script with the namespace created by
the CRD

Signed-off-by: parth-gr <paarora@redhat.com>
2022-05-10 12:52:36 +05:30
Satoru Takeuchi a9465efa07 Merge pull request #9931 from cybozu-go/test-add-canary-integration-tests-for-osd-on-device
test: add canary integration tests for osd on device
2022-05-06 05:25:57 +09:00
Satoru Takeuchi 805163e2e2 test: add canary integration tests for osd on device
OSD on PVC is tested in many patterns but OSD on device is not.
It's preferable to add the following patterns for OSD on device.

- An OSD on a raw disk
- Two OSDs on a device

Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
2022-05-05 13:15:18 +00:00
Sébastien Han 6ef491d9fc osd: close the encrypted disk after cleanup is done
Once we are done cleaning up the content of the encrypted osd, let's
close the main LUKS device.
This avoids having dm devices on the system after the cleanup.

Closes: https://github.com/rook/rook/issues/10181
Signed-off-by: Sébastien Han <seb@redhat.com>
2022-05-03 16:47:59 +02:00
Sébastien Han ed3121defd Merge pull request #9925 from leseb/multus-plugin-restart-fix
core: fix csi-cephfsplugin pod restart on non-hostnetworking env
2022-04-27 11:41:59 +02:00
Travis Nielsen d5070dc418 Merge pull request #10125 from subhamkrai/update-go-ceph
build: update go-ceph version and remove ceph_preview
2022-04-26 16:05:49 -06:00
Sébastien Han 73b1347675 core: fix csi-cephfsplugin pod restart on non-hostnetworking env
Implementation of the design proposed in
https://github.com/rook/rook/pull/9903.

Signed-off-by: Sébastien Han <seb@redhat.com>
2022-04-26 17:53:01 +02:00
Travis Nielsen d26b6cf403 build: update min version to k8s 1.17
Support is removed for k8s for various limitations such as
priority classes not working and csi driver feature
incompleteness and missing snapshots. Documentation is updated
with the new min version of k8s 1.17 and also the tests are
updated to run on the min version of 1.17.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2022-04-25 15:32:09 -06:00
subhamkrai 4283973e07 build: add support for go 1.18
adding support for go 1.18 but rook master still
build on 1.17.

Signed-off-by: subhamkrai <srai@redhat.com>
2022-04-21 19:59:46 +05:30
subhamkrai 6de3e3d48d build: update go-ceph version and remove ceph_preview
updating go ceph version to 0.15.0 will no longer require
`ceph_preview` during build. Also if added in VsCode workspace
we can remove that now.

Signed-off-by: subhamkrai <srai@redhat.com>
2022-04-21 11:38:11 +05:30
subhamkrai 81d696652d build: update golang version to v1.17
update golang version to v1.17

Signed-off-by: subhamkrai <srai@redhat.com>
2022-04-19 09:04:29 +05:30
Sébastien Han 2c09bbb91b ci: add multus integration test
This new integration test will deploy a cluster with multus enabled. It
will be comprised of two network interfaces for ceph public and cluster
communications.
For now, it only deploys a Ceph cluster up to the OSDs.

Closes: https://github.com/rook/rook/issues/9784
Signed-off-by: Sébastien Han <seb@redhat.com>
2022-04-12 17:30:47 +02:00
Travis Nielsen 738a300827 build: remove obsolete cross build container
The cross build container is not used anymore since the conversion
to github actions. Now the obsolete scripts and makefiles are
cleaned up to remove some confusing leftovers from the
cross container.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2022-04-07 13:42:18 -06:00
Travis Nielsen 9a06367194 Merge pull request #9981 from subhamkrai/skip-lable
ci: skip few ci when pr labled skip-ci
2022-04-05 07:43:47 -06:00
subhamkrai e4a2a06d2e ci: skip few ci when pr labled skip-ci
skip build, codegen and unit test ci test when
skip-ci labled is marked in PR.

Closes: https://github.com/rook/rook/issues/9972
Signed-off-by: subhamkrai <srai@redhat.com>
2022-04-05 11:35:38 +05:30
Madhu Rajanna b0fc7c9b92 namespace: add new CRD
This introduces a new CRD to add the ability
to create rados namespace for a given
ceph block pool. Typically the name of the pool
is the name of the blockpool created by rook.

Closes: #7035

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2022-04-05 10:10:04 +05:30
subhamkrai 0cdb32a403 ci: update golangci linter version
update golangci linter version

Signed-off-by: subhamkrai <srai@redhat.com>
2022-04-04 19:37:20 +05:30
Travis Nielsen 4f9a72c1db Merge pull request #9894 from yuvalman/resources
helm: enable resource defaults on rook components
2022-03-21 13:58:17 -06:00
Yuval Manor ff7a5c2d2d helm: enable resource defaults on rook components
This PR assign default values to the resources of all Rook and Ceph components

Closes: https://github.com/rook/rook/issues/9858
Signed-off-by: Yuval Manor <yuvalman958@gmail.com>
2022-03-21 21:23:35 +02:00
Travis Nielsen 48be000b4f core: add quincy to the supported versions
Ceph Quincy is now supported as of Rook v1.9.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2022-03-16 14:26:20 -06:00
subhamkrai fd475575ff ci: add pylint in ci
adding pylint in ci.

Closes: https://github.com/rook/rook/issues/9866
Signed-off-by: subhamkrai <srai@redhat.com>
2022-03-14 18:58:20 +05:30
Sébastien Han 1a78fbac67 Merge pull request #9732 from subhamkrai/split-code-and-unit-test
core: split external script unit test and main code in diff file
2022-03-07 15:09:28 +01:00
Travis Nielsen 879bde4416 osd: remove osd with purge instead of destroy
The osd destroy command leaves the osd id in use instead
of fully purging the osd id. If the osd id is not also
removed, it gives the impression that there is still
something that needs to be cleaned up from the old osd.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2022-02-25 12:02:20 -07:00
subhamkrai 3e6aa9e556 core: split external script unit test and main code in diff file
split the external script main code and unit test in different file.

Closes: https://github.com/rook/rook/issues/9588
Signed-off-by: subhamkrai <srai@redhat.com>
2022-02-24 18:23:21 +05:30
Blaine Gardner 7a7d278ab4 test: fix helm suite conflicting artifact
Two test jobs were collecting artifacts to the same artifact name, which
can cause race conditions and failures to upload artifacts.

Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
2022-02-22 13:14:39 -07:00
Blaine Gardner 362eaac98d test: fix upgrade test namespace in daily-nightly CI
PR #9546 missed updating the daily-nightly CI jobs, and logs are no
longer properly collected from the upgrade jobs there.

Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
2022-02-17 15:05:33 -07:00
Sébastien Han a6fc3ae467 Merge pull request #9609 from parth-gr/external-cluster-client-upgrade
csi: modify upgrade flag in external cluster
2022-02-16 11:10:02 +01:00
parth-gr 9b20b475cf csi: modify upgrade flag in external cluster
The upgrade function doesn't seem to be that smart
for now so it can update the new auth caps listed
with the existing one, it only compares the value of
the current cap with the MIN_USER_CAP_PERMISSIONS,

Modified the upgrade flag functionality so we can use
this while upgrading the cluster clients

Closes: https://github.com/rook/rook/issues/9589

Signed-off-by: parth-gr <paarora@redhat.com>
2022-02-16 10:29:34 +05:30
Jiffin Tony Thottan 0b4cdb992b object: fix backend path for transit engine for rgw kms
The backend path was added with additional `transit` to it.
Also added PR test case to check transit engine

Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
2022-02-15 18:49:31 +05:30
parth-gr 4f43f2d93e csi: make create and get process separate for csi users
Currently if we run external-script and user already exit,
it fails to create/run same user again if the caps are upgraded,
so we need to check first if user is already present.
And for upgrading user we can do upgrade after this
PR: https://github.com/rook/rook/pull/9609 will get merged.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2048458

Signed-off-by: parth-gr <paarora@redhat.com>
2022-02-04 20:08:31 +05:30
Sébastien Han d99290ee81 ci: fix daily encryption ibm kms test
The secret is called secrets.IBM_INSTANCE_ID instead of
secrets.IBM_KP_INSTANCE_ID. Now the daily test should pass.

Signed-off-by: Sébastien Han <seb@redhat.com>
2022-01-24 09:25:57 +01:00
Sébastien Han 802a86ccd5 ci: fix encryption test condition
For the "if" to work we need to bring the env in the step with the "env"
keyword. Otherwise, the env is never imported and the condition is
always false.

Signed-off-by: Sébastien Han <seb@redhat.com>
2022-01-21 10:23:21 +01:00
Sébastien Han 7cc6e23a0b osd: rename a few configuration flags
For better consistency with IBM_KP_SERVICE_API_KEY and use
"ibmkeyprotect" as a provider name for more clarity.

Signed-off-by: Sébastien Han <seb@redhat.com>
2022-01-20 16:01:26 +01:00
parth-gr 7e851f15c6 csi: add osd blocklist capabilities to the external cephcluster
The CSI users created by the external script(both for rbd and cephfs)
need the blocklist capability so the CSI pods can execute the
`osd blocklist` commands for metro DR
update the mon caps of csi users with `profile simple-rados-client-with-blocklist`
so they have privileges to run osd blocklist cmds

Closes: https://issues.redhat.com/browse/RHSTOR-2451

Signed-off-by: parth-gr <paarora@redhat.com>
2022-01-18 18:01:01 +05:30
Sébastien Han f014724288 ci: skip encryption test if env is not set
If the secret is not present in the run then let's skip it.

Signed-off-by: Sébastien Han <seb@redhat.com>
2022-01-17 15:50:40 +01:00