Files
Joshua Hoblitt 278453e10c core: remove unused ceph client helper functions
Remove four dead functions from pkg/daemon/ceph/client; none had any
callers anywhere in the repo (verified with deadcode, staticcheck U1000,
and repo-wide grep, tests included):

- auth.go: AuthGetOrCreate
- command.go: ExecuteRBDCommandWithTimeout
- filesystem.go: MarkFilesystemAsDown
- status.go: IsClusterCleanError (IsClusterClean itself remains in use)

No imports become unused by these removals.

Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
2026-06-09 15:06:17 -07:00

271 lines
8.9 KiB
Go

/*
Copyright 2018 The Rook Authors. All rights reserved.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package client
import (
"fmt"
"path"
"strconv"
"time"
"github.com/pkg/errors"
"github.com/rook/rook/pkg/clusterd"
"github.com/rook/rook/pkg/util/exec"
)
// RunAllCephCommandsInToolboxPod - when running the e2e tests, all ceph commands need to be run in the toolbox.
// Everywhere else, the ceph tools are assumed to be in the container where we can shell out.
// This is the name of the pod.
var RunAllCephCommandsInToolboxPod string
const (
// AdminUsername is the name of the admin user
AdminUsername = "client.admin"
// CephTool is the name of the CLI tool for 'ceph'
CephTool = "ceph"
// RBDTool is the name of the CLI tool for 'rbd'
RBDTool = "rbd"
// RadosTool is the name of the CLI tool for 'rados'
RadosTool = "rados"
// Kubectl is the name of the CLI tool for 'kubectl'
Kubectl = "kubectl"
// CrushTool is the name of the CLI tool for 'crushtool'
CrushTool = "crushtool"
// GaneshaRadosGraceTool is the name of the CLI tool for 'ganesha-rados-grace'
GaneshaRadosGraceTool = "ganesha-rados-grace"
// DefaultPGCount will cause Ceph to use the internal default PG count
DefaultPGCount = "0"
// CommandProxyInitContainerName is the name of the init container for proxying ceph command when multus is used
CommandProxyInitContainerName = "cmd-proxy"
// ProxyAppLabel is the label used to identify the proxy container
ProxyAppLabel = "rook-ceph-mgr"
)
// CephConfFilePath returns the location to the cluster's config file in the operator container.
func CephConfFilePath(configDir, clusterName string) string {
confFile := fmt.Sprintf("%s.config", clusterName)
return path.Join(configDir, clusterName, confFile)
}
// FinalizeCephCommandArgs builds the command line to be called
func FinalizeCephCommandArgs(command string, clusterInfo *ClusterInfo, args []string, configDir string) (string, []string) {
timeout := strconv.Itoa(int(exec.CephCommandsTimeout.Seconds()))
cephConfPath := CephConfFilePath(configDir, clusterInfo.Namespace)
// some tools not support the '--connect-timeout' option
// so we only use it for the 'ceph' command
switch command {
case RBDTool, CrushTool, RadosTool, "radosgw-admin":
// do not add timeout flag
case GaneshaRadosGraceTool:
// do not add timeout flag
// ganesha-rados-grace uses '--cephconf' for config file path
args = append(args, fmt.Sprintf("--cephconf=%s", cephConfPath))
default:
args = append(args, "--connect-timeout="+timeout)
}
// If the command should be run inside the toolbox pod, include the kubectl args to call the toolbox
if RunAllCephCommandsInToolboxPod != "" {
toolArgs := []string{
"exec", "-i", RunAllCephCommandsInToolboxPod, "-n", clusterInfo.Namespace,
"--", "timeout", timeout, command,
}
return Kubectl, append(toolArgs, args...)
}
configArgs := []string{}
switch command {
case GaneshaRadosGraceTool:
// ganesha-rados-grace does not accept any standard flags
default:
// Append the standard flags for config and keyring
keyringFile := fmt.Sprintf("%s.keyring", clusterInfo.CephCred.Username)
keyringPath := path.Join(configDir, clusterInfo.Namespace, keyringFile)
if clusterInfo.KeyringFileOverride != "" {
keyringPath = clusterInfo.KeyringFileOverride
}
configArgs = []string{
fmt.Sprintf("--cluster=%s", clusterInfo.Namespace),
fmt.Sprintf("--conf=%s", cephConfPath),
fmt.Sprintf("--name=%s", clusterInfo.CephCred.Username),
fmt.Sprintf("--keyring=%s", keyringPath),
}
}
return command, append(args, configArgs...)
}
type CephToolCommand struct {
context *clusterd.Context
clusterInfo *ClusterInfo
tool string
args []string
timeout time.Duration
JsonOutput bool
combinedOutput bool
RemoteExecution bool
}
func newCephToolCommand(tool string, context *clusterd.Context, clusterInfo *ClusterInfo, args []string) *CephToolCommand {
return &CephToolCommand{
context: context,
tool: tool,
clusterInfo: clusterInfo,
args: args,
JsonOutput: true,
combinedOutput: false,
}
}
func NewCephCommand(context *clusterd.Context, clusterInfo *ClusterInfo, args []string) *CephToolCommand {
return newCephToolCommand(CephTool, context, clusterInfo, args)
}
func NewRBDCommand(context *clusterd.Context, clusterInfo *ClusterInfo, args []string) *CephToolCommand {
cmd := newCephToolCommand(RBDTool, context, clusterInfo, args)
cmd.JsonOutput = false
// When Multus is enabled, the RBD tool should run inside the proxy container
if clusterInfo.NetworkSpec.IsMultus() {
cmd.RemoteExecution = true
}
return cmd
}
func NewRadosCommand(context *clusterd.Context, clusterInfo *ClusterInfo, args []string) *CephToolCommand {
cmd := newCephToolCommand(RadosTool, context, clusterInfo, args)
cmd.JsonOutput = false
// When Multus is enabled, the rados tool should run inside the proxy container
if clusterInfo.NetworkSpec.IsMultus() {
cmd.RemoteExecution = true
}
return cmd
}
func NewGaneshaRadosGraceCommand(context *clusterd.Context, clusterInfo *ClusterInfo, args []string) *CephToolCommand {
cmd := newCephToolCommand(GaneshaRadosGraceTool, context, clusterInfo, args)
cmd.JsonOutput = false
// When Multus is enabled, the rados tool should run inside the proxy container
if clusterInfo.NetworkSpec.IsMultus() {
cmd.RemoteExecution = true
}
return cmd
}
func (c *CephToolCommand) run() ([]byte, error) {
// Return if the context has been canceled
if c.clusterInfo.Context.Err() != nil {
return nil, c.clusterInfo.Context.Err()
}
// Initialize the command and args
command := c.tool
args := c.args
// If this is a remote execution, we don't want to build the full set of args. For instance all
// these args are not needed since those paths don't exist inside the cmd-proxy container:
// --cluster=openshift-storage
// --conf=/var/lib/rook/openshift-storage/openshift-storage.config
// --name=client.admin
// --keyring=/var/lib/rook/openshift-storage/client.admin.keyring
//
// The cmd-proxy container will take care of the rest with the help of the env CEPH_ARGS
if !c.RemoteExecution {
command, args = FinalizeCephCommandArgs(c.tool, c.clusterInfo, c.args, c.context.ConfigDir)
}
if c.JsonOutput {
args = append(args, "--format", "json")
} else {
// the `rbd` tool doesn't use special flag for plain format
switch c.tool {
case RBDTool, RadosTool, GaneshaRadosGraceTool:
// do not add format option
default:
args = append(args, "--format", "plain")
}
}
var output, stderr string
var err error
// NewRBDCommand does not use the --out-file option so we only check for remote execution here
// Still forcing the check for the command if the behavior changes in the future
if command == RBDTool || command == RadosTool || command == GaneshaRadosGraceTool {
if c.RemoteExecution {
defaultTimeout := exec.CephCommandsTimeout
output, stderr, err = c.context.RemoteExecutor.ExecCommandInContainerWithFullOutputWithTimeout(c.clusterInfo.Context, ProxyAppLabel, CommandProxyInitContainerName, c.clusterInfo.Namespace, defaultTimeout, append([]string{command}, args...)...)
if err != nil {
err = errors.Errorf("%s", err.Error())
}
if stderr != "" {
err = errors.Errorf("err=%s: stderr=%s", err.Error(), stderr)
}
} else if c.timeout == 0 {
output, err = c.context.Executor.ExecuteCommandWithOutput(command, args...)
} else {
output, err = c.context.Executor.ExecuteCommandWithTimeout(c.timeout, command, args...)
}
} else if c.timeout == 0 {
if c.combinedOutput {
output, err = c.context.Executor.ExecuteCommandWithCombinedOutput(command, args...)
} else {
output, err = c.context.Executor.ExecuteCommandWithOutput(command, args...)
}
} else {
output, err = c.context.Executor.ExecuteCommandWithTimeout(c.timeout, command, args...)
}
return []byte(output), err
}
func (c *CephToolCommand) Run() ([]byte, error) {
c.timeout = 0
return c.run()
}
func (c *CephToolCommand) RunWithTimeout(timeout time.Duration) ([]byte, error) {
c.timeout = timeout
return c.run()
}
func ExecuteCephCommandWithRetry(
cmd func() (string, []byte, error),
retries int,
waitTime time.Duration,
) ([]byte, error) {
for i := 0; i < retries; i++ {
action, data, err := cmd()
if err != nil {
logger.Infof("command failed for %s. trying again...", action)
time.Sleep(waitTime)
continue
}
if i > 0 {
logger.Infof("action %s succeeded on attempt %d", action, i)
}
return data, nil
}
return nil, errors.New("max command retries exceeded")
}