forked from rook/rook
All existing controller runtime watches are converted to use "typed" handlers and predicates instead of operating on `client.Object`. The intent is to be bug for bug equivalent with the existing logic while replacing run time type assertions and switch statements with compile time type constraints and type casts. In several cases, functions using assertions were split up such that each function only handles a single Kind at a time. It is hoped that this will improve readability and maintainability while facilitating future refactoring such as migrating some watches to using IndexFields. Of particular note is that the massive switch statement in `WatchControllerPredicate()` from `pkg/operator/ceph/controller/predicate.go` has been replaced with generics, reflection, and splitting the obc logic into its own predicate function. There are still many helper functions operating on `client.Object`. These were not updated unless required by the compiler in order to limit the size of this change. The type safety of these funcs should be improved as followup work. It is strongly suggested that going forward, handlers and predicates only handle a single Kind (generic or not) and that switches / type assertions are heavily discouraged or forbidden. This PR removed all but a single switch statement in a predicate, which should be addressed in future work. Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
122 lines
4.6 KiB
Go
122 lines
4.6 KiB
Go
/*
|
|
Copyright 2021 The Rook Authors. All rights reserved.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package csi
|
|
|
|
import (
|
|
"context"
|
|
|
|
"github.com/google/go-cmp/cmp"
|
|
cephv1 "github.com/rook/rook/pkg/apis/ceph.rook.io/v1"
|
|
opcontroller "github.com/rook/rook/pkg/operator/ceph/controller"
|
|
corev1 "k8s.io/api/core/v1"
|
|
kerrors "k8s.io/apimachinery/pkg/api/errors"
|
|
"k8s.io/apimachinery/pkg/api/resource"
|
|
"k8s.io/apimachinery/pkg/types"
|
|
"sigs.k8s.io/controller-runtime/pkg/client"
|
|
"sigs.k8s.io/controller-runtime/pkg/event"
|
|
"sigs.k8s.io/controller-runtime/pkg/predicate"
|
|
)
|
|
|
|
// reconcile on operator settings cm change
|
|
func cmPredicate[T *corev1.ConfigMap]() predicate.TypedFuncs[T] {
|
|
return predicate.TypedFuncs[T]{
|
|
CreateFunc: func(e event.TypedCreateEvent[T]) bool {
|
|
cm := (*corev1.ConfigMap)(e.Object)
|
|
|
|
// We don't want to use cm.Generation here, it case the operator was stopped and the
|
|
// ConfigMap was created
|
|
return cm.Name == opcontroller.OperatorSettingConfigMapName
|
|
},
|
|
|
|
UpdateFunc: func(e event.TypedUpdateEvent[T]) bool {
|
|
cmOld := (*corev1.ConfigMap)(e.ObjectOld)
|
|
cmNew := (*corev1.ConfigMap)(e.ObjectNew)
|
|
|
|
resourceQtyComparer := cmp.Comparer(func(x, y resource.Quantity) bool { return x.Cmp(y) == 0 })
|
|
if cmOld.GetName() == opcontroller.OperatorSettingConfigMapName && cmNew.GetName() == opcontroller.OperatorSettingConfigMapName {
|
|
diff := cmp.Diff(cmOld.Data, cmNew.Data, resourceQtyComparer)
|
|
logger.Debugf("operator configmap diff:\n %s", diff)
|
|
if diff != "" {
|
|
return true
|
|
}
|
|
}
|
|
|
|
return false
|
|
},
|
|
|
|
DeleteFunc: func(e event.TypedDeleteEvent[T]) bool {
|
|
cm := (*corev1.ConfigMap)(e.Object)
|
|
|
|
// if the operator configuration file is deleted we want to reconcile to apply the
|
|
// configuration based on environment variables present in the operator's pod spec
|
|
return cm.Name == opcontroller.OperatorSettingConfigMapName
|
|
},
|
|
|
|
GenericFunc: func(e event.TypedGenericEvent[T]) bool {
|
|
return false
|
|
},
|
|
}
|
|
}
|
|
|
|
// predicateController is the predicate function to trigger reconcile on operator configuration cm change
|
|
func cephClusterPredicate[T *cephv1.CephCluster](ctx context.Context, c client.Client, opNamespace string) predicate.TypedFuncs[T] {
|
|
return predicate.TypedFuncs[T]{
|
|
CreateFunc: func(e event.TypedCreateEvent[T]) bool {
|
|
cephCluster := (*cephv1.CephCluster)(e.Object)
|
|
|
|
// If a Ceph Cluster is created we want to reconcile the csi driver
|
|
// If there are more than one ceph cluster in the same namespace do not reconcile
|
|
if opcontroller.DuplicateCephClusters(ctx, c, cephCluster, false) {
|
|
return false
|
|
}
|
|
|
|
// We still have users that don't use the ConfigMap to configure the
|
|
// operator/csi and still rely on environment variables from the operator pod's
|
|
// spec. So we still want to reconcile the controller if the ConfigMap cannot be found.
|
|
err := c.Get(ctx, types.NamespacedName{Name: opcontroller.OperatorSettingConfigMapName, Namespace: opNamespace}, &corev1.ConfigMap{})
|
|
if err != nil && kerrors.IsNotFound(err) {
|
|
logger.Debugf("could not find operator configuration ConfigMap, will reconcile the csi controller")
|
|
return true
|
|
}
|
|
|
|
// This allows us to avoid a double reconcile of the CSI controller if this is not
|
|
// the first generation of the CephCluster. So only return true if this is the very
|
|
// first instance of the CephCluster
|
|
// Corner case is when the cluster is created but the operator is down AND the cm
|
|
// does not exist... However, these days the operator config map is part of the
|
|
// operator.yaml so it's probably acceptable?
|
|
// This does not account for the case where the cephcluster is already deployed and
|
|
// the upgrade the operator or restart it. However, the CM check above should catch that
|
|
return cephCluster.Generation == 1
|
|
},
|
|
|
|
UpdateFunc: func(e event.TypedUpdateEvent[T]) bool {
|
|
return false
|
|
},
|
|
|
|
DeleteFunc: func(e event.TypedDeleteEvent[T]) bool {
|
|
// if cephCluster is deleted, trigger reconcile to cleanup the csi driver resources
|
|
// if zero cephClusters exist.
|
|
return true
|
|
},
|
|
|
|
GenericFunc: func(e event.TypedGenericEvent[T]) bool {
|
|
return false
|
|
},
|
|
}
|
|
}
|