Files
Oded Viner 81a2cd8833 object: migrate sns topic provisioner to aws sdk v2
migrate the sns-based topic provisioner from aws-sdk-go (v1)
to aws-sdk-go-v2. replace v1 session, credentials, and
request handlers with v2 aws.Config, static credentials
provider, and endpoint resolver. convert the custom ceph rgw
v2 signer hack from a v1 handler swap to a smithy finalize
middleware. update sns api calls to use context-first
signatures, map[string]string attributes, and typed
snstypes.NotFoundException error handling via errors.As.
update unit tests accordingly.

Signed-off-by: Oded Viner <oviner@redhat.com>
2026-05-20 13:02:00 +03:00

295 lines
11 KiB
Go

/*
Copyright 2021 The Rook Authors. All rights reserved.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
// Package topic to manage a rook bucket topics.
package topic
import (
"context"
"net/http"
"net/url"
"strconv"
"strings"
"github.com/aws/aws-sdk-go-v2/aws"
"github.com/aws/aws-sdk-go-v2/aws/arn"
"github.com/aws/aws-sdk-go-v2/credentials"
"github.com/aws/aws-sdk-go-v2/service/sns"
snstypes "github.com/aws/aws-sdk-go-v2/service/sns/types"
smithyendpoints "github.com/aws/smithy-go/endpoints"
"github.com/coreos/pkg/capnslog"
"github.com/pkg/errors"
cephv1 "github.com/rook/rook/pkg/apis/ceph.rook.io/v1"
"github.com/rook/rook/pkg/clusterd"
cephclient "github.com/rook/rook/pkg/daemon/ceph/client"
"github.com/rook/rook/pkg/operator/ceph/controller"
"github.com/rook/rook/pkg/operator/ceph/object"
"github.com/rook/rook/pkg/util/log"
corev1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/types"
"sigs.k8s.io/controller-runtime/pkg/client"
)
type provisioner struct {
client client.Client
context *clusterd.Context
clusterInfo *cephclient.ClusterInfo
clusterSpec *cephv1.ClusterSpec
opManagerContext context.Context
}
// snsEndpointResolver implements sns.EndpointResolverV2 to point at the Ceph RGW endpoint.
type snsEndpointResolver struct {
endpoint string
}
func (r *snsEndpointResolver) ResolveEndpoint(ctx context.Context, params sns.EndpointParameters) (smithyendpoints.Endpoint, error) {
u, err := url.Parse(r.endpoint)
if err != nil {
return smithyendpoints.Endpoint{}, err
}
return smithyendpoints.Endpoint{URI: *u}, nil
}
// A new client type is needed here since topic management is part of AWS's Simple Notification Service (SNS) and not part of S3
func createSNSClient(p provisioner, objectStoreName types.NamespacedName) (*sns.Client, error) {
objStore, err := p.context.RookClientset.CephV1().CephObjectStores(objectStoreName.Namespace).Get(p.opManagerContext, objectStoreName.Name, metav1.GetOptions{})
if err != nil {
return nil, errors.Wrapf(err, "failed to get CephObjectStore %v", objectStoreName)
}
objContext, err := object.NewMultisiteContext(p.context, p.clusterInfo, objStore)
if err != nil {
return nil, errors.Wrapf(err, "failed to get object context for CephObjectStore %v", objectStoreName)
}
accessKey, secretKey, err := object.GetAdminOPSUserCredentials(objContext, &objStore.Spec)
if err != nil {
return nil, errors.Wrap(err, "failed to get Ceph RGW admin ops user credentials")
}
httpClient := &http.Client{
Timeout: object.HttpTimeOut,
}
tlsEnabled := objStore.Spec.IsTLSEnabled()
if tlsEnabled {
tlsCert, _, err := object.GetTlsCaCert(objContext, &objStore.Spec)
if err != nil {
return nil, errors.Wrap(err, "failed to get TLS certificate for the object store")
}
if len(tlsCert) > 0 {
httpClient.Transport = object.BuildTransportTLS(tlsCert, false)
}
}
endpoint := objContext.Endpoint
log.NamedDebug(objectStoreName, logger, "creating SNS client. endpoint %q secure %v",
endpoint,
tlsEnabled,
)
var logMode aws.ClientLogMode
if logger.LevelAt(capnslog.DEBUG) {
logMode = aws.LogRequestWithBody | aws.LogResponseWithBody
}
snsClient := sns.NewFromConfig(aws.Config{
Region: object.CephRegion,
Credentials: aws.NewCredentialsCache(credentials.NewStaticCredentialsProvider(accessKey, secretKey, "")),
HTTPClient: httpClient,
RetryMaxAttempts: 3,
RetryMode: aws.RetryModeStandard,
ClientLogMode: logMode,
}, func(o *sns.Options) {
o.EndpointResolverV2 = &snsEndpointResolver{endpoint: endpoint}
})
return snsClient, nil
}
func createTopicAttributes(p provisioner, topic *cephv1.CephBucketTopic) (map[string]string, *map[types.UID]*corev1.Secret, error) {
attr := make(map[string]string)
nsName := controller.NsName(topic.Namespace, topic.Name)
referencedSecrets := make(map[types.UID]*corev1.Secret)
attr["OpaqueData"] = topic.Spec.OpaqueData
attr["persistent"] = strconv.FormatBool(topic.Spec.Persistent)
if topic.Spec.Endpoint.AMQP != nil {
log.NamedInfo(nsName, logger, "creating CephBucketTopic %q with endpoint %q", nsName, topic.Spec.Endpoint.AMQP.URI)
attr["push-endpoint"] = topic.Spec.Endpoint.AMQP.URI
attr["amqp-exchange"] = topic.Spec.Endpoint.AMQP.Exchange
attr["amqp-ack-level"] = topic.Spec.Endpoint.AMQP.AckLevel
attr["verify-ssl"] = strconv.FormatBool(!topic.Spec.Endpoint.AMQP.DisableVerifySSL)
}
if topic.Spec.Endpoint.HTTP != nil {
log.NamedInfo(nsName, logger, "creating CephBucketTopic %q with endpoint %q", nsName, topic.Spec.Endpoint.HTTP.URI)
attr["push-endpoint"] = topic.Spec.Endpoint.HTTP.URI
attr["verify-ssl"] = strconv.FormatBool(!topic.Spec.Endpoint.HTTP.DisableVerifySSL)
attr["cloudevents"] = strconv.FormatBool(topic.Spec.Endpoint.HTTP.SendCloudEvents)
}
if topic.Spec.Endpoint.Kafka != nil {
kafka := topic.Spec.Endpoint.Kafka
uri, err := url.Parse(kafka.URI)
if err != nil {
// URI could contain a passphrase...
return nil, nil, errors.Wrapf(err, "failed to parse CephBucketTopic %q .spec.endpoint.kafka.URI %q", nsName, kafka.URI)
}
// If UserSecretRef or PasswordRef is set, we need to parse the URI and insert the
// credentials as http basic auth. If basic auth was already set as part of
// the URI string, it will be overridden.
if kafka.UserSecretRef != nil || kafka.PasswordSecretRef != nil {
var user, pass string
if kafka.UserSecretRef != nil {
var secret *corev1.Secret
user, secret, err = p.getSecretValue(kafka.UserSecretRef, topic.Namespace)
if err != nil {
return nil, nil, errors.Wrapf(err, "failed to get secret value from CephBucketTopic %q .spec.endpoint.kafka.userSecretRef %q", nsName, kafka.UserSecretRef)
}
log.NamedDebug(nsName, logger, "CephBucketTopic %q references secret %q", nsName, client.ObjectKeyFromObject(secret))
referencedSecrets[secret.UID] = secret
}
if kafka.PasswordSecretRef != nil {
var secret *corev1.Secret
pass, secret, err = p.getSecretValue(kafka.PasswordSecretRef, topic.Namespace)
if err != nil {
return nil, nil, errors.Wrapf(err, "failed to get secret value from CephBucketTopic %q .spec.endpoint.kafka.passwordSecretRef %q", nsName, kafka.PasswordSecretRef)
}
log.NamedDebug(nsName, logger, "CephBucketTopic %q references secret %q", nsName, client.ObjectKeyFromObject(secret))
referencedSecrets[secret.UID] = secret
}
uri.User = url.UserPassword(user, pass)
}
// do not log passphrases, if set
log.NamedInfo(nsName, logger, "creating CephBucketTopic %q with endpoint %q", nsName, uri.Redacted())
attr["push-endpoint"] = uri.String()
attr["use-ssl"] = strconv.FormatBool(topic.Spec.Endpoint.Kafka.UseSSL)
attr["kafka-ack-level"] = topic.Spec.Endpoint.Kafka.AckLevel
attr["verify-ssl"] = strconv.FormatBool(!topic.Spec.Endpoint.Kafka.DisableVerifySSL)
attr["mechanism"] = topic.Spec.Endpoint.Kafka.Mechanism
}
return attr, &referencedSecrets, nil
}
// Allow overriding this function for unit tests
var createTopicFunc = createTopic
func createTopic(p provisioner, topic *cephv1.CephBucketTopic) (*string, *map[types.UID]*corev1.Secret, error) {
nsName := controller.NsName(topic.Namespace, topic.Name)
snsClient, err := createSNSClient(p, types.NamespacedName{Name: topic.Spec.ObjectStoreName, Namespace: topic.Spec.ObjectStoreNamespace})
if err != nil {
return nil, nil, errors.Wrapf(err, "failed to create SNS client for CephBucketTopic %q provisioning", nsName)
}
attr, referencedSecrets, err := createTopicAttributes(p, topic)
if err != nil {
return nil, nil, errors.Wrapf(err, "failed to generate topic attributes for CephBucketTopic %q", nsName)
}
topicOutput, err := snsClient.CreateTopic(p.opManagerContext, &sns.CreateTopicInput{
Name: &topic.Name,
Attributes: attr,
})
if err != nil {
return nil, nil, errors.Wrapf(err, "failed to provision CephBucketTopic %q", nsName)
}
log.NamedInfo(nsName, logger, "CephBucketTopic %q created with ARN %q", nsName, *topicOutput.TopicArn)
return topicOutput.TopicArn, referencedSecrets, nil
}
// Allow overriding this function for unit tests
var deleteTopicFunc = deleteTopic
func deleteTopic(p provisioner, topic *cephv1.CephBucketTopic) error {
nsName := controller.NsName(topic.Namespace, topic.Name)
log.NamedInfo(nsName, logger, "deleting CephBucketTopic %q", nsName)
if topic.Status.ARN == nil {
log.NamedWarning(nsName, logger, "ignore CephBucketTopic deletion. topic %q was never successfully provisioned", nsName)
return nil
}
snsClient, err := createSNSClient(p, types.NamespacedName{Name: topic.Spec.ObjectStoreName, Namespace: topic.Spec.ObjectStoreNamespace})
if err != nil {
return errors.Wrapf(err, "failed to create SNS client for CephBucketTopic %q deletion", nsName)
}
_, err = snsClient.DeleteTopic(p.opManagerContext, &sns.DeleteTopicInput{TopicArn: topic.Status.ARN})
if err != nil {
var notFoundErr *snstypes.NotFoundException
if !errors.As(err, &notFoundErr) {
return errors.Wrapf(err, "failed to delete CephBucketTopic %q", nsName)
}
log.NamedWarning(nsName, logger, "ignore CephBucketTopic deletion. %q was already deleted", nsName)
}
log.NamedInfo(nsName, logger, "CephBucketTopic %q deleted", nsName)
return nil
}
func GetProvisioned(cl client.Client, ctx context.Context, topicName types.NamespacedName) (*cephv1.CephBucketTopic, error) {
bucketTopic := &cephv1.CephBucketTopic{}
if err := cl.Get(ctx, topicName, bucketTopic); err != nil {
return nil, errors.Wrapf(err, "failed to retrieve CephBucketTopic %q", topicName)
}
if bucketTopic.Status == nil || bucketTopic.Status.ARN == nil {
return nil, errors.Errorf("no ARN in topic. CephBucketTopic %q was not provisioned yet", topicName)
}
topicARN := *bucketTopic.Status.ARN
parsedTopicARN, err := arn.Parse(topicARN)
if err != nil {
return nil, errors.Wrapf(err, "failed to parse CephBucketTopic %q ARN %q", topicName, topicARN)
}
if strings.ToLower(parsedTopicARN.Service) != "sns" {
return nil, errors.Errorf("CephBucketTopic %q ARN %q must have 'sns' service", topicName, topicARN)
}
if parsedTopicARN.Resource == "" {
return nil, errors.Errorf("CephBucketTopic %q is missing a topic inside ARN %q", topicName, topicARN)
}
log.NamedDebug(topicName, logger, "CephBucketTopic found with valid ARN %q", topicARN)
return bucketTopic, nil
}
// getSecretValue returns the value of key in a kubernetes secret
func (p *provisioner) getSecretValue(selector *corev1.SecretKeySelector, namespace string) (string, *corev1.Secret, error) {
secret := &corev1.Secret{}
namespacedName := types.NamespacedName{
Name: selector.Name,
Namespace: namespace,
}
if err := p.client.Get(p.opManagerContext, namespacedName, secret); err != nil {
return "", nil, errors.Wrapf(err, "failed to get secret %q", namespacedName)
}
value, ok := secret.Data[selector.Key]
if !ok {
return "", nil, errors.Errorf("failed to find key %q in secret %q", selector.Key, namespacedName)
}
return string(value), secret, nil
}