Madhu Rajanna
f482b1ceba
Instead of setting the default values in the Rook we should use the defaults provided by the ceph it self. This configuration is causing problem for the rbd image creation, this is not allowing the rbd images to have default image features which comes with librbd. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
89 lines
2.9 KiB
Go
89 lines
2.9 KiB
Go
/*
|
|
Copyright 2019 The Rook Authors. All rights reserved.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
// Package config provides default configurations which Rook will set in Ceph clusters.
|
|
package config
|
|
|
|
import (
|
|
"github.com/rook/rook/pkg/operator/ceph/version"
|
|
)
|
|
|
|
// DefaultFlags returns the default configuration flags Rook will set on the command line for all
|
|
// calls to Ceph daemons and tools. Values specified here will not be able to be overridden using
|
|
// the mon's central KV store, and that is (and should be) by intent.
|
|
func DefaultFlags(fsid, mountedKeyringPath string) []string {
|
|
flags := []string{
|
|
// fsid unnecessary but is a safety to make sure daemons can only connect to their cluster
|
|
NewFlag("fsid", fsid),
|
|
NewFlag("keyring", mountedKeyringPath),
|
|
}
|
|
|
|
flags = append(flags, LoggingFlags()...)
|
|
flags = append(flags, StoredMonHostEnvVarFlags()...)
|
|
|
|
return flags
|
|
}
|
|
|
|
// makes it possible to be slightly less verbose to create a ConfigOverride here
|
|
func configOverride(who, option, value string) Option {
|
|
return Option{Who: who, Option: option, Value: value}
|
|
}
|
|
|
|
func LoggingFlags() []string {
|
|
return []string{
|
|
// For containers, we're expected to log everything to stderr
|
|
NewFlag("log-to-stderr", "true"),
|
|
NewFlag("err-to-stderr", "true"),
|
|
NewFlag("mon-cluster-log-to-stderr", "true"),
|
|
// differentiate debug text from audit text, and the space after 'debug' is critical
|
|
NewFlag("log-stderr-prefix", "debug "),
|
|
NewFlag("default-log-to-file", "false"),
|
|
NewFlag("default-mon-cluster-log-to-file", "false"),
|
|
}
|
|
}
|
|
|
|
// DefaultCentralizedConfigs returns the default configuration options Rook will set in Ceph's
|
|
// centralized config store.
|
|
func DefaultCentralizedConfigs(cephVersion version.CephVersion) []Option {
|
|
overrides := []Option{
|
|
configOverride("global", "mon allow pool delete", "true"),
|
|
configOverride("global", "mon cluster log file", ""),
|
|
}
|
|
|
|
// For Pacific
|
|
if cephVersion.IsAtLeastPacific() {
|
|
overrides = append(overrides, []Option{
|
|
configOverride("global", "mon allow pool size one", "true"),
|
|
}...)
|
|
}
|
|
|
|
// Every release before Quincy will enable PG auto repair on Bluestore OSDs
|
|
if !cephVersion.IsAtLeastQuincy() {
|
|
overrides = append(overrides, []Option{
|
|
configOverride("global", "osd scrub auto repair", "true"),
|
|
}...)
|
|
}
|
|
|
|
return overrides
|
|
}
|
|
|
|
// LegacyConfigs represents old configuration that were applied to a cluster and not needed anymore
|
|
func LegacyConfigs() []Option {
|
|
return []Option{
|
|
{Who: "global", Option: "log file"},
|
|
}
|
|
}
|