forked from rook/rook
Blaine Gardner
c8a2db368a
Even if we can use raw mode, do NOT use raw mode on disks. Ceph bluestore disks can sometimes appear as though they have "phantom" Atari (AHDI) partitions created on them when they don't in reality. This is due to a series of bugs in the Linux kernel when it is built with Atari support enabled. This behavior does not appear for raw mode OSDs on partitions, and we need the raw mode to create partition-based OSDs. We cannot merely skip creating OSDs on "phantom" partitions due to a bug in `ceph-volume raw inventory` which reports only the phantom partitions (and malformed OSD info) when they exist and ignores the original (correct) OSDs created on the raw disk. Resolves https://github.com/rook/rook/issues/7940 Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
199 lines
6.5 KiB
Go
199 lines
6.5 KiB
Go
/*
|
|
Copyright 2016 The Rook Authors. All rights reserved.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
package sys
|
|
|
|
import (
|
|
"fmt"
|
|
"testing"
|
|
|
|
exectest "github.com/rook/rook/pkg/util/exec/test"
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
const (
|
|
udevOutput = `DEVLINKS=/dev/disk/by-id/scsi-36001405d27e5d898829468b90ce4ef8c /dev/disk/by-id/wwn-0x6001405d27e5d898829468b90ce4ef8c /dev/disk/by-path/ip-127.0.0.1:3260-iscsi-iqn.2016-06.world.srv:storage.target01-lun-0 /dev/disk/by-uuid/f2d38cba-37da-411d-b7ba-9a6696c58174
|
|
DEVNAME=/dev/sdk
|
|
DEVPATH=/devices/platform/host6/session2/target6:0:0/6:0:0:0/block/sdk
|
|
DEVTYPE=disk
|
|
ID_BUS=scsi
|
|
ID_FS_TYPE=ext2
|
|
ID_FS_USAGE=filesystem
|
|
ID_FS_UUID=f2d38cba-37da-411d-b7ba-9a6696c58174
|
|
ID_FS_UUID_ENC=f2d38cba-37da-411d-b7ba-9a6696c58174
|
|
ID_FS_VERSION=1.0
|
|
ID_MODEL=disk01
|
|
ID_MODEL_ENC=disk01\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20
|
|
ID_PATH=ip-127.0.0.1:3260-iscsi-iqn.2016-06.world.srv:storage.target01-lun-0
|
|
ID_PATH_TAG=ip-127_0_0_1_3260-iscsi-iqn_2016-06_world_srv_storage_target01-lun-0
|
|
ID_REVISION=4.0
|
|
ID_SCSI=1
|
|
ID_SCSI_SERIAL=d27e5d89-8829-468b-90ce-4ef8c02f07fe
|
|
ID_SERIAL=36001405d27e5d898829468b90ce4ef8c
|
|
ID_SERIAL_SHORT=6001405d27e5d898829468b90ce4ef8c
|
|
ID_TARGET_PORT=0
|
|
ID_TYPE=disk
|
|
ID_VENDOR=LIO-ORG
|
|
ID_VENDOR_ENC=LIO-ORG\x20
|
|
ID_WWN=0x6001405d27e5d898
|
|
ID_WWN_VENDOR_EXTENSION=0x829468b90ce4ef8c
|
|
ID_WWN_WITH_EXTENSION=0x6001405d27e5d898829468b90ce4ef8c
|
|
MAJOR=8
|
|
MINOR=160
|
|
SUBSYSTEM=block
|
|
TAGS=:systemd:
|
|
USEC_INITIALIZED=15981915740802
|
|
`
|
|
udevPartOutput = `ID_PART_ENTRY_DISK=8:32
|
|
ID_PART_ENTRY_NAME=%s
|
|
ID_PART_ENTRY_NUMBER=3
|
|
ID_PART_ENTRY_OFFSET=3278848
|
|
ID_PART_ENTRY_SCHEME=gpt
|
|
ID_PART_ENTRY_SIZE=7206879
|
|
ID_PART_ENTRY_TYPE=0fc63daf-8483-4772-8e79-3d69d8477de4
|
|
ID_PART_ENTRY_UUID=2089640e-bdeb-4fb4-aaec-88e165780b88
|
|
ID_PART_TABLE_TYPE=gpt
|
|
ID_PART_TABLE_UUID=46242f96-6cf7-4e5d-b4bd-9d046e6ad920
|
|
ID_REVISION=4.0
|
|
ID_SCSI=1
|
|
ID_SCSI_SERIAL=68c0bd28-d4ee-4376-9387-c9f02c53b3f2
|
|
ID_SERIAL=3600140568c0bd28d4ee43769387c9f02
|
|
ID_SERIAL_SHORT=600140568c0bd28d4ee43769387c9f02
|
|
ID_TARGET_PORT=0
|
|
ID_TYPE=disk
|
|
ID_VENDOR=LIO-ORG
|
|
ID_VENDOR_ENC=LIO-ORG\x20
|
|
ID_WWN=0x600140568c0bd28d
|
|
ID_WWN_VENDOR_EXTENSION=0x4ee43769387c9f02
|
|
ID_WWN_WITH_EXTENSION=0x600140568c0bd28d4ee43769387c9f02
|
|
MAJOR=8
|
|
MINOR=35
|
|
PARTN=3
|
|
PARTNAME=Linux filesystem
|
|
SUBSYSTEM=block
|
|
`
|
|
)
|
|
|
|
var (
|
|
lsblkChildOutput = `NAME="ceph--cec981b8--2eca--45cd--bf91--a4472779f2a9-osd--data--428984b7--f94d--40cd--9cb7--1458e1613eab" MAJ:MIN="252:0" RM="0" SIZE="29G" RO="0" TYPE="lvm" MOUNTPOINT=""
|
|
NAME="vdb" MAJ:MIN="253:16" RM="0" SIZE="30G" RO="0" TYPE="disk" MOUNTPOINT=""
|
|
NAME="vdb1" MAJ:MIN="253:17" RM="0" SIZE="30G" RO="0" TYPE="part" MOUNTPOINT=""`
|
|
)
|
|
|
|
func TestFindUUID(t *testing.T) {
|
|
output := `Disk /dev/sdb: 10485760 sectors, 5.0 GiB
|
|
Logical sector size: 512 bytes
|
|
Disk identifier (GUID): 31273B25-7B2E-4D31-BAC9-EE77E62EAC71
|
|
Partition table holds up to 128 entries
|
|
First usable sector is 34, last usable sector is 10485726
|
|
Partitions will be aligned on 2048-sector boundaries
|
|
Total free space is 20971453 sectors (10.0 GiB)
|
|
`
|
|
uuid, err := parseUUID("sdb", output)
|
|
assert.Nil(t, err)
|
|
assert.Equal(t, "31273b25-7b2e-4d31-bac9-ee77e62eac71", uuid)
|
|
}
|
|
|
|
func TestParseFileSystem(t *testing.T) {
|
|
output := udevOutput
|
|
|
|
result := parseFS(output)
|
|
assert.Equal(t, "ext2", result)
|
|
}
|
|
|
|
func TestGetPartitions(t *testing.T) {
|
|
run := 0
|
|
executor := &exectest.MockExecutor{
|
|
MockExecuteCommandWithOutput: func(command string, arg ...string) (string, error) {
|
|
run++
|
|
logger.Infof("run %d command %s", run, command)
|
|
switch {
|
|
case run == 1:
|
|
return `NAME="sdc" SIZE="100000" TYPE="disk" PKNAME=""`, nil
|
|
case run == 2:
|
|
return `NAME="sdb" SIZE="65" TYPE="disk" PKNAME=""
|
|
NAME="sdb2" SIZE="10" TYPE="part" PKNAME="sdb"
|
|
NAME="sdb3" SIZE="20" TYPE="part" PKNAME="sdb"
|
|
NAME="sdb1" SIZE="30" TYPE="part" PKNAME="sdb"`, nil
|
|
case run == 3:
|
|
return fmt.Sprintf(udevPartOutput, "ROOK-OSD0-DB"), nil
|
|
case run == 4:
|
|
return fmt.Sprintf(udevPartOutput, "ROOK-OSD0-BLOCK"), nil
|
|
case run == 5:
|
|
return fmt.Sprintf(udevPartOutput, "ROOK-OSD0-WAL"), nil
|
|
case run == 6:
|
|
return `NAME="sda" SIZE="19818086400" TYPE="disk" PKNAME=""
|
|
NAME="sda4" SIZE="1073741824" TYPE="part" PKNAME="sda"
|
|
NAME="sda2" SIZE="2097152" TYPE="part" PKNAME="sda"
|
|
NAME="sda9" SIZE="17328766976" TYPE="part" PKNAME="sda"
|
|
NAME="sda7" SIZE="67108864" TYPE="part" PKNAME="sda"
|
|
NAME="sda3" SIZE="1073741824" TYPE="part" PKNAME="sda"
|
|
NAME="usr" SIZE="1065345024" TYPE="crypt" PKNAME="sda3"
|
|
NAME="sda1" SIZE="134217728" TYPE="part" PKNAME="sda"
|
|
NAME="sda6" SIZE="134217728" TYPE="part" PKNAME="sda"`, nil
|
|
case run == 14:
|
|
return `NAME="dm-0" SIZE="100000" TYPE="lvm" PKNAME=""
|
|
NAME="ceph--89fa04fa--b93a--4874--9364--c95be3ec01c6-osd--data--70847bdb--2ec1--4874--98ba--d87d4860a70d" SIZE="31138512896" TYPE="lvm" PKNAME=""`, nil
|
|
}
|
|
return "", nil
|
|
},
|
|
}
|
|
|
|
partitions, unused, err := GetDevicePartitions("sdc", executor)
|
|
assert.Nil(t, err)
|
|
assert.Equal(t, uint64(100000), unused)
|
|
assert.Equal(t, 0, len(partitions))
|
|
|
|
partitions, unused, err = GetDevicePartitions("sdb", executor)
|
|
assert.Nil(t, err)
|
|
assert.Equal(t, uint64(5), unused)
|
|
assert.Equal(t, 3, len(partitions))
|
|
assert.Equal(t, uint64(10), partitions[0].Size)
|
|
assert.Equal(t, "ROOK-OSD0-DB", partitions[0].Label)
|
|
assert.Equal(t, "sdb2", partitions[0].Name)
|
|
|
|
partitions, unused, err = GetDevicePartitions("sda", executor)
|
|
assert.Nil(t, err)
|
|
assert.Equal(t, uint64(0x400000), unused)
|
|
assert.Equal(t, 7, len(partitions))
|
|
|
|
partitions, _, err = GetDevicePartitions("dm-0", executor)
|
|
assert.Nil(t, err)
|
|
assert.Equal(t, 1, len(partitions))
|
|
|
|
partitions, _, err = GetDevicePartitions("sdx", executor)
|
|
assert.Nil(t, err)
|
|
assert.Equal(t, 0, len(partitions))
|
|
}
|
|
|
|
func TestParseUdevInfo(t *testing.T) {
|
|
m := parseUdevInfo(udevOutput)
|
|
assert.Equal(t, m["ID_FS_TYPE"], "ext2")
|
|
}
|
|
|
|
func TestListDevicesChildListDevicesChild(t *testing.T) {
|
|
executor := &exectest.MockExecutor{
|
|
MockExecuteCommandWithOutput: func(command string, arg ...string) (string, error) {
|
|
logger.Infof("command %s", command)
|
|
return lsblkChildOutput, nil
|
|
},
|
|
}
|
|
|
|
device := "/dev/vdb"
|
|
child, err := ListDevicesChild(executor, device)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, 3, len(child))
|
|
}
|