Files
my-rook-config/pkg/operator/ceph/version/version.go
T
Sébastien Han 9c1bb7c62d ceph: external be a bit more flexible on upgrade
Add various upgrade tests so that the local cluster does not fail if
an upgrade is available on the external cluster.

Also, add better upgrades handling on update and on add. We now rely as
much as possible on a unique function that works both local and external
cluster 'detectAndValidateCephVersion()'. So the code will act the same
way wether a CR update is triggered or if the operator is restarted.

The health check now reports any topology changes on the external
cluster such as odd number of mons and low number. It will also detect
if the external cluster has been upgraded and will log that information,
  helping the admin in his/her decision to trigger an image upgrade.

Finally, we prevent the creation of new CRs if the external cluster
version has a higher major number than the local one.

Closes: https://github.com/rook/rook/issues/3731
Signed-off-by: Sébastien Han <seb@redhat.com>
2019-09-04 19:02:08 -06:00

258 lines
7.0 KiB
Go

/*
Copyright 2019 The Rook Authors. All rights reserved.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package version
import (
"fmt"
"regexp"
"strconv"
"github.com/coreos/pkg/capnslog"
)
// CephVersion represents the Ceph version format
type CephVersion struct {
Major int
Minor int
Extra int
}
const (
unknownVersionString = "<unknown version>"
)
var (
// Minimum supported version is 13.2.4 where ceph-volume is supported
Minimum = CephVersion{13, 2, 4}
// Mimic Ceph version
Mimic = CephVersion{13, 0, 0}
// Nautilus Ceph version
Nautilus = CephVersion{14, 0, 0}
// Octopus Ceph version
Octopus = CephVersion{15, 0, 0}
// supportedVersions are production-ready versions that rook supports
supportedVersions = []CephVersion{Mimic, Nautilus}
unsupportedVersions = []CephVersion{Octopus}
// allVersions includes all supportedVersions as well as unreleased versions that are being tested with rook
allVersions = append(supportedVersions, unsupportedVersions...)
// for parsing the output of `ceph --version`
versionPattern = regexp.MustCompile(`ceph version (\d+)\.(\d+)\.(\d+)`)
logger = capnslog.NewPackageLogger("github.com/rook/rook", "cephver")
)
func (v *CephVersion) String() string {
return fmt.Sprintf("%d.%d.%d %s",
v.Major, v.Minor, v.Extra, v.ReleaseName())
}
// CephVersionFormatted returns the Ceph version in a human readable format
func (v *CephVersion) CephVersionFormatted() string {
return fmt.Sprintf("ceph version %d.%d.%d %s",
v.Major, v.Minor, v.Extra, v.ReleaseName())
}
// ReleaseName is the name of the Ceph release
func (v *CephVersion) ReleaseName() string {
switch v.Major {
case Octopus.Major:
return "octopus"
case Nautilus.Major:
return "nautilus"
case Mimic.Major:
return "mimic"
default:
return unknownVersionString
}
}
// ExtractCephVersion extracts the major, minor and extra digit of a Ceph release
func ExtractCephVersion(src string) (*CephVersion, error) {
m := versionPattern.FindStringSubmatch(src)
if m == nil {
return nil, fmt.Errorf("failed to parse version from: %s", src)
}
major, err := strconv.Atoi(m[1])
if err != nil {
return nil, fmt.Errorf("failed to parse version major part: %s", m[0])
}
minor, err := strconv.Atoi(m[2])
if err != nil {
return nil, fmt.Errorf("failed to parse version minor part: %s", m[1])
}
extra, err := strconv.Atoi(m[3])
if err != nil {
return nil, fmt.Errorf("failed to parse version extra part: %s", m[2])
}
return &CephVersion{major, minor, extra}, nil
}
// Supported checks if a given release is supported
func (v *CephVersion) Supported() bool {
for _, sv := range supportedVersions {
if v.isRelease(sv) {
return true
}
}
return false
}
func (v *CephVersion) isRelease(other CephVersion) bool {
return v.Major == other.Major
}
// IsMimic checks if the Ceph version is Mimic
func (v *CephVersion) IsMimic() bool {
return v.isRelease(Mimic)
}
// IsAtLeast checks a given Ceph version is at least a given one
func (v *CephVersion) IsAtLeast(other CephVersion) bool {
if v.Major > other.Major {
return true
} else if v.Major < other.Major {
return false
}
// If we arrive here then v.Major == other.Major
if v.Minor > other.Minor {
return true
} else if v.Minor < other.Minor {
return false
}
// If we arrive here then v.Minor == other.Minor
if v.Extra > other.Extra {
return true
} else if v.Extra < other.Extra {
return false
}
// If we arrive here then both versions are identical
return true
}
// IsAtLeastOctopus check that the Ceph version is at least Octopus
func (v *CephVersion) IsAtLeastOctopus() bool {
return v.IsAtLeast(Octopus)
}
// IsAtLeastNautilus check that the Ceph version is at least Nautilus
func (v *CephVersion) IsAtLeastNautilus() bool {
return v.IsAtLeast(Nautilus)
}
// IsAtLeastMimic check that the Ceph version is at least Mimic
func (v *CephVersion) IsAtLeastMimic() bool {
return v.IsAtLeast(Mimic)
}
// IsIdentical checks if Ceph versions are identical
func IsIdentical(a, b CephVersion) bool {
if a.Major == b.Major {
if a.Minor == b.Minor {
if a.Extra == b.Extra {
return true
}
}
}
return false
}
// IsSuperior checks if a given version if superior to another one
func IsSuperior(a, b CephVersion) bool {
if a.Major > b.Major {
return true
}
if a.Major == b.Major {
if a.Minor > b.Minor {
return true
}
}
if a.Major == b.Major {
if a.Minor == b.Minor {
if a.Extra > b.Extra {
return true
}
}
}
return false
}
// IsInferior checks if a given version if inferior to another one
func IsInferior(a, b CephVersion) bool {
if a.Major < b.Major {
return true
}
if a.Major == b.Major {
if a.Minor < b.Minor {
return true
}
}
if a.Major == b.Major {
if a.Minor == b.Minor {
if a.Extra < b.Extra {
return true
}
}
}
return false
}
// ValidateCephVersionsBetweenLocalAndExternalClusters makes sure an external cluster can be connected
// by checking the external ceph versions available and comparing it with the local image provided
func ValidateCephVersionsBetweenLocalAndExternalClusters(localVersion, externalVersion CephVersion) error {
logger.Debugf("local version is %s, external version is %s", localVersion.String(), externalVersion.String())
// We only support Nautilus or newer
if !externalVersion.IsAtLeastNautilus() {
return fmt.Errorf("unsupported ceph version %s, need at least nautilus, delete your cluster CR and create a new one with a correct ceph version", externalVersion.String())
}
// Identical version, regardless if other CRs are running, it's ok!
if IsIdentical(localVersion, externalVersion) {
return nil
}
// Local version must never be higher than the external one
if IsSuperior(localVersion, externalVersion) {
return fmt.Errorf("local cluster ceph version is higher %s than the external cluster %s, this must never happen", externalVersion.String(), localVersion.String())
}
// External cluster was updated to a minor version higher, consider updating too!
if localVersion.Major == externalVersion.Major {
if IsSuperior(externalVersion, localVersion) {
logger.Warningf("external cluster ceph version is a minor version higher %s than the local cluster %s, consider upgrading", externalVersion.String(), localVersion.String())
return nil
}
}
// The external cluster was upgraded, consider upgrading too!
if localVersion.Major < externalVersion.Major {
logger.Errorf("external cluster ceph version is a major version higher %s than the local cluster %s, consider upgrading", externalVersion.String(), localVersion.String())
return nil
}
return nil
}