forked from rook/rook
Sébastien Han
db614473c2
We recently discovered a race condition which happens not to update the child CRDs when CR image changes. The race happens under the following sequence: * orchestration onAdd() is called when the operator image restarts or its image updated * the orchestration then goes into processing mon/mgr/osd * during this the cluster CR is updated so onUpdate() is called, however, onAdd() is not done yet for child CRDs (mds, rgw) * onUpdate() runs against the cluster CR and updates the cluster images * by the time the child CRDs reached onUpdate() from their respective ParentClusterChanged() methods, the image is already up to date so we were exiting since our check for updating these resources are based on the cluster image version To fix this, we changed the comparison, but using isUpgrade instead and slightly changed the way isUpgrade operates. So now, isUpgrade is true even if the Ceph version is identical which allows us to verify whether or not the image changed. Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1775624 Signed-off-by: Sébastien Han <seb@redhat.com>