forked from rook/rook
Sébastien Han
19de2b28e9
We don't need to set log_file to empty string since "log_to_file" is set to False. This is probably an old leftover/hack we were doing in the past when "log_to_file" and other related options were not there. Because of this line https://github.com/ceph/ceph/blob/master/src/perfglue/heap_profiler.cc#L99, Ceph looks for the log_file conf option. In our case it was empty, so the logging would default to the current directory which points to the container runtime root when not set and we don't have permission to write there. We now force it to Ceph's default so that existing cluster will get the fix after upgrading. Just removing the option allows us to get dump in /var/log/ceph. Phew, what a bug! Signed-off-by: Sébastien Han <seb@redhat.com>
108 lines
3.9 KiB
Go
108 lines
3.9 KiB
Go
/*
|
|
Copyright 2019 The Rook Authors. All rights reserved.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
// Package config provides default configurations which Rook will set in Ceph clusters.
|
|
package config
|
|
|
|
import (
|
|
"github.com/rook/rook/pkg/operator/ceph/version"
|
|
)
|
|
|
|
// DefaultFlags returns the default configuration flags Rook will set on the command line for all
|
|
// calls to Ceph daemons and tools. Values specified here will not be able to be overridden using
|
|
// the mon's central KV store, and that is (and should be) by intent.
|
|
func DefaultFlags(fsid, mountedKeyringPath string) []string {
|
|
flags := []string{
|
|
// fsid unnecessary but is a safety to make sure daemons can only connect to their cluster
|
|
NewFlag("fsid", fsid),
|
|
NewFlag("keyring", mountedKeyringPath),
|
|
}
|
|
|
|
flags = append(flags, LoggingFlags()...)
|
|
flags = append(flags, StoredMonHostEnvVarFlags()...)
|
|
|
|
return flags
|
|
}
|
|
|
|
// makes it possible to be slightly less verbose to create a ConfigOverride here
|
|
func configOverride(who, option, value string) Option {
|
|
return Option{Who: who, Option: option, Value: value}
|
|
}
|
|
|
|
func LoggingFlags() []string {
|
|
return []string{
|
|
// For containers, we're expected to log everything to stderr
|
|
NewFlag("log-to-stderr", "true"),
|
|
NewFlag("err-to-stderr", "true"),
|
|
NewFlag("mon-cluster-log-to-stderr", "true"),
|
|
// differentiate debug text from audit text, and the space after 'debug' is critical
|
|
NewFlag("log-stderr-prefix", "debug "),
|
|
NewFlag("default-log-to-file", "false"),
|
|
NewFlag("default-mon-cluster-log-to-file", "false"),
|
|
}
|
|
}
|
|
|
|
// DefaultCentralizedConfigs returns the default configuration options Rook will set in Ceph's
|
|
// centralized config store.
|
|
func DefaultCentralizedConfigs(cephVersion version.CephVersion) []Option {
|
|
overrides := []Option{
|
|
configOverride("global", "mon allow pool delete", "true"),
|
|
configOverride("global", "mon cluster log file", ""),
|
|
}
|
|
|
|
// We disable "bluestore warn on legacy statfs"
|
|
// This setting appeared on 14.2.2, so if detected we disable the warning
|
|
// As of 14.2.5 (https://github.com/rook/rook/issues/3539#issuecomment-531287051), Ceph will disable this flag by default so there is no need to apply it
|
|
if cephVersion.IsAtLeast(version.CephVersion{Major: 14, Minor: 2, Extra: 2}) && version.IsInferior(cephVersion, version.CephVersion{Major: 14, Minor: 2, Extra: 5}) {
|
|
overrides = append(overrides, []Option{
|
|
configOverride("global", "bluestore warn on legacy statfs", "false"),
|
|
}...)
|
|
}
|
|
|
|
// For Pacific
|
|
if cephVersion.IsAtLeastPacific() {
|
|
overrides = append(overrides, []Option{
|
|
configOverride("global", "mon allow pool size one", "true"),
|
|
}...)
|
|
}
|
|
|
|
// Every release before Quincy will enable PG auto repair on Bluestore OSDs
|
|
if !cephVersion.IsAtLeastQuincy() {
|
|
overrides = append(overrides, []Option{
|
|
configOverride("global", "osd scrub auto repair", "true"),
|
|
}...)
|
|
}
|
|
|
|
return overrides
|
|
}
|
|
|
|
// DefaultLegacyConfigs need to be added to the Ceph config file until the integration tests can be
|
|
// made to override these options for the Ceph clusters it creates.
|
|
func DefaultLegacyConfigs() []Option {
|
|
overrides := []Option{
|
|
// TODO: move this under LegacyConfigs() when FlexVolume is no longer supported
|
|
configOverride("global", "rbd_default_features", "3"),
|
|
}
|
|
return overrides
|
|
}
|
|
|
|
// LegacyConfigs represents old configuration that were applied to a cluster and not needed anymore
|
|
func LegacyConfigs() []Option {
|
|
return []Option{
|
|
{Who: "global", Option: "log file"},
|
|
}
|
|
}
|