subhamkrai
536909a58b
this commit adds flag stripe_unit for the command
ceph osd erasure-code-profile set [flags]. This key
increase perfomance for ec pool. The default value
is 4kib/4096 bytes.
Signed-off-by: subhamkrai <srai@redhat.com>
(cherry picked from commit 9fb0582dd6)
100 lines
3.2 KiB
Go
100 lines
3.2 KiB
Go
/*
|
|
Copyright 2016 The Rook Authors. All rights reserved.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
package client
|
|
|
|
import (
|
|
"fmt"
|
|
"testing"
|
|
|
|
"github.com/pkg/errors"
|
|
cephv1 "github.com/rook/rook/pkg/apis/ceph.rook.io/v1"
|
|
exectest "github.com/rook/rook/pkg/util/exec/test"
|
|
"github.com/stretchr/testify/assert"
|
|
"k8s.io/apimachinery/pkg/api/resource"
|
|
|
|
"github.com/rook/rook/pkg/clusterd"
|
|
)
|
|
|
|
func TestCreateProfile(t *testing.T) {
|
|
testCreateProfile(t, "", "myroot", "")
|
|
}
|
|
|
|
func TestCreateProfileWithFailureDomain(t *testing.T) {
|
|
testCreateProfile(t, "osd", "", "")
|
|
}
|
|
|
|
func TestCreateProfileWithDeviceClass(t *testing.T) {
|
|
testCreateProfile(t, "osd", "", "hdd")
|
|
}
|
|
|
|
func testCreateProfile(t *testing.T, failureDomain, crushRoot, deviceClass string) {
|
|
stripeUnit := resource.MustParse("4Ki")
|
|
spec := cephv1.PoolSpec{
|
|
FailureDomain: failureDomain,
|
|
CrushRoot: crushRoot,
|
|
DeviceClass: deviceClass,
|
|
ErasureCoded: cephv1.ErasureCodedSpec{
|
|
DataChunks: 2,
|
|
CodingChunks: 3,
|
|
StripeUnit: &stripeUnit,
|
|
},
|
|
}
|
|
|
|
executor := &exectest.MockExecutor{}
|
|
context := &clusterd.Context{Executor: executor}
|
|
executor.MockExecuteCommandWithOutput = func(command string, args ...string) (string, error) {
|
|
logger.Infof("Command: %s %v", command, args)
|
|
if args[1] == "erasure-code-profile" {
|
|
if args[2] == "get" {
|
|
assert.Equal(t, "default", args[3])
|
|
return `{"plugin":"myplugin","technique":"t"}`, nil
|
|
}
|
|
if args[2] == "set" {
|
|
assert.Equal(t, "myapp", args[3])
|
|
assert.Equal(t, "--force", args[4])
|
|
assert.Equal(t, fmt.Sprintf("k=%d", spec.ErasureCoded.DataChunks), args[5])
|
|
assert.Equal(t, fmt.Sprintf("m=%d", spec.ErasureCoded.CodingChunks), args[6])
|
|
assert.Equal(t, "plugin=myplugin", args[7])
|
|
assert.Equal(t, "technique=t", args[8])
|
|
nextArg := 9
|
|
if failureDomain != "" {
|
|
assert.Equal(t, fmt.Sprintf("crush-failure-domain=%s", failureDomain), args[nextArg])
|
|
nextArg++
|
|
}
|
|
if crushRoot != "" {
|
|
assert.Equal(t, fmt.Sprintf("crush-root=%s", crushRoot), args[nextArg])
|
|
nextArg++
|
|
}
|
|
if deviceClass != "" {
|
|
assert.Equal(t, fmt.Sprintf("crush-device-class=%s", deviceClass), args[nextArg])
|
|
nextArg++
|
|
}
|
|
if spec.ErasureCoded.StripeUnit != nil && !spec.ErasureCoded.StripeUnit.IsZero() {
|
|
stripeBytes, ok := spec.ErasureCoded.StripeUnit.AsInt64()
|
|
assert.True(t, ok)
|
|
assert.Equal(t, fmt.Sprintf("stripe_unit=%d", stripeBytes), args[nextArg])
|
|
assert.Equal(t, stripeBytes, int64(4096), "Validate the resource conversion to bytes")
|
|
}
|
|
return "", nil
|
|
}
|
|
}
|
|
return "", errors.Errorf("unexpected ceph command %q", args)
|
|
}
|
|
|
|
err := CreateErasureCodeProfile(context, AdminTestClusterInfo("mycluster"), "myapp", spec)
|
|
assert.Nil(t, err)
|
|
}
|