forked from rook/rook
Rook does not support running multiple clusters in the same namespace, so the operator should not reconcile if a new cluster is added. The scenario where a cluster is added while the operator is down is also handled. CR updates are also handled. When the operator detects more than one cluster it will refuse to reconcile the CephCluster, and child CRDs will block too until the operator is ready. The user must remove one of the clusters before can continue to perform any reconcile. Closes: https://github.com/rook/rook/issues/9452 Signed-off-by: Sébastien Han <seb@redhat.com>
178 lines
5.8 KiB
Go
178 lines
5.8 KiB
Go
/*
|
|
Copyright 2020 The Rook Authors. All rights reserved.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
// Package cluster to manage a Ceph cluster.
|
|
package cluster
|
|
|
|
import (
|
|
"context"
|
|
|
|
"github.com/google/go-cmp/cmp"
|
|
cephv1 "github.com/rook/rook/pkg/apis/ceph.rook.io/v1"
|
|
"github.com/rook/rook/pkg/clusterd"
|
|
discoverDaemon "github.com/rook/rook/pkg/daemon/discover"
|
|
"github.com/rook/rook/pkg/operator/ceph/controller"
|
|
"github.com/rook/rook/pkg/operator/k8sutil"
|
|
corev1 "k8s.io/api/core/v1"
|
|
"k8s.io/apimachinery/pkg/api/resource"
|
|
"k8s.io/apimachinery/pkg/runtime"
|
|
"sigs.k8s.io/controller-runtime/pkg/client"
|
|
"sigs.k8s.io/controller-runtime/pkg/event"
|
|
"sigs.k8s.io/controller-runtime/pkg/predicate"
|
|
)
|
|
|
|
// predicateForNodeWatcher is the predicate function to trigger reconcile on Node events
|
|
func predicateForNodeWatcher(client client.Client, context *clusterd.Context) predicate.Funcs {
|
|
return predicate.Funcs{
|
|
CreateFunc: func(e event.CreateEvent) bool {
|
|
clientCluster := newClientCluster(client, e.Object.GetNamespace(), context)
|
|
return clientCluster.onK8sNode(e.Object)
|
|
},
|
|
|
|
UpdateFunc: func(e event.UpdateEvent) bool {
|
|
clientCluster := newClientCluster(client, e.ObjectNew.GetNamespace(), context)
|
|
return clientCluster.onK8sNode(e.ObjectNew)
|
|
},
|
|
|
|
DeleteFunc: func(e event.DeleteEvent) bool {
|
|
return false
|
|
},
|
|
|
|
GenericFunc: func(e event.GenericEvent) bool {
|
|
return false
|
|
},
|
|
}
|
|
}
|
|
|
|
// predicateForHotPlugCMWatcher is the predicate function to trigger reconcile on ConfigMap events (hot-plug)
|
|
func predicateForHotPlugCMWatcher(client client.Client) predicate.Funcs {
|
|
return predicate.Funcs{
|
|
UpdateFunc: func(e event.UpdateEvent) bool {
|
|
isHotPlugCM := isHotPlugCM(e.ObjectNew)
|
|
if !isHotPlugCM {
|
|
logger.Debugf("hot-plug cm watcher: only reconcile on hot plug cm changes, this %q cm is handled by another watcher", e.ObjectNew.GetName())
|
|
return false
|
|
}
|
|
|
|
clientCluster := newClientCluster(client, e.ObjectNew.GetNamespace(), &clusterd.Context{})
|
|
return clientCluster.onDeviceCMUpdate(e.ObjectOld, e.ObjectNew)
|
|
},
|
|
|
|
DeleteFunc: func(e event.DeleteEvent) bool {
|
|
// TODO: if the configmap goes away we could retrigger rook-discover DS
|
|
// However at this point the returned bool can only trigger a reconcile of the CephCluster object
|
|
// Definitely non-trivial but nice to have in the future
|
|
return false
|
|
},
|
|
|
|
CreateFunc: func(e event.CreateEvent) bool {
|
|
return false
|
|
},
|
|
|
|
GenericFunc: func(e event.GenericEvent) bool {
|
|
return false
|
|
},
|
|
}
|
|
}
|
|
|
|
// isHotPlugCM informs whether the object is the cm for hot-plug disk
|
|
func isHotPlugCM(obj runtime.Object) bool {
|
|
// If not a ConfigMap, let's not reconcile
|
|
cm, ok := obj.(*corev1.ConfigMap)
|
|
if !ok {
|
|
return false
|
|
}
|
|
|
|
// Get the labels
|
|
labels := cm.GetLabels()
|
|
|
|
labelVal, labelKeyExist := labels[k8sutil.AppAttr]
|
|
if labelKeyExist && labelVal == discoverDaemon.AppName {
|
|
return true
|
|
}
|
|
|
|
return false
|
|
}
|
|
|
|
func watchControllerPredicate(ctx context.Context, c client.Client) predicate.Funcs {
|
|
return predicate.Funcs{
|
|
CreateFunc: func(e event.CreateEvent) bool {
|
|
if controller.DuplicateCephClusters(ctx, c, e.Object, true) {
|
|
return false
|
|
}
|
|
logger.Debug("create event from a CR")
|
|
return true
|
|
},
|
|
DeleteFunc: func(e event.DeleteEvent) bool {
|
|
logger.Debug("delete event from a CR")
|
|
return true
|
|
},
|
|
UpdateFunc: func(e event.UpdateEvent) bool {
|
|
// We still need to check on update event since the user must delete the additional CR
|
|
// Until this is done, the user can still update the CR and the operator will reconcile
|
|
// This should not happen
|
|
if controller.DuplicateCephClusters(ctx, c, e.ObjectOld, true) {
|
|
return false
|
|
}
|
|
|
|
// resource.Quantity has non-exportable fields, so we use its comparator method
|
|
resourceQtyComparer := cmp.Comparer(func(x, y resource.Quantity) bool { return x.Cmp(y) == 0 })
|
|
|
|
switch objOld := e.ObjectOld.(type) {
|
|
case *cephv1.CephCluster:
|
|
objNew := e.ObjectNew.(*cephv1.CephCluster)
|
|
logger.Debug("update event on CephCluster CR")
|
|
// If the labels "do_not_reconcile" is set on the object, let's not reconcile that request
|
|
isDoNotReconcile := controller.IsDoNotReconcile(objNew.GetLabels())
|
|
if isDoNotReconcile {
|
|
logger.Debugf("object %q matched on update but %q label is set, doing nothing", controller.DoNotReconcileLabelName, objNew.Name)
|
|
return false
|
|
}
|
|
diff := cmp.Diff(objOld.Spec, objNew.Spec, resourceQtyComparer)
|
|
if diff != "" {
|
|
logger.Infof("CR has changed for %q. diff=%s", objNew.Name, diff)
|
|
|
|
if objNew.Spec.CleanupPolicy.HasDataDirCleanPolicy() {
|
|
logger.Infof("skipping orchestration for cluster object %q in namespace %q because its cleanup policy is set. not reloading the manager", objNew.GetName(), objNew.GetNamespace())
|
|
return false
|
|
}
|
|
|
|
// Stop any ongoing orchestration
|
|
controller.ReloadManager()
|
|
|
|
return false
|
|
|
|
} else if !objOld.GetDeletionTimestamp().Equal(objNew.GetDeletionTimestamp()) {
|
|
logger.Infof("CR %q is going be deleted, cancelling any ongoing orchestration", objNew.Name)
|
|
|
|
// Stop any ongoing orchestration
|
|
controller.ReloadManager()
|
|
|
|
return false
|
|
|
|
} else if objOld.GetGeneration() != objNew.GetGeneration() {
|
|
logger.Debugf("skipping resource %q update with unchanged spec", objNew.Name)
|
|
}
|
|
}
|
|
|
|
return false
|
|
},
|
|
GenericFunc: func(e event.GenericEvent) bool {
|
|
return false
|
|
},
|
|
}
|
|
}
|