Files
my-rook-config/pkg/daemon/discover/discover.go
T
Noah Watkins 3966f163ed discover: handle false-positives observed by users
the only exception to a naive device list comparison had been to ignore
drive UUID information which was unreliable when a device wasn't
formatted / partitioned. however various users have reported different
type of false positives that resulted in orchestration being run
continuously due to the wrong observation that devices were changing.

this patch fixes the cases we have observed and attempts to be slightly
more conservative in the calculation.

1. the devlinks is ignored. when a device is setup for lvm, for example,
the devlinks will be updated with different paths that point to the
device in addition to its standard paths addressable by pci address.

2. in the lvm case, the "model" field and "filesystem" field may also
change.

3. we ignore devices with devlinks that contain "usb" to avoid issues
when using usb drives.

4. be smart about detecting device availability. if a device transitions
from a non-empty (or has-partitions) state to an empty (or unpartitioned)
state then orchestration is triggered. this like observing that a device
is now available (e.g. in the allDevices case). however, when a device
transistions from empty to non-empty, then this is ignored as while it
is a change, it's generally a change associated with the new consumption
of the device.

fixes: #3059
fixes: #3185
fixes: #3131

Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
2019-06-07 08:22:08 -07:00

380 lines
9.9 KiB
Go

/*
Copyright 2018 The Rook Authors. All rights reserved.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
// Package discover to discover unused devices.
package discover
import (
"bufio"
"encoding/json"
"fmt"
"os"
"os/exec"
"os/signal"
"regexp"
"strings"
"syscall"
"time"
"github.com/coreos/pkg/capnslog"
"github.com/rook/rook/pkg/clusterd"
"github.com/rook/rook/pkg/operator/k8sutil"
"github.com/rook/rook/pkg/util/sys"
"k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/api/errors"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
)
var (
logger = capnslog.NewPackageLogger("github.com/rook/rook", "rook-discover")
AppName = "rook-discover"
NodeAttr = "rook.io/node"
LocalDiskCMData = "devices"
LocalDiskCMName = "local-device-%s"
nodeName string
namespace string
lastDevice string
cmName string
cm *v1.ConfigMap
udevEventPeriod = time.Duration(5) * time.Second
)
func Run(context *clusterd.Context, probeInterval time.Duration) error {
if context == nil {
return fmt.Errorf("nil context")
}
logger.Infof("device discovery interval is %s", probeInterval.String())
nodeName = os.Getenv(k8sutil.NodeNameEnvVar)
namespace = os.Getenv(k8sutil.PodNamespaceEnvVar)
cmName = k8sutil.TruncateNodeName(LocalDiskCMName, nodeName)
sigc := make(chan os.Signal, 1)
signal.Notify(sigc, syscall.SIGTERM)
err := updateDeviceCM(context)
if err != nil {
logger.Infof("failed to update device configmap: %v", err)
return err
}
udevEvents := make(chan string)
go udevBlockMonitor(udevEvents, udevEventPeriod)
for {
select {
case <-sigc:
logger.Infof("shutdown signal received, exiting...")
return nil
case <-time.After(probeInterval):
updateDeviceCM(context)
case _, ok := <-udevEvents:
if ok {
logger.Info("trigger probe from udev event")
updateDeviceCM(context)
} else {
logger.Warningf("disabling udev monitoring")
udevEvents = nil
}
}
}
}
func matchUdevEvent(text string, matches, exclusions []string) (bool, error) {
for _, match := range matches {
matched, err := regexp.MatchString(match, text)
if err != nil {
return false, fmt.Errorf("failed to search string: %v", err)
}
if matched {
hasExclusion := false
for _, exclusion := range exclusions {
matched, err = regexp.MatchString(exclusion, text)
if err != nil {
return false, fmt.Errorf("failed to search string: %v", err)
}
if matched {
hasExclusion = true
break
}
}
if !hasExclusion {
logger.Infof("udevadm monitor: matched event: %s", text)
return true, nil
}
}
}
return false, nil
}
// Scans `udevadm monitor` output for block sub-system events. Each line of
// output matching a set of substrings is sent to the provided channel. An event
// is returned if it passes any matches tests, and passes all exclusion tests.
func rawUdevBlockMonitor(c chan string, matches, exclusions []string) {
defer close(c)
// stdbuf -oL performs line bufferred output
cmd := exec.Command("stdbuf", "-oL", "udevadm", "monitor", "-u", "-k", "-s", "block")
stdout, err := cmd.StdoutPipe()
if err != nil {
logger.Warningf("Cannot open udevadm stdout: %v", err)
return
}
err = cmd.Start()
if err != nil {
logger.Warningf("Cannot start udevadm monitoring: %v", err)
return
}
scanner := bufio.NewScanner(stdout)
for scanner.Scan() {
text := scanner.Text()
logger.Debugf("udevadm monitor: %s", text)
match, err := matchUdevEvent(text, matches, exclusions)
if err != nil {
logger.Warningf("udevadm filtering failed: %v", err)
return
}
if match {
c <- text
}
}
if err := scanner.Err(); err != nil {
logger.Warningf("udevadm monitor scanner error: %v", err)
}
logger.Info("udevadm monitor finished")
}
// Monitors udev for block device changes, and collapses these events such that
// only one event is emitted per period in order to deal with flapping.
func udevBlockMonitor(c chan string, period time.Duration) {
defer close(c)
// return any add or remove events, but none that match device mapper
// events. string matching is case-insensitve
events := make(chan string)
go rawUdevBlockMonitor(events,
[]string{"(?i)add", "(?i)remove"},
[]string{"(?i)dm-[0-9]+", "(?i)rbd[0-9]+"})
for {
event, ok := <-events
if !ok {
return
}
timeout := time.NewTimer(period)
for {
select {
case <-timeout.C:
break
case _, ok := <-events:
if !ok {
return
}
continue
}
break
}
c <- event
}
}
func ignoreDevice(dev sys.LocalDisk) bool {
return strings.Contains(strings.ToUpper(dev.DevLinks), "USB")
}
func checkMatchingDevice(checkDev sys.LocalDisk, devices []sys.LocalDisk) *sys.LocalDisk {
for i, dev := range devices {
if ignoreDevice(dev) {
continue
}
// check if devices should be considered the same. the uuid can be
// unstable, so we also use the reported serial and device name, which
// appear to be more stable.
if checkDev.UUID == dev.UUID {
return &devices[i]
}
// on virt-io devices in libvirt, the serial is reported as an empty
// string, so also account for that.
if checkDev.Serial == dev.Serial && checkDev.Serial != "" {
return &devices[i]
}
if checkDev.Name == dev.Name {
return &devices[i]
}
}
return nil
}
// note that the idea of equality here may not be intuitive. equality of device
// sets refers to a state in which no change has been observed between the sets
// of devices that would warrant changes to their consumption by storage
// daemons. for example, if a device appears to have been wiped vs a device
// appears to now be in use.
func checkDeviceListsEqual(oldDevs, newDevs []sys.LocalDisk) bool {
for _, oldDev := range oldDevs {
if ignoreDevice(oldDev) {
continue
}
match := checkMatchingDevice(oldDev, newDevs)
if match == nil {
// device has been removed
return false
}
if !oldDev.Empty && match.Empty {
// device has changed from non-empty to empty
return false
}
if oldDev.Partitions != nil && match.Partitions == nil {
return false
}
}
for _, newDev := range newDevs {
if ignoreDevice(newDev) {
continue
}
match := checkMatchingDevice(newDev, oldDevs)
if match == nil {
// device has been added
return false
}
// the matching case is handled in the previous join
}
return true
}
func DeviceListsEqual(old, new string) (bool, error) {
var oldDevs []sys.LocalDisk
var newDevs []sys.LocalDisk
err := json.Unmarshal([]byte(old), &oldDevs)
if err != nil {
return false, fmt.Errorf("cannot unmarshal devices: %+v", err)
}
err = json.Unmarshal([]byte(new), &newDevs)
if err != nil {
return false, fmt.Errorf("cannot unmarshal devices: %+v", err)
}
return checkDeviceListsEqual(oldDevs, newDevs), nil
}
func updateDeviceCM(context *clusterd.Context) error {
logger.Infof("updating device configmap")
devices, err := probeDevices(context)
if err != nil {
logger.Infof("failed to probe devices: %v", err)
return err
}
deviceJson, err := json.Marshal(devices)
if err != nil {
logger.Infof("failed to marshal: %v", err)
return err
}
deviceStr := string(deviceJson)
if cm == nil {
cm, err = context.Clientset.CoreV1().ConfigMaps(namespace).Get(cmName, metav1.GetOptions{})
}
if err == nil {
lastDevice = cm.Data[LocalDiskCMData]
logger.Debugf("last devices %s", lastDevice)
} else {
if !errors.IsNotFound(err) {
logger.Infof("failed to get configmap: %v", err)
return err
}
data := make(map[string]string, 1)
data[LocalDiskCMData] = deviceStr
// the map doesn't exist yet, create it now
cm = &v1.ConfigMap{
ObjectMeta: metav1.ObjectMeta{
Name: cmName,
Namespace: namespace,
Labels: map[string]string{
k8sutil.AppAttr: AppName,
NodeAttr: nodeName,
},
},
Data: data,
}
cm, err = context.Clientset.CoreV1().ConfigMaps(namespace).Create(cm)
if err != nil {
logger.Infof("failed to create configmap: %v", err)
return fmt.Errorf("failed to create local device map %s: %+v", cmName, err)
}
lastDevice = deviceStr
}
devicesEqual, err := DeviceListsEqual(lastDevice, deviceStr)
if err != nil {
return fmt.Errorf("failed to compare device lists: %v", err)
}
if !devicesEqual {
data := make(map[string]string, 1)
data[LocalDiskCMData] = deviceStr
cm.Data = data
cm, err = context.Clientset.CoreV1().ConfigMaps(namespace).Update(cm)
if err != nil {
logger.Infof("failed to update configmap %s: %v", cmName, err)
return err
}
}
return nil
}
func probeDevices(context *clusterd.Context) ([]sys.LocalDisk, error) {
devices := make([]sys.LocalDisk, 0)
localDevices, err := clusterd.DiscoverDevices(context.Executor)
if err != nil {
return devices, fmt.Errorf("failed initial hardware discovery. %+v", err)
}
for _, device := range localDevices {
if device == nil {
continue
}
if device.Type == sys.PartType {
continue
}
partitions, _, err := sys.GetDevicePartitions(device.Name, context.Executor)
if err != nil {
logger.Infof("failed to check device partitions %s: %v", device.Name, err)
continue
}
// check if there is a file system on the device
fs, err := sys.GetDeviceFilesystems(device.Name, context.Executor)
if err != nil {
logger.Infof("failed to check device filesystem %s: %v", device.Name, err)
continue
}
device.Partitions = partitions
device.Filesystem = fs
device.Empty = clusterd.GetDeviceEmpty(device)
devices = append(devices, *device)
}
logger.Infof("available devices: %+v", devices)
return devices, nil
}