forked from rook/rook
travisn
c6c4a9b42a
When the operator first starts, the only operation needed is to watch for new cephcluster crds to be created and start the discovery to find available devices. The flexvolume agent, the csi driver, and the volume provisioning can all be delayed starting until the first cluster is created. Signed-off-by: travisn <tnielsen@redhat.com>
239 lines
8.8 KiB
Go
239 lines
8.8 KiB
Go
/*
|
|
Copyright 2016 The Rook Authors. All rights reserved.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package cluster
|
|
|
|
import (
|
|
"fmt"
|
|
"os"
|
|
"testing"
|
|
"time"
|
|
|
|
cephv1 "github.com/rook/rook/pkg/apis/ceph.rook.io/v1"
|
|
cephbeta "github.com/rook/rook/pkg/apis/ceph.rook.io/v1beta1"
|
|
rookalpha "github.com/rook/rook/pkg/apis/rook.io/v1alpha2"
|
|
rookfake "github.com/rook/rook/pkg/client/clientset/versioned/fake"
|
|
"github.com/rook/rook/pkg/clusterd"
|
|
"github.com/rook/rook/pkg/daemon/ceph/agent/flexvolume/attachment"
|
|
"github.com/rook/rook/pkg/operator/ceph/cluster/mon"
|
|
"github.com/rook/rook/pkg/operator/k8sutil"
|
|
testop "github.com/rook/rook/pkg/operator/test"
|
|
exectest "github.com/rook/rook/pkg/util/exec/test"
|
|
"github.com/stretchr/testify/assert"
|
|
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
|
|
)
|
|
|
|
func TestCreateInitialCrushMap(t *testing.T) {
|
|
clientset := testop.New(3)
|
|
executor := &exectest.MockExecutor{}
|
|
context := &clusterd.Context{Clientset: clientset, Executor: executor}
|
|
c := newCluster(&cephv1.CephCluster{}, context)
|
|
c.Namespace = "rook294"
|
|
|
|
// create the initial crush map and verify that a configmap value was created that says the crush map was created
|
|
err := c.createInitialCrushMap()
|
|
assert.Nil(t, err)
|
|
cm, err := clientset.CoreV1().ConfigMaps(c.Namespace).Get(crushConfigMapName, metav1.GetOptions{})
|
|
assert.Nil(t, err)
|
|
assert.NotNil(t, cm)
|
|
assert.Equal(t, "1", cm.Data[crushmapCreatedKey])
|
|
|
|
// the crushmap should NOT get created again
|
|
executor.MockExecuteCommandWithOutputFile = func(debug bool, actionName string, command string, outFileArg string, args ...string) (string, error) {
|
|
return "", fmt.Errorf("crushmap was already created, we shouldn't be calling this again")
|
|
}
|
|
err = c.createInitialCrushMap()
|
|
assert.Nil(t, err)
|
|
}
|
|
|
|
func TestClusterDelete(t *testing.T) {
|
|
nodeName := "node841"
|
|
clusterName := "cluster684"
|
|
pvName := "pvc-540"
|
|
rookSystemNamespace := "rook-system-6413"
|
|
|
|
os.Setenv(k8sutil.PodNamespaceEnvVar, rookSystemNamespace)
|
|
defer os.Unsetenv(k8sutil.PodNamespaceEnvVar)
|
|
|
|
clientset := testop.New(3)
|
|
context := &clusterd.Context{
|
|
Clientset: clientset,
|
|
}
|
|
|
|
listCount := 0
|
|
volumeAttachmentController := &attachment.MockAttachment{
|
|
MockList: func(namespace string) (*rookalpha.VolumeList, error) {
|
|
listCount++
|
|
if listCount == 1 {
|
|
// first listing returns an existing volume attachment, so the controller should wait
|
|
return &rookalpha.VolumeList{
|
|
Items: []rookalpha.Volume{
|
|
{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: pvName,
|
|
Namespace: rookSystemNamespace,
|
|
},
|
|
Attachments: []rookalpha.Attachment{
|
|
{
|
|
Node: nodeName,
|
|
ClusterName: clusterName,
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}, nil
|
|
}
|
|
|
|
// subsequent listings should return no volume attachments, meaning that they have all
|
|
// been cleaned up and the controller can move on.
|
|
return &rookalpha.VolumeList{Items: []rookalpha.Volume{}}, nil
|
|
|
|
},
|
|
}
|
|
callback := func() error {
|
|
logger.Infof("test success callback")
|
|
return nil
|
|
}
|
|
|
|
// create the cluster controller and tell it that the cluster has been deleted
|
|
controller := NewClusterController(context, "", volumeAttachmentController, callback)
|
|
clusterToDelete := &cephv1.CephCluster{ObjectMeta: metav1.ObjectMeta{Namespace: clusterName}}
|
|
controller.handleDelete(clusterToDelete, time.Microsecond)
|
|
|
|
// listing of volume attachments should have been called twice. the first time there were volume attachments
|
|
// that the controller needed to wait on to be cleaned up and the second time they were all cleaned up.
|
|
assert.Equal(t, 2, listCount)
|
|
}
|
|
|
|
func TestClusterChanged(t *testing.T) {
|
|
// a new node added, should be a change
|
|
old := cephv1.ClusterSpec{
|
|
Storage: rookalpha.StorageScopeSpec{
|
|
Nodes: []rookalpha.Node{
|
|
{Name: "node1", Selection: rookalpha.Selection{Devices: []rookalpha.Device{{Name: "sda"}}}},
|
|
},
|
|
},
|
|
}
|
|
new := cephv1.ClusterSpec{
|
|
Storage: rookalpha.StorageScopeSpec{
|
|
Nodes: []rookalpha.Node{
|
|
{Name: "node1", Selection: rookalpha.Selection{Devices: []rookalpha.Device{{Name: "sda"}}}},
|
|
{Name: "node2", Selection: rookalpha.Selection{Devices: []rookalpha.Device{{Name: "sda"}}}},
|
|
},
|
|
},
|
|
}
|
|
c := &cluster{Spec: &cephv1.ClusterSpec{}, mons: &mon.Cluster{}}
|
|
changed, diff := clusterChanged(old, new, c)
|
|
assert.True(t, changed)
|
|
assert.Equal(t, "{v1.ClusterSpec}.Storage.Nodes[?->1]:\n\t-: <non-existent>\n\t+: v1alpha2.Node{Name: \"node2\", Selection: v1alpha2.Selection{Devices: []v1alpha2.Device{{Name: \"sda\"}}}}\n", diff)
|
|
assert.Equal(t, 0, c.Spec.Mon.Count)
|
|
|
|
// a node was removed, should be a change
|
|
old.Storage.Nodes = []rookalpha.Node{
|
|
{Name: "node1", Selection: rookalpha.Selection{Devices: []rookalpha.Device{{Name: "sda"}}}},
|
|
{Name: "node2", Selection: rookalpha.Selection{Devices: []rookalpha.Device{{Name: "sda"}}}},
|
|
}
|
|
new.Storage.Nodes = []rookalpha.Node{
|
|
{Name: "node1", Selection: rookalpha.Selection{Devices: []rookalpha.Device{{Name: "sda"}}}},
|
|
}
|
|
changed, diff = clusterChanged(old, new, c)
|
|
assert.True(t, changed)
|
|
assert.Equal(t, "{v1.ClusterSpec}.Storage.Nodes[1->?]:\n\t-: v1alpha2.Node{Name: \"node2\", Selection: v1alpha2.Selection{Devices: []v1alpha2.Device{{Name: \"sda\"}}}}\n\t+: <non-existent>\n", diff)
|
|
|
|
// the nodes being in a different order should not be a change
|
|
old.Storage.Nodes = []rookalpha.Node{
|
|
{Name: "node1", Selection: rookalpha.Selection{Devices: []rookalpha.Device{{Name: "sda"}}}},
|
|
{Name: "node2", Selection: rookalpha.Selection{Devices: []rookalpha.Device{{Name: "sda"}}}},
|
|
}
|
|
new.Storage.Nodes = []rookalpha.Node{
|
|
{Name: "node2", Selection: rookalpha.Selection{Devices: []rookalpha.Device{{Name: "sda"}}}},
|
|
{Name: "node1", Selection: rookalpha.Selection{Devices: []rookalpha.Device{{Name: "sda"}}}},
|
|
}
|
|
changed, diff = clusterChanged(old, new, c)
|
|
assert.False(t, changed)
|
|
assert.Equal(t, 0, c.Spec.Mon.Count)
|
|
assert.Equal(t, "", diff)
|
|
|
|
// If the number of mons changes, the cluster would be updated
|
|
new.Mon.Count = 3
|
|
new.Mon.AllowMultiplePerNode = true
|
|
changed, diff = clusterChanged(old, new, c)
|
|
assert.True(t, changed)
|
|
assert.Equal(t, "{v1.ClusterSpec}.Mon.Count:\n\t-: 0\n\t+: 3\n{v1.ClusterSpec}.Mon.AllowMultiplePerNode:\n\t-: false\n\t+: true\n", diff)
|
|
}
|
|
|
|
func TestRemoveFinalizer(t *testing.T) {
|
|
clientset := testop.New(3)
|
|
context := &clusterd.Context{
|
|
Clientset: clientset,
|
|
RookClientset: rookfake.NewSimpleClientset(),
|
|
}
|
|
callback := func() error {
|
|
return fmt.Errorf("test failed callback")
|
|
}
|
|
controller := NewClusterController(context, "", &attachment.MockAttachment{}, callback)
|
|
|
|
// *****************************************
|
|
// start with a current version ceph cluster
|
|
// *****************************************
|
|
cluster := &cephv1.CephCluster{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: "cluster-1893",
|
|
Namespace: "namespace-6551",
|
|
Finalizers: []string{finalizerName},
|
|
},
|
|
}
|
|
|
|
// create the cluster initially so it exists in the k8s api
|
|
cluster, err := context.RookClientset.CephV1().CephClusters(cluster.Namespace).Create(cluster)
|
|
assert.NoError(t, err)
|
|
assert.Len(t, cluster.Finalizers, 1)
|
|
|
|
// remove the finalizer from the cluster object
|
|
controller.removeFinalizer(cluster)
|
|
|
|
// verify the finalizer was removed
|
|
cluster, err = context.RookClientset.CephV1().CephClusters(cluster.Namespace).Get(cluster.Name, metav1.GetOptions{})
|
|
assert.NoError(t, err)
|
|
assert.NotNil(t, cluster)
|
|
assert.Len(t, cluster.Finalizers, 0)
|
|
|
|
// ****************************************
|
|
// now try with with a legacy rook cluster
|
|
// ****************************************
|
|
legacyRookCluster := &cephbeta.Cluster{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: "cluster-6842",
|
|
Namespace: "namespace-9523",
|
|
Finalizers: []string{finalizerNameRookLegacy},
|
|
},
|
|
}
|
|
|
|
// create the cluster initially so it exists in the k8s api
|
|
legacyRookCluster, err = context.RookClientset.CephV1beta1().Clusters(legacyRookCluster.Namespace).Create(legacyRookCluster)
|
|
assert.NoError(t, err)
|
|
assert.Len(t, legacyRookCluster.Finalizers, 1)
|
|
|
|
// remove the finalizer from the cluster object
|
|
controller.removeFinalizer(legacyRookCluster)
|
|
|
|
// verify the finalizer was removed
|
|
legacyRookCluster, err = context.RookClientset.CephV1beta1().Clusters(legacyRookCluster.Namespace).Get(legacyRookCluster.Name, metav1.GetOptions{})
|
|
assert.NoError(t, err)
|
|
assert.NotNil(t, legacyRookCluster)
|
|
assert.Len(t, legacyRookCluster.Finalizers, 0)
|
|
}
|