Files
my-rook-config/pkg/daemon/ceph/client/mgr_test.go
T
Sébastien Han 362637ec3d ceph: do not explicitly turn on the balancer
As of Pacific the balancer is now on by default in upmap mode.
In earlier versions, the balancer was included in the `always_on_modules` list, but needed to be
turned on explicitly using the ``ceph balancer on command.

Signed-off-by: Sébastien Han <seb@redhat.com>
2021-01-08 17:20:47 +01:00

146 lines
4.9 KiB
Go

/*
Copyright 2019 The Rook Authors. All rights reserved.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package client
import (
"testing"
"github.com/pkg/errors"
"github.com/rook/rook/pkg/clusterd"
"github.com/rook/rook/pkg/operator/ceph/version"
exectest "github.com/rook/rook/pkg/util/exec/test"
"github.com/stretchr/testify/assert"
)
func TestEnableModuleRetries(t *testing.T) {
moduleEnableRetries := 0
moduleEnableWaitTime = 0
executor := &exectest.MockExecutor{}
executor.MockExecuteCommandWithOutputFile = func(command, outputFile string, args ...string) (string, error) {
logger.Infof("Command: %s %v", command, args)
switch {
case args[0] == "balancer" && args[1] == "on":
return "", nil
case args[0] == "mgr" && args[1] == "module" && args[2] == "enable":
if args[3] == "prometheus" || args[3] == "pg_autoscaler" || args[3] == "crash" {
return "", nil
}
case args[0] == "mgr" && args[1] == "module" && args[2] == "disable":
if args[3] == "prometheus" || args[3] == "pg_autoscaler" || args[3] == "crash" {
return "", nil
}
}
moduleEnableRetries = moduleEnableRetries + 1
return "", errors.Errorf("unexpected ceph command %q", args)
}
clusterInfo := AdminClusterInfo("mycluster")
_ = MgrEnableModule(&clusterd.Context{Executor: executor}, clusterInfo, "invalidModuleName", false)
assert.Equal(t, 5, moduleEnableRetries)
moduleEnableRetries = 0
_ = MgrEnableModule(&clusterd.Context{Executor: executor}, clusterInfo, "pg_autoscaler", false)
assert.Equal(t, 0, moduleEnableRetries)
// Balancer not on Ceph Pacific
moduleEnableRetries = 0
_ = MgrEnableModule(&clusterd.Context{Executor: executor}, clusterInfo, "balancer", false)
assert.Equal(t, 0, moduleEnableRetries)
// Balancer skipped on Pacific
clusterInfo.CephVersion = version.Pacific
_ = MgrEnableModule(&clusterd.Context{Executor: executor}, clusterInfo, "balancer", false)
assert.Equal(t, 0, moduleEnableRetries)
}
func TestEnableModule(t *testing.T) {
executor := &exectest.MockExecutor{}
executor.MockExecuteCommandWithOutputFile = func(command, outputFile string, args ...string) (string, error) {
logger.Infof("Command: %s %v", command, args)
switch {
case args[0] == "mgr" && args[1] == "module" && args[2] == "enable":
if args[3] == "prometheus" || args[3] == "pg_autoscaler" || args[3] == "crash" {
return "", nil
}
case args[0] == "mgr" && args[1] == "module" && args[2] == "disable":
if args[3] == "prometheus" || args[3] == "pg_autoscaler" || args[3] == "crash" {
return "", nil
}
}
return "", errors.Errorf("unexpected ceph command %q", args)
}
clusterInfo := AdminClusterInfo("mycluster")
err := enableModule(&clusterd.Context{Executor: executor}, clusterInfo, "pg_autoscaler", true, "enable")
assert.NoError(t, err)
err = enableModule(&clusterd.Context{Executor: executor}, clusterInfo, "prometheus", true, "disable")
assert.NoError(t, err)
err = enableModule(&clusterd.Context{Executor: executor}, clusterInfo, "invalidModuleName", false, "enable")
assert.Error(t, err)
err = enableModule(&clusterd.Context{Executor: executor}, clusterInfo, "pg_autoscaler", false, "invalidCommandArgs")
assert.Error(t, err)
}
func TestEnableDisableBalancerModule(t *testing.T) {
executor := &exectest.MockExecutor{}
executor.MockExecuteCommandWithOutputFile = func(command, outputFile string, args ...string) (string, error) {
logger.Infof("Command: %s %v", command, args)
switch {
case args[0] == "balancer" && args[1] == "on":
return "", nil
case args[0] == "balancer" && args[1] == "off":
return "", nil
}
return "", errors.Errorf("unexpected ceph command %q", args)
}
clusterInfo := AdminClusterInfo("mycluster")
err := enableDisableBalancerModule(&clusterd.Context{Executor: executor}, clusterInfo, "on")
assert.NoError(t, err)
err = enableDisableBalancerModule(&clusterd.Context{Executor: executor}, clusterInfo, "off")
assert.NoError(t, err)
}
func TestSetBalancerMode(t *testing.T) {
executor := &exectest.MockExecutor{}
executor.MockExecuteCommandWithOutputFile = func(command, outputFile string, args ...string) (string, error) {
logger.Infof("Command: %s %v", command, args)
if args[0] == "balancer" && args[1] == "mode" && args[2] == "upmap" {
return "", nil
}
return "", errors.Errorf("unexpected ceph command %q", args)
}
err := setBalancerMode(&clusterd.Context{Executor: executor}, AdminClusterInfo("mycluster"), "upmap")
assert.NoError(t, err)
}