forked from rook/rook
subhamkrai
dd7a1a895a
adding fields `TotalBytes`, `UsedBytes`, `AvailableBytes`
`LastUpdated` to the ceph cluster CR's status section to
report the storage details of ceph cluster.
`TotalBytes`: Total storage capacity in bytes
`UsedBytes`: Total storage used in bytes
`AvailableBytes`: Total storage used in bytes(Total - Used)
`LastUpdated`: Last update time
for example(I have added 10GB disk):
`kubectl get cephclusters.ceph.rook.io -o yaml`
```
status:
ceph:
capacity:
bytesAvailable: 9657188352
bytesTotal: 10733223936
bytesUsed: 1076035584
lastUpdated: "2020-10-23T12:57:48Z"
```
Signed-off-by: subhamkrai <srai@redhat.com>
200 lines
8.6 KiB
Go
200 lines
8.6 KiB
Go
/*
|
|
Copyright 2019 The Rook Authors. All rights reserved.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
// Package cluster to manage Kubernetes storage.
|
|
package cluster
|
|
|
|
import (
|
|
"reflect"
|
|
"testing"
|
|
"time"
|
|
|
|
cephv1 "github.com/rook/rook/pkg/apis/ceph.rook.io/v1"
|
|
"github.com/rook/rook/pkg/clusterd"
|
|
"github.com/rook/rook/pkg/daemon/ceph/client"
|
|
cephclient "github.com/rook/rook/pkg/daemon/ceph/client"
|
|
"github.com/stretchr/testify/assert"
|
|
controllerclient "sigs.k8s.io/controller-runtime/pkg/client"
|
|
)
|
|
|
|
func TestCephStatus(t *testing.T) {
|
|
newStatus := &cephclient.CephStatus{
|
|
Health: cephclient.HealthStatus{Status: "HEALTH_OK"},
|
|
}
|
|
|
|
// Empty initial status will have no previous health
|
|
currentStatus := cephv1.ClusterStatus{}
|
|
aggregateStatus := toCustomResourceStatus(currentStatus, newStatus)
|
|
assert.NotNil(t, aggregateStatus)
|
|
assert.Equal(t, "HEALTH_OK", aggregateStatus.Health)
|
|
assert.NotEqual(t, "", aggregateStatus.LastChecked)
|
|
assert.Equal(t, "", aggregateStatus.LastChanged)
|
|
assert.Equal(t, "", aggregateStatus.PreviousHealth)
|
|
assert.Equal(t, 0, len(aggregateStatus.Details))
|
|
|
|
// Set the current status to the same as the new status and there will be no previous health
|
|
currentStatus.CephStatus = &cephv1.CephStatus{
|
|
Health: "HEALTH_OK",
|
|
}
|
|
aggregateStatus = toCustomResourceStatus(currentStatus, newStatus)
|
|
assert.NotNil(t, aggregateStatus)
|
|
assert.Equal(t, "HEALTH_OK", aggregateStatus.Health)
|
|
assert.NotEqual(t, "", aggregateStatus.LastChecked)
|
|
assert.Equal(t, "", aggregateStatus.LastChanged)
|
|
assert.Equal(t, "", aggregateStatus.PreviousHealth)
|
|
assert.Equal(t, 0, len(aggregateStatus.Details))
|
|
|
|
// Set the new status to something different and we should get a previous health
|
|
// Simulate the previous check a minute ago.
|
|
previousTime := formatTime(time.Now().Add(-time.Minute).UTC())
|
|
currentStatus.CephStatus.LastChecked = previousTime
|
|
newStatus.Health.Status = "HEALTH_WARN"
|
|
aggregateStatus = toCustomResourceStatus(currentStatus, newStatus)
|
|
assert.NotNil(t, aggregateStatus)
|
|
assert.Equal(t, "HEALTH_WARN", aggregateStatus.Health)
|
|
assert.NotEqual(t, "", aggregateStatus.LastChecked)
|
|
assert.Equal(t, aggregateStatus.LastChecked, aggregateStatus.LastChanged)
|
|
assert.Equal(t, "HEALTH_OK", aggregateStatus.PreviousHealth)
|
|
assert.Equal(t, 0, len(aggregateStatus.Details))
|
|
|
|
// Add some details to the warning
|
|
osdDownMsg := cephclient.CheckMessage{Severity: "HEALTH_WARN"}
|
|
osdDownMsg.Summary.Message = "1 osd down"
|
|
pgAvailMsg := cephclient.CheckMessage{Severity: "HEALTH_ERR"}
|
|
pgAvailMsg.Summary.Message = "'Reduced data availability: 100 pgs stale'"
|
|
newStatus.Health.Checks = map[string]cephclient.CheckMessage{
|
|
"OSD_DOWN": osdDownMsg,
|
|
"PG_AVAILABILITY": pgAvailMsg,
|
|
}
|
|
newStatus.Health.Status = "HEALTH_ERR"
|
|
aggregateStatus = toCustomResourceStatus(currentStatus, newStatus)
|
|
assert.NotNil(t, aggregateStatus)
|
|
assert.Equal(t, "HEALTH_ERR", aggregateStatus.Health)
|
|
assert.NotEqual(t, "", aggregateStatus.LastChecked)
|
|
assert.Equal(t, aggregateStatus.LastChecked, aggregateStatus.LastChanged)
|
|
assert.Equal(t, "HEALTH_OK", aggregateStatus.PreviousHealth)
|
|
assert.Equal(t, 2, len(aggregateStatus.Details))
|
|
assert.Equal(t, osdDownMsg.Summary.Message, aggregateStatus.Details["OSD_DOWN"].Message)
|
|
assert.Equal(t, osdDownMsg.Severity, aggregateStatus.Details["OSD_DOWN"].Severity)
|
|
assert.Equal(t, pgAvailMsg.Summary.Message, aggregateStatus.Details["PG_AVAILABILITY"].Message)
|
|
assert.Equal(t, pgAvailMsg.Severity, aggregateStatus.Details["PG_AVAILABILITY"].Severity)
|
|
|
|
// Test for storage capacity of the ceph cluster when there is no disk
|
|
newStatus = &cephclient.CephStatus{
|
|
PgMap: cephclient.PgMap{TotalBytes: 0},
|
|
}
|
|
aggregateStatus = toCustomResourceStatus(currentStatus, newStatus)
|
|
assert.Equal(t, 0, int(aggregateStatus.Capacity.TotalBytes))
|
|
assert.Equal(t, "", aggregateStatus.Capacity.LastUpdated)
|
|
|
|
// Test for storage capacity of the ceph cluster when the disk of size 1024 bytes attached
|
|
newStatus = &cephclient.CephStatus{
|
|
PgMap: cephclient.PgMap{TotalBytes: 1024},
|
|
}
|
|
aggregateStatus = toCustomResourceStatus(currentStatus, newStatus)
|
|
assert.Equal(t, 1024, int(aggregateStatus.Capacity.TotalBytes))
|
|
assert.Equal(t, formatTime(time.Now().UTC()), aggregateStatus.Capacity.LastUpdated)
|
|
|
|
// Test for storage capacity of the ceph cluster when initially there is a disk of size
|
|
// 1024 bytes attached and then the disk is removed or newStatus.PgMap.TotalBytes is 0.
|
|
currentStatus.CephStatus.Capacity.TotalBytes = 1024
|
|
newStatus = &cephclient.CephStatus{
|
|
PgMap: cephclient.PgMap{TotalBytes: 0},
|
|
}
|
|
|
|
aggregateStatus = toCustomResourceStatus(currentStatus, newStatus)
|
|
assert.Equal(t, 1024, int(aggregateStatus.Capacity.TotalBytes))
|
|
assert.Equal(t, formatTime(time.Now().Add(-time.Minute).UTC()), formatTime(time.Now().Add(-time.Minute).UTC()))
|
|
}
|
|
|
|
func TestNewCephStatusChecker(t *testing.T) {
|
|
clusterInfo := client.AdminClusterInfo("ns")
|
|
c := &clusterd.Context{}
|
|
time10s, err := time.ParseDuration("10s")
|
|
assert.NoError(t, err)
|
|
|
|
type args struct {
|
|
context *clusterd.Context
|
|
clusterInfo *cephclient.ClusterInfo
|
|
clusterSpec *cephv1.ClusterSpec
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
args args
|
|
want *cephStatusChecker
|
|
}{
|
|
{"default-interval", args{c, clusterInfo, &cephv1.ClusterSpec{}}, &cephStatusChecker{c, clusterInfo, defaultStatusCheckInterval, c.Client, false}},
|
|
{"10s-interval", args{c, clusterInfo, &cephv1.ClusterSpec{HealthCheck: cephv1.CephClusterHealthCheckSpec{DaemonHealth: cephv1.DaemonHealthSpec{Status: cephv1.HealthCheckSpec{Interval: "10s"}}}}}, &cephStatusChecker{c, clusterInfo, time10s, c.Client, false}},
|
|
{"10s-interval-external", args{c, clusterInfo, &cephv1.ClusterSpec{External: cephv1.ExternalSpec{Enable: true}, HealthCheck: cephv1.CephClusterHealthCheckSpec{DaemonHealth: cephv1.DaemonHealthSpec{Status: cephv1.HealthCheckSpec{Interval: "10s"}}}}}, &cephStatusChecker{c, clusterInfo, time10s, c.Client, true}},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
if got := newCephStatusChecker(tt.args.context, tt.args.clusterInfo, tt.args.clusterSpec); !reflect.DeepEqual(got, tt.want) {
|
|
t.Errorf("newCephStatusChecker() = %v, want %v", got, tt.want)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func Test_cephStatusChecker_conditionMessageReason(t *testing.T) {
|
|
c := &clusterd.Context{}
|
|
clusterInfo := client.AdminClusterInfo("ns")
|
|
type fields struct {
|
|
context *clusterd.Context
|
|
clusterInfo *cephclient.ClusterInfo
|
|
interval time.Duration
|
|
client controllerclient.Client
|
|
isExternal bool
|
|
}
|
|
type args struct {
|
|
condition cephv1.ConditionType
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
fields fields
|
|
args args
|
|
want cephv1.ConditionType
|
|
want1 string
|
|
want2 string
|
|
}{
|
|
{"failure-converged", fields{c, clusterInfo, defaultStatusCheckInterval, c.Client, false}, args{cephv1.ConditionFailure}, cephv1.ConditionFailure, "ClusterFailure", "Failed to configure ceph cluster"},
|
|
{"failure-external", fields{c, clusterInfo, defaultStatusCheckInterval, c.Client, true}, args{cephv1.ConditionFailure}, cephv1.ConditionFailure, "ClusterFailure", "Failed to configure external ceph cluster"},
|
|
{"success-converged", fields{c, clusterInfo, defaultStatusCheckInterval, c.Client, false}, args{cephv1.ConditionReady}, cephv1.ConditionReady, "ClusterCreated", "Cluster created successfully"},
|
|
{"success-external", fields{c, clusterInfo, defaultStatusCheckInterval, c.Client, true}, args{cephv1.ConditionReady}, cephv1.ConditionConnected, "ClusterConnected", "Cluster connected successfully"},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
c := &cephStatusChecker{
|
|
context: tt.fields.context,
|
|
clusterInfo: tt.fields.clusterInfo,
|
|
interval: tt.fields.interval,
|
|
client: tt.fields.client,
|
|
isExternal: tt.fields.isExternal,
|
|
}
|
|
got, got1, got2 := c.conditionMessageReason(tt.args.condition)
|
|
if !reflect.DeepEqual(got, tt.want) {
|
|
t.Errorf("cephStatusChecker.conditionMessageReason() got = %v, want %v", got, tt.want)
|
|
}
|
|
if got1 != tt.want1 {
|
|
t.Errorf("cephStatusChecker.conditionMessageReason() got1 = %v, want %v", got1, tt.want1)
|
|
}
|
|
if got2 != tt.want2 {
|
|
t.Errorf("cephStatusChecker.conditionMessageReason() got2 = %v, want %v", got2, tt.want2)
|
|
}
|
|
})
|
|
}
|
|
}
|