Sébastien Han
8aaff235bb
When the cluster is external we want to expose manager service port along with the endpoints. This allows us to connect but Rook will keep on using 9283 as a facing port for Prometheus and more. ``` monitoring: enabled: true ... ... externalMgrPrometheusPort: 9283 ``` Signed-off-by: Sébastien Han <seb@redhat.com>
47 lines
1.4 KiB
Go
47 lines
1.4 KiB
Go
/*
|
|
Copyright 2020 The Rook Authors. All rights reserved.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package cluster
|
|
|
|
import (
|
|
"testing"
|
|
|
|
cephv1 "github.com/rook/rook/pkg/apis/ceph.rook.io/v1"
|
|
"github.com/rook/rook/pkg/operator/ceph/cluster/mon"
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestValidateExternalClusterSpec(t *testing.T) {
|
|
c := &cluster{Spec: &cephv1.ClusterSpec{}, mons: &mon.Cluster{}}
|
|
err := validateExternalClusterSpec(c)
|
|
assert.NoError(t, err)
|
|
|
|
c.Spec.CephVersion.Image = "ceph/ceph:v15"
|
|
err = validateExternalClusterSpec(c)
|
|
assert.Error(t, err)
|
|
|
|
c.Spec.DataDirHostPath = "path"
|
|
err = validateExternalClusterSpec(c)
|
|
assert.NoError(t, err, err)
|
|
assert.Equal(t, uint16(0), c.Spec.Monitoring.ExternalMgrPrometheusPort)
|
|
|
|
c.Spec.Monitoring.Enabled = true
|
|
err = validateExternalClusterSpec(c)
|
|
assert.NoError(t, err, err)
|
|
assert.Equal(t, uint16(9283), c.Spec.Monitoring.ExternalMgrPrometheusPort)
|
|
|
|
}
|