forked from rook/rook
This is the first implementation of CephX key rotation in Rook. Adds key rotation API from design PR 15915. Also add helper methods for rotating keys, determining when keys need to be rotated, and for generating CephX key statuses. These will be reusable for other Rook reconciles beyond object/RGW. Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
208 lines
6.5 KiB
Go
208 lines
6.5 KiB
Go
/*
|
|
Copyright 2019 The Rook Authors. All rights reserved.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package csi
|
|
|
|
import (
|
|
"github.com/pkg/errors"
|
|
"github.com/rook/rook/pkg/clusterd"
|
|
"github.com/rook/rook/pkg/daemon/ceph/client"
|
|
"github.com/rook/rook/pkg/operator/ceph/config/keyring"
|
|
"github.com/rook/rook/pkg/operator/k8sutil"
|
|
v1 "k8s.io/api/core/v1"
|
|
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
|
|
)
|
|
|
|
//nolint:gosec // because of the word `Secret`
|
|
const (
|
|
csiKeyringRBDProvisionerUsername = "client.csi-rbd-provisioner"
|
|
csiKeyringRBDNodeUsername = "client.csi-rbd-node"
|
|
CsiRBDNodeSecret = "rook-csi-rbd-node"
|
|
CsiRBDProvisionerSecret = "rook-csi-rbd-provisioner"
|
|
)
|
|
|
|
//nolint:gosec // because of the word `Secret`
|
|
const (
|
|
csiKeyringCephFSProvisionerUsername = "client.csi-cephfs-provisioner"
|
|
csiKeyringCephFSNodeUsername = "client.csi-cephfs-node"
|
|
CsiCephFSNodeSecret = "rook-csi-cephfs-node"
|
|
CsiCephFSProvisionerSecret = "rook-csi-cephfs-provisioner"
|
|
)
|
|
|
|
func createCSIKeyringRBDNode(s *keyring.SecretStore) (string, error) {
|
|
key, err := s.GenerateKey(csiKeyringRBDNodeUsername, cephCSIKeyringRBDNodeCaps())
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
|
|
return key, nil
|
|
}
|
|
|
|
func createCSIKeyringRBDProvisioner(s *keyring.SecretStore) (string, error) {
|
|
key, err := s.GenerateKey(csiKeyringRBDProvisionerUsername, cephCSIKeyringRBDProvisionerCaps())
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
|
|
return key, nil
|
|
}
|
|
|
|
func createCSIKeyringCephFSNode(s *keyring.SecretStore) (string, error) {
|
|
key, err := s.GenerateKey(csiKeyringCephFSNodeUsername, cephCSIKeyringCephFSNodeCaps())
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
|
|
return key, nil
|
|
}
|
|
|
|
func createCSIKeyringCephFSProvisioner(s *keyring.SecretStore) (string, error) {
|
|
key, err := s.GenerateKey(csiKeyringCephFSProvisionerUsername, cephCSIKeyringCephFSProvisionerCaps())
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
|
|
return key, nil
|
|
}
|
|
|
|
func cephCSIKeyringRBDNodeCaps() []string {
|
|
return []string{
|
|
"mon", "profile rbd",
|
|
"mgr", "allow rw",
|
|
"osd", "profile rbd",
|
|
}
|
|
}
|
|
|
|
func cephCSIKeyringRBDProvisionerCaps() []string {
|
|
return []string{
|
|
"mon", "profile rbd, allow command 'osd blocklist'",
|
|
"mgr", "allow rw",
|
|
"osd", "profile rbd",
|
|
}
|
|
}
|
|
|
|
func cephCSIKeyringCephFSNodeCaps() []string {
|
|
return []string{
|
|
"mon", "allow r",
|
|
"mgr", "allow rw",
|
|
"osd", "allow rwx tag cephfs metadata=*, allow rw tag cephfs data=*",
|
|
"mds", "allow rw",
|
|
}
|
|
}
|
|
|
|
func cephCSIKeyringCephFSProvisionerCaps() []string {
|
|
return []string{
|
|
"mon", "allow r, allow command 'osd blocklist'",
|
|
"mgr", "allow rw",
|
|
"osd", "allow rw tag cephfs metadata=*",
|
|
// MDS require all(*) permissions to be able to execute admin socket commands like ceph tell required for client eviction in cephFS.
|
|
"mds", "allow *",
|
|
}
|
|
}
|
|
|
|
func createOrUpdateCSISecret(clusterInfo *client.ClusterInfo, csiRBDProvisionerSecretKey, csiRBDNodeSecretKey, csiCephFSProvisionerSecretKey, csiCephFSNodeSecretKey string, k *keyring.SecretStore) error {
|
|
csiRBDProvisionerSecrets := map[string][]byte{
|
|
// userID is expected for the rbd provisioner driver
|
|
"userID": []byte("csi-rbd-provisioner"),
|
|
"userKey": []byte(csiRBDProvisionerSecretKey),
|
|
}
|
|
|
|
csiRBDNodeSecrets := map[string][]byte{
|
|
// userID is expected for the rbd node driver
|
|
"userID": []byte("csi-rbd-node"),
|
|
"userKey": []byte(csiRBDNodeSecretKey),
|
|
}
|
|
|
|
csiCephFSProvisionerSecrets := map[string][]byte{
|
|
// adminID is expected for the cephfs provisioner driver
|
|
"adminID": []byte("csi-cephfs-provisioner"),
|
|
"adminKey": []byte(csiCephFSProvisionerSecretKey),
|
|
}
|
|
|
|
csiCephFSNodeSecrets := map[string][]byte{
|
|
// adminID is expected for the cephfs node driver
|
|
"adminID": []byte("csi-cephfs-node"),
|
|
"adminKey": []byte(csiCephFSNodeSecretKey),
|
|
}
|
|
|
|
keyringSecretMap := make(map[string]map[string][]byte)
|
|
keyringSecretMap[CsiRBDProvisionerSecret] = csiRBDProvisionerSecrets
|
|
keyringSecretMap[CsiRBDNodeSecret] = csiRBDNodeSecrets
|
|
keyringSecretMap[CsiCephFSProvisionerSecret] = csiCephFSProvisionerSecrets
|
|
keyringSecretMap[CsiCephFSNodeSecret] = csiCephFSNodeSecrets
|
|
|
|
for secretName, secret := range keyringSecretMap {
|
|
s := &v1.Secret{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: secretName,
|
|
Namespace: clusterInfo.Namespace,
|
|
},
|
|
Data: secret,
|
|
Type: k8sutil.RookType,
|
|
}
|
|
err := clusterInfo.OwnerInfo.SetControllerReference(s)
|
|
if err != nil {
|
|
return errors.Wrapf(err, "failed to set owner reference to keyring secret %q", secretName)
|
|
}
|
|
|
|
// Create Kubernetes Secret
|
|
_, err = k.CreateSecret(s)
|
|
if err != nil {
|
|
return errors.Wrapf(err, "failed to create kubernetes secret %q for cluster %q", s.Name, clusterInfo.Namespace)
|
|
}
|
|
|
|
}
|
|
|
|
logger.Infof("created kubernetes csi secrets for cluster %q", clusterInfo.Namespace)
|
|
return nil
|
|
}
|
|
|
|
// CreateCSISecrets creates all the Kubernetes CSI Secrets
|
|
func CreateCSISecrets(context *clusterd.Context, clusterInfo *client.ClusterInfo) error {
|
|
k := keyring.GetSecretStore(context, clusterInfo, clusterInfo.OwnerInfo)
|
|
|
|
// Create CSI RBD Provisioner Ceph key
|
|
csiRBDProvisionerSecretKey, err := createCSIKeyringRBDProvisioner(k)
|
|
if err != nil {
|
|
return errors.Wrap(err, "failed to create csi rbd provisioner ceph keyring")
|
|
}
|
|
|
|
// Create CSI RBD Node Ceph key
|
|
csiRBDNodeSecretKey, err := createCSIKeyringRBDNode(k)
|
|
if err != nil {
|
|
return errors.Wrap(err, "failed to create csi rbd node ceph keyring")
|
|
}
|
|
|
|
// Create CSI Cephfs provisioner Ceph key
|
|
csiCephFSProvisionerSecretKey, err := createCSIKeyringCephFSProvisioner(k)
|
|
if err != nil {
|
|
return errors.Wrap(err, "failed to create csi cephfs provisioner ceph keyring")
|
|
}
|
|
|
|
// Create CSI Cephfs node Ceph key
|
|
csiCephFSNodeSecretKey, err := createCSIKeyringCephFSNode(k)
|
|
if err != nil {
|
|
return errors.Wrap(err, "failed to create csi cephfs node ceph keyring")
|
|
}
|
|
|
|
// Create or update Kubernetes CSI secret
|
|
if err := createOrUpdateCSISecret(clusterInfo, csiRBDProvisionerSecretKey, csiRBDNodeSecretKey, csiCephFSProvisionerSecretKey, csiCephFSNodeSecretKey, k); err != nil {
|
|
return errors.Wrap(err, "failed to create kubernetes csi secret")
|
|
}
|
|
|
|
return nil
|
|
}
|