Files
my-rook-config/pkg/operator/ceph/file/status.go
T
Arun Kumar Mohan 7e87c67536 core: fix CephFS status updates
CephFS object fails to do a initial status update.
Operator shows the following error message in logs,

'Error while updation: Operation cannot be fulfilled on
cephfilesystems.ceph.rook.io "myfs": the object has been
modified; please apply your changes to the latest version
and try again'

Function 'updateStatus' now returns the new/updated
CephFilesystem object if successfully updated or nil.

Signed-off-by: Arun Kumar Mohan <amohan@redhat.com>
2023-01-24 19:06:55 +05:30

118 lines
4.4 KiB
Go

/*
Copyright 2021 The Rook Authors. All rights reserved.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
// Package file manages a CephFS filesystem and the required daemons.
package file
import (
"time"
cephv1 "github.com/rook/rook/pkg/apis/ceph.rook.io/v1"
"github.com/rook/rook/pkg/operator/ceph/reporting"
"github.com/rook/rook/pkg/operator/k8sutil"
kerrors "k8s.io/apimachinery/pkg/api/errors"
"k8s.io/apimachinery/pkg/types"
)
// updateStatus updates a fs CR with the given status
func (r *ReconcileCephFilesystem) updateStatus(observedGeneration int64, namespacedName types.NamespacedName, status cephv1.ConditionType, info map[string]string) *cephv1.CephFilesystem {
fs := &cephv1.CephFilesystem{}
err := r.client.Get(r.opManagerContext, namespacedName, fs)
if err != nil {
if kerrors.IsNotFound(err) {
logger.Debug("CephFilesystem resource not found. Ignoring since object must be deleted.")
return nil
}
logger.Warningf("failed to retrieve filesystem %q to update status to %q. %v", namespacedName, status, err)
return nil
}
if fs.Status == nil {
fs.Status = &cephv1.CephFilesystemStatus{}
}
fs.Status.Phase = status
fs.Status.Info = info
if observedGeneration != k8sutil.ObservedGenerationNotAvailable {
fs.Status.ObservedGeneration = observedGeneration
}
if err := reporting.UpdateStatus(r.client, fs); err != nil {
logger.Warningf("failed to set filesystem %q status to %q. %v", fs.Name, status, err)
return nil
}
logger.Debugf("filesystem %q status updated to %q", fs.Name, status)
return fs
}
// updateStatusBucket updates an object with a given status
func (c *mirrorChecker) updateStatusMirroring(mirrorStatus []cephv1.FilesystemMirroringInfo, snapSchedStatus []cephv1.FilesystemSnapshotSchedulesSpec, details string) {
fs := &cephv1.CephFilesystem{}
if err := c.client.Get(c.clusterInfo.Context, c.namespacedName, fs); err != nil {
if kerrors.IsNotFound(err) {
logger.Debug("CephFilesystem resource not found. Ignoring since object must be deleted.")
return
}
logger.Warningf("failed to retrieve ceph filesystem %q to update mirroring status. %v", c.namespacedName.Name, err)
return
}
if fs.Status == nil {
fs.Status = &cephv1.CephFilesystemStatus{}
}
// Update the CephFilesystem CR status field
fs.Status = toCustomResourceStatus(fs.Status, mirrorStatus, snapSchedStatus, details)
if err := reporting.UpdateStatus(c.client, fs); err != nil {
logger.Errorf("failed to set ceph filesystem %q mirroring status. %v", c.namespacedName.Name, err)
return
}
logger.Debugf("ceph filesystem %q mirroring status updated", c.namespacedName.Name)
}
func toCustomResourceStatus(currentStatus *cephv1.CephFilesystemStatus, mirrorStatus []cephv1.FilesystemMirroringInfo, snapSchedStatus []cephv1.FilesystemSnapshotSchedulesSpec, details string) *cephv1.CephFilesystemStatus {
mirrorStatusSpec := &cephv1.FilesystemMirroringInfoSpec{}
mirrorSnapScheduleStatusSpec := &cephv1.FilesystemSnapshotScheduleStatusSpec{}
now := time.Now().UTC().Format(time.RFC3339)
// MIRROR
if len(mirrorStatus) != 0 {
mirrorStatusSpec.LastChecked = now
mirrorStatusSpec.FilesystemMirroringAllInfo = mirrorStatus
}
// Always display the details, typically an error
mirrorStatusSpec.Details = details
if currentStatus != nil {
if currentStatus.MirroringStatus != nil {
mirrorStatusSpec.LastChanged = currentStatus.MirroringStatus.LastChanged
}
if currentStatus.SnapshotScheduleStatus != nil {
mirrorStatusSpec.LastChanged = currentStatus.SnapshotScheduleStatus.LastChanged
}
}
// SNAP SCHEDULE
if len(snapSchedStatus) != 0 {
mirrorSnapScheduleStatusSpec.LastChecked = now
mirrorSnapScheduleStatusSpec.SnapshotSchedules = snapSchedStatus
}
// Always display the details, typically an error
mirrorSnapScheduleStatusSpec.Details = details
return &cephv1.CephFilesystemStatus{MirroringStatus: mirrorStatusSpec, SnapshotScheduleStatus: mirrorSnapScheduleStatusSpec, Phase: currentStatus.Phase, Info: currentStatus.Info}
}