forked from rook/rook
ShyamsundarR
48a0decc49
A recent PR #4172 added the ability for rook to create the CSIDriver object on a kubernetes cluster. The change also made it so that attachRequired value in the ceph CSI drivers were set to false. This leads to the entire attach skipping the AD controller that deals with RWO attachment enforcement. Thus, if a CephFS volume is marked RWO, 2 pods on different hosts can end up mounting the same and consuming it at the same time. Further for RBD, currently the image watchers are the only ones that prevent a double mount of an image, other than the AD controller enforcement of single attach for RWO RBD PVs. This has proven not to be reliable in the face of MON failures, as the watcher information is lost, and a second mount is allowed. Thus, we need to bring back the attach requirement to leverage kubernetes checks and balances for RWO volume type, and prevent unwanted multi-attach use of the same. This PR hence undoes some of the changes introduced by the PR #4172, to bring the attacher side car back, and also declare the attachRequired for both RBD and CephFS CSI plugins as true. NOTE: Initially the attachRequired was set to false as this improved attach times considerably on kubernetes, as the entire phase was being avoided. Signed-off-by: ShyamsundarR <srangana@redhat.com>