forked from rook/rook
df511fb58f
The ci was using a pretty old version og golangci-lint. This updates to the latest version. Additionally, it silences some gosec integer conversion overflow false positves and fixes some real errors of this category and string format errors found by golangci-lint, while at it. Co-authored-by: Blaine Gardner <b.blaine.gardner@gmail.com> Co-authored-by: Travis Nielsen <tnielsen@redhat.com> Signed-off-by: Michael Adam <obnox@samba.org>
60 lines
1.8 KiB
Go
60 lines
1.8 KiB
Go
/*
|
|
Copyright 2017 The Rook Authors. All rights reserved.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package util
|
|
|
|
import (
|
|
"net"
|
|
"strconv"
|
|
|
|
"github.com/coreos/pkg/capnslog"
|
|
)
|
|
|
|
const (
|
|
RBDSysBusPathDefault = "/sys/bus/rbd"
|
|
RBDDevicesDir = "devices"
|
|
RBDDevicePathPrefix = "/dev/rbd"
|
|
)
|
|
|
|
var logger = capnslog.NewPackageLogger("github.com/rook/rook", "op-ceph-util")
|
|
|
|
// GetIPFromEndpoint return the IP from an endpoint string (192.168.0.1:6789)
|
|
func GetIPFromEndpoint(endpoint string) string {
|
|
host, _, err := net.SplitHostPort(endpoint)
|
|
if err != nil {
|
|
logger.Errorf("failed to split ip and port for endpoint %q. %v", endpoint, err)
|
|
}
|
|
return host
|
|
}
|
|
|
|
// GetPortFromEndpoint return the port from an endpoint string (192.168.0.1:6789)
|
|
func GetPortFromEndpoint(endpoint string) int32 {
|
|
var port int64
|
|
_, portString, err := net.SplitHostPort(endpoint)
|
|
if err != nil {
|
|
logger.Errorf("failed to split host and port for endpoint %q, assuming default Ceph port %q. %v", endpoint, portString, err)
|
|
} else {
|
|
//nolint:gosec // using Atoi to convert type into int is not a real risk
|
|
port, err = strconv.ParseInt(portString, 10, 32)
|
|
if err != nil {
|
|
logger.Errorf("failed to convert %q to integer. %v", portString, err)
|
|
}
|
|
}
|
|
//nolint:gosec // G109 No overflow: we parsed to 32 bits above
|
|
portInt32 := int32(port)
|
|
return portInt32
|
|
}
|