forked from rook/rook
Blaine Gardner
0c721e05d5
Add the ability to specify node profiles in the multus validation test. This addresses a few points of early feedback on the validation tool. Statements below critique the tool's behavior before this patch. 1. The tool assumes all daemons are on public and cluster network, which means users who have a significantly smaller cluster net (a design choice) cannot run a single test to determine if Rook is likely to install correctly. 2. The tool does not have placement options to select only a subset of Kubernetes nodes to run validation on. 3. Users of multus seem to have a dedicated pool of storage nodes more often than the average Rook install. This makes sense for security- and perforance-minded users. The tool cannot run a single test to verify storage-only and general-workload nodes at one time. These points are addressed by allowing users to specify configurations for different "NodeTypes." Each NodeType config has options for selecting the number of OSDs as well as the number of other (non-OSD) Ceph daemons. This limits the unnecessary exhaustion of cluster network addresses from critique 1. Each NodeType config has its own placement (critique 2). Users can define as many NodeTypes as needed to test the network for their planned CephCluster. Specifically, this allows the tool to test storage-only nodes and generalized-workload nodes at the same time. An arbitrary number of NodeTypes are allowed to support even more highly specialized cluster setups, such as multiple tiers of storage nodes where some storage-only nodes may run more OSDs than others. Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
95 lines
3.7 KiB
Go
95 lines
3.7 KiB
Go
/*
|
|
Copyright 2023 The Rook Authors. All rights reserved.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package multus
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func Test_perNodeTypeCount_Increment(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
a *perNodeTypeCount
|
|
want *perNodeTypeCount
|
|
}{
|
|
{"empty", &perNodeTypeCount{}, &perNodeTypeCount{"type": 1}},
|
|
{"type already set", &perNodeTypeCount{"type": 2}, &perNodeTypeCount{"type": 3}},
|
|
{"other already set", &perNodeTypeCount{"other": 3}, &perNodeTypeCount{"other": 3, "type": 1}},
|
|
{"type and other already set", &perNodeTypeCount{"type": 1, "other": 3}, &perNodeTypeCount{"type": 2, "other": 3}},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
tt.a.Increment("type")
|
|
assert.Equal(t, *tt.want, *tt.a)
|
|
})
|
|
}
|
|
}
|
|
|
|
func Test_perNodeTypeCount_Equal(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
a *perNodeTypeCount
|
|
b *perNodeTypeCount
|
|
want bool
|
|
}{
|
|
{"empty vs empty", &perNodeTypeCount{}, &perNodeTypeCount{}, true},
|
|
{"shared:1 vs empty", &perNodeTypeCount{"shared": 1}, &perNodeTypeCount{}, false},
|
|
{"empty vs shared:1", &perNodeTypeCount{}, &perNodeTypeCount{"shared": 1}, false},
|
|
{"shared:0 vs shared:0", &perNodeTypeCount{"shared": 0}, &perNodeTypeCount{"shared": 0}, true},
|
|
{"shared:1 vs shared:0", &perNodeTypeCount{"shared": 1}, &perNodeTypeCount{"shared": 0}, false},
|
|
{"shared:0 vs shared:1", &perNodeTypeCount{"shared": 0}, &perNodeTypeCount{"shared": 1}, false},
|
|
{"shared:1 vs shared:1", &perNodeTypeCount{"shared": 1}, &perNodeTypeCount{"shared": 1}, true},
|
|
{"shared:1 vs shared:2", &perNodeTypeCount{"shared": 1}, &perNodeTypeCount{"shared": 2}, false},
|
|
{"shared:1 vs other:1", &perNodeTypeCount{"shared": 1}, &perNodeTypeCount{"other": 1}, false},
|
|
{"shared:1 vs other:0", &perNodeTypeCount{"shared": 1}, &perNodeTypeCount{"other": 0}, false},
|
|
{"shared:1,other:2 vs shared:1,other:2", &perNodeTypeCount{"shared": 1, "other": 2}, &perNodeTypeCount{"shared": 1, "other": 2}, true},
|
|
{"shared:1,other:2 vs shared:2,other:2", &perNodeTypeCount{"shared": 1, "other": 2}, &perNodeTypeCount{"shared": 2, "other": 2}, false},
|
|
{"shared:1,other:2 vs shared:2,other:1", &perNodeTypeCount{"shared": 1, "other": 2}, &perNodeTypeCount{"shared": 2, "other": 1}, false},
|
|
{"shared:1,other:2 vs shared:1,other:1", &perNodeTypeCount{"shared": 1, "other": 2}, &perNodeTypeCount{"shared": 1, "other": 1}, false},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
if got := tt.a.Equal(tt.b); got != tt.want {
|
|
t.Errorf("perNodeTypeCount.Equal() = %v, want %v", got, tt.want)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func Test_perNodeTypeCount_Total(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
a *perNodeTypeCount
|
|
want int
|
|
}{
|
|
{"empty", &perNodeTypeCount{}, 0},
|
|
{"sample:1", &perNodeTypeCount{"sample": 1}, 1},
|
|
{"sample:1, other:2", &perNodeTypeCount{"sample": 1, "other": 2}, 3},
|
|
{"sample:0", &perNodeTypeCount{"sample": 0}, 0},
|
|
{"sample:0, other:2", &perNodeTypeCount{"sample": 0, "other": 2}, 2},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
if got := tt.a.Total(); got != tt.want {
|
|
t.Errorf("perNodeTypeCount.Total() = %v, want %v", got, tt.want)
|
|
}
|
|
})
|
|
}
|
|
}
|