forked from rook/rook
We should not use %+v when printing errors and wrapping it in the
caller. Passing %+v to errors.Wrap() returns a strack trace.
See:
```
2021-08-03 09:42:40.460946 E | ceph-file-controller: failed to reconcile failed to create filesystem "myfs2": failed to start deployment for MDS "a" for filesystem "myfs2": failed to update mds deployment "rook-ceph-mds-myfs2-a": failed to check if deployment "rook-ceph-mds-myfs2-a" can continue: failed to check if we can continue the deployment rook-ceph-mds-myfs2-a: failed to check if rook-ceph-mds-myfs2-a was ok to continue: max retries exceeded, last err: mds myfs2-a is up:creating, bad state
github.com/rook/rook/pkg/daemon/ceph/client.MdsActiveOrStandbyReplay
/home/leseb/go/src/github.com/rook/rook/pkg/daemon/ceph/client/status.go:286
github.com/rook/rook/pkg/daemon/ceph/client.okToContinueMDSDaemon.func1
/home/leseb/go/src/github.com/rook/rook/pkg/daemon/ceph/client/upgrade.go:215
github.com/rook/rook/pkg/util.Retry
/home/leseb/go/src/github.com/rook/rook/pkg/util/retry.go:31
github.com/rook/rook/pkg/daemon/ceph/client.okToContinueMDSDaemon
/home/leseb/go/src/github.com/rook/rook/pkg/daemon/ceph/client/upgrade.go:214
github.com/rook/rook/pkg/daemon/ceph/client.OkToContinue
/home/leseb/go/src/github.com/rook/rook/pkg/daemon/ceph/client/upgrade.go:181
github.com/rook/rook/pkg/operator/ceph/cluster/mon.UpdateCephDeploymentAndWait.func1
/home/leseb/go/src/github.com/rook/rook/pkg/operator/ceph/cluster/mon/spec.go:370
github.com/rook/rook/pkg/operator/k8sutil.UpdateDeploymentAndWait
/home/leseb/go/src/github.com/rook/rook/pkg/operator/k8sutil/deployment.go:113
github.com/rook/rook/pkg/operator/ceph/cluster/mon.UpdateCephDeploymentAndWait
/home/leseb/go/src/github.com/rook/rook/pkg/operator/ceph/cluster/mon/spec.go:383
github.com/rook/rook/pkg/operator/ceph/file/mds.(*Cluster).startDeployment
/home/leseb/go/src/github.com/rook/rook/pkg/operator/ceph/file/mds/mds.go:216
github.com/rook/rook/pkg/operator/ceph/file/mds.(*Cluster).Start
/home/leseb/go/src/github.com/rook/rook/pkg/operator/ceph/file/mds/mds.go:138
github.com/rook/rook/pkg/operator/ceph/file.createFilesystem
/home/leseb/go/src/github.com/rook/rook/pkg/operator/ceph/file/filesystem.go:81
github.com/rook/rook/pkg/operator/ceph/file.(*ReconcileCephFilesystem).reconcileCreateFilesystem
/home/leseb/go/src/github.com/rook/rook/pkg/operator/ceph/file/controller.go:373
github.com/rook/rook/pkg/operator/ceph/file.(*ReconcileCephFilesystem).reconcile
/home/leseb/go/src/github.com/rook/rook/pkg/operator/ceph/file/controller.go:288
github.com/rook/rook/pkg/operator/ceph/file.(*ReconcileCephFilesystem).Reconcile
/home/leseb/go/src/github.com/rook/rook/pkg/operator/ceph/file/controller.go:167
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
/home/leseb/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.9.0/pkg/internal/controller/controller.go:298
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
/home/leseb/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.9.0/pkg/internal/controller/controller.go:253
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
/home/leseb/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.9.0/pkg/internal/controller/controller.go:214
runtime.goexit
/usr/local/go/src/runtime/asm_amd64.s:1371
```
Signed-off-by: Sébastien Han <seb@redhat.com>
89 lines
2.6 KiB
Go
89 lines
2.6 KiB
Go
/*
|
|
Copyright 2017 The Rook Authors. All rights reserved.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package util
|
|
|
|
import (
|
|
"fmt"
|
|
"time"
|
|
|
|
"github.com/pkg/errors"
|
|
)
|
|
|
|
// Retry will attempt the given function until it succeeds, up to the given maximum amount of retries,
|
|
// sleeping for the given duration in between attempts.
|
|
func Retry(maxRetries int, delay time.Duration, f func() error) error {
|
|
tries := 0
|
|
for {
|
|
err := f()
|
|
if err == nil {
|
|
// function succeeded, all done
|
|
return nil
|
|
}
|
|
|
|
tries++
|
|
if tries > maxRetries {
|
|
return fmt.Errorf("max retries exceeded, last err: %v", err)
|
|
}
|
|
|
|
logger.Infof("retrying after %v, last error: %v", delay, err)
|
|
<-time.After(delay)
|
|
}
|
|
}
|
|
|
|
// RetryFunc is a function that returns true when it is done and it should be retried no longer.
|
|
// It should return error if there has been an error. The error will be logged if done==false
|
|
// (should keep retrying). The error will be returned by the calling function if done==true (should
|
|
// stop retrying).
|
|
type RetryFunc func() (done bool, err error)
|
|
|
|
// RetryWithTimeout retries the RetryFunc until the timeout occurs. It will retry once more after
|
|
// the timeout to avoid race conditions at the expense of running for slightly longer than timeout
|
|
// in the timeout/error case.
|
|
// The given description will be output in log/error messages as "... waiting for <description>..."
|
|
func RetryWithTimeout(f RetryFunc, period time.Duration, timeout time.Duration, description string) error {
|
|
tt := time.After(timeout)
|
|
var done bool
|
|
var err error
|
|
for {
|
|
done, err = f()
|
|
if done {
|
|
break
|
|
}
|
|
if err != nil {
|
|
logger.Errorf("error occurred waiting for %s. retrying after %v. %v", description, period, err)
|
|
}
|
|
logger.Debugf("waiting for %s. retrying after %v", description, period)
|
|
|
|
select {
|
|
case <-time.After(period):
|
|
// go back to start of loop
|
|
case <-tt:
|
|
// timeout; try one last time
|
|
done, err = f()
|
|
if !done {
|
|
if err != nil {
|
|
return errors.Wrapf(err, "timed out waiting for %s", description)
|
|
}
|
|
return fmt.Errorf("timed out waiting for %s", description)
|
|
}
|
|
return err
|
|
}
|
|
}
|
|
|
|
return err
|
|
}
|