Files
my-rook-config/pkg/operator/ceph/object/user/controller.go
T
Sébastien Han 90bea8a560 ceph: stop using radosgw-admin CLI for s3 user management
We have been having many issues with external mode with Ceph version
mismatching. The operator would have a Ceph version different than the
external cluster. The `radosgw-admin` was used to interact with S3
users, even a small version delta would cause the command to coredump.
After checking with the rgw core team it appears Rook was misusing the
CLI and the admin ops API should be used instead.
So this patch is the first introduction of go-ceph in Rook to consume
the rgw admin ops API instead of the `radosgw-admin` CLI, **only** for
user management in this initial commit.
Later we can do more such as bucket operation, zone management etc.

Closes: https://github.com/rook/rook/issues/7924
Signed-off-by: Sébastien Han <seb@redhat.com>
2021-06-09 11:08:22 +02:00

556 lines
19 KiB
Go

/*
Copyright 2018 The Rook Authors. All rights reserved.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
// Package objectuser to manage a rook object store user.
package objectuser
import (
"context"
"fmt"
"net/http"
"reflect"
"github.com/ceph/go-ceph/rgw/admin"
"github.com/rook/rook/pkg/operator/ceph/cluster/mon"
opcontroller "github.com/rook/rook/pkg/operator/ceph/controller"
"k8s.io/apimachinery/pkg/runtime"
"k8s.io/apimachinery/pkg/types"
"sigs.k8s.io/controller-runtime/pkg/controller"
"sigs.k8s.io/controller-runtime/pkg/controller/controllerutil"
"sigs.k8s.io/controller-runtime/pkg/handler"
"sigs.k8s.io/controller-runtime/pkg/manager"
"sigs.k8s.io/controller-runtime/pkg/reconcile"
"sigs.k8s.io/controller-runtime/pkg/source"
"github.com/coreos/pkg/capnslog"
"github.com/pkg/errors"
cephv1 "github.com/rook/rook/pkg/apis/ceph.rook.io/v1"
"github.com/rook/rook/pkg/clusterd"
cephclient "github.com/rook/rook/pkg/daemon/ceph/client"
"github.com/rook/rook/pkg/operator/ceph/object"
"github.com/rook/rook/pkg/operator/k8sutil"
corev1 "k8s.io/api/core/v1"
kerrors "k8s.io/apimachinery/pkg/api/errors"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"sigs.k8s.io/controller-runtime/pkg/client"
)
const (
appName = object.AppName
controllerName = "ceph-object-store-user-controller"
)
var logger = capnslog.NewPackageLogger("github.com/rook/rook", controllerName)
var cephObjectStoreUserKind = reflect.TypeOf(cephv1.CephObjectStoreUser{}).Name()
// Sets the type meta for the controller main object
var controllerTypeMeta = metav1.TypeMeta{
Kind: cephObjectStoreUserKind,
APIVersion: fmt.Sprintf("%s/%s", cephv1.CustomResourceGroup, cephv1.Version),
}
// ReconcileObjectStoreUser reconciles a ObjectStoreUser object
type ReconcileObjectStoreUser struct {
client client.Client
scheme *runtime.Scheme
context *clusterd.Context
objContext *object.Context
userConfig *admin.User
cephClusterSpec *cephv1.ClusterSpec
clusterInfo *cephclient.ClusterInfo
adminOpsAPI *admin.API
}
// Add creates a new CephObjectStoreUser Controller and adds it to the Manager. The Manager will set fields on the Controller
// and Start it when the Manager is Started.
func Add(mgr manager.Manager, context *clusterd.Context) error {
return add(mgr, newReconciler(mgr, context))
}
// newReconciler returns a new reconcile.Reconciler
func newReconciler(mgr manager.Manager, context *clusterd.Context) reconcile.Reconciler {
// Add the cephv1 scheme to the manager scheme so that the controller knows about it
mgrScheme := mgr.GetScheme()
if err := cephv1.AddToScheme(mgr.GetScheme()); err != nil {
panic(err)
}
return &ReconcileObjectStoreUser{
client: mgr.GetClient(),
scheme: mgrScheme,
context: context,
}
}
func add(mgr manager.Manager, r reconcile.Reconciler) error {
// Create a new controller
c, err := controller.New(controllerName, mgr, controller.Options{Reconciler: r})
if err != nil {
return err
}
logger.Info("successfully started")
// Watch for changes on the CephObjectStoreUser CRD object
err = c.Watch(&source.Kind{Type: &cephv1.CephObjectStoreUser{TypeMeta: controllerTypeMeta}}, &handler.EnqueueRequestForObject{}, opcontroller.WatchControllerPredicate())
if err != nil {
return err
}
// Watch secrets
err = c.Watch(&source.Kind{Type: &corev1.Secret{TypeMeta: metav1.TypeMeta{Kind: "Secret", APIVersion: corev1.SchemeGroupVersion.String()}}}, &handler.EnqueueRequestForOwner{
IsController: true,
OwnerType: &cephv1.CephObjectStoreUser{},
}, opcontroller.WatchPredicateForNonCRDObject(&cephv1.CephObjectStoreUser{TypeMeta: controllerTypeMeta}, mgr.GetScheme()))
if err != nil {
return err
}
return nil
}
// Reconcile reads that state of the cluster for a CephObjectStoreUser object and makes changes based on the state read
// and what is in the CephObjectStoreUser.Spec
// The Controller will requeue the Request to be processed again if the returned error is non-nil or
// Result.Requeue is true, otherwise upon completion it will remove the work from the queue.
func (r *ReconcileObjectStoreUser) Reconcile(context context.Context, request reconcile.Request) (reconcile.Result, error) {
// workaround because the rook logging mechanism is not compatible with the controller-runtime logging interface
reconcileResponse, err := r.reconcile(request)
if err != nil {
logger.Errorf("failed to reconcile %v", err)
}
return reconcileResponse, err
}
func (r *ReconcileObjectStoreUser) reconcile(request reconcile.Request) (reconcile.Result, error) {
// Fetch the CephObjectStoreUser instance
cephObjectStoreUser := &cephv1.CephObjectStoreUser{}
err := r.client.Get(context.TODO(), request.NamespacedName, cephObjectStoreUser)
if err != nil {
if kerrors.IsNotFound(err) {
logger.Debug("CephObjectStoreUser resource not found. Ignoring since object must be deleted.")
return reconcile.Result{}, nil
}
// Error reading the object - requeue the request.
return reconcile.Result{}, errors.Wrap(err, "failed to get CephObjectStoreUser")
}
// Set a finalizer so we can do cleanup before the object goes away
err = opcontroller.AddFinalizerIfNotPresent(r.client, cephObjectStoreUser)
if err != nil {
return reconcile.Result{}, errors.Wrap(err, "failed to add finalizer")
}
// The CR was just created, initializing status fields
if cephObjectStoreUser.Status == nil {
updateStatus(r.client, request.NamespacedName, k8sutil.Created)
}
// Make sure a CephCluster is present otherwise do nothing
cephCluster, isReadyToReconcile, cephClusterExists, reconcileResponse := opcontroller.IsReadyToReconcile(r.client, r.context, request.NamespacedName, controllerName)
if !isReadyToReconcile {
// This handles the case where the Ceph Cluster is gone and we want to delete that CR
// We skip the deleteUser() function since everything is gone already
//
// Also, only remove the finalizer if the CephCluster is gone
// If not, we should wait for it to be ready
// This handles the case where the operator is not ready to accept Ceph command but the cluster exists
if !cephObjectStoreUser.GetDeletionTimestamp().IsZero() && !cephClusterExists {
// Remove finalizer
err = opcontroller.RemoveFinalizer(r.client, cephObjectStoreUser)
if err != nil {
return reconcile.Result{}, errors.Wrap(err, "failed to remove finalizer")
}
// Return and do not requeue. Successful deletion.
return reconcile.Result{}, nil
}
return reconcileResponse, nil
}
r.cephClusterSpec = &cephCluster.Spec
// Populate clusterInfo during each reconcile
r.clusterInfo, _, _, err = mon.LoadClusterInfo(r.context, request.NamespacedName.Namespace)
if err != nil {
return reconcile.Result{}, errors.Wrap(err, "failed to populate cluster info")
}
// Validate the object store has been initialized
err = r.initializeObjectStoreContext(cephObjectStoreUser)
if err != nil {
if !cephObjectStoreUser.GetDeletionTimestamp().IsZero() {
// Remove finalizer
err = opcontroller.RemoveFinalizer(r.client, cephObjectStoreUser)
if err != nil {
return reconcile.Result{}, errors.Wrap(err, "failed to remove finalizer")
}
// Return and do not requeue. Successful deletion.
return reconcile.Result{}, nil
}
logger.Debugf("ObjectStore resource not ready in namespace %q, retrying in %q. %v",
request.NamespacedName.Namespace, opcontroller.WaitForRequeueIfCephClusterNotReady.RequeueAfter.String(), err)
updateStatus(r.client, request.NamespacedName, k8sutil.ReconcileFailedStatus)
return opcontroller.WaitForRequeueIfCephClusterNotReady, nil
}
// Generate user config
userConfig := generateUserConfig(cephObjectStoreUser)
r.userConfig = &userConfig
// DELETE: the CR was deleted
if !cephObjectStoreUser.GetDeletionTimestamp().IsZero() {
logger.Debugf("deleting pool %q", cephObjectStoreUser.Name)
err := r.deleteUser(cephObjectStoreUser)
if err != nil {
return reconcile.Result{}, errors.Wrapf(err, "failed to delete ceph object user %q", cephObjectStoreUser.Name)
}
// Remove finalizer
err = opcontroller.RemoveFinalizer(r.client, cephObjectStoreUser)
if err != nil {
return reconcile.Result{}, errors.Wrap(err, "failed to remove finalizer")
}
// Return and do not requeue. Successful deletion.
return reconcile.Result{}, nil
}
// validate the user settings
err = r.validateUser(cephObjectStoreUser)
if err != nil {
updateStatus(r.client, request.NamespacedName, k8sutil.ReconcileFailedStatus)
return reconcile.Result{}, errors.Wrapf(err, "invalid pool CR %q spec", cephObjectStoreUser.Name)
}
// CREATE/UPDATE CEPH USER
reconcileResponse, err = r.reconcileCephUser(cephObjectStoreUser)
if err != nil {
updateStatus(r.client, request.NamespacedName, k8sutil.ReconcileFailedStatus)
return reconcileResponse, err
}
// CREATE/UPDATE KUBERNETES SECRET
reconcileResponse, err = r.reconcileCephUserSecret(cephObjectStoreUser)
if err != nil {
updateStatus(r.client, request.NamespacedName, k8sutil.ReconcileFailedStatus)
return reconcileResponse, err
}
// Set Ready status, we are done reconciling
updateStatus(r.client, request.NamespacedName, k8sutil.ReadyStatus)
// Return and do not requeue
logger.Debug("done reconciling")
return reconcile.Result{}, nil
}
func (r *ReconcileObjectStoreUser) reconcileCephUser(cephObjectStoreUser *cephv1.CephObjectStoreUser) (reconcile.Result, error) {
err := r.createorUpdateCephUser(cephObjectStoreUser)
if err != nil {
return reconcile.Result{}, errors.Wrapf(err, "failed to create/update object store user %q", cephObjectStoreUser.Name)
}
return reconcile.Result{}, nil
}
func (r *ReconcileObjectStoreUser) createorUpdateCephUser(u *cephv1.CephObjectStoreUser) error {
logger.Infof("creating ceph object user %q in namespace %q", u.Name, u.Namespace)
var user admin.User
var err error
user, err = r.adminOpsAPI.CreateUser(context.TODO(), *r.userConfig)
if err != nil {
if errors.Is(err, admin.ErrUserExists) {
user, err = r.adminOpsAPI.GetUser(context.TODO(), *r.userConfig)
if err != nil {
return errors.Wrapf(err, "failed to get details from ceph object user %v", &r.userConfig.ID)
}
return nil
}
return errors.Wrapf(err, "failed to create ceph object user %q", u.Name)
}
// Set access and secret key
r.userConfig.Keys[0].AccessKey = user.Keys[0].AccessKey
r.userConfig.Keys[0].SecretKey = user.Keys[0].SecretKey
logger.Infof("created ceph object user %q", u.Name)
return nil
}
func (r *ReconcileObjectStoreUser) initializeObjectStoreContext(u *cephv1.CephObjectStoreUser) error {
err := r.objectStoreInitialized(u)
if err != nil {
return errors.Wrapf(err, "failed to detect if object store %q is initialized", u.Spec.Store)
}
store, err := r.getObjectStore(u.Spec.Store)
if err != nil {
return errors.Wrapf(err, "failed to get object store %q", u.Spec.Store)
}
objContext, err := object.NewMultisiteContext(r.context, r.clusterInfo, store)
if err != nil {
return errors.Wrapf(err, "Multisite failed to set on object context for object store user")
}
r.objContext = objContext
if store.Status == nil {
return errors.New("failed to initialize ceph object user because unknown object store status")
}
if _, ok := store.Status.Info["endpoint"]; ok {
r.objContext.Endpoint = store.Status.Info["endpoint"]
} else {
return errors.New("endpoint is missing in the status Info")
}
if _, ok := store.Status.Info["secureEndpoint"]; ok {
r.objContext.Endpoint = store.Status.Info["secureEndpoint"]
}
// Fetch admin Ops API user credentials
var accessKey, secretKey string
accessKey, secretKey, err = object.GetAdminOPSUserCredentials(r.context, r.clusterInfo, objContext, store)
if err != nil {
return errors.Wrap(err, "failed to fetch rgw admin ops api user credentials")
}
// Build TLS client if needed
var httpClient *http.Client
if store.Spec.IsTLSEnabled() {
tlsCert, err := object.GetTlsCaCert(objContext, &store.Spec)
if err != nil {
return errors.Wrapf(err, "failed to fetch CA cert to establish TLS connection with the object store %q", store.Name)
}
httpClient.Transport = object.BuildTransportTLS(tlsCert)
}
adminOpsAPI, err := admin.New(r.objContext.Endpoint, accessKey, secretKey, httpClient)
if err != nil {
return errors.Wrap(err, "failed to initialized rgw admin ops client api")
}
r.adminOpsAPI = adminOpsAPI
return nil
}
func generateUserConfig(user *cephv1.CephObjectStoreUser) admin.User {
// Set DisplayName to match Name if DisplayName is not set
displayName := user.Spec.DisplayName
if len(displayName) == 0 {
displayName = user.Name
}
// create the user
userConfig := admin.User{
ID: user.Name,
DisplayName: displayName,
Keys: make([]admin.UserKeySpec, 1),
}
return userConfig
}
func generateCephUserSecretName(u *cephv1.CephObjectStoreUser) string {
return fmt.Sprintf("rook-ceph-object-user-%s-%s", u.Spec.Store, u.Name)
}
func generateStatusInfo(u *cephv1.CephObjectStoreUser) map[string]string {
m := make(map[string]string)
m["secretName"] = generateCephUserSecretName(u)
return m
}
func (r *ReconcileObjectStoreUser) generateCephUserSecret(u *cephv1.CephObjectStoreUser) *corev1.Secret {
// Store the keys in a secret
secrets := map[string]string{
"AccessKey": r.userConfig.Keys[0].AccessKey,
"SecretKey": r.userConfig.Keys[0].SecretKey,
"Endpoint": r.objContext.Endpoint,
}
secret := &corev1.Secret{
ObjectMeta: metav1.ObjectMeta{
Name: generateCephUserSecretName(u),
Namespace: u.Namespace,
Labels: map[string]string{
"app": appName,
"user": u.Name,
"rook_cluster": u.Namespace,
"rook_object_store": u.Spec.Store,
},
},
StringData: secrets,
Type: k8sutil.RookType,
}
return secret
}
func (r *ReconcileObjectStoreUser) reconcileCephUserSecret(cephObjectStoreUser *cephv1.CephObjectStoreUser) (reconcile.Result, error) {
// Generate Kubernetes Secret
secret := r.generateCephUserSecret(cephObjectStoreUser)
// Set owner ref to the object store user object
err := controllerutil.SetControllerReference(cephObjectStoreUser, secret, r.scheme)
if err != nil {
return reconcile.Result{}, errors.Wrapf(err, "failed to set owner reference of ceph object user secret %q", secret.Name)
}
// Create Kubernetes Secret
err = opcontroller.CreateOrUpdateObject(r.client, secret)
if err != nil {
return reconcile.Result{}, errors.Wrapf(err, "failed to create or update ceph object user %q secret", secret.Name)
}
logger.Infof("created ceph object user secret %q", secret.Name)
return reconcile.Result{}, nil
}
func (r *ReconcileObjectStoreUser) objectStoreInitialized(cephObjectStoreUser *cephv1.CephObjectStoreUser) error {
_, err := r.getObjectStore(cephObjectStoreUser.Spec.Store)
if err != nil {
return err
}
logger.Debug("CephObjectStore exists")
// If the cluster is external just return
// since there are no pods running
if r.cephClusterSpec.External.Enable {
return nil
}
// There are no pods running when the cluster is external
// Unless you pass the admin key...
pods, err := r.getRgwPodList(cephObjectStoreUser)
if err != nil {
return err
}
// check if at least one pod is running
if len(pods.Items) > 0 {
logger.Debugf("CephObjectStore %q is running with %d pods", cephObjectStoreUser.Name, len(pods.Items))
return nil
}
return errors.New("no rgw pod found")
}
func (r *ReconcileObjectStoreUser) getObjectStore(storeName string) (*cephv1.CephObjectStore, error) {
// check if CephObjectStore CR is created
objectStores := &cephv1.CephObjectStoreList{}
err := r.client.List(context.TODO(), objectStores)
if err != nil {
if kerrors.IsNotFound(err) {
return nil, errors.Wrapf(err, "CephObjectStore %q could not be found", storeName)
}
return nil, errors.Wrap(err, "failed to get CephObjectStore")
}
for _, store := range objectStores.Items {
if store.Name == storeName {
logger.Infof("CephObjectStore %q found", storeName)
return &store, nil
}
}
return nil, errors.Errorf("CephObjectStore %q could not be found", storeName)
}
func (r *ReconcileObjectStoreUser) getRgwPodList(cephObjectStoreUser *cephv1.CephObjectStoreUser) (*corev1.PodList, error) {
pods := &corev1.PodList{}
// check if ObjectStore is initialized
// rook does this by starting the RGW pod(s)
listOpts := []client.ListOption{
client.InNamespace(cephObjectStoreUser.Namespace),
client.MatchingLabels(labelsForRgw(cephObjectStoreUser.Spec.Store)),
}
err := r.client.List(context.TODO(), pods, listOpts...)
if err != nil {
if kerrors.IsNotFound(err) {
return pods, errors.Wrap(err, "no rgw pod could not be found")
}
return pods, errors.Wrap(err, "failed to list rgw pods")
}
return pods, nil
}
// Delete the user
func (r *ReconcileObjectStoreUser) deleteUser(u *cephv1.CephObjectStoreUser) error {
err := r.adminOpsAPI.RemoveUser(context.TODO(), admin.User{ID: u.Name})
if err != nil {
if errors.Is(err, admin.ErrNoSuchUser) {
logger.Warningf("user %q does not exist, nothing to remove", u.Name)
return nil
}
return errors.Wrapf(err, "failed to delete ceph object user %q.", u.Name)
}
logger.Infof("ceph object user %q deleted successfully", u.Name)
return nil
}
// validateUser validates the user arguments
func (r *ReconcileObjectStoreUser) validateUser(u *cephv1.CephObjectStoreUser) error {
if u.Name == "" {
return errors.New("missing name")
}
if u.Namespace == "" {
return errors.New("missing namespace")
}
if !r.cephClusterSpec.External.Enable {
if u.Spec.Store == "" {
return errors.New("missing store")
}
}
return nil
}
func labelsForRgw(name string) map[string]string {
return map[string]string{"rgw": name, k8sutil.AppAttr: appName}
}
// updateStatus updates an object with a given status
func updateStatus(client client.Client, name types.NamespacedName, status string) {
user := &cephv1.CephObjectStoreUser{}
if err := client.Get(context.TODO(), name, user); err != nil {
if kerrors.IsNotFound(err) {
logger.Debug("CephObjectStoreUser resource not found. Ignoring since object must be deleted.")
return
}
logger.Warningf("failed to retrieve object store user %q to update status to %q. %v", name, status, err)
return
}
if user.Status == nil {
user.Status = &cephv1.ObjectStoreUserStatus{}
}
user.Status.Phase = status
if user.Status.Phase == k8sutil.ReadyStatus {
user.Status.Info = generateStatusInfo(user)
}
if err := opcontroller.UpdateStatus(client, user); err != nil {
logger.Errorf("failed to set object store user %q status to %q. %v", name, status, err)
return
}
logger.Debugf("object store user %q status updated to %q", name, status)
}