forked from rook/rook
Blaine Gardner
3a243d2978
After further consideration and working with the feature for a few weeks, the `configOverride` functionality seems to be more complexity than is worth it for the expected benefit. Users still have the most preferred option of setting configs in Ceph's config database using `ceph cofig set` or the dashboard, and the override ConfigMap still exists for fallback scenarios. The config database can still be used by Rook for setting necessary configs, but the user has no way of telling Rook to do so. Signed-off-by: Blaine Gardner <blaine.gardner@suse.com>
85 lines
2.5 KiB
Go
85 lines
2.5 KiB
Go
/*
|
|
Copyright 2019 The Rook Authors. All rights reserved.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package config
|
|
|
|
import (
|
|
"fmt"
|
|
|
|
"github.com/rook/rook/pkg/clusterd"
|
|
"github.com/rook/rook/pkg/daemon/ceph/client"
|
|
)
|
|
|
|
// MonStore provides methods for setting Ceph configurations in the centralized mon
|
|
// configuration database.
|
|
type MonStore struct {
|
|
context *clusterd.Context
|
|
namespace string
|
|
}
|
|
|
|
// GetMonStore returns a new MonStore for the cluster.
|
|
func GetMonStore(context *clusterd.Context, namespace string) *MonStore {
|
|
return &MonStore{
|
|
context: context,
|
|
namespace: namespace,
|
|
}
|
|
}
|
|
|
|
// Option defines the pieces of information relevant to Ceph configuration options.
|
|
type Option struct {
|
|
// Who is the entity(-ies) the option should apply to.
|
|
Who string
|
|
|
|
// Option is the option key
|
|
Option string
|
|
|
|
// Value is the value for the option
|
|
Value string
|
|
}
|
|
|
|
// Set sets a config in the centralized mon configuration database.
|
|
// https://docs.ceph.com/docs/master/rados/configuration/ceph-conf/#monitor-configuration-database
|
|
func (m *MonStore) Set(who, option, value string) error {
|
|
args := []string{"config", "set", who, normalizeKey(option), value}
|
|
cephCmd := client.NewCephCommand(m.context, m.namespace, args)
|
|
out, err := cephCmd.Run()
|
|
if err != nil {
|
|
return fmt.Errorf("failed to set Ceph config in the centralized mon configuration database; "+
|
|
"you may need to use the rook-config-override ConfigMap. output: %s. %+v", string(out), err)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// SetAll sets all configs from the overrides in the centralized mon configuration database.
|
|
// See MonStore.Set for more.
|
|
func (m *MonStore) SetAll(options ...Option) error {
|
|
var errs []error
|
|
for _, override := range options {
|
|
err := m.Set(override.Who, override.Option, override.Value)
|
|
if err != nil {
|
|
errs = append(errs, err)
|
|
}
|
|
}
|
|
if len(errs) > 0 {
|
|
retErr := fmt.Errorf("failed to set one or more Ceph configs")
|
|
for _, err := range errs {
|
|
retErr = fmt.Errorf("%+v. %+v", retErr, err)
|
|
}
|
|
return retErr
|
|
}
|
|
return nil
|
|
}
|