Santosh Pillai
4081a74448
Enabling pg_autoscalar module fails most probably becasue `ceph mgr module enable <>` is happening very quickly after ceph mgr starts. This PR adds a retry (5 times) with a sleep interval of 5 seconds (for each interval) to handle failure while enabling mgr modules. Signed-off-by: Santosh Pillai <sapillai@redhat.com>
99 lines
2.9 KiB
Go
Executable File
99 lines
2.9 KiB
Go
Executable File
/*
|
|
Copyright 2019 The Rook Authors. All rights reserved.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package client
|
|
|
|
import (
|
|
"fmt"
|
|
"strings"
|
|
"time"
|
|
|
|
"github.com/pkg/errors"
|
|
"github.com/rook/rook/pkg/clusterd"
|
|
cephver "github.com/rook/rook/pkg/operator/ceph/version"
|
|
)
|
|
|
|
var (
|
|
moduleEnableWaitTime = 5 * time.Second
|
|
)
|
|
|
|
// MgrEnableModule enables a mgr module
|
|
func MgrEnableModule(context *clusterd.Context, clusterName, name string, force bool) error {
|
|
retryCount := 5
|
|
for i := 0; i < retryCount; i++ {
|
|
err := enableModule(context, clusterName, name, force, "enable")
|
|
if err != nil {
|
|
if i < retryCount-1 {
|
|
logger.Warningf("failed to enable mgr module %q. trying again...", name)
|
|
time.Sleep(moduleEnableWaitTime)
|
|
continue
|
|
} else {
|
|
return errors.Wrapf(err, "failed to enable mgr module %q even after %d retries", name, retryCount)
|
|
}
|
|
}
|
|
break
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// MgrDisableModule disables a mgr module
|
|
func MgrDisableModule(context *clusterd.Context, clusterName, name string) error {
|
|
return enableModule(context, clusterName, name, false, "disable")
|
|
}
|
|
|
|
// MgrSetConfig applies a setting for a single mgr daemon
|
|
func MgrSetConfig(context *clusterd.Context, clusterName, mgrName string, cephVersion cephver.CephVersion, key, val string, force bool) (bool, error) {
|
|
var getArgs, setArgs []string
|
|
mgrID := fmt.Sprintf("mgr.%s", mgrName)
|
|
getArgs = append(getArgs, "config", "get", mgrID, key)
|
|
if val == "" {
|
|
setArgs = append(setArgs, "config", "rm", mgrID, key)
|
|
} else {
|
|
setArgs = append(setArgs, "config", "set", mgrID, key, val)
|
|
}
|
|
if force && cephVersion.IsAtLeastNautilus() {
|
|
setArgs = append(setArgs, "--force")
|
|
}
|
|
|
|
// Retrieve previous value to monitor changes
|
|
var prevVal string
|
|
buf, err := NewCephCommand(context, clusterName, getArgs).Run()
|
|
if err == nil {
|
|
prevVal = strings.TrimSpace(string(buf))
|
|
}
|
|
|
|
if _, err := NewCephCommand(context, clusterName, setArgs).Run(); err != nil {
|
|
return false, errors.Wrapf(err, "failed to set mgr config key %s to \"%s\"", key, val)
|
|
}
|
|
|
|
hasChanged := prevVal != val
|
|
return hasChanged, nil
|
|
}
|
|
|
|
func enableModule(context *clusterd.Context, clusterName, name string, force bool, action string) error {
|
|
args := []string{"mgr", "module", action, name}
|
|
if force {
|
|
args = append(args, "--force")
|
|
}
|
|
|
|
_, err := NewCephCommand(context, clusterName, args).Run()
|
|
if err != nil {
|
|
return errors.Wrapf(err, "failed to enable mgr module %q", name)
|
|
}
|
|
|
|
return nil
|
|
}
|