Files
my-rook-config/pkg/operator/ceph/csi/secrets.go
T
Madhu Rajanna ece9efd978 ceph: add mgr caps for csi-rbd-node client
If the kernel doesnt support mapping of
rbd image with deep-flatten feature,cephcsi
need to flatten the rbd image first and than
map the image on the node.

cephcsi first tries to add a task to flatten
the rbd image if its receives any permission
error it will try to call rbd CLI command which
is a blocking call.
This commit adds mgr caps to the csi-rbd-node user
so that cephcsi will add flatten task and return
immediate error to the kubelet, let kubelet retry
again,If we go with blocking rbd CLI call we may
end up having stale maps on the node in corner cases.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-12-08 17:09:18 +05:30

203 lines
6.1 KiB
Go

/*
Copyright 2019 The Rook Authors. All rights reserved.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package csi
import (
"github.com/pkg/errors"
"github.com/rook/rook/pkg/clusterd"
"github.com/rook/rook/pkg/daemon/ceph/client"
"github.com/rook/rook/pkg/operator/ceph/config/keyring"
"github.com/rook/rook/pkg/operator/k8sutil"
v1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
)
// #nosec because of the word `Secret`
const (
csiKeyringRBDProvisionerUsername = "client.csi-rbd-provisioner"
csiKeyringRBDNodeUsername = "client.csi-rbd-node"
CsiRBDNodeSecret = "rook-csi-rbd-node"
CsiRBDProvisionerSecret = "rook-csi-rbd-provisioner"
)
// #nosec because of the word `Secret`
const (
csiKeyringCephFSProvisionerUsername = "client.csi-cephfs-provisioner"
csiKeyringCephFSNodeUsername = "client.csi-cephfs-node"
CsiCephFSNodeSecret = "rook-csi-cephfs-node"
CsiCephFSProvisionerSecret = "rook-csi-cephfs-provisioner"
)
func createCSIKeyringRBDNode(s *keyring.SecretStore) (string, error) {
key, err := s.GenerateKey(csiKeyringRBDNodeUsername, cephCSIKeyringRBDNodeCaps())
if err != nil {
return "", err
}
return key, nil
}
func createCSIKeyringRBDProvisioner(s *keyring.SecretStore) (string, error) {
key, err := s.GenerateKey(csiKeyringRBDProvisionerUsername, cephCSIKeyringRBDProvisionerCaps())
if err != nil {
return "", err
}
return key, nil
}
func createCSIKeyringCephFSNode(s *keyring.SecretStore) (string, error) {
key, err := s.GenerateKey(csiKeyringCephFSNodeUsername, cephCSIKeyringCephFSNodeCaps())
if err != nil {
return "", err
}
return key, nil
}
func createCSIKeyringCephFSProvisioner(s *keyring.SecretStore) (string, error) {
key, err := s.GenerateKey(csiKeyringCephFSProvisionerUsername, cephCSIKeyringCephFSProvisionerCaps())
if err != nil {
return "", err
}
return key, nil
}
func cephCSIKeyringRBDNodeCaps() []string {
return []string{
"mon", "profile rbd",
"mgr", "allow rw",
"osd", "profile rbd",
}
}
func cephCSIKeyringRBDProvisionerCaps() []string {
return []string{
"mon", "profile rbd",
"mgr", "allow rw",
"osd", "profile rbd",
}
}
func cephCSIKeyringCephFSNodeCaps() []string {
return []string{
"mon", "allow r",
"mgr", "allow rw",
"osd", "allow rw tag cephfs *=*",
"mds", "allow rw",
}
}
func cephCSIKeyringCephFSProvisionerCaps() []string {
return []string{
"mon", "allow r",
"mgr", "allow rw",
"osd", "allow rw tag cephfs metadata=*",
}
}
func createOrUpdateCSISecret(clusterInfo *client.ClusterInfo, csiRBDProvisionerSecretKey, csiRBDNodeSecretKey, csiCephFSProvisionerSecretKey, csiCephFSNodeSecretKey string, k *keyring.SecretStore) error {
csiRBDProvisionerSecrets := map[string][]byte{
// userID is expected for the rbd provisioner driver
"userID": []byte("csi-rbd-provisioner"),
"userKey": []byte(csiRBDProvisionerSecretKey),
}
csiRBDNodeSecrets := map[string][]byte{
// userID is expected for the rbd node driver
"userID": []byte("csi-rbd-node"),
"userKey": []byte(csiRBDNodeSecretKey),
}
csiCephFSProvisionerSecrets := map[string][]byte{
// adminID is expected for the cephfs provisioner driver
"adminID": []byte("csi-cephfs-provisioner"),
"adminKey": []byte(csiCephFSProvisionerSecretKey),
}
csiCephFSNodeSecrets := map[string][]byte{
// adminID is expected for the cephfs node driver
"adminID": []byte("csi-cephfs-node"),
"adminKey": []byte(csiCephFSNodeSecretKey),
}
keyringSecretMap := make(map[string]map[string][]byte)
keyringSecretMap[CsiRBDProvisionerSecret] = csiRBDProvisionerSecrets
keyringSecretMap[CsiRBDNodeSecret] = csiRBDNodeSecrets
keyringSecretMap[CsiCephFSProvisionerSecret] = csiCephFSProvisionerSecrets
keyringSecretMap[CsiCephFSNodeSecret] = csiCephFSNodeSecrets
for secretName, secret := range keyringSecretMap {
s := &v1.Secret{
ObjectMeta: metav1.ObjectMeta{
Name: secretName,
Namespace: clusterInfo.Namespace,
},
Data: secret,
Type: k8sutil.RookType,
}
k8sutil.SetOwnerRef(&s.ObjectMeta, &clusterInfo.OwnerRef)
// Create Kubernetes Secret
err := k.CreateSecret(s)
if err != nil {
return errors.Wrapf(err, "failed to create kubernetes secret %q for cluster %q", secret, clusterInfo.Namespace)
}
}
logger.Infof("created kubernetes csi secrets for cluster %q", clusterInfo.Namespace)
return nil
}
// CreateCSISecrets creates all the Kubernetes CSI Secrets
func CreateCSISecrets(context *clusterd.Context, clusterInfo *client.ClusterInfo) error {
k := keyring.GetSecretStore(context, clusterInfo, &clusterInfo.OwnerRef)
// Create CSI RBD Provisioner Ceph key
csiRBDProvisionerSecretKey, err := createCSIKeyringRBDProvisioner(k)
if err != nil {
return errors.Wrap(err, "failed to create csi rbd provisioner ceph keyring")
}
// Create CSI RBD Node Ceph key
csiRBDNodeSecretKey, err := createCSIKeyringRBDNode(k)
if err != nil {
return errors.Wrap(err, "failed to create csi rbd node ceph keyring")
}
// Create CSI Cephfs provisioner Ceph key
csiCephFSProvisionerSecretKey, err := createCSIKeyringCephFSProvisioner(k)
if err != nil {
return errors.Wrap(err, "failed to create csi cephfs provisioner ceph keyring")
}
// Create CSI Cephfs node Ceph key
csiCephFSNodeSecretKey, err := createCSIKeyringCephFSNode(k)
if err != nil {
return errors.Wrap(err, "failed to create csi cephfs node ceph keyring")
}
// Create or update Kubernetes CSI secret
if err := createOrUpdateCSISecret(clusterInfo, csiRBDProvisionerSecretKey, csiRBDNodeSecretKey, csiCephFSProvisionerSecretKey, csiCephFSNodeSecretKey, k); err != nil {
return errors.Wrap(err, "failed to create kubernetes csi secret")
}
return nil
}