Sébastien Han
dbac1c11d0
callCephVolume() was using our exec interface with CombinedOutput which means return both stdout and stderr. This is fine when preparing OSDs since we read back the stdout and also want any errors if any (stderr). However when listing OSD we only want the output since ceph-volume tends to mix stdout and stderr in the output and does not always silence the warning types/harmless errors. If the listing has a problem we report it by printing the ceph-volume log file. Signed-off-by: Sébastien Han <seb@redhat.com>
395 lines
12 KiB
Go
395 lines
12 KiB
Go
/*
|
|
Copyright 2016 The Rook Authors. All rights reserved.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
package osd
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/pkg/errors"
|
|
"github.com/rook/rook/pkg/clusterd"
|
|
cephclient "github.com/rook/rook/pkg/daemon/ceph/client"
|
|
cephver "github.com/rook/rook/pkg/operator/ceph/version"
|
|
exectest "github.com/rook/rook/pkg/util/exec/test"
|
|
"github.com/rook/rook/pkg/util/sys"
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
const (
|
|
udevFSOutput = `
|
|
DEVNAME=/dev/sdk
|
|
DEVPATH=/devices/platform/host6/session2/target6:0:0/6:0:0:0/block/sdk
|
|
DEVTYPE=disk
|
|
ID_BUS=scsi
|
|
ID_FS_TYPE=ext2
|
|
ID_FS_USAGE=filesystem
|
|
ID_FS_UUID=f2d38cba-37da-411d-b7ba-9a6696c58174
|
|
ID_FS_UUID_ENC=f2d38cba-37da-411d-b7ba-9a6696c58174
|
|
ID_FS_VERSION=1.0
|
|
ID_MODEL=disk01
|
|
ID_MODEL_ENC=disk01\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20
|
|
ID_PATH=ip-127.0.0.1:3260-iscsi-iqn.2016-06.world.srv:storage.target01-lun-0
|
|
ID_PATH_TAG=ip-127_0_0_1_3260-iscsi-iqn_2016-06_world_srv_storage_target01-lun-0
|
|
ID_REVISION=4.0
|
|
ID_SCSI=1
|
|
ID_SCSI_SERIAL=d27e5d89-8829-468b-90ce-4ef8c02f07fe
|
|
ID_SERIAL=36001405d27e5d898829468b90ce4ef8c
|
|
ID_SERIAL_SHORT=6001405d27e5d898829468b90ce4ef8c
|
|
ID_TARGET_PORT=0
|
|
ID_TYPE=disk
|
|
ID_VENDOR=LIO-ORG
|
|
ID_VENDOR_ENC=LIO-ORG\x20
|
|
ID_WWN=0x6001405d27e5d898
|
|
ID_WWN_VENDOR_EXTENSION=0x829468b90ce4ef8c
|
|
ID_WWN_WITH_EXTENSION=0x6001405d27e5d898829468b90ce4ef8c
|
|
MAJOR=8
|
|
MINOR=160
|
|
SUBSYSTEM=block
|
|
TAGS=:systemd:
|
|
USEC_INITIALIZED=15981915740802
|
|
`
|
|
|
|
udevPartOutput = `
|
|
DEVNAME=/dev/sdt1
|
|
DEVLINKS=/dev/disk/by-partlabel/test
|
|
DEVPATH=/devices/LNXSYSTM:00/LNXSYBUS:00/ACPI0004:00/VMBUS:00/763a35b7-6c97-461e-a494-c92c785255d0/host0/target0:0:0/0:0:0:0/block/sdt/sdt1
|
|
DEVTYPE=partition
|
|
ID_BUS=scsi
|
|
ID_MODEL=Virtual_Disk
|
|
ID_MODEL_ENC=Virtual\x20Disk\x20\x20\x20\x20
|
|
ID_PART_ENTRY_DISK=8:0
|
|
ID_PART_ENTRY_NUMBER=2
|
|
ID_PART_ENTRY_OFFSET=1050624
|
|
ID_PART_ENTRY_SCHEME=gpt
|
|
ID_PART_ENTRY_SIZE=535818240
|
|
ID_PART_ENTRY_TYPE=0fc63daf-8483-4772-8e79-3d69d8477de4
|
|
ID_PART_ENTRY_UUID=ce8b0ba3-b2b6-48f8-8ffb-4231fef4a5b5
|
|
ID_PART_TABLE_TYPE=gpt
|
|
ID_PART_TABLE_UUID=4180a289-da60-4d28-b951-91456d8848ed
|
|
ID_PATH=acpi-VMBUS:00-scsi-0:0:0:0
|
|
ID_PATH_TAG=acpi-VMBUS_00-scsi-0_0_0_0
|
|
ID_REVISION=1.0
|
|
ID_SCSI=1
|
|
ID_SERIAL=3600224807a025e35d9994b5f1d81cf8f
|
|
ID_SERIAL_SHORT=600224807a025e35d9994b5f1d81cf8f
|
|
ID_TYPE=disk
|
|
ID_VENDOR=Msft
|
|
ID_VENDOR_ENC=Msft\x20\x20\x20\x20
|
|
ID_WWN=0x600224807a025e35
|
|
ID_WWN_VENDOR_EXTENSION=0xd9994b5f1d81cf8f
|
|
ID_WWN_WITH_EXTENSION=0x600224807a025e35d9994b5f1d81cf8f
|
|
MAJOR=8
|
|
MINOR=2
|
|
PARTN=2
|
|
SUBSYSTEM=block
|
|
TAGS=:systemd:
|
|
USEC_INITIALIZED=1128667
|
|
`
|
|
|
|
cvInventoryOutputAvailable = `
|
|
{
|
|
"available":true,
|
|
"lvs":[
|
|
|
|
],
|
|
"rejected_reasons":[
|
|
""
|
|
],
|
|
"sys_api":{
|
|
"size":10737418240.0,
|
|
"scheduler_mode":"mq-deadline",
|
|
"rotational":"0",
|
|
"vendor":"",
|
|
"human_readable_size":"10.00 GB",
|
|
"sectors":0,
|
|
"sas_device_handle":"",
|
|
"rev":"",
|
|
"sas_address":"",
|
|
"locked":0,
|
|
"sectorsize":"512",
|
|
"removable":"0",
|
|
"path":"/dev/sdb",
|
|
"support_discard":"0",
|
|
"model":"",
|
|
"ro":"0",
|
|
"nr_requests":"64",
|
|
"partitions":{
|
|
|
|
}
|
|
},
|
|
"path":"/dev/sdb",
|
|
"device_id":""
|
|
}
|
|
`
|
|
|
|
cvInventoryOutputNotAvailableBluestoreLabel = `
|
|
{
|
|
"available":false,
|
|
"lvs":[
|
|
|
|
],
|
|
"rejected_reasons":[
|
|
"Has BlueStore device label"
|
|
]
|
|
}
|
|
`
|
|
|
|
cvInventoryOutputNotAvailableLocked = `
|
|
{
|
|
"available":false,
|
|
"lvs":[
|
|
|
|
],
|
|
"rejected_reasons":[
|
|
"locked"
|
|
]
|
|
}
|
|
`
|
|
|
|
cvInventoryOutputNotAvailableSmall = `
|
|
{
|
|
"available":false,
|
|
"lvs":[
|
|
|
|
],
|
|
"rejected_reasons":[
|
|
["Insufficient space (<5GB)"]
|
|
]
|
|
}
|
|
`
|
|
)
|
|
|
|
func TestAvailableDevices(t *testing.T) {
|
|
// set up a mock function to return "rook owned" partitions on the device and it does not have a filesystem
|
|
executor := &exectest.MockExecutor{
|
|
MockExecuteCommandWithOutput: func(command string, args ...string) (string, error) {
|
|
logger.Infof("OUTPUT for %s %v", command, args)
|
|
|
|
if command == "lsblk" {
|
|
if strings.Index(args[3], "sdb") != -1 {
|
|
// /dev/sdb has a partition
|
|
return `NAME="sdb" SIZE="65" TYPE="disk" PKNAME=""
|
|
NAME="sdb1" SIZE="30" TYPE="part" PKNAME="sdb"`, nil
|
|
} else if strings.Index(args[0], "vg1-lv") != -1 {
|
|
// /dev/mapper/vg1-lv* are LVs
|
|
return `TYPE="lvm"`, nil
|
|
} else if strings.Index(args[0], "sdt1") != -1 {
|
|
return `TYPE="part"`, nil
|
|
} else if strings.HasPrefix(args[0], "/dev") {
|
|
return `TYPE="disk"`, nil
|
|
}
|
|
return "", nil
|
|
} else if command == "blkid" {
|
|
if strings.Index(args[3], "sdb1") != -1 {
|
|
// partition sdb1 has a label MY-PART
|
|
return "MY-PART", nil
|
|
}
|
|
} else if command == "udevadm" {
|
|
if strings.Index(args[2], "sdc") != -1 {
|
|
// /dev/sdc has a file system
|
|
return udevFSOutput, nil
|
|
} else if strings.Index(args[2], "sdt1") != -1 {
|
|
return udevPartOutput, nil
|
|
}
|
|
|
|
return "", nil
|
|
} else if command == "dmsetup" && args[0] == "info" {
|
|
if strings.Index(args[5], "vg1-lv1") != -1 {
|
|
return "vg1-lv1", nil
|
|
} else if strings.Index(args[5], "vg1-lv2") != -1 {
|
|
return "vg1-lv2", nil
|
|
}
|
|
} else if command == "dmsetup" && args[0] == "splitname" {
|
|
if strings.Index(args[2], "vg1-lv1") != -1 {
|
|
return "vg1:lv1:", nil
|
|
} else if strings.Index(args[2], "vg1-lv2") != -1 {
|
|
return "vg1:lv2:", nil
|
|
}
|
|
} else if command == "ceph-volume" {
|
|
if args[0] == "inventory" {
|
|
if strings.Index(args[3], "/mnt/set1-0-data-qfhfk") != -1 {
|
|
return cvInventoryOutputNotAvailableBluestoreLabel, nil
|
|
} else if strings.Index(args[3], "sdb") != -1 {
|
|
// sdb is locked
|
|
return cvInventoryOutputNotAvailableLocked, nil
|
|
} else if strings.Index(args[3], "sdc") != -1 {
|
|
// sdc is too small
|
|
return cvInventoryOutputNotAvailableSmall, nil
|
|
}
|
|
|
|
return cvInventoryOutputAvailable, nil
|
|
}
|
|
|
|
} else if command == "stdbuf" {
|
|
if args[4] == "raw" && args[5] == "list" {
|
|
return cephVolumeRAWTestResult, nil
|
|
} else if command == "ceph-volume" && args[0] == "lvm" {
|
|
if args[4] == "vg1/lv2" {
|
|
return `{"0":[{"name":"lv2","type":"block"}]}`, nil
|
|
}
|
|
}
|
|
return "{}", nil
|
|
}
|
|
return "", errors.Errorf("unknown command %s %s", command, args)
|
|
},
|
|
}
|
|
|
|
context := &clusterd.Context{Executor: executor}
|
|
context.Devices = []*sys.LocalDisk{
|
|
{Name: "sda", DevLinks: "/dev/disk/by-id/scsi-0123 /dev/disk/by-path/pci-0:1:2:3-scsi-1", RealPath: "/dev/sda"},
|
|
{Name: "sdb", DevLinks: "/dev/disk/by-id/scsi-4567 /dev/disk/by-path/pci-4:5:6:7-scsi-1", RealPath: "/dev/sdb"},
|
|
{Name: "sdc", DevLinks: "/dev/disk/by-id/scsi-89ab /dev/disk/by-path/pci-8:9:a:b-scsi-1", RealPath: "/dev/sdc"},
|
|
{Name: "sdd", DevLinks: "/dev/disk/by-id/scsi-cdef /dev/disk/by-path/pci-c:d:e:f-scsi-1", RealPath: "/dev/sdd"},
|
|
{Name: "sde", DevLinks: "/dev/disk/by-id/sde-0x0000 /dev/disk/by-path/pci-0000:00:18.0-ata-1", RealPath: "/dev/sde"},
|
|
{Name: "nvme01", DevLinks: "/dev/disk/by-id/nvme-0246 /dev/disk/by-path/pci-0:2:4:6-nvme-1", RealPath: "/dev/nvme01"},
|
|
{Name: "rda", RealPath: "/dev/rda"},
|
|
{Name: "rdb", RealPath: "/dev/rdb"},
|
|
{Name: "sdt1", RealPath: "/dev/sdt1", Type: sys.PartType},
|
|
}
|
|
|
|
version := cephver.Octopus
|
|
|
|
// select all devices, including nvme01 for metadata
|
|
pvcBackedOSD := false
|
|
agent := &OsdAgent{
|
|
devices: []DesiredDevice{{Name: "all"}},
|
|
metadataDevice: "nvme01",
|
|
pvcBacked: pvcBackedOSD,
|
|
clusterInfo: &cephclient.ClusterInfo{},
|
|
}
|
|
agent.clusterInfo.CephVersion = version
|
|
mapping, err := getAvailableDevices(context, agent)
|
|
assert.Nil(t, err)
|
|
assert.Equal(t, 7, len(mapping.Entries))
|
|
assert.Equal(t, -1, mapping.Entries["sda"].Data)
|
|
assert.Equal(t, -1, mapping.Entries["sdd"].Data)
|
|
assert.Equal(t, -1, mapping.Entries["rda"].Data)
|
|
assert.Equal(t, -1, mapping.Entries["rdb"].Data)
|
|
assert.Equal(t, -1, mapping.Entries["nvme01"].Data)
|
|
assert.NotNil(t, mapping.Entries["nvme01"].Metadata)
|
|
assert.Equal(t, 0, len(mapping.Entries["nvme01"].Metadata))
|
|
|
|
// Partition is skipped
|
|
agent.clusterInfo.CephVersion = cephver.Nautilus
|
|
mapping, err = getAvailableDevices(context, agent)
|
|
assert.Nil(t, err)
|
|
assert.Equal(t, 6, len(mapping.Entries))
|
|
|
|
// Do not skip partition anymore
|
|
agent.clusterInfo.CephVersion = cephver.Octopus
|
|
|
|
// select no devices both using and not using a filter
|
|
agent.metadataDevice = ""
|
|
agent.devices = nil
|
|
mapping, err = getAvailableDevices(context, agent)
|
|
assert.Nil(t, err)
|
|
assert.Equal(t, 0, len(mapping.Entries))
|
|
|
|
mapping, err = getAvailableDevices(context, agent)
|
|
assert.Nil(t, err)
|
|
assert.Equal(t, 0, len(mapping.Entries))
|
|
|
|
// select the sd* devices
|
|
agent.devices = []DesiredDevice{{Name: "^sd.$", IsFilter: true}}
|
|
mapping, err = getAvailableDevices(context, agent)
|
|
assert.Nil(t, err)
|
|
assert.Equal(t, 3, len(mapping.Entries))
|
|
assert.Equal(t, -1, mapping.Entries["sda"].Data)
|
|
assert.Equal(t, -1, mapping.Entries["sdd"].Data)
|
|
|
|
// select an exact device
|
|
agent.devices = []DesiredDevice{{Name: "sdd"}}
|
|
mapping, err = getAvailableDevices(context, agent)
|
|
assert.Nil(t, err)
|
|
assert.Equal(t, 1, len(mapping.Entries))
|
|
assert.Equal(t, -1, mapping.Entries["sdd"].Data)
|
|
|
|
// select all devices except those that have a prefix of "s"
|
|
agent.devices = []DesiredDevice{{Name: "^[^s]", IsFilter: true}}
|
|
mapping, err = getAvailableDevices(context, agent)
|
|
assert.Nil(t, err)
|
|
assert.Equal(t, 3, len(mapping.Entries))
|
|
assert.Equal(t, -1, mapping.Entries["rda"].Data)
|
|
assert.Equal(t, -1, mapping.Entries["rdb"].Data)
|
|
assert.Equal(t, -1, mapping.Entries["nvme01"].Data)
|
|
|
|
// select the sd* devices by devicePathFilter
|
|
agent.devices = []DesiredDevice{{Name: "^/dev/sd.$", IsDevicePathFilter: true}}
|
|
mapping, err = getAvailableDevices(context, agent)
|
|
assert.Nil(t, err)
|
|
assert.Equal(t, 3, len(mapping.Entries))
|
|
assert.Equal(t, -1, mapping.Entries["sda"].Data)
|
|
assert.Equal(t, -1, mapping.Entries["sdd"].Data)
|
|
|
|
// select the devices that have udev persistent names by devicePathFilter
|
|
agent.devices = []DesiredDevice{{Name: "^/dev/disk/by-path/.*-scsi-.*", IsDevicePathFilter: true}}
|
|
mapping, err = getAvailableDevices(context, agent)
|
|
assert.Nil(t, err)
|
|
assert.Equal(t, 2, len(mapping.Entries))
|
|
assert.Equal(t, -1, mapping.Entries["sda"].Data)
|
|
assert.Equal(t, -1, mapping.Entries["sdd"].Data)
|
|
agent.devices = []DesiredDevice{{Name: "^/dev/disk/by-partlabel/te.*", IsDevicePathFilter: true}}
|
|
mapping, err = getAvailableDevices(context, agent)
|
|
assert.Nil(t, err)
|
|
assert.Equal(t, 1, len(mapping.Entries))
|
|
assert.Equal(t, -1, mapping.Entries["sdt1"].Data)
|
|
|
|
// select a device by explicit link
|
|
agent.devices = []DesiredDevice{{Name: "/dev/disk/by-id/sde-0x0000"}}
|
|
mapping, err = getAvailableDevices(context, agent)
|
|
assert.Nil(t, err)
|
|
assert.Equal(t, 1, len(mapping.Entries))
|
|
assert.Equal(t, -1, mapping.Entries["sde"].Data)
|
|
agent.devices = []DesiredDevice{{Name: "/dev/disk/by-partlabel/test"}}
|
|
mapping, err = getAvailableDevices(context, agent)
|
|
assert.Nil(t, err)
|
|
assert.Equal(t, 1, len(mapping.Entries))
|
|
assert.Equal(t, -1, mapping.Entries["sdt1"].Data)
|
|
|
|
// test on PVC
|
|
context.Devices = []*sys.LocalDisk{
|
|
{Name: "/mnt/set1-0-data-qfhfk", RealPath: "/dev/xvdcy", Type: "data"},
|
|
}
|
|
agent.devices = []DesiredDevice{{Name: "all"}}
|
|
agent.pvcBacked = true
|
|
mapping, err = getAvailableDevices(context, agent)
|
|
assert.Nil(t, err)
|
|
assert.Equal(t, 1, len(mapping.Entries), mapping)
|
|
|
|
// on PVC, backed by LV, available
|
|
context.Devices = []*sys.LocalDisk{
|
|
{Name: "/mnt/set1-0-data-wjkla", RealPath: "/dev/mapper/vg1-lv1", Type: "data"},
|
|
}
|
|
mapping, err = getAvailableDevices(context, agent)
|
|
assert.Nil(t, err)
|
|
assert.Equal(t, 1, len(mapping.Entries), mapping)
|
|
}
|
|
|
|
func TestGetVolumeGroupName(t *testing.T) {
|
|
validLVPath := "/dev/vgName1/lvName2"
|
|
invalidLVPath1 := "/dev//vgName2"
|
|
invalidLVPath2 := "/dev/"
|
|
|
|
vgName := getVolumeGroupName(validLVPath)
|
|
assert.Equal(t, vgName, "vgName1")
|
|
|
|
vgName = getVolumeGroupName(invalidLVPath1)
|
|
assert.Equal(t, vgName, "")
|
|
|
|
vgName = getVolumeGroupName(invalidLVPath2)
|
|
assert.Equal(t, vgName, "")
|
|
}
|