Files
my-rook-config/pkg/daemon/util/copybins.go
T
subhamkrai c938849cf8 ceph: closing file which are open for writing
using defer for closing file which are open
for writing is not safe. so closing file again
following  below steps:
1. open files
2. defer file.close()
3. write
4.file.close()

these will make sure files are closed.

Signed-off-by: subhamkrai <subhamkumarrai03@gmail.com>
2020-07-30 22:37:56 +05:30

77 lines
2.1 KiB
Go

/*
Copyright 2019 The Rook Authors. All rights reserved.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package util
import (
"io"
"os"
"os/exec"
"path"
"path/filepath"
)
// override these for unit testing
var defaultRookDir = "/usr/local/bin"
var defaultTiniDir = "/"
// CopyBinaries copies the "tini" and "rook" binaries to a shared volume at the target path.
func CopyBinaries(target string) error {
if err := copyBinary(defaultRookDir, target, "rook"); err != nil {
return err
}
return copyBinary(defaultTiniDir, target, "tini")
}
// #nosec G307 Calling defer to close the file without checking the error return is not a risk for a simple file open and close
func copyBinary(sourceDir, targetDir, filename string) error {
sourcePath := path.Join(sourceDir, filename)
targetPath := path.Join(targetDir, filename)
logger.Infof("copying %s to %s", sourcePath, targetPath)
// Check if the source path exists, and look in PATH if it doesn't
if _, err := os.Stat(sourcePath); err != nil {
if sourcePath, err = exec.LookPath(filename); err != nil {
return err
}
}
// Check if the target path exists, and skip the copy if it does
if _, err := os.Stat(targetPath); err == nil {
return nil
}
sourceFile, err := os.Open(filepath.Clean(sourcePath))
if err != nil {
return err
}
defer sourceFile.Close()
destinationFile, err := os.Create(filepath.Clean(targetPath))
if err != nil {
return err
}
defer destinationFile.Close()
if _, err := io.Copy(destinationFile, sourceFile); err != nil {
return err
}
if err := destinationFile.Close(); err != nil {
return err
}
// #nosec targetPath requires the permission to execute
return os.Chmod(targetPath, 0700)
}