Files
my-rook-config/pkg/operator/ceph/object/bucket/util.go
T
Blaine Gardner a777b1d7d1 object: do not create service for external object stores
External CephObjectStores already have endpoints defined by
spec.gateway.externalRgwEndpoints, and if the external store is
configured with TLS (HTTPS), the store's certificates will likely not
accept connections intended for the Service endpoint Rook creates. Some
users might not be able to easily add the service endpoint to their
certificates. Therefore, don't even bother creating a Service for
external clusters.

This does introduce a few issues. The Service seems to have been
initially created to allow multiple external RGW endpoints to be
addressable via a single address in Rook. For all connections to an
external CephObjectStore with multiple endpoints, simply choose an
endpoint at random. Random selection will prevent Rook from failing to
create buckets or users on an external store if one of the external
store's endpoints fails.

The latest OBC library (lib-bucket-provisioner) allows updating the
endpoints on ObjectBuckets after they are created. This allows Rook
users to change endpoints on external CephObjectStores without breaking
all existing OBCs. It requires implementation of the new GetUserID()
library call, requires updating Provision() and Grant() calls to be
idempotent, and it requires removing the Update() call.

Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
2022-11-04 17:30:30 -06:00

142 lines
5.2 KiB
Go

/*
Copyright 2018 The Kubernetes Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package bucket
import (
"fmt"
"github.com/coreos/pkg/capnslog"
"github.com/kube-object-storage/lib-bucket-provisioner/pkg/apis/objectbucket.io/v1alpha1"
bktv1alpha1 "github.com/kube-object-storage/lib-bucket-provisioner/pkg/apis/objectbucket.io/v1alpha1"
"github.com/kube-object-storage/lib-bucket-provisioner/pkg/provisioner"
"github.com/pkg/errors"
cephv1 "github.com/rook/rook/pkg/apis/ceph.rook.io/v1"
cephObject "github.com/rook/rook/pkg/operator/ceph/object"
storagev1 "k8s.io/api/storage/v1"
kerrors "k8s.io/apimachinery/pkg/api/errors"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/types"
"k8s.io/client-go/rest"
)
var logger = capnslog.NewPackageLogger("github.com/rook/rook", "op-bucket-prov")
const (
CephUser = "cephUser"
ObjectStoreName = "objectStoreName"
ObjectStoreNamespace = "objectStoreNamespace"
objectStoreEndpoint = "endpoint"
)
func NewBucketController(cfg *rest.Config, p *Provisioner, data map[string]string) (*provisioner.Provisioner, error) {
const allNamespaces = ""
provName := cephObject.GetObjectBucketProvisioner(data, p.clusterInfo.Namespace)
logger.Infof("ceph bucket provisioner launched watching for provisioner %q", provName)
return provisioner.NewProvisioner(cfg, provName, p, allNamespaces)
}
func getObjectStoreName(sc *storagev1.StorageClass) string {
return sc.Parameters[ObjectStoreName]
}
func getObjectStoreEndpoint(sc *storagev1.StorageClass) string {
return sc.Parameters[objectStoreEndpoint]
}
func getBucketName(ob *bktv1alpha1.ObjectBucket) string {
return ob.Spec.Endpoint.BucketName
}
func isStaticBucket(sc *storagev1.StorageClass) (string, bool) {
const key = "bucketName"
val, ok := sc.Parameters[key]
return val, ok
}
func getCephUser(ob *bktv1alpha1.ObjectBucket) string {
return ob.Spec.AdditionalState[CephUser]
}
func (p *Provisioner) getObjectStore() (*cephv1.CephObjectStore, error) {
ctx := p.clusterInfo.Context
// Verify the object store API object actually exists
store, err := p.context.RookClientset.CephV1().CephObjectStores(p.clusterInfo.Namespace).Get(ctx, p.objectStoreName, metav1.GetOptions{})
if err != nil {
if kerrors.IsNotFound(err) {
return nil, errors.Wrap(err, "cephObjectStore not found")
}
return nil, errors.Wrapf(err, "failed to get ceph object store %q", p.objectStoreName)
}
return store, err
}
func (p *Provisioner) getCephCluster() (*cephv1.CephCluster, error) {
cephCluster, err := p.context.RookClientset.CephV1().CephClusters(p.clusterInfo.Namespace).List(p.clusterInfo.Context, metav1.ListOptions{})
if err != nil {
return nil, errors.Wrapf(err, "failed to list ceph clusters in namespace %q", p.clusterInfo.Namespace)
}
if len(cephCluster.Items) == 0 {
return nil, errors.Errorf("failed to find ceph cluster in namespace %q", p.clusterInfo.Namespace)
}
// This is a bit weak, but there will always be a single cluster per namespace anyway
return &cephCluster.Items[0], err
}
func MaxObjectQuota(AdditionalConfig map[string]string) string {
return AdditionalConfig["maxObjects"]
}
func MaxSizeQuota(AdditionalConfig map[string]string) string {
return AdditionalConfig["maxSize"]
}
func GetObjectStoreNameFromBucket(ob *v1alpha1.ObjectBucket) (types.NamespacedName, error) {
// Rook v1.11 OBCs have additional state labels that tell the object store namespace and name.
// This is critical for CephObjectStores in external mode that connect to RGW endpoints directly
// which don't have a deterministic domain structure.
nsName, err := getNSNameFromAdditionalState(ob.Spec.AdditionalState)
if err == nil {
return nsName, nil
}
// TODO: remove after Rook v1.12
// Older OBCs don't have the additional state labels, but they will always be configured to use
// the legacy CephObjectStore Service which has a deterministic domain structure.
logger.Debugf("falling back to legacy method for determining OBC \"%s/%s\"'s CephObjectStore from endpoint %q",
ob.Namespace, ob.Name, ob.Spec.Connection.Endpoint.BucketHost)
nsName, err = cephObject.ParseDomainName(ob.Spec.Connection.Endpoint.BucketHost)
if err != nil {
return types.NamespacedName{}, errors.Wrapf(err, "malformed BucketHost %q", ob.Spec.Endpoint.BucketHost)
}
return nsName, nil
}
func getNSNameFromAdditionalState(state map[string]string) (types.NamespacedName, error) {
name, ok := state[ObjectStoreName]
if !ok {
return types.NamespacedName{}, fmt.Errorf("failed to get %q from OB additional state: %v", ObjectStoreName, state)
}
namespace, ok := state[ObjectStoreNamespace]
if !ok {
return types.NamespacedName{}, fmt.Errorf("failed to get %q from OB additional state: %v", ObjectStoreNamespace, state)
}
return types.NamespacedName{Name: name, Namespace: namespace}, nil
}