forked from rook/rook
Travis Nielsen
d55669293a
The failover of the arbiter mon in a stretch cluster was sometimes failing due to the new tiebreaker not being set in ceph. Rook would repeatedly try to remove the old tiebreaker mon and keep failing because the new tiebreaker had not been set. Now we make setting the tiebreaker idempotent in case the operator restarts in the middle of the operation or some other corner case causes the expected tiebreaker to be set. In that case, the next reconcile will also ensure the tiebreaker mon is set as expected. Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
481 lines
18 KiB
Go
Executable File
481 lines
18 KiB
Go
Executable File
/*
|
||
Copyright 2018 The Rook Authors. All rights reserved.
|
||
|
||
Licensed under the Apache License, Version 2.0 (the "License");
|
||
you may not use this file except in compliance with the License.
|
||
You may obtain a copy of the License at
|
||
|
||
http://www.apache.org/licenses/LICENSE-2.0
|
||
|
||
Unless required by applicable law or agreed to in writing, software
|
||
distributed under the License is distributed on an "AS IS" BASIS,
|
||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||
See the License for the specific language governing permissions and
|
||
limitations under the License.
|
||
*/
|
||
|
||
// Package cluster to manage a Ceph cluster.
|
||
package cluster
|
||
|
||
import (
|
||
"context"
|
||
"fmt"
|
||
"os/exec"
|
||
"path"
|
||
"sync"
|
||
"syscall"
|
||
|
||
"github.com/pkg/errors"
|
||
|
||
cephv1 "github.com/rook/rook/pkg/apis/ceph.rook.io/v1"
|
||
"github.com/rook/rook/pkg/clusterd"
|
||
"github.com/rook/rook/pkg/daemon/ceph/client"
|
||
"github.com/rook/rook/pkg/daemon/ceph/osd/kms"
|
||
"github.com/rook/rook/pkg/operator/ceph/cluster/crash"
|
||
"github.com/rook/rook/pkg/operator/ceph/cluster/mgr"
|
||
"github.com/rook/rook/pkg/operator/ceph/cluster/mon"
|
||
"github.com/rook/rook/pkg/operator/ceph/cluster/osd"
|
||
"github.com/rook/rook/pkg/operator/ceph/config"
|
||
"github.com/rook/rook/pkg/operator/ceph/controller"
|
||
"github.com/rook/rook/pkg/operator/ceph/csi"
|
||
cephver "github.com/rook/rook/pkg/operator/ceph/version"
|
||
"github.com/rook/rook/pkg/operator/k8sutil"
|
||
v1 "k8s.io/api/core/v1"
|
||
kerrors "k8s.io/apimachinery/pkg/api/errors"
|
||
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
|
||
"k8s.io/apimachinery/pkg/types"
|
||
)
|
||
|
||
const (
|
||
detectVersionName = "rook-ceph-detect-version"
|
||
)
|
||
|
||
type cluster struct {
|
||
ClusterInfo *client.ClusterInfo
|
||
context *clusterd.Context
|
||
Namespace string
|
||
Spec *cephv1.ClusterSpec
|
||
namespacedName types.NamespacedName
|
||
mons *mon.Cluster
|
||
ownerInfo *k8sutil.OwnerInfo
|
||
isUpgrade bool
|
||
monitoringRoutines map[string]*clusterHealth
|
||
}
|
||
|
||
type clusterHealth struct {
|
||
internalCtx context.Context
|
||
internalCancel context.CancelFunc
|
||
}
|
||
|
||
func newCluster(c *cephv1.CephCluster, context *clusterd.Context, csiMutex *sync.Mutex, ownerInfo *k8sutil.OwnerInfo) *cluster {
|
||
return &cluster{
|
||
// at this phase of the cluster creation process, the identity components of the cluster are
|
||
// not yet established. we reserve this struct which is filled in as soon as the cluster's
|
||
// identity can be established.
|
||
ClusterInfo: client.AdminClusterInfo(c.Namespace, c.Name),
|
||
Namespace: c.Namespace,
|
||
Spec: &c.Spec,
|
||
context: context,
|
||
namespacedName: types.NamespacedName{Namespace: c.Namespace, Name: c.Name},
|
||
monitoringRoutines: make(map[string]*clusterHealth),
|
||
ownerInfo: ownerInfo,
|
||
mons: mon.New(context, c.Namespace, c.Spec, ownerInfo, csiMutex),
|
||
}
|
||
}
|
||
|
||
func (c *cluster) reconcileCephDaemons(rookImage string, cephVersion cephver.CephVersion) error {
|
||
// Create a configmap for overriding ceph config settings
|
||
// These settings should only be modified by a user after they are initialized
|
||
err := populateConfigOverrideConfigMap(c.context, c.Namespace, c.ownerInfo)
|
||
if err != nil {
|
||
return errors.Wrap(err, "failed to populate config override config map")
|
||
}
|
||
c.ClusterInfo.SetName(c.namespacedName.Name)
|
||
|
||
// Start the mon pods
|
||
controller.UpdateCondition(c.ClusterInfo.Context, c.context, c.namespacedName, cephv1.ConditionProgressing, v1.ConditionTrue, cephv1.ClusterProgressingReason, "Configuring Ceph Mons")
|
||
clusterInfo, err := c.mons.Start(c.ClusterInfo, rookImage, cephVersion, *c.Spec)
|
||
if err != nil {
|
||
return errors.Wrap(err, "failed to start ceph monitors")
|
||
}
|
||
clusterInfo.OwnerInfo = c.ownerInfo
|
||
clusterInfo.SetName(c.namespacedName.Name)
|
||
clusterInfo.Context = c.ClusterInfo.Context
|
||
c.ClusterInfo = clusterInfo
|
||
c.ClusterInfo.NetworkSpec = c.Spec.Network
|
||
|
||
// The cluster Identity must be established at this point
|
||
if !c.ClusterInfo.IsInitialized(true) {
|
||
return errors.New("the cluster identity was not established")
|
||
}
|
||
|
||
if c.ClusterInfo.Context.Err() != nil {
|
||
return c.ClusterInfo.Context.Err()
|
||
}
|
||
|
||
// Execute actions after the monitors are up and running
|
||
logger.Debug("monitors are up and running, executing post actions")
|
||
err = c.postMonStartupActions()
|
||
if err != nil {
|
||
return errors.Wrap(err, "failed to execute post actions after all the ceph monitors started")
|
||
}
|
||
|
||
// Start Ceph manager
|
||
controller.UpdateCondition(c.ClusterInfo.Context, c.context, c.namespacedName, cephv1.ConditionProgressing, v1.ConditionTrue, cephv1.ClusterProgressingReason, "Configuring Ceph Mgr(s)")
|
||
mgrs := mgr.New(c.context, c.ClusterInfo, *c.Spec, rookImage)
|
||
err = mgrs.Start()
|
||
if err != nil {
|
||
return errors.Wrap(err, "failed to start ceph mgr")
|
||
}
|
||
|
||
// Start the OSDs
|
||
controller.UpdateCondition(c.ClusterInfo.Context, c.context, c.namespacedName, cephv1.ConditionProgressing, v1.ConditionTrue, cephv1.ClusterProgressingReason, "Configuring Ceph OSDs")
|
||
osds := osd.New(c.context, c.ClusterInfo, *c.Spec, rookImage)
|
||
err = osds.Start()
|
||
if err != nil {
|
||
return errors.Wrap(err, "failed to start ceph osds")
|
||
}
|
||
|
||
// If a stretch cluster, enable the arbiter after the OSDs are created with the CRUSH map
|
||
if c.Spec.IsStretchCluster() {
|
||
if err := c.mons.ConfigureArbiter(); err != nil {
|
||
return errors.Wrap(err, "failed to configure stretch arbiter")
|
||
}
|
||
}
|
||
|
||
logger.Infof("done reconciling ceph cluster in namespace %q", c.Namespace)
|
||
|
||
// We should be done updating by now
|
||
if c.isUpgrade {
|
||
c.printOverallCephVersion()
|
||
|
||
// reset the isUpgrade flag
|
||
c.isUpgrade = false
|
||
}
|
||
|
||
return nil
|
||
}
|
||
|
||
func (c *ClusterController) initializeCluster(cluster *cluster) error {
|
||
// Check if the dataDirHostPath is located in the disallowed paths list
|
||
cleanDataDirHostPath := path.Clean(cluster.Spec.DataDirHostPath)
|
||
for _, b := range disallowedHostDirectories {
|
||
if cleanDataDirHostPath == b {
|
||
logger.Errorf("dataDirHostPath (given: %q) must not be used, conflicts with %q internal path", cluster.Spec.DataDirHostPath, b)
|
||
return nil
|
||
}
|
||
}
|
||
|
||
clusterInfo, _, _, err := mon.LoadClusterInfo(c.context, c.OpManagerCtx, cluster.Namespace)
|
||
if err != nil {
|
||
logger.Infof("clusterInfo not yet found, must be a new cluster")
|
||
} else {
|
||
clusterInfo.OwnerInfo = cluster.ownerInfo
|
||
clusterInfo.SetName(c.namespacedName.Name)
|
||
cluster.ClusterInfo = clusterInfo
|
||
}
|
||
|
||
// Depending on the cluster type choose the correct orchestation
|
||
if cluster.Spec.External.Enable {
|
||
err := c.configureExternalCephCluster(cluster)
|
||
if err != nil {
|
||
controller.UpdateCondition(c.OpManagerCtx, c.context, c.namespacedName, cephv1.ConditionProgressing, v1.ConditionFalse, cephv1.ClusterProgressingReason, err.Error())
|
||
return errors.Wrap(err, "failed to configure external ceph cluster")
|
||
}
|
||
} else {
|
||
// If the local cluster has already been configured, immediately start monitoring the cluster.
|
||
// Test if the cluster has already been configured if the mgr deployment has been created.
|
||
// If the mgr does not exist, the mons have never been verified to be in quorum.
|
||
opts := metav1.ListOptions{LabelSelector: fmt.Sprintf("%s=%s", k8sutil.AppAttr, mgr.AppName)}
|
||
mgrDeployments, err := c.context.Clientset.AppsV1().Deployments(cluster.Namespace).List(c.OpManagerCtx, opts)
|
||
if err == nil && len(mgrDeployments.Items) > 0 && cluster.ClusterInfo != nil {
|
||
c.configureCephMonitoring(cluster, clusterInfo)
|
||
}
|
||
|
||
err = c.configureLocalCephCluster(cluster)
|
||
if err != nil {
|
||
controller.UpdateCondition(c.OpManagerCtx, c.context, c.namespacedName, cephv1.ConditionProgressing, v1.ConditionFalse, cephv1.ClusterProgressingReason, err.Error())
|
||
return errors.Wrap(err, "failed to configure local ceph cluster")
|
||
}
|
||
}
|
||
|
||
// Populate ClusterInfo with the last value
|
||
cluster.mons.ClusterInfo = cluster.ClusterInfo
|
||
cluster.mons.ClusterInfo.SetName(c.namespacedName.Name)
|
||
|
||
// Start the monitoring if not already started
|
||
c.configureCephMonitoring(cluster, cluster.ClusterInfo)
|
||
return nil
|
||
}
|
||
|
||
func (c *ClusterController) configureLocalCephCluster(cluster *cluster) error {
|
||
// Cluster Spec validation
|
||
err := preClusterStartValidation(cluster)
|
||
if err != nil {
|
||
return errors.Wrap(err, "failed to perform validation before cluster creation")
|
||
}
|
||
|
||
// Run image validation job
|
||
controller.UpdateCondition(c.OpManagerCtx, c.context, c.namespacedName, cephv1.ConditionProgressing, v1.ConditionTrue, cephv1.ClusterProgressingReason, "Detecting Ceph version")
|
||
cephVersion, isUpgrade, err := c.detectAndValidateCephVersion(cluster)
|
||
if err != nil {
|
||
return errors.Wrap(err, "failed the ceph version check")
|
||
}
|
||
// Set the value of isUpgrade based on the image discovery done by detectAndValidateCephVersion()
|
||
cluster.isUpgrade = isUpgrade
|
||
|
||
if cluster.Spec.IsStretchCluster() {
|
||
stretchVersion := cephver.CephVersion{Major: 16, Minor: 2, Build: 5}
|
||
if !cephVersion.IsAtLeast(stretchVersion) {
|
||
return errors.Errorf("stretch clusters minimum ceph version is %q, but is running %s", stretchVersion.String(), cephVersion.String())
|
||
}
|
||
}
|
||
|
||
controller.UpdateCondition(c.OpManagerCtx, c.context, c.namespacedName, cephv1.ConditionProgressing, v1.ConditionTrue, cephv1.ClusterProgressingReason, "Configuring the Ceph cluster")
|
||
|
||
cluster.ClusterInfo.Context = c.OpManagerCtx
|
||
// Run the orchestration
|
||
err = cluster.reconcileCephDaemons(c.rookImage, *cephVersion)
|
||
if err != nil {
|
||
return errors.Wrap(err, "failed to create cluster")
|
||
}
|
||
|
||
// Set the condition to the cluster object
|
||
controller.UpdateCondition(c.OpManagerCtx, c.context, c.namespacedName, cephv1.ConditionReady, v1.ConditionTrue, cephv1.ClusterCreatedReason, "Cluster created successfully")
|
||
return nil
|
||
}
|
||
|
||
// Validate the cluster Specs
|
||
func preClusterStartValidation(cluster *cluster) error {
|
||
if cluster.Spec.Mon.Count == 0 {
|
||
logger.Warningf("mon count should be at least 1, will use default value of %d", mon.DefaultMonCount)
|
||
cluster.Spec.Mon.Count = mon.DefaultMonCount
|
||
}
|
||
if !cluster.Spec.Mon.AllowMultiplePerNode {
|
||
// Check that there are enough nodes to have a chance of starting the requested number of mons
|
||
nodes, err := cluster.context.Clientset.CoreV1().Nodes().List(cluster.ClusterInfo.Context, metav1.ListOptions{})
|
||
if err == nil && len(nodes.Items) < cluster.Spec.Mon.Count {
|
||
return errors.Errorf("cannot start %d mons on %d node(s) when allowMultiplePerNode is false", cluster.Spec.Mon.Count, len(nodes.Items))
|
||
}
|
||
}
|
||
if err := validateStretchCluster(cluster); err != nil {
|
||
return err
|
||
}
|
||
if cluster.Spec.Network.IsMultus() {
|
||
_, isPublic := cluster.Spec.Network.Selectors[config.PublicNetworkSelectorKeyName]
|
||
_, isCluster := cluster.Spec.Network.Selectors[config.ClusterNetworkSelectorKeyName]
|
||
if !isPublic && !isCluster {
|
||
return errors.New("both network selector values for public and cluster selector cannot be empty for multus provider")
|
||
}
|
||
|
||
for _, selector := range config.NetworkSelectors {
|
||
// If one selector is empty, we continue
|
||
// This means a single interface is used both public and cluster network
|
||
if _, ok := cluster.Spec.Network.Selectors[selector]; !ok {
|
||
continue
|
||
}
|
||
|
||
multusNamespace, nad := config.GetMultusNamespace(cluster.Spec.Network.Selectors[selector])
|
||
if multusNamespace == "" {
|
||
multusNamespace = cluster.Namespace
|
||
}
|
||
|
||
// Get network attachment definition
|
||
_, err := cluster.context.NetworkClient.NetworkAttachmentDefinitions(multusNamespace).Get(cluster.ClusterInfo.Context, nad, metav1.GetOptions{})
|
||
if err != nil {
|
||
if kerrors.IsNotFound(err) {
|
||
return errors.Wrapf(err, "specified network attachment definition for selector %q does not exist", selector)
|
||
}
|
||
return errors.Wrapf(err, "failed to fetch network attachment definition for selector %q", selector)
|
||
}
|
||
}
|
||
}
|
||
|
||
// Validate on-PVC cluster encryption KMS settings
|
||
if cluster.Spec.Storage.IsOnPVCEncrypted() && cluster.Spec.Security.KeyManagementService.IsEnabled() {
|
||
// Validate the KMS details
|
||
err := kms.ValidateConnectionDetails(cluster.context, &cluster.Spec.Security, cluster.Namespace)
|
||
if err != nil {
|
||
return errors.Wrap(err, "failed to validate kms connection details")
|
||
}
|
||
}
|
||
|
||
logger.Debug("cluster spec successfully validated")
|
||
return nil
|
||
}
|
||
|
||
func validateStretchCluster(cluster *cluster) error {
|
||
if !cluster.Spec.IsStretchCluster() {
|
||
return nil
|
||
}
|
||
if len(cluster.Spec.Mon.StretchCluster.Zones) != 3 {
|
||
return errors.Errorf("expecting exactly three zones for the stretch cluster, but found %d", len(cluster.Spec.Mon.StretchCluster.Zones))
|
||
}
|
||
if cluster.Spec.Mon.Count != 3 && cluster.Spec.Mon.Count != 5 {
|
||
return errors.Errorf("invalid number of mons %d for a stretch cluster, expecting 5 (recommended) or 3 (minimal)", cluster.Spec.Mon.Count)
|
||
}
|
||
arbitersFound := 0
|
||
for _, zone := range cluster.Spec.Mon.StretchCluster.Zones {
|
||
if zone.Arbiter {
|
||
arbitersFound++
|
||
}
|
||
if zone.Name == "" {
|
||
return errors.New("missing zone name for the stretch cluster")
|
||
}
|
||
}
|
||
if arbitersFound != 1 {
|
||
return errors.Errorf("expecting to find exactly one arbiter zone, but found %d", arbitersFound)
|
||
}
|
||
return nil
|
||
}
|
||
|
||
func extractExitCode(err error) (int, bool) {
|
||
exitErr, ok := err.(*exec.ExitError)
|
||
if ok {
|
||
return exitErr.ExitCode(), true
|
||
}
|
||
return 0, false
|
||
}
|
||
|
||
func (c *cluster) createCrushRoot(newRoot string) error {
|
||
args := []string{"osd", "crush", "add-bucket", newRoot, "root"}
|
||
cephCmd := client.NewCephCommand(c.context, c.ClusterInfo, args)
|
||
_, err := cephCmd.Run()
|
||
if err != nil {
|
||
// returns zero if the bucket exists already, so any error is fatal
|
||
return errors.Wrap(err, "failed to create CRUSH root")
|
||
}
|
||
|
||
return nil
|
||
}
|
||
|
||
func (c *cluster) replaceDefaultReplicationRule(newRoot string) error {
|
||
args := []string{"osd", "crush", "rule", "rm", "replicated_rule"}
|
||
cephCmd := client.NewCephCommand(c.context, c.ClusterInfo, args)
|
||
_, err := cephCmd.Run()
|
||
if err != nil {
|
||
if code, ok := extractExitCode(err); ok && code == int(syscall.EBUSY) {
|
||
// we do not want to delete the replicated_rule if it’s in use,
|
||
// and we also do not care much. There are two possible causes:
|
||
// - the user has created this rule with the non-default CRUSH
|
||
// root manually
|
||
// - the user is using this rule despite the rule using the default
|
||
// CRUSH root
|
||
// in both cases, we cannot do anything about it either way and
|
||
// we’ll assume that the user knows what they’re doing.
|
||
logger.Warning("replicated_rule is in use, not replaced")
|
||
return nil
|
||
}
|
||
// the error does not refer to EBUSY -> return as error
|
||
return errors.Wrap(err, "failed to remove default replicated_rule")
|
||
}
|
||
|
||
args = []string{
|
||
"osd", "crush", "rule", "create-replicated",
|
||
"replicated_rule", newRoot, "host",
|
||
}
|
||
cephCmd = client.NewCephCommand(c.context, c.ClusterInfo, args)
|
||
_, err = cephCmd.Run()
|
||
if err != nil {
|
||
// returns zero if the rule exists already, so any error is fatal
|
||
return errors.Wrap(err, "failed to create new default replicated_rule")
|
||
}
|
||
|
||
return nil
|
||
}
|
||
|
||
func (c *cluster) removeDefaultCrushRoot() error {
|
||
args := []string{"osd", "crush", "rm", "default"}
|
||
cephCmd := client.NewCephCommand(c.context, c.ClusterInfo, args)
|
||
_, err := cephCmd.Run()
|
||
if err != nil {
|
||
if code, ok := extractExitCode(err); ok {
|
||
if code == int(syscall.ENOTEMPTY) || code == int(syscall.EBUSY) {
|
||
// we do not want to delete the default node if it’s in use,
|
||
// and we also do not care much. There are two more causes here:
|
||
// - a (non-root?) CRUSH node with the default label was created
|
||
// automatically, e.g. from topology labels, and OSDs (or sub
|
||
// nodes) have been placed in there. In this case, the node
|
||
// obviously needs to be preserved.
|
||
// - the root=default CRUSH node is in use by a non-default
|
||
// CRUSH rule
|
||
// - OSDs or subnodes have been placed under the root=default
|
||
// CRUSH node
|
||
//
|
||
// in all cases, we cannot do anything about it either way and
|
||
// we’ll assume that the user knows what they’re doing.
|
||
logger.Debug("default is not empty or is still in use, not removed")
|
||
return nil
|
||
}
|
||
}
|
||
// the error does not refer to EBUSY or ENOTEMPTY -> return as error
|
||
return errors.Wrap(err, "failed to remove CRUSH node 'default'")
|
||
}
|
||
return nil
|
||
}
|
||
|
||
// Remove the default root=default and replicated_rule CRUSH objects which are created by Ceph on initial startup.
|
||
// Those objects may interfere with the normal operation of the cluster.
|
||
// Note that errors which indicate that the objects are in use are ignored and the objects will continue to exist in that case.
|
||
func (c *cluster) replaceDefaultCrushMap(newRoot string) (err error) {
|
||
logger.Info("creating new CRUSH root if it does not exist")
|
||
err = c.createCrushRoot(newRoot)
|
||
if err != nil {
|
||
return errors.Wrap(err, "failed to create CRUSH root")
|
||
}
|
||
|
||
logger.Info("replacing default replicated_rule CRUSH rule for use of non-default CRUSH root")
|
||
err = c.replaceDefaultReplicationRule(newRoot)
|
||
if err != nil {
|
||
return errors.Wrap(err, "failed to replace default rule")
|
||
}
|
||
|
||
logger.Info("replacing default CRUSH node if applicable")
|
||
err = c.removeDefaultCrushRoot()
|
||
if err != nil {
|
||
return errors.Wrap(err, "failed to remove default CRUSH root")
|
||
}
|
||
|
||
return nil
|
||
}
|
||
|
||
// postMonStartupActions is a collection of actions to run once the monitors are up and running
|
||
// It gets executed right after the main mon Start() method
|
||
// Basically, it is executed between the monitors and the manager sequence
|
||
func (c *cluster) postMonStartupActions() error {
|
||
// Create CSI Kubernetes Secrets
|
||
err := csi.CreateCSISecrets(c.context, c.ClusterInfo)
|
||
if err != nil {
|
||
return errors.Wrap(err, "failed to create csi kubernetes secrets")
|
||
}
|
||
|
||
// Create crash collector Kubernetes Secret
|
||
err = crash.CreateCrashCollectorSecret(c.context, c.ClusterInfo)
|
||
if err != nil {
|
||
return errors.Wrap(err, "failed to create crash collector kubernetes secret")
|
||
}
|
||
|
||
// Enable Ceph messenger 2 protocol on Nautilus
|
||
if err := client.EnableMessenger2(c.context, c.ClusterInfo); err != nil {
|
||
return errors.Wrap(err, "failed to enable Ceph messenger version 2")
|
||
}
|
||
|
||
crushRoot := client.GetCrushRootFromSpec(c.Spec)
|
||
if crushRoot != "default" {
|
||
// Remove the root=default and replicated_rule which are created by
|
||
// default. Note that RemoveDefaultCrushMap ignores some types of errors
|
||
// internally
|
||
if err := c.replaceDefaultCrushMap(crushRoot); err != nil {
|
||
return errors.Wrap(err, "failed to remove default CRUSH map")
|
||
}
|
||
}
|
||
|
||
// Create cluster-wide RBD bootstrap peer token
|
||
_, err = controller.CreateBootstrapPeerSecret(c.context, c.ClusterInfo, &cephv1.CephCluster{ObjectMeta: metav1.ObjectMeta{Name: c.namespacedName.Name, Namespace: c.Namespace}}, c.ownerInfo)
|
||
if err != nil {
|
||
return errors.Wrap(err, "failed to create cluster rbd bootstrap peer token")
|
||
}
|
||
|
||
return nil
|
||
}
|