Files
my-rook-config/pkg/operator/ceph/cluster/mgr/drain_test.go
T
parth-gr e50d83771e ceph: add pdb for mgr
Currently PDB for MGR is not been created,
Creating the PDB for MGR if its count is 2

Closes: https://github.com/rook/rook/issues/8275
Signed-off-by: parth-gr <paarora@redhat.com>
2021-09-03 14:30:58 +05:30

149 lines
4.9 KiB
Go

/*
Copyright 2021 The Rook Authors. All rights reserved.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package mgr
import (
"context"
"testing"
cephv1 "github.com/rook/rook/pkg/apis/ceph.rook.io/v1"
"github.com/rook/rook/pkg/client/clientset/versioned/scheme"
"github.com/rook/rook/pkg/clusterd"
cephclient "github.com/rook/rook/pkg/daemon/ceph/client"
"github.com/rook/rook/pkg/operator/test"
"github.com/stretchr/testify/assert"
policyv1 "k8s.io/api/policy/v1"
policyv1beta1 "k8s.io/api/policy/v1beta1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/types"
"sigs.k8s.io/controller-runtime/pkg/client/fake"
)
const (
mockNamespace = "test-ns"
)
func createFakeCluster(t *testing.T, cephClusterObj *cephv1.CephCluster, k8sVersion string) *Cluster {
ownerInfo := cephclient.NewMinimumOwnerInfoWithOwnerRef()
scheme := scheme.Scheme
err := policyv1.AddToScheme(scheme)
assert.NoError(t, err)
err = policyv1beta1.AddToScheme(scheme)
assert.NoError(t, err)
cl := fake.NewClientBuilder().WithScheme(scheme).WithRuntimeObjects().Build()
clientset := test.New(t, 3)
clusterInfo := &cephclient.ClusterInfo{Namespace: mockNamespace, OwnerInfo: ownerInfo}
clusterInfo.SetName("test")
c := New(&clusterd.Context{Client: cl, Clientset: clientset}, clusterInfo, cephClusterObj.Spec, "myversion")
test.SetFakeKubernetesVersion(clientset, k8sVersion)
return c
}
func TestReconcileMgrPDB(t *testing.T) {
testCases := struct {
name string
cephCluster *cephv1.CephCluster
expectedMaxUnAvailable int32
errorExpected bool
}{
name: "1 mgr",
cephCluster: &cephv1.CephCluster{
ObjectMeta: metav1.ObjectMeta{Name: "rook", Namespace: mockNamespace},
Spec: cephv1.ClusterSpec{
Mgr: cephv1.MgrSpec{
Count: 1,
},
DisruptionManagement: cephv1.DisruptionManagementSpec{
ManagePodBudgets: true,
},
},
},
expectedMaxUnAvailable: 1,
errorExpected: false,
}
// check for PDBV1Beta1 version
c := createFakeCluster(t, testCases.cephCluster, "v1.20.0")
err := c.reconcileMgrPDB()
assert.NoError(t, err)
existingPDBV1Beta1 := &policyv1beta1.PodDisruptionBudget{}
err = c.context.Client.Get(context.TODO(), types.NamespacedName{Name: mgrPDBName, Namespace: mockNamespace}, existingPDBV1Beta1)
if testCases.errorExpected {
assert.Error(t, err)
}
assert.NoError(t, err)
assert.Equalf(t, testCases.expectedMaxUnAvailable, int32(existingPDBV1Beta1.Spec.MaxUnavailable.IntValue()), "[%s]: incorrect minAvailable count in pdb", testCases.name)
// check for PDBV1 version
c = createFakeCluster(t, testCases.cephCluster, "v1.21.0")
err = c.reconcileMgrPDB()
assert.NoError(t, err)
existingPDBV1 := &policyv1.PodDisruptionBudget{}
err = c.context.Client.Get(context.TODO(), types.NamespacedName{Name: mgrPDBName, Namespace: mockNamespace}, existingPDBV1)
if testCases.errorExpected {
assert.Error(t, err)
}
assert.NoError(t, err)
assert.Equalf(t, testCases.expectedMaxUnAvailable, int32(existingPDBV1.Spec.MaxUnavailable.IntValue()), "[%s]: incorrect minAvailable count in pdb", testCases.name)
// reconcile mon PDB again to test update
err = c.reconcileMgrPDB()
assert.NoError(t, err)
}
func TestDeleteMgrPDB(t *testing.T) {
// check for PDBV1 version
fakeNamespaceName := types.NamespacedName{Namespace: mockNamespace, Name: mgrPDBName}
c := createFakeCluster(t, &cephv1.CephCluster{
Spec: cephv1.ClusterSpec{
DisruptionManagement: cephv1.DisruptionManagementSpec{
ManagePodBudgets: true,
},
},
}, "v1.21.0")
err := c.reconcileMgrPDB()
assert.NoError(t, err)
existingPDBV1 := &policyv1.PodDisruptionBudget{}
// mgr PDB exist
err = c.context.Client.Get(context.TODO(), fakeNamespaceName, existingPDBV1)
assert.NoError(t, err)
c.deleteMgrPDB()
// mgr PDB deleted
err = c.context.Client.Get(context.TODO(), fakeNamespaceName, existingPDBV1)
assert.Error(t, err)
// check for PDBV1Beta1 version
c = createFakeCluster(t, &cephv1.CephCluster{
Spec: cephv1.ClusterSpec{
DisruptionManagement: cephv1.DisruptionManagementSpec{
ManagePodBudgets: true,
},
},
}, "v1.20.0")
err = c.reconcileMgrPDB()
assert.NoError(t, err)
existingPDBV1Beta1 := &policyv1beta1.PodDisruptionBudget{}
// mgr PDB exist
err = c.context.Client.Get(context.TODO(), fakeNamespaceName, existingPDBV1Beta1)
assert.NoError(t, err)
c.deleteMgrPDB()
// mgr PDB deleted
err = c.context.Client.Get(context.TODO(), fakeNamespaceName, existingPDBV1Beta1)
assert.Error(t, err)
}