forked from rook/rook
Humble Chirammal
731b0f5274
With the release of Ceph CSI 3.4.0, Ceph CSI project came up with a new support policy where we support only versions >= 3.3.0 The supported window of Ceph CSI versions is known as "N.(x-1)": (N (Latest major release) . (x (Latest minor release) - 1)). For example, if Ceph CSI latest major version is 3.4.0 today, support is provided for the versions above 3.3.0. If users are running an unsupported Ceph CSI version, they will be asked to upgrade when requesting support for the cluster. This PR lift the minimum supported version of Ceph CSI to 3.3.0 in this repo. Fix https://github.com/rook/rook/issues/8709 Ref # https://github.com/ceph/ceph-csi/releases/tag/v3.4.0 https://github.com/ceph/ceph-csi/#known-to-work-co-platforms Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
92 lines
2.4 KiB
Go
92 lines
2.4 KiB
Go
/*
|
|
Copyright 2020 The Rook Authors. All rights reserved.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package csi
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
var (
|
|
testMinVersion = CephCSIVersion{3, 3, 0}
|
|
testReleaseV330 = CephCSIVersion{3, 3, 0}
|
|
testReleaseV340 = CephCSIVersion{3, 4, 0}
|
|
testVersionUnsupported = CephCSIVersion{4, 0, 0}
|
|
)
|
|
|
|
func TestIsAtLeast(t *testing.T) {
|
|
// Test version which is smaller
|
|
var version = CephCSIVersion{1, 40, 10}
|
|
ret := testMinVersion.isAtLeast(&version)
|
|
assert.Equal(t, true, ret)
|
|
|
|
// Test version which is equal
|
|
ret = testMinVersion.isAtLeast(&testMinVersion)
|
|
assert.Equal(t, true, ret)
|
|
|
|
// Test version which is equal
|
|
ret = testReleaseV330.isAtLeast(&testReleaseV330)
|
|
assert.Equal(t, true, ret)
|
|
|
|
// Test for 3.4.0
|
|
// Test version which is lesser
|
|
ret = testReleaseV340.isAtLeast(&testReleaseV330)
|
|
assert.Equal(t, true, ret)
|
|
|
|
}
|
|
|
|
func TestSupported(t *testing.T) {
|
|
AllowUnsupported = false
|
|
ret := testMinVersion.Supported()
|
|
assert.Equal(t, true, ret)
|
|
|
|
ret = testVersionUnsupported.Supported()
|
|
assert.Equal(t, false, ret)
|
|
|
|
ret = testReleaseV330.Supported()
|
|
assert.Equal(t, true, ret)
|
|
|
|
ret = testReleaseV340.Supported()
|
|
assert.Equal(t, true, ret)
|
|
}
|
|
|
|
func Test_extractCephCSIVersion(t *testing.T) {
|
|
expectedVersion := CephCSIVersion{3, 0, 0}
|
|
csiString := []byte(`Cephcsi Version: v3.0.0
|
|
Git Commit: e58d537a07ca0184f67d33db85bf6b4911624b44
|
|
Go Version: go1.12.15
|
|
Compiler: gc
|
|
Platform: linux/amd64
|
|
`)
|
|
version, err := extractCephCSIVersion(string(csiString))
|
|
|
|
assert.Equal(t, &expectedVersion, version)
|
|
assert.Nil(t, err)
|
|
|
|
csiString = []byte(`Cephcsi Version: rubish
|
|
Git Commit: e58d537a07ca0184f67d33db85bf6b4911624b44
|
|
Go Version: go1.12.15
|
|
Compiler: gc
|
|
Platform: linux/amd64
|
|
`)
|
|
version, err = extractCephCSIVersion(string(csiString))
|
|
|
|
assert.Nil(t, version)
|
|
assert.Contains(t, err.Error(), "failed to parse version from")
|
|
}
|