forked from rook/rook
Work around issue https://github.com/rook/rook/issues/7573 and make sure integration tests check for regressions. Eventually we should use the RADOS Gateway admin REST API, but for now we need to work around an issue where the built version of 'radosgw-admin' has incompatibilities with the RADOS Gateway version running in the Ceph cluster. Of note, Rook built on the Ceph Pacific image will not support some 'radosgw-admin' commands to Ceph Nautilus (v14) or Octopus (v15) clusters. Further complicating matters, the flag used for the workaround changes between Ceph v16.2.0 and v16.2.1 (both Pacific). This bug needs to be treated a little differently than most of the ways Rook handles different commands for different Ceph versions because this is based on the Ceph version that is installed in the container with the Rook operator primarily and not the version of Ceph running in the cluster. Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
158 lines
6.0 KiB
Go
158 lines
6.0 KiB
Go
/*
|
|
Copyright 2016 The Rook Authors. All rights reserved.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package object
|
|
|
|
import (
|
|
"fmt"
|
|
"regexp"
|
|
"time"
|
|
|
|
"github.com/pkg/errors"
|
|
cephv1 "github.com/rook/rook/pkg/apis/ceph.rook.io/v1"
|
|
"github.com/rook/rook/pkg/clusterd"
|
|
"github.com/rook/rook/pkg/daemon/ceph/client"
|
|
"github.com/rook/rook/pkg/util/exec"
|
|
)
|
|
|
|
// Context holds the context for the object store.
|
|
type Context struct {
|
|
Context *clusterd.Context
|
|
clusterInfo *client.ClusterInfo
|
|
Name string
|
|
UID string
|
|
Endpoint string
|
|
Realm string
|
|
ZoneGroup string
|
|
Zone string
|
|
}
|
|
|
|
// NewContext creates a new object store context.
|
|
func NewContext(context *clusterd.Context, clusterInfo *client.ClusterInfo, name string) *Context {
|
|
return &Context{Context: context, Name: name, clusterInfo: clusterInfo}
|
|
}
|
|
|
|
func NewMultisiteContext(context *clusterd.Context, clusterInfo *client.ClusterInfo, store *cephv1.CephObjectStore) (*Context, error) {
|
|
objContext := &Context{Context: context, Name: store.Name, clusterInfo: clusterInfo}
|
|
realmName, zoneGroupName, zoneName, err := getMultisiteForObjectStore(context, store)
|
|
if err != nil {
|
|
return nil, errors.Wrapf(err, "failed to get realm/zone group/zone for object store %q", store.Name)
|
|
}
|
|
|
|
objContext.Realm = realmName
|
|
objContext.ZoneGroup = zoneGroupName
|
|
objContext.Zone = zoneName
|
|
return objContext, nil
|
|
}
|
|
|
|
func extractJSON(output string) (string, error) {
|
|
// `radosgw-admin` sometimes leaves logs to stderr even if it succeeds.
|
|
// So we should skip them if parsing output as json.
|
|
pattern := regexp.MustCompile("(?ms)^{.*")
|
|
match := pattern.Find([]byte(output))
|
|
if match == nil {
|
|
return "", errors.Errorf("didn't contain json. %s", output)
|
|
}
|
|
return string(match), nil
|
|
}
|
|
|
|
// RunAdminCommandNoMultisite is for running radosgw-admin commands in scenarios where an object-store has not been created yet or for commands on the realm or zonegroup (ex: radosgw-admin zonegroup get)
|
|
// This function times out after a fixed interval if no response is received.
|
|
func RunAdminCommandNoMultisite(c *Context, expectJSON bool, args ...string) (string, error) {
|
|
command, args := client.FinalizeCephCommandArgs("radosgw-admin", c.clusterInfo, args, c.Context.ConfigDir)
|
|
|
|
timeout, err := time.ParseDuration(fmt.Sprintf("%ss", client.CephConnectionTimeout))
|
|
if err != nil {
|
|
return "", errors.Wrap(err, "failed to parse CephConnectionTimeout")
|
|
}
|
|
|
|
// start the rgw admin command
|
|
output, err := c.Context.Executor.ExecuteCommandWithTimeout(timeout, command, args...)
|
|
if err != nil {
|
|
return output, err
|
|
}
|
|
if expectJSON {
|
|
match, err := extractJSON(output)
|
|
if err != nil {
|
|
return output, errors.Wrap(err, "failed to parse as JSON")
|
|
}
|
|
output = match
|
|
}
|
|
|
|
return output, nil
|
|
}
|
|
|
|
// This function is for running radosgw-admin commands in scenarios where an object-store has been created and the Context has been updated with the appropriate realm, zone group, and zone.
|
|
func runAdminCommand(c *Context, expectJSON bool, args ...string) (string, error) {
|
|
// If the objectStoreName is not passed in the storage class
|
|
// This means we are pointing to an external cluster so these commands are not needed
|
|
// simply because the external cluster mode does not support that yet
|
|
//
|
|
// The following conditions tries to determine if the cluster is external
|
|
// When connecting to an external cluster, the Ceph user is different than client.admin
|
|
// This is not perfect though since "client.admin" is somehow supported...
|
|
if c.Name != "" && c.clusterInfo.CephCred.Username == client.AdminUsername {
|
|
options := []string{
|
|
fmt.Sprintf("--rgw-realm=%s", c.Realm),
|
|
fmt.Sprintf("--rgw-zonegroup=%s", c.ZoneGroup),
|
|
fmt.Sprintf("--rgw-zone=%s", c.Zone),
|
|
}
|
|
|
|
args = append(args, options...)
|
|
}
|
|
|
|
// work around FIFO file I/O issue when radosgw-admin is not compatible between version
|
|
// installed in Rook operator and RGW version in Ceph cluster (#7573)
|
|
result, err := RunAdminCommandNoMultisite(c, expectJSON, args...)
|
|
if err != nil && isFifoFileIOError(err) {
|
|
logger.Info("retrying 'radosgw-admin' command with OMAP backend to work around FIFO file I/O issue")
|
|
|
|
// We can either run 'ceph --version' to determine the Ceph version running in the operator
|
|
// and then pick a flag to use, or we can just try to use both flags and return the one that
|
|
// works. Same number of commands being run.
|
|
retryArgs := append(args, "--rgw-data-log-backing=omap") // v16.2.0- in the operator
|
|
retryResult, retryErr := RunAdminCommandNoMultisite(c, expectJSON, retryArgs...)
|
|
if retryErr != nil && isInvalidFlagError(retryErr) {
|
|
retryArgs = append(args, "--rgw-default-data-log-backing=omap") // v16.2.1+ in the operator
|
|
retryResult, retryErr = RunAdminCommandNoMultisite(c, expectJSON, retryArgs...)
|
|
}
|
|
|
|
return retryResult, retryErr
|
|
}
|
|
|
|
return result, err
|
|
}
|
|
|
|
func isFifoFileIOError(err error) bool {
|
|
exitCode, extractErr := exec.ExtractExitCode(err)
|
|
if extractErr != nil {
|
|
logger.Errorf("failed to determine return code of 'radosgw-admin' command. assuming this could be a FIFO file I/O issue. %#v", err)
|
|
return true
|
|
}
|
|
// exit code 5 (EIO) is returned when there is a FIFO file I/O issue
|
|
return exitCode == 5
|
|
}
|
|
|
|
func isInvalidFlagError(err error) bool {
|
|
exitCode, extractErr := exec.ExtractExitCode(err)
|
|
if extractErr != nil {
|
|
logger.Errorf("failed to determine return code of 'radosgw-admin' command. assuming this could be an invalid flag error. %#v", err)
|
|
}
|
|
// exit code 22 (EINVAL) is returned when there is an invalid flag
|
|
// it's also returned from some other failures, but this should be rare for Rook
|
|
return exitCode == 22
|
|
}
|