Files
my-rook-config/pkg/daemon/ceph/client/rados_test.go
T
Carlos Barria 030ada45b0 core: fix golangci-lint check QF1003 QF1002
Refactored multiple conditional if-else blocks into switch statements to improve readability and maintainability. Also removed outdated staticcheck rule comments (QF1002, QF1003) from .golangci.yaml.

Signed-off-by: Carlos Barria <cbarria@yahoo.com>
2025-05-27 13:49:49 -04:00

115 lines
3.3 KiB
Go

/*
Copyright 2022 The Rook Authors. All rights reserved.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package client
import (
"context"
"errors"
"fmt"
"testing"
"time"
"github.com/rook/rook/pkg/clusterd"
"github.com/rook/rook/pkg/util/exec"
"github.com/rook/rook/pkg/util/exec/test"
"github.com/stretchr/testify/assert"
)
func TestRadosRemoveObject(t *testing.T) {
newTest := func(mockExec *test.MockExecutor) (*clusterd.Context, *ClusterInfo) {
ctx := &clusterd.Context{
Executor: mockExec,
}
info := &ClusterInfo{
Context: context.Background(),
}
return ctx, info
}
t.Run("timeout stat-ing", func(t *testing.T) {
me := &test.MockExecutor{
MockExecuteCommandWithTimeout: func(timeout time.Duration, command string, arg ...string) (string, error) {
return "", test.FakeTimeoutError("")
},
}
c, i := newTest(me)
err := RadosRemoveObject(c, i, "mypool", "myns", "someobj")
assert.Error(t, err)
assert.True(t, exec.IsTimeout(err))
})
t.Run("stat err means the object is already gone", func(t *testing.T) {
me := &test.MockExecutor{
MockExecuteCommandWithTimeout: func(timeout time.Duration, command string, arg ...string) (string, error) {
subCommand := arg[4]
assert.Equal(t, subCommand, "stat")
return "", errors.New("induced stat error")
},
}
c, i := newTest(me)
err := RadosRemoveObject(c, i, "mypool", "myns", "someobj")
assert.NoError(t, err)
})
t.Run("rm err is an error", func(t *testing.T) {
me := &test.MockExecutor{
MockExecuteCommandWithTimeout: func(timeout time.Duration, command string, arg ...string) (string, error) {
assert.Equal(t, arg[0], "--pool")
assert.Equal(t, arg[1], "mypool")
assert.Equal(t, arg[2], "--namespace")
assert.Equal(t, arg[3], "myns")
subCommand := arg[4]
assert.Equal(t, arg[5], "someobj")
switch subCommand {
case "stat":
return "", nil // successful stat means obj exists
case "rm":
return "", errors.New("induced rm error")
default:
panic(fmt.Sprintf("unhandled subcommand %q", subCommand))
}
},
}
c, i := newTest(me)
err := RadosRemoveObject(c, i, "mypool", "myns", "someobj")
assert.Error(t, err)
})
t.Run("rm successful", func(t *testing.T) {
me := &test.MockExecutor{
MockExecuteCommandWithTimeout: func(timeout time.Duration, command string, arg ...string) (string, error) {
assert.Equal(t, arg[0], "--pool")
assert.Equal(t, arg[1], "mypool")
assert.Equal(t, arg[2], "--namespace")
assert.Equal(t, arg[3], "myns")
subCommand := arg[4]
assert.Equal(t, arg[5], "someobj")
if subCommand == "stat" || subCommand == "rm" {
return "", nil
} else {
panic(fmt.Sprintf("unhandled subcommand %q", subCommand))
}
},
}
c, i := newTest(me)
err := RadosRemoveObject(c, i, "mypool", "myns", "someobj")
assert.NoError(t, err)
})
}