Files
my-rook-config/pkg/operator/ceph/object/controller.go
T
Sébastien Han 92c1696bfc ceph: cleanup/trim isUpgrade variable a bit
We now always perform ok-to-stop change when the deployment is going to
be updated. This could be for various reasons like change in the spec or
a new Ceph image.
In any case, if Ceph resources are going to be restarted this must be
done carefully.

Also trimmed the isUpgrade variable, the upcoming commit will remove the
need of that variable.

Keeping isUpgrade from the controller code since we need it to detect
whether an orchestration upgrade should be triggered or not (based on
the ceph cluster status).

Also, we keep it on the child controllers so we don't go into an
orchestration phase if the cluster image hasn't changed. The child does
not need to be updated/go into its orchestration phase because the
cluster CR changed.

Closes: https://github.com/rook/rook/issues/4379
Signed-off-by: Sébastien Han <seb@redhat.com>
2020-01-24 17:02:37 +01:00

301 lines
11 KiB
Go

/*
Copyright 2016 The Rook Authors. All rights reserved.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package object
import (
"fmt"
"reflect"
"sync"
"github.com/coreos/pkg/capnslog"
"github.com/pkg/errors"
cephv1 "github.com/rook/rook/pkg/apis/ceph.rook.io/v1"
"github.com/rook/rook/pkg/clusterd"
daemonconfig "github.com/rook/rook/pkg/daemon/ceph/config"
cephconfig "github.com/rook/rook/pkg/operator/ceph/config"
cephspec "github.com/rook/rook/pkg/operator/ceph/spec"
"github.com/rook/rook/pkg/operator/k8sutil"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/client-go/tools/cache"
)
var logger = capnslog.NewPackageLogger("github.com/rook/rook", "op-object")
// ObjectStoreResource represents the object store custom resource
var ObjectStoreResource = k8sutil.CustomResource{
Name: "cephobjectstore",
Plural: "cephobjectstores",
Group: cephv1.CustomResourceGroup,
Version: cephv1.Version,
Kind: reflect.TypeOf(cephv1.CephObjectStore{}).Name(),
}
// ObjectStoreController represents a controller object for object store custom resources
type ObjectStoreController struct {
clusterInfo *daemonconfig.ClusterInfo
clusterSpec *cephv1.ClusterSpec
context *clusterd.Context
namespace string
rookImage string
ownerRef metav1.OwnerReference
dataDirHostPath string
orchestrationMutex sync.Mutex
}
// NewObjectStoreController create controller for watching object store custom resources created
func NewObjectStoreController(
clusterInfo *daemonconfig.ClusterInfo,
context *clusterd.Context,
namespace string,
rookImage string,
clusterSpec *cephv1.ClusterSpec,
ownerRef metav1.OwnerReference,
dataDirHostPath string,
) *ObjectStoreController {
return &ObjectStoreController{
clusterInfo: clusterInfo,
clusterSpec: clusterSpec,
context: context,
namespace: namespace,
rookImage: rookImage,
ownerRef: ownerRef,
dataDirHostPath: dataDirHostPath,
}
}
// StartWatch watches for instances of ObjectStore custom resources and acts on them
func (c *ObjectStoreController) StartWatch(namespace string, stopCh chan struct{}) error {
resourceHandlerFuncs := cache.ResourceEventHandlerFuncs{
AddFunc: c.onAdd,
UpdateFunc: c.onUpdate,
DeleteFunc: c.onDelete,
}
logger.Infof("start watching object store resources in namespace %s", c.namespace)
go k8sutil.WatchCR(ObjectStoreResource, c.namespace, resourceHandlerFuncs, c.context.RookClientset.CephV1().RESTClient(), &cephv1.CephObjectStore{}, stopCh)
return nil
}
func (c *ObjectStoreController) onAdd(obj interface{}) {
if c.clusterSpec.External.Enable && c.clusterSpec.CephVersion.Image == "" {
logger.Warningf("Creating object store for an external ceph cluster is disabled because no Ceph image is specified")
return
}
objectStore, err := getObjectStoreObject(obj)
if err != nil {
logger.Errorf("failed to get objectstore object. %v", err)
return
}
c.acquireOrchestrationLock()
defer c.releaseOrchestrationLock()
updateCephObjectStoreStatus(objectStore.GetName(), objectStore.GetNamespace(), k8sutil.ProcessingStatus, c.context)
if c.clusterSpec.External.Enable {
_, err := cephspec.ValidateCephVersionsBetweenLocalAndExternalClusters(c.context, c.namespace, c.clusterInfo.CephVersion)
if err != nil {
// This handles the case where the operator is running, the external cluster has been upgraded and a CR creation is called
// If that's a major version upgrade we fail, if it's a minor version, we continue, it's not ideal but not critical
logger.Errorf("refusing to run new crd. %v", err)
updateCephObjectStoreStatus(objectStore.GetName(), objectStore.GetNamespace(), k8sutil.FailedStatus, c.context)
return
}
}
c.createOrUpdateStore(objectStore)
updateCephObjectStoreStatus(objectStore.GetName(), objectStore.GetNamespace(), k8sutil.ReadyStatus, c.context)
}
func (c *ObjectStoreController) onUpdate(oldObj, newObj interface{}) {
if c.clusterSpec.External.Enable && c.clusterSpec.CephVersion.Image == "" {
logger.Warningf("Updating object store for an external ceph cluster is disabled because no Ceph image is specified")
return
}
// if the object store spec is modified, update the object store
oldStore, err := getObjectStoreObject(oldObj)
if err != nil {
logger.Errorf("failed to get old objectstore object. %v", err)
return
}
newStore, err := getObjectStoreObject(newObj)
if err != nil {
logger.Errorf("failed to get new objectstore object. %v", err)
return
}
if !storeChanged(oldStore.Spec, newStore.Spec) {
logger.Debugf("object store %q did not change", newStore.Name)
return
}
c.acquireOrchestrationLock()
defer c.releaseOrchestrationLock()
updateCephObjectStoreStatus(newStore.GetName(), newStore.GetNamespace(), k8sutil.ProcessingStatus, c.context)
c.createOrUpdateStore(newStore)
updateCephObjectStoreStatus(newStore.GetName(), newStore.GetNamespace(), k8sutil.ReadyStatus, c.context)
}
func (c *ObjectStoreController) createOrUpdateStore(objectstore *cephv1.CephObjectStore) {
logger.Infof("creating object store %q", objectstore.Name)
cfg := clusterConfig{
clusterInfo: c.clusterInfo,
context: c.context,
store: *objectstore,
rookVersion: c.rookImage,
clusterSpec: c.clusterSpec,
ownerRef: c.storeOwners(objectstore),
DataPathMap: cephconfig.NewStatelessDaemonDataPathMap(cephconfig.RgwType, objectstore.Name, c.clusterInfo.Name, c.dataDirHostPath),
}
if err := cfg.createOrUpdate(); err != nil {
logger.Errorf("failed to create or update object store %s. %v", objectstore.Name, err)
}
}
func (c *ObjectStoreController) onDelete(obj interface{}) {
if c.clusterSpec.External.Enable && c.clusterSpec.CephVersion.Image == "" {
logger.Warningf("Deleting object store for an external ceph cluster is disabled because no Ceph image is specified")
return
}
objectstore, err := getObjectStoreObject(obj)
if err != nil {
logger.Errorf("failed to get objectstore object. %v", err)
return
}
c.acquireOrchestrationLock()
defer c.releaseOrchestrationLock()
cfg := clusterConfig{context: c.context, store: *objectstore}
if err = cfg.deleteStore(); err != nil {
logger.Errorf("failed to delete object store %q. %v", objectstore.Name, err)
}
}
// ParentClusterChanged determines wether or not a CR update has been sent
func (c *ObjectStoreController) ParentClusterChanged(cluster cephv1.ClusterSpec, clusterInfo *daemonconfig.ClusterInfo, isUpgrade bool) {
c.clusterInfo = clusterInfo
if !isUpgrade {
logger.Debugf("No need to update the object store after the parent cluster changed")
return
}
c.acquireOrchestrationLock()
defer c.releaseOrchestrationLock()
c.clusterSpec.CephVersion = cluster.CephVersion
objectStores, err := c.context.RookClientset.CephV1().CephObjectStores(c.namespace).List(metav1.ListOptions{})
if err != nil {
logger.Errorf("failed to retrieve object stores to update the ceph version. %v", err)
return
}
for _, store := range objectStores.Items {
logger.Infof("updating the ceph version for object store %q to %q", store.Name, c.clusterSpec.CephVersion.Image)
c.createOrUpdateStore(&store)
if err != nil {
logger.Errorf("failed to update object store %q. %v", store.Name, err)
} else {
logger.Infof("updated object store %q to ceph version %q", store.Name, c.clusterSpec.CephVersion.Image)
}
}
}
func (c *ObjectStoreController) storeOwners(store *cephv1.CephObjectStore) metav1.OwnerReference {
// Set the object store CR as the owner
return metav1.OwnerReference{
APIVersion: fmt.Sprintf("%s/%s", ObjectStoreResource.Group, ObjectStoreResource.Version),
Kind: ObjectStoreResource.Kind,
Name: store.Name,
UID: store.UID,
}
}
func storeChanged(oldStore, newStore cephv1.ObjectStoreSpec) bool {
if oldStore.DataPool.Replicated.Size != newStore.DataPool.Replicated.Size {
logger.Infof("data pool replication changed from %d to %d", oldStore.DataPool.Replicated.Size, newStore.DataPool.Replicated.Size)
return true
}
if oldStore.MetadataPool.Replicated.Size != newStore.MetadataPool.Replicated.Size {
logger.Infof("metadata pool replication changed from %d to %d", oldStore.MetadataPool.Replicated.Size, newStore.MetadataPool.Replicated.Size)
return true
}
if oldStore.Gateway.Instances != newStore.Gateway.Instances {
logger.Infof("RGW instances changed from %d to %d", oldStore.Gateway.Instances, newStore.Gateway.Instances)
return true
}
if oldStore.Gateway.Port != newStore.Gateway.Port {
logger.Infof("Port changed from %d to %d", oldStore.Gateway.Port, newStore.Gateway.Port)
return true
}
if oldStore.Gateway.SecurePort != newStore.Gateway.SecurePort {
logger.Infof("SecurePort changed from %d to %d", oldStore.Gateway.SecurePort, newStore.Gateway.SecurePort)
return true
}
if oldStore.Gateway.AllNodes != newStore.Gateway.AllNodes {
logger.Infof("AllNodes changed from %t to %t", oldStore.Gateway.AllNodes, newStore.Gateway.AllNodes)
return true
}
if oldStore.Gateway.SSLCertificateRef != newStore.Gateway.SSLCertificateRef {
logger.Infof("SSLCertificateRef changed from %s to %s", oldStore.Gateway.SSLCertificateRef, newStore.Gateway.SSLCertificateRef)
return true
}
return false
}
func getObjectStoreObject(obj interface{}) (objectstore *cephv1.CephObjectStore, err error) {
var ok bool
objectstore, ok = obj.(*cephv1.CephObjectStore)
if ok {
// the objectstore object is of the latest type, simply return it
return objectstore.DeepCopy(), nil
}
return nil, errors.Errorf("not a known objectstore object %+v", obj)
}
func (c *ObjectStoreController) acquireOrchestrationLock() {
logger.Debugf("Acquiring lock for object store orchestration")
c.orchestrationMutex.Lock()
logger.Debugf("Acquired lock for object store orchestration")
}
func (c *ObjectStoreController) releaseOrchestrationLock() {
c.orchestrationMutex.Unlock()
logger.Debugf("Released lock for object store orchestration")
}
func updateCephObjectStoreStatus(name, namespace, status string, context *clusterd.Context) {
updatedCephObjectStore, err := context.RookClientset.CephV1().CephObjectStores(namespace).Get(name, metav1.GetOptions{})
if err != nil {
logger.Errorf("Unable to update the cephObjectStore %s status %v", updatedCephObjectStore.GetName(), err)
return
}
if updatedCephObjectStore.Status == nil {
updatedCephObjectStore.Status = &cephv1.Status{}
} else if updatedCephObjectStore.Status.Phase == status {
return
}
updatedCephObjectStore.Status.Phase = status
_, err = context.RookClientset.CephV1().CephObjectStores(updatedCephObjectStore.Namespace).Update(updatedCephObjectStore)
if err != nil {
logger.Errorf("Unable to update the cephObjectStore %s status %v", updatedCephObjectStore.GetName(), err)
return
}
}