forked from rook/rook
To ensure a file handle is closed, we defer the close command so it is guaranteed to run when the method returns. The closing of the file handle is not going to fail in our usage since we aren't using the SetDeadline on the files that would cancel a request and return an error. Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
285 lines
8.5 KiB
Go
285 lines
8.5 KiB
Go
/*
|
|
Copyright 2016 The Rook Authors. All rights reserved.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package exec
|
|
|
|
import (
|
|
"bufio"
|
|
"bytes"
|
|
"context"
|
|
"fmt"
|
|
"io"
|
|
"io/ioutil"
|
|
"os"
|
|
"os/exec"
|
|
"strings"
|
|
"time"
|
|
|
|
"github.com/coreos/pkg/capnslog"
|
|
)
|
|
|
|
// Executor is the main interface for all the exec commands
|
|
type Executor interface {
|
|
ExecuteCommand(command string, arg ...string) error
|
|
ExecuteCommandWithEnv(env []string, comand string, arg ...string) error
|
|
ExecuteCommandWithOutput(command string, arg ...string) (string, error)
|
|
ExecuteCommandWithCombinedOutput(command string, arg ...string) (string, error)
|
|
ExecuteCommandWithOutputFile(command, outfileArg string, arg ...string) (string, error)
|
|
ExecuteCommandWithOutputFileTimeout(timeout time.Duration, command, outfileArg string, arg ...string) (string, error)
|
|
ExecuteCommandWithTimeout(timeout time.Duration, command string, arg ...string) (string, error)
|
|
}
|
|
|
|
// CommandExecutor is the type of the Executor
|
|
type CommandExecutor struct {
|
|
}
|
|
|
|
// ExecuteCommand starts a process and wait for its completion
|
|
func (c *CommandExecutor) ExecuteCommand(command string, arg ...string) error {
|
|
return c.ExecuteCommandWithEnv([]string{}, command, arg...)
|
|
}
|
|
|
|
// ExecuteCommandWithEnv starts a process with env variables and wait for its completion
|
|
func (*CommandExecutor) ExecuteCommandWithEnv(env []string, command string, arg ...string) error {
|
|
cmd, stdout, stderr, err := startCommand(env, command, arg...)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
logOutput(stdout, stderr)
|
|
|
|
if err := cmd.Wait(); err != nil {
|
|
return err
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// ExecuteCommandWithTimeout starts a process and wait for its completion with timeout.
|
|
func (*CommandExecutor) ExecuteCommandWithTimeout(timeout time.Duration, command string, arg ...string) (string, error) {
|
|
logCommand(command, arg...)
|
|
cmd := exec.Command(command, arg...)
|
|
|
|
var b bytes.Buffer
|
|
cmd.Stdout = &b
|
|
cmd.Stderr = &b
|
|
|
|
if err := cmd.Start(); err != nil {
|
|
return "", err
|
|
}
|
|
|
|
done := make(chan error, 1)
|
|
go func() {
|
|
done <- cmd.Wait()
|
|
}()
|
|
|
|
interruptSent := false
|
|
for {
|
|
select {
|
|
case <-time.After(timeout):
|
|
if interruptSent {
|
|
logger.Infof("timeout waiting for process %s to return after interrupt signal was sent. Sending kill signal to the process", command)
|
|
var e error
|
|
if err := cmd.Process.Kill(); err != nil {
|
|
logger.Errorf("Failed to kill process %s: %v", command, err)
|
|
e = fmt.Errorf("timeout waiting for the command %s to return after interrupt signal was sent. Tried to kill the process but that failed: %v", command, err)
|
|
} else {
|
|
e = fmt.Errorf("timeout waiting for the command %s to return", command)
|
|
}
|
|
return strings.TrimSpace(b.String()), e
|
|
}
|
|
|
|
logger.Infof("timeout waiting for process %s to return. Sending interrupt signal to the process", command)
|
|
if err := cmd.Process.Signal(os.Interrupt); err != nil {
|
|
logger.Errorf("Failed to send interrupt signal to process %s: %v", command, err)
|
|
// kill signal will be sent next loop
|
|
}
|
|
interruptSent = true
|
|
case err := <-done:
|
|
if err != nil {
|
|
return strings.TrimSpace(b.String()), err
|
|
}
|
|
if interruptSent {
|
|
return strings.TrimSpace(b.String()), fmt.Errorf("timeout waiting for the command %s to return", command)
|
|
}
|
|
return strings.TrimSpace(b.String()), nil
|
|
}
|
|
}
|
|
}
|
|
|
|
// ExecuteCommandWithOutput executes a command with output
|
|
func (*CommandExecutor) ExecuteCommandWithOutput(command string, arg ...string) (string, error) {
|
|
logCommand(command, arg...)
|
|
cmd := exec.Command(command, arg...)
|
|
return runCommandWithOutput(cmd, false)
|
|
}
|
|
|
|
// ExecuteCommandWithCombinedOutput executes a command with combined output
|
|
func (*CommandExecutor) ExecuteCommandWithCombinedOutput(command string, arg ...string) (string, error) {
|
|
logCommand(command, arg...)
|
|
cmd := exec.Command(command, arg...)
|
|
return runCommandWithOutput(cmd, true)
|
|
}
|
|
|
|
// ExecuteCommandWithOutputFileTimeout Same as ExecuteCommandWithOutputFile but with a timeout limit.
|
|
// #nosec G307 Calling defer to close the file without checking the error return is not a risk for a simple file open and close
|
|
func (*CommandExecutor) ExecuteCommandWithOutputFileTimeout(timeout time.Duration,
|
|
command, outfileArg string, arg ...string) (string, error) {
|
|
|
|
outFile, err := ioutil.TempFile("", "")
|
|
if err != nil {
|
|
return "", fmt.Errorf("failed to open output file: %+v", err)
|
|
}
|
|
defer outFile.Close()
|
|
defer os.Remove(outFile.Name())
|
|
|
|
arg = append(arg, outfileArg, outFile.Name())
|
|
logCommand(command, arg...)
|
|
|
|
ctx, cancel := context.WithTimeout(context.Background(), timeout)
|
|
defer cancel()
|
|
|
|
cmd := exec.CommandContext(ctx, command, arg...)
|
|
cmdOut, err := cmd.CombinedOutput()
|
|
|
|
// if there was anything that went to stdout/stderr then log it, even before
|
|
// we return an error
|
|
if string(cmdOut) != "" {
|
|
logger.Debug(string(cmdOut))
|
|
}
|
|
|
|
if ctx.Err() == context.DeadlineExceeded {
|
|
return string(cmdOut), ctx.Err()
|
|
}
|
|
|
|
if err != nil {
|
|
return string(cmdOut), err
|
|
}
|
|
|
|
fileOut, err := ioutil.ReadAll(outFile)
|
|
return string(fileOut), err
|
|
}
|
|
|
|
// ExecuteCommandWithOutputFile executes a command with output on a file
|
|
func (*CommandExecutor) ExecuteCommandWithOutputFile(command, outfileArg string, arg ...string) (string, error) {
|
|
|
|
// create a temporary file to serve as the output file for the command to be run and ensure
|
|
// it is cleaned up after this function is done
|
|
outFile, err := ioutil.TempFile("", "")
|
|
if err != nil {
|
|
return "", fmt.Errorf("failed to open output file: %+v", err)
|
|
}
|
|
defer outFile.Close()
|
|
defer os.Remove(outFile.Name())
|
|
|
|
// append the output file argument to the list or args
|
|
arg = append(arg, outfileArg, outFile.Name())
|
|
|
|
logCommand(command, arg...)
|
|
cmd := exec.Command(command, arg...)
|
|
cmdOut, err := cmd.CombinedOutput()
|
|
// if there was anything that went to stdout/stderr then log it, even before we return an error
|
|
if string(cmdOut) != "" {
|
|
logger.Debug(string(cmdOut))
|
|
}
|
|
if err != nil {
|
|
return string(cmdOut), err
|
|
}
|
|
|
|
// read the entire output file and return that to the caller
|
|
fileOut, err := ioutil.ReadAll(outFile)
|
|
return string(fileOut), err
|
|
}
|
|
|
|
func startCommand(env []string, command string, arg ...string) (*exec.Cmd, io.ReadCloser, io.ReadCloser, error) {
|
|
logCommand(command, arg...)
|
|
|
|
cmd := exec.Command(command, arg...)
|
|
stdout, err := cmd.StdoutPipe()
|
|
if err != nil {
|
|
logger.Warningf("failed to open stdout pipe: %+v", err)
|
|
}
|
|
stderr, err := cmd.StderrPipe()
|
|
if err != nil {
|
|
logger.Warningf("failed to open stderr pipe: %+v", err)
|
|
}
|
|
|
|
if len(env) > 0 {
|
|
cmd.Env = env
|
|
}
|
|
|
|
err = cmd.Start()
|
|
|
|
return cmd, stdout, stderr, err
|
|
}
|
|
|
|
// read from reader line by line and write it to the log
|
|
func logFromReader(logger *capnslog.PackageLogger, reader io.ReadCloser) {
|
|
in := bufio.NewScanner(reader)
|
|
lastLine := ""
|
|
for in.Scan() {
|
|
lastLine = in.Text()
|
|
logger.Debug(lastLine)
|
|
}
|
|
}
|
|
|
|
func logOutput(stdout, stderr io.ReadCloser) {
|
|
if stdout == nil || stderr == nil {
|
|
logger.Warningf("failed to collect stdout and stderr")
|
|
return
|
|
}
|
|
|
|
// The child processes should appropriately be outputting at the desired global level. Therefore,
|
|
// we always log at INFO level here, so that log statements from child procs at higher levels
|
|
// (e.g., WARNING) will still be displayed. We are relying on the child procs to output appropriately.
|
|
childLogger := capnslog.NewPackageLogger("github.com/rook/rook", "exec")
|
|
if !childLogger.LevelAt(capnslog.INFO) {
|
|
rl, err := capnslog.GetRepoLogger("github.com/rook/rook")
|
|
if err == nil {
|
|
rl.SetLogLevel(map[string]capnslog.LogLevel{"exec": capnslog.INFO})
|
|
}
|
|
}
|
|
|
|
go logFromReader(childLogger, stderr)
|
|
logFromReader(childLogger, stdout)
|
|
}
|
|
|
|
func runCommandWithOutput(cmd *exec.Cmd, combinedOutput bool) (string, error) {
|
|
var output []byte
|
|
var err error
|
|
var out string
|
|
|
|
if combinedOutput {
|
|
output, err = cmd.CombinedOutput()
|
|
} else {
|
|
output, err = cmd.Output()
|
|
if err != nil {
|
|
output = []byte(fmt.Sprintf("%s. %s", string(output), string(err.(*exec.ExitError).Stderr)))
|
|
}
|
|
}
|
|
|
|
out = strings.TrimSpace(string(output))
|
|
|
|
if err != nil {
|
|
return out, err
|
|
}
|
|
|
|
return out, nil
|
|
}
|
|
|
|
func logCommand(command string, arg ...string) {
|
|
logger.Debugf("Running command: %s %s", command, strings.Join(arg, " "))
|
|
}
|