When a private docker registry is used and an
image pull secret is specified in the chart,
the pods with default Service Account fail to pull
the image due to authentication issues.
Added rook-ceph-default service account and modify the pods
specifications by adding the serviceAccountName
closes: https://github.com/rook/rook/issues/12786
Closes: https://github.com/rook/rook/issues/6673
Co-authored-by: Tareq Sharafy <tareq.sha@gmail.com>
Signed-off-by: parth-gr <partharora1010@gmail.com>
(cherry picked from commit 737fb099fe)
Signed-off-by: parth-gr <partharora1010@gmail.com>
133 lines
4.9 KiB
Go
133 lines
4.9 KiB
Go
/*
|
|
Copyright 2016 The Rook Authors. All rights reserved.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package mds
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/rook/rook/pkg/operator/ceph/config"
|
|
"github.com/rook/rook/pkg/operator/ceph/controller"
|
|
"github.com/rook/rook/pkg/operator/ceph/test"
|
|
"github.com/rook/rook/pkg/operator/k8sutil"
|
|
|
|
cephv1 "github.com/rook/rook/pkg/apis/ceph.rook.io/v1"
|
|
"github.com/rook/rook/pkg/clusterd"
|
|
cephclient "github.com/rook/rook/pkg/daemon/ceph/client"
|
|
cephver "github.com/rook/rook/pkg/operator/ceph/version"
|
|
testop "github.com/rook/rook/pkg/operator/test"
|
|
"github.com/stretchr/testify/assert"
|
|
apps "k8s.io/api/apps/v1"
|
|
v1 "k8s.io/api/core/v1"
|
|
"k8s.io/apimachinery/pkg/api/resource"
|
|
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
|
|
"k8s.io/apimachinery/pkg/types"
|
|
)
|
|
|
|
func testDeploymentObject(t *testing.T, network cephv1.NetworkSpec) (*apps.Deployment, error) {
|
|
fs := cephv1.CephFilesystem{
|
|
ObjectMeta: metav1.ObjectMeta{Name: "myfs", Namespace: "ns"},
|
|
Spec: cephv1.FilesystemSpec{
|
|
MetadataServer: cephv1.MetadataServerSpec{
|
|
ActiveCount: 1,
|
|
ActiveStandby: false,
|
|
Resources: v1.ResourceRequirements{
|
|
Limits: v1.ResourceList{
|
|
v1.ResourceCPU: *resource.NewQuantity(500.0, resource.BinarySI),
|
|
v1.ResourceMemory: *resource.NewQuantity(4337.0, resource.BinarySI),
|
|
},
|
|
Requests: v1.ResourceList{
|
|
v1.ResourceCPU: *resource.NewQuantity(250.0, resource.BinarySI),
|
|
v1.ResourceMemory: *resource.NewQuantity(2169.0, resource.BinarySI),
|
|
},
|
|
},
|
|
PriorityClassName: "my-priority-class",
|
|
},
|
|
},
|
|
}
|
|
clusterInfo := &cephclient.ClusterInfo{
|
|
FSID: "myfsid",
|
|
CephVersion: cephver.Quincy,
|
|
}
|
|
clientset := testop.New(t, 1)
|
|
|
|
c := NewCluster(
|
|
clusterInfo,
|
|
&clusterd.Context{Clientset: clientset},
|
|
&cephv1.ClusterSpec{
|
|
CephVersion: cephv1.CephVersionSpec{Image: "quay.io/ceph/ceph:testversion"},
|
|
Network: network,
|
|
DataDirHostPath: "/var/lib/rook/",
|
|
},
|
|
fs,
|
|
&k8sutil.OwnerInfo{},
|
|
"/var/lib/rook/",
|
|
)
|
|
mdsTestConfig := &mdsConfig{
|
|
DaemonID: "myfs-a",
|
|
ResourceName: "rook-ceph-mds-myfs-a",
|
|
DataPathMap: config.NewStatelessDaemonDataPathMap(config.MdsType, "myfs-a", "rook-ceph", "/var/lib/rook/"),
|
|
}
|
|
fsNamespacedname := types.NamespacedName{Name: "myfs-a", Namespace: "ns"}
|
|
|
|
t.Run(("check mds ConfigureProbe"), func(t *testing.T) {
|
|
c.fs.Spec.MetadataServer.LivenessProbe = &cephv1.ProbeSpec{Disabled: false, Probe: &v1.Probe{InitialDelaySeconds: 900}}
|
|
deployment, err := c.makeDeployment(mdsTestConfig, fsNamespacedname)
|
|
assert.Nil(t, err)
|
|
assert.NotNil(t, deployment)
|
|
assert.NotNil(t, c.fs.Spec.MetadataServer.LivenessProbe)
|
|
assert.Equal(t, "myfs-a", mdsTestConfig.DaemonID)
|
|
assert.Equal(t, "myfs-a", fsNamespacedname.Name)
|
|
assert.Equal(t, int32(900), deployment.Spec.Template.Spec.Containers[0].LivenessProbe.InitialDelaySeconds)
|
|
assert.NotNil(t, deployment.Spec.Template.Spec.Containers[0].LivenessProbe.ProbeHandler.Exec)
|
|
})
|
|
return c.makeDeployment(mdsTestConfig, fsNamespacedname)
|
|
}
|
|
|
|
func TestPodSpecs(t *testing.T) {
|
|
d, err := testDeploymentObject(t, cephv1.NetworkSpec{HostNetwork: false}) // no host network
|
|
assert.Nil(t, err)
|
|
|
|
assert.NotNil(t, d)
|
|
assert.Equal(t, v1.RestartPolicyAlways, d.Spec.Template.Spec.RestartPolicy)
|
|
assert.Equal(t, k8sutil.DefaultServiceAccount, d.Spec.Template.Spec.ServiceAccountName)
|
|
|
|
// Deployment should have Ceph labels
|
|
test.AssertLabelsContainCephRequirements(t, d.ObjectMeta.Labels,
|
|
config.MdsType, "myfs-a", "rook-ceph-mds", "ns", "myfs", "cephfilesystems.ceph.rook.io", "ceph-mds")
|
|
|
|
podTemplate := test.NewPodTemplateSpecTester(t, &d.Spec.Template)
|
|
podTemplate.RunFullSuite(config.MdsType, "myfs-a", "rook-ceph-mds", "ns", "quay.io/ceph/ceph:testversion",
|
|
"500", "250", "4337", "2169", /* resources */
|
|
"my-priority-class", "myfs", "cephfilesystems.ceph.rook.io", "ceph-mds")
|
|
|
|
// assert --public-addr is appended to args
|
|
assert.Contains(t, d.Spec.Template.Spec.Containers[0].Args,
|
|
config.NewFlag("public-addr", controller.ContainerEnvVarReference(podIPEnvVar)))
|
|
}
|
|
|
|
func TestHostNetwork(t *testing.T) {
|
|
d, err := testDeploymentObject(t, cephv1.NetworkSpec{HostNetwork: true}) // host network
|
|
assert.Nil(t, err)
|
|
|
|
assert.Equal(t, true, d.Spec.Template.Spec.HostNetwork)
|
|
assert.Equal(t, v1.DNSClusterFirstWithHostNet, d.Spec.Template.Spec.DNSPolicy)
|
|
|
|
// assert --public-addr is not appended to args
|
|
assert.NotContains(t, d.Spec.Template.Spec.Containers[0].Args,
|
|
config.NewFlag("public-addr", controller.ContainerEnvVarReference(podIPEnvVar)))
|
|
}
|