Files
my-rook-config/pkg/operator/ceph/object/config.go
T
egafford 8ec1256af8 ceph: Generate RGW keyrings before creating dependent deployments
Failure to create a keyring prior to creating a deployment
dependent on that keyring created a race conditition resulting
in an intermittent and unnecessary pod failure. This change
creates a keyring prior to any RGW deployment.

Partially fixes: #4089
Signed-off-by: egafford <egafford@redhat.com>
2019-11-05 14:58:46 -05:00

134 lines
4.0 KiB
Go

/*
Copyright 2019 The Rook Authors. All rights reserved.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package object
import (
"fmt"
"path"
"strconv"
"strings"
cephconfig "github.com/rook/rook/pkg/operator/ceph/config"
"github.com/rook/rook/pkg/operator/ceph/config/keyring"
cephver "github.com/rook/rook/pkg/operator/ceph/version"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
)
const (
keyringTemplate = `
[%s]
key = %s
caps mon = "allow rw"
caps osd = "allow rwx"
`
certVolumeName = "rook-ceph-rgw-cert"
certDir = "/etc/ceph/private"
certKeyName = "cert"
certFilename = "rgw-cert.pem"
)
var (
rgwFrontendName = "civetweb"
)
func rgwFrontend(v cephver.CephVersion) string {
if v.IsAtLeastNautilus() {
rgwFrontendName = "beast"
}
return rgwFrontendName
}
// TODO: these should be set in the mon's central kv store for mimic+
func (c *clusterConfig) defaultFlags() []string {
return []string{
cephconfig.NewFlag("rgw log nonexistent bucket", "true"),
cephconfig.NewFlag("rgw intent log object name utc", "true"),
cephconfig.NewFlag("rgw enable usage log", "true"),
cephconfig.NewFlag("rgw frontends", fmt.Sprintf("%s %s", rgwFrontend(c.clusterInfo.CephVersion), c.portString(c.clusterInfo.CephVersion))),
cephconfig.NewFlag("rgw zone", c.store.Name),
cephconfig.NewFlag("rgw zonegroup", c.store.Name),
}
}
func (c *clusterConfig) portString(v cephver.CephVersion) string {
var portString string
port := c.store.Spec.Gateway.Port
if port != 0 {
portString = fmt.Sprintf("port=%s", strconv.Itoa(int(port)))
}
if c.store.Spec.Gateway.SecurePort != 0 && c.store.Spec.Gateway.SSLCertificateRef != "" {
certPath := path.Join(certDir, certFilename)
// This is the beast backend
// Config is: http://docs.ceph.com/docs/master/radosgw/frontends/#id3
if v.IsAtLeastNautilus() {
if port != 0 {
portString = fmt.Sprintf("%s ssl_port=%d ssl_certificate=%s",
portString, c.store.Spec.Gateway.SecurePort, certPath)
} else {
portString = fmt.Sprintf("ssl_port=%d ssl_certificate=%s",
c.store.Spec.Gateway.SecurePort, certPath)
}
} else {
// This is civetweb config
// Config is http://docs.ceph.com/docs/master/radosgw/frontends/#id5
var separator string
if port != 0 {
separator = "+"
} else {
// This means there is only one port and it's a secured one
portString = "port="
}
// with ssl enabled, the port number must end with the letter s.
// e.g., "443s ssl_certificate=/etc/ceph/private/keyandcert.pem"
portString = fmt.Sprintf("%s%s%ds ssl_certificate=%s",
portString, separator, c.store.Spec.Gateway.SecurePort, certPath)
}
}
return portString
}
func generateCephXUser(name string) string {
user := strings.TrimPrefix(name, AppName)
return "client" + strings.Replace(user, "-", ".", -1)
}
func (c *clusterConfig) generateKeyring(rgwConfig *rgwConfig) (string, error) {
user := generateCephXUser(rgwConfig.ResourceName)
/* TODO: this says `osd allow rwx` while template says `osd allow *`; which is correct? */
access := []string{"osd", "allow rwx", "mon", "allow rw"}
s := keyring.GetSecretStore(c.context, c.store.Namespace, &c.ownerRef)
key, err := s.GenerateKey(user, access)
if err != nil {
return "", err
}
keyring := fmt.Sprintf(keyringTemplate, user, key)
return keyring, s.CreateOrUpdate(rgwConfig.ResourceName, keyring)
}
func (c *clusterConfig) associateKeyring(existingKeyring string, ownerRef *metav1.OwnerReference) error {
resourceName := ownerRef.Name
s := keyring.GetSecretStore(c.context, c.store.Namespace, ownerRef)
return s.CreateOrUpdate(resourceName, existingKeyring)
}