Files
my-rook-config/pkg/operator/ceph/nfs/controller.go
T
Jeff Layton c21aa227cf nfs: scale up/down ganesha servers with Active count
Rename createCephNFS to upCephNFS and have it take a parameter with the
old active count. Rename deleteGanesha to downCephNFS and have it take a
parameter with the new desired active count. Both the existing callers
pass in "0" for the new count parameters.

Fix up the onUpdate handler for CephNFS objects, such that changes to
the active count are reflected in the number of active servers. Have it
pass in the appropriate values when scaling servers up or down.

Finally, fix downCephNFS to shut down the highest-index servers first
and count down, instead of doing them in the order they were started.
This should eventually allow us more predictable behavior when scaling
down the number of server nodes.

Resolves: https://github.com/rook/rook/issues/2644
Signed-off-by: Jeff Layton <jlayton@redhat.com>
2019-02-13 16:49:48 -05:00

140 lines
4.5 KiB
Go

/*
Copyright 2019 The Rook Authors. All rights reserved.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
// Package nfs to manage a NFS Ganesha server
package nfs
import (
"reflect"
"github.com/coreos/pkg/capnslog"
opkit "github.com/rook/operator-kit"
cephv1 "github.com/rook/rook/pkg/apis/ceph.rook.io/v1"
"github.com/rook/rook/pkg/clusterd"
apiextensionsv1beta1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1beta1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/client-go/tools/cache"
)
var logger = capnslog.NewPackageLogger("github.com/rook/rook", "op-nfs")
// CephNFSResource represents the file system custom resource
var CephNFSResource = opkit.CustomResource{
Name: "cephnfs",
Plural: "cephnfses",
Group: cephv1.CustomResourceGroup,
Version: cephv1.Version,
Scope: apiextensionsv1beta1.NamespaceScoped,
Kind: reflect.TypeOf(cephv1.CephNFS{}).Name(),
}
// NFSCephNFSController represents a controller for NFS custom resources
type CephNFSController struct {
context *clusterd.Context
rookImage string
cephVersion cephv1.CephVersionSpec
hostNetwork bool
ownerRef metav1.OwnerReference
}
// NewNFSCephNFSController create controller for watching NFS custom resources created
func NewCephNFSController(context *clusterd.Context, rookImage string, cephVersion cephv1.CephVersionSpec, hostNetwork bool, ownerRef metav1.OwnerReference) *CephNFSController {
return &CephNFSController{
context: context,
rookImage: rookImage,
cephVersion: cephVersion,
hostNetwork: hostNetwork,
ownerRef: ownerRef,
}
}
// StartWatch watches for instances of CephNFS custom resources and acts on them
func (c *CephNFSController) StartWatch(namespace string, stopCh chan struct{}) error {
resourceHandlerFuncs := cache.ResourceEventHandlerFuncs{
AddFunc: c.onAdd,
UpdateFunc: c.onUpdate,
DeleteFunc: c.onDelete,
}
logger.Infof("start watching ceph nfs resource in namespace %s", namespace)
watcher := opkit.NewWatcher(CephNFSResource, namespace, resourceHandlerFuncs, c.context.RookClientset.CephV1().RESTClient())
go watcher.Watch(&cephv1.CephNFS{}, stopCh)
return nil
}
func (c *CephNFSController) onAdd(obj interface{}) {
nfs := obj.(*cephv1.CephNFS).DeepCopy()
if !cephv1.VersionAtLeast(c.cephVersion.Name, cephv1.Nautilus) {
logger.Errorf("Ceph NFS is only supported with Nautilus or newer. CRD %s will be ignored.", nfs.Name)
return
}
err := c.upCephNFS(*nfs, 0)
if err != nil {
logger.Errorf("failed to create NFS Ganesha %s. %+v", nfs.Name, err)
}
}
func (c *CephNFSController) onUpdate(oldObj, newObj interface{}) {
oldNFS := oldObj.(*cephv1.CephNFS).DeepCopy()
newNFS := newObj.(*cephv1.CephNFS).DeepCopy()
if !cephv1.VersionAtLeast(c.cephVersion.Name, cephv1.Nautilus) {
logger.Errorf("Ceph NFS is only supported with Nautilus or newer. CRD %s will be ignored.", newNFS.Name)
return
}
if !nfsChanged(oldNFS.Spec, newNFS.Spec) {
logger.Debugf("nfs ganesha %s not updated", newNFS.Name)
return
}
logger.Infof("Updating the ganesha server from %d to %d active count", oldNFS.Spec.Server.Active, newNFS.Spec.Server.Active)
if oldNFS.Spec.Server.Active < newNFS.Spec.Server.Active {
err := c.upCephNFS(*newNFS, oldNFS.Spec.Server.Active)
if err != nil {
logger.Errorf("Failed to start daemons for CephNFS %s. %+v", newNFS.Name, err)
}
} else {
err := c.downCephNFS(*oldNFS, newNFS.Spec.Server.Active)
if err != nil {
logger.Errorf("Failed to stop daemons for CephNFS %s. %+v", newNFS.Name, err)
}
}
}
func (c *CephNFSController) onDelete(obj interface{}) {
nfs := obj.(*cephv1.CephNFS).DeepCopy()
if !cephv1.VersionAtLeast(c.cephVersion.Name, cephv1.Nautilus) {
logger.Errorf("Ceph NFS is only supported with Nautilus or newer. CRD %s cleanup will be ignored.", nfs.Name)
return
}
err := c.downCephNFS(*nfs, 0)
if err != nil {
logger.Errorf("failed to delete file system %s. %+v", nfs.Name, err)
}
}
func nfsChanged(oldNFS, newNFS cephv1.NFSGaneshaSpec) bool {
if oldNFS.Server.Active != newNFS.Server.Active {
return true
}
return false
}